[INFO] fetching crate notnow 0.3.9... [INFO] checking notnow-0.3.9 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate notnow 0.3.9 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate notnow 0.3.9 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate notnow 0.3.9 [INFO] finished tweaking crates.io crate notnow 0.3.9 [INFO] tweaked toml for crates.io crate notnow 0.3.9 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate notnow 0.3.9 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a1628bd0b9d8cc88b5cfe13d27c5c157206edc318e30a32ce55dac01205b77e0 [INFO] running `Command { std: "docker" "start" "-a" "a1628bd0b9d8cc88b5cfe13d27c5c157206edc318e30a32ce55dac01205b77e0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a1628bd0b9d8cc88b5cfe13d27c5c157206edc318e30a32ce55dac01205b77e0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a1628bd0b9d8cc88b5cfe13d27c5c157206edc318e30a32ce55dac01205b77e0", kill_on_drop: false }` [INFO] [stdout] a1628bd0b9d8cc88b5cfe13d27c5c157206edc318e30a32ce55dac01205b77e0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bebc228da1c41f2cbdc1ea89d3130531be66ce8c18175c0544b6313bac8a2c9c [INFO] running `Command { std: "docker" "start" "-a" "bebc228da1c41f2cbdc1ea89d3130531be66ce8c18175c0544b6313bac8a2c9c", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking numtoa v0.1.0 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking rbuf v0.1.3 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Compiling syn v2.0.76 [INFO] [stderr] Checking gaps v0.3.1 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking termion v4.0.2 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Compiling grev v0.1.3 [INFO] [stderr] Compiling notnow v0.3.9 (/opt/rustwide/workdir) [INFO] [stderr] warning: notnow@0.3.9: Not in a git repository; unable to embed git revision [INFO] [stderr] Checking iso8601 v0.6.1 [INFO] [stderr] Compiling gui-derive v0.6.2 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Checking gui v0.6.2 [INFO] [stderr] Checking tokio v1.39.3 [INFO] [stderr] Checking clap v4.5.16 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking icalendar v0.16.5 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:291:16 [INFO] [stdout] | [INFO] [stdout] 256 | let task_state = TaskState::load(&paths.tasks_dir()) [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 281 | let ui_config_dir_cap = DirCap::for_dir(paths.ui_config_dir().to_path_buf()).await?; [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 284 | let ui_state_dir_cap = DirCap::for_dir(paths.ui_state_dir().to_path_buf()).await?; [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 287 | let tasks_root_cap = DirCap::for_dir(paths.tasks_dir()).await?; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 291 | Box::new(TermUiData::new( [INFO] [stdout] | ________________^ [INFO] [stdout] 292 | | tasks_root_cap, [INFO] [stdout] 293 | | task_state, [INFO] [stdout] 294 | | (ui_config_dir_cap, ui_config_file), [INFO] [stdout] ... | [INFO] [stdout] 297 | | toggle_tag, [INFO] [stdout] 298 | | )) [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cap.rs:160:5 [INFO] [stdout] | [INFO] [stdout] 144 | fn run_async(future: Fut) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 157 | let handle = scope.spawn(|| handle.block_on(future)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | handle.join().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db.rs:346:19 [INFO] [stdout] | [INFO] [stdout] 336 | pub fn from_iter_with_aux(iter: I) -> Self [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 340 | let data = iter [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 346 | by_ptr_idx: RefCell::new(make_ptr_idx(&data)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db.rs:342:27 [INFO] [stdout] | [INFO] [stdout] 342 | .map(|(item, aux)| (Rc::new(item), Cell::new(aux))) [INFO] [stdout] | ----------- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db.rs:342:42 [INFO] [stdout] | [INFO] [stdout] 342 | .map(|(item, aux)| (Rc::new(item), Cell::new(aux))) [INFO] [stdout] | ----------- ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db.rs:425:17 [INFO] [stdout] | [INFO] [stdout] 421 | let mut by_ptr_idx = self.by_ptr_idx.borrow_mut(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 425 | .get_mut(&HRc(Rc::clone(item))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db.rs:548:12 [INFO] [stdout] | [INFO] [stdout] 547 | let (item, aux) = self.data.remove(index); [INFO] [stdout] | ---- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 548 | (item, aux.into_inner()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ser/backends/ical/mod.rs:77:5 [INFO] [stdout] | [INFO] [stdout] 77 | T::from_ical_string(&string).map_err(Box::from).map_err(E) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ser/backends/ical/tasks_meta.rs:64:16 [INFO] [stdout] | [INFO] [stdout] 64 | .map(|s| parse_list::