[INFO] fetching crate notify 4.0.18... [INFO] checking notify-4.0.18 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate notify 4.0.18 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate notify 4.0.18 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate notify 4.0.18 [INFO] finished tweaking crates.io crate notify 4.0.18 [INFO] tweaked toml for crates.io crate notify 4.0.18 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate notify 4.0.18 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 147da2ac6d48601a4c2e6cf50bcb8d9aa85887ab5ee0141f957a0c8f605566eb [INFO] running `Command { std: "docker" "start" "-a" "147da2ac6d48601a4c2e6cf50bcb8d9aa85887ab5ee0141f957a0c8f605566eb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "147da2ac6d48601a4c2e6cf50bcb8d9aa85887ab5ee0141f957a0c8f605566eb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "147da2ac6d48601a4c2e6cf50bcb8d9aa85887ab5ee0141f957a0c8f605566eb", kill_on_drop: false }` [INFO] [stdout] 147da2ac6d48601a4c2e6cf50bcb8d9aa85887ab5ee0141f957a0c8f605566eb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6b770726a9cc95e561504ed9384b466af0a515e5c167f3bd2b5f07460e7820d9 [INFO] running `Command { std: "docker" "start" "-a" "6b770726a9cc95e561504ed9384b466af0a515e5c167f3bd2b5f07460e7820d9", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling io-lifetimes v1.0.10 [INFO] [stderr] Compiling rustix v0.37.19 [INFO] [stderr] Checking lazycell v1.3.0 [INFO] [stderr] Checking linux-raw-sys v0.3.7 [INFO] [stderr] Checking fastrand v1.8.0 [INFO] [stderr] Compiling slab v0.4.7 [INFO] [stderr] Checking walkdir v2.3.2 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking net2 v0.2.39 [INFO] [stderr] Checking inotify-sys v0.1.5 [INFO] [stderr] Checking filetime v0.2.22 [INFO] [stderr] Checking inotify v0.7.1 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Checking mio-extras v2.0.6 [INFO] [stderr] Checking notify v4.0.18 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/inotify.rs:332:24 [INFO] [stdout] | [INFO] [stdout] 332 | let metadata = try!(metadata(&path).map_err(Error::Io)); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/inotify.rs:343:13 [INFO] [stdout] | [INFO] [stdout] 343 | try!(self.add_single_watch(entry.path().to_path_buf(), is_recursive, watch_self)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/inotify.rs:395:21 [INFO] [stdout] | [INFO] [stdout] 395 | try!(inotify.rm_watch(w.clone()).map_err(Error::Io)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/inotify.rs:402:33 [INFO] [stdout] | [INFO] [stdout] 402 | ... try!(inotify.rm_watch(w.clone()).map_err(Error::Io)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/inotify.rs:420:17 [INFO] [stdout] | [INFO] [stdout] 420 | try!(inotify.rm_watch(w.clone()).map_err(Error::Io)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/inotify.rs:467:21 [INFO] [stdout] | [INFO] [stdout] 467 | let p = try!(env::current_dir().map_err(Error::Io)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/inotify.rs:482:21 [INFO] [stdout] | [INFO] [stdout] 482 | let p = try!(env::current_dir().map_err(Error::Io)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/lib.rs:461:17 [INFO] [stdout] | [INFO] [stdout] 461 | (a1 == b1 && a2 == b2) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 461 - (a1 == b1 && a2 == b2) [INFO] [stdout] 461 + a1 == b1 && a2 == b2 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:513:32 [INFO] [stdout] | [INFO] [stdout] 513 | fn cause(&self) -> Option<&StdError> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 513 | fn cause(&self) -> Option<&dyn StdError> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/lib.rs:493:39 [INFO] [stdout] | [INFO] [stdout] 493 | Error::Io(ref err) => err.description(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/inotify.rs:448:12 [INFO] [stdout] | [INFO] [stdout] 442 | fn new_raw(tx: Sender) -> Result { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 443 | let inotify = Inotify::init()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 444 | let event_tx = EventTx::Raw { tx }; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 445 | let event_loop = EventLoop::new(inotify, event_tx)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 446 | let channel = event_loop.channel(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 447 | event_loop.run(); [INFO] [stdout] 448 | Ok(INotifyWatcher(Mutex::new(channel))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/inotify.rs:460:12 [INFO] [stdout] | [INFO] [stdout] 451 | fn new(tx: Sender, delay: Duration) -> Result { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 452 | let inotify = Inotify::init()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 453 | let event_tx = EventTx::Debounced { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 457 | let event_loop = EventLoop::new(inotify, event_tx)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 458 | let channel = event_loop.channel(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 459 | event_loop.run(); [INFO] [stdout] 460 | Ok(INotifyWatcher(Mutex::new(channel))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/inotify.rs:475:9 [INFO] [stdout] | [INFO] [stdout] 463 | fn watch>(&mut self, path: P, recursive_mode: RecursiveMode) -> Result<()> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 467 | let p = try!(env::current_dir().map_err(Error::Io)); [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 470 | let (tx, rx) = mpsc::channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 471 | let msg = EventLoopMsg::AddWatch(pb, recursive_mode, tx); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 475 | rx.recv().unwrap() [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/inotify.rs:490:9 [INFO] [stdout] | [INFO] [stdout] 478 | fn unwatch>(&mut self, path: P) -> Result<()> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 482 | let p = try!(env::current_dir().map_err(Error::Io)); [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 485 | let (tx, rx) = mpsc::channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 486 | let msg = EventLoopMsg::RemoveWatch(pb, tx); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 490 | rx.recv().unwrap() [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/debounce/timer.rs:41:56 [INFO] [stdout] | [INFO] [stdout] 41 | let state = state.take().unwrap_or_else(|| self.state.0.lock().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `notify` (lib) due to 6 previous errors; 10 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "6b770726a9cc95e561504ed9384b466af0a515e5c167f3bd2b5f07460e7820d9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6b770726a9cc95e561504ed9384b466af0a515e5c167f3bd2b5f07460e7820d9", kill_on_drop: false }` [INFO] [stdout] 6b770726a9cc95e561504ed9384b466af0a515e5c167f3bd2b5f07460e7820d9