[INFO] fetching crate notes-rs 0.2.2... [INFO] checking notes-rs-0.2.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate notes-rs 0.2.2 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate notes-rs 0.2.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate notes-rs 0.2.2 [INFO] finished tweaking crates.io crate notes-rs 0.2.2 [INFO] tweaked toml for crates.io crate notes-rs 0.2.2 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate notes-rs 0.2.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ff24161721e31d19aa119f584767dc4e617fdf90582d53accdd565d0816e1597 [INFO] running `Command { std: "docker" "start" "-a" "ff24161721e31d19aa119f584767dc4e617fdf90582d53accdd565d0816e1597", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ff24161721e31d19aa119f584767dc4e617fdf90582d53accdd565d0816e1597", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ff24161721e31d19aa119f584767dc4e617fdf90582d53accdd565d0816e1597", kill_on_drop: false }` [INFO] [stdout] ff24161721e31d19aa119f584767dc4e617fdf90582d53accdd565d0816e1597 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cce9b28f00473ae30b19eac01d996d900dde671e548e9ef7ac520986b0206e14 [INFO] running `Command { std: "docker" "start" "-a" "cce9b28f00473ae30b19eac01d996d900dde671e548e9ef7ac520986b0206e14", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.70 [INFO] [stderr] Compiling proc-macro2 v1.0.10 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling syn v1.0.17 [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Compiling serde v1.0.110 [INFO] [stderr] Compiling getrandom v0.1.14 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Checking unicode-width v0.1.7 [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Checking regex-syntax v0.6.17 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Checking ppv-lite86 v0.2.8 [INFO] [stderr] Checking aho-corasick v0.7.10 [INFO] [stderr] Checking regex-automata v0.1.9 [INFO] [stderr] Compiling num-integer v0.1.42 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling quote v1.0.3 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking termios v0.3.2 [INFO] [stderr] Checking dirs v1.0.5 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking terminal_size v0.1.12 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking remove_dir_all v0.5.2 [INFO] [stderr] Compiling anyhow v1.0.31 [INFO] [stderr] Checking predicates-core v1.0.0 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking itoa v0.4.6 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking term v0.5.2 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking dirs-sys v0.3.4 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking float-cmp v0.6.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking treeline v0.1.0 [INFO] [stderr] Checking encode_unicode v0.3.6 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking unicode-segmentation v1.6.0 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking difference v2.0.0 [INFO] [stderr] Checking predicates-tree v1.0.0 [INFO] [stderr] Checking dirs v2.0.2 [INFO] [stderr] Checking clap v2.33.2 [INFO] [stderr] Checking heck v0.3.1 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking tempfile v3.1.0 [INFO] [stderr] Checking regex v1.3.7 [INFO] [stderr] Compiling serde_derive v1.0.110 [INFO] [stderr] Compiling thiserror-impl v1.0.18 [INFO] [stderr] Checking console v0.11.3 [INFO] [stderr] Checking predicates v1.0.4 [INFO] [stderr] Checking assert_cmd v1.0.1 [INFO] [stderr] Checking dialoguer v0.6.2 [INFO] [stderr] Checking thiserror v1.0.18 [INFO] [stderr] Checking bstr v0.2.13 [INFO] [stderr] Checking bincode v1.2.1 [INFO] [stderr] Checking chrono v0.4.11 [INFO] [stderr] Checking csv v1.1.3 [INFO] [stderr] Checking prettytable-rs v0.8.0 [INFO] [stderr] Checking notes-rs v0.2.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::process::Stdio` [INFO] [stdout] --> tests/app.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::process::Stdio; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `assert_cmd::prelude` [INFO] [stdout] --> tests/app.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use assert_cmd::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `NoteWithId` [INFO] [stdout] --> src/notes/mod.rs:6:35 [INFO] [stdout] | [INFO] [stdout] 6 | pub use note::{Note, NoteBuilder, NoteWithId}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/app.rs:63:13 [INFO] [stdout] | [INFO] [stdout] 63 | let mut cmd = TestCommand::new()?; [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] ... [INFO] [stdout] 85 | let mut cmd = cmd_with_args!(); [INFO] [stdout] | ---------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] = note: this warning originates in the macro `cmd_with_args` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/app.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | let mut new_cmd = new_cmd!($cmd.path); [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] ... [INFO] [stdout] 149 | cmd = cmd_with_args!(cmd); [INFO] [stdout] | ------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `cmd_with_args` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/app.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | let mut new_cmd = new_cmd!($cmd.path); [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] ... [INFO] [stdout] 155 | cmd = cmd_with_args!(cmd); [INFO] [stdout] | ------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `cmd_with_args` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/app.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | let mut new_cmd = new_cmd!($cmd.path); [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] ... [INFO] [stdout] 166 | cmd = cmd_with_args!(cmd); [INFO] [stdout] | ------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `cmd_with_args` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/app.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | let mut new_cmd = new_cmd!($cmd.path); [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] ... [INFO] [stdout] 180 | cmd = cmd_with_args!(cmd); [INFO] [stdout] | ------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `cmd_with_args` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/app.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | let mut new_cmd = new_cmd!($cmd.path); [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] ... [INFO] [stdout] 186 | cmd = cmd_with_args!(cmd); [INFO] [stdout] | ------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `cmd_with_args` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `path_as_os_str` and `path` are never used [INFO] [stdout] --> tests/app.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 25 | impl TestCommand { [INFO] [stdout] | ---------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 38 | pub fn path_as_os_str(&self) -> &OsStr { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 42 | pub fn path(&self) -> &Path { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/app.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 12 | let mut cmd = Command::cargo_bin("notes")?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | let tempdir = tempdir()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | let path = tempdir.path().to_owned().join("test"); [INFO] [stdout] 29 | let cmd = new_cmd!(path); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | [INFO] [stdout] 31 | Ok(TestCommand { [INFO] [stdout] | ____________^ [INFO] [stdout] 32 | | cmd, [INFO] [stdout] 33 | | path, [INFO] [stdout] 34 | | _tempdir: tempdir, [INFO] [stdout] 35 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `notes-rs` (test "app") due to 2 previous errors; 9 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notes/notes.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn from_file>(path: P) -> anyhow::Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | bincode::deserialize::(buf.as_bytes()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notes/notes.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn from_file>(path: P) -> anyhow::Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | bincode::deserialize::(buf.as_bytes()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `notes-rs` (bin "notes") due to 2 previous errors; 1 warning emitted [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `notes-rs` (bin "notes" test) due to 2 previous errors [INFO] running `Command { std: "docker" "inspect" "cce9b28f00473ae30b19eac01d996d900dde671e548e9ef7ac520986b0206e14", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cce9b28f00473ae30b19eac01d996d900dde671e548e9ef7ac520986b0206e14", kill_on_drop: false }` [INFO] [stdout] cce9b28f00473ae30b19eac01d996d900dde671e548e9ef7ac520986b0206e14