[INFO] fetching crate notegraf 0.1.1... [INFO] checking notegraf-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate notegraf 0.1.1 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate notegraf 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate notegraf 0.1.1 [INFO] finished tweaking crates.io crate notegraf 0.1.1 [INFO] tweaked toml for crates.io crate notegraf 0.1.1 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 175 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding ahash v0.7.8 (latest: v0.8.11) [INFO] [stderr] Adding atoi v1.0.0 (latest: v2.0.0) [INFO] [stderr] Adding base64 v0.13.1 (latest: v0.22.1) [INFO] [stderr] Adding base64 v0.21.7 (latest: v0.22.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding dirs v4.0.0 (latest: v5.0.1) [INFO] [stderr] Adding dirs-sys v0.3.7 (latest: v0.4.1) [INFO] [stderr] Adding event-listener v2.5.3 (latest: v5.3.1) [INFO] [stderr] Adding futures-intrusive v0.4.2 (latest: v0.5.0) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding hashlink v0.8.4 (latest: v0.9.1) [INFO] [stderr] Adding heck v0.4.1 (latest: v0.5.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding parking_lot v0.11.2 (latest: v0.12.3) [INFO] [stderr] Adding parking_lot_core v0.8.6 (latest: v0.9.10) [INFO] [stderr] Adding pulldown-cmark v0.9.6 (latest: v0.12.0) [INFO] [stderr] Adding pulldown-cmark-to-cmark v10.0.4 (latest: v16.0.1) [INFO] [stderr] Adding redox_syscall v0.2.16 (latest: v0.5.3) [INFO] [stderr] Adding redox_syscall v0.4.1 (latest: v0.5.3) [INFO] [stderr] Adding ring v0.16.20 (latest: v0.17.8) [INFO] [stderr] Adding rustls v0.20.9 (latest: v0.23.12) [INFO] [stderr] Adding rustls-pemfile v1.0.4 (latest: v2.1.3) [INFO] [stderr] Adding spin v0.5.2 (latest: v0.9.8) [INFO] [stderr] Adding sqlx v0.6.3 (latest: v0.8.1) [INFO] [stderr] Adding sqlx-core v0.6.3 (latest: v0.8.1) [INFO] [stderr] Adding sqlx-macros v0.6.3 (latest: v0.8.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding tokio-rustls v0.23.4 (latest: v0.26.0) [INFO] [stderr] Adding untrusted v0.7.1 (latest: v0.9.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding webpki-roots v0.22.6 (latest: v0.26.5) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b8621c68198019c7d23ea3640e6c155325342068949b2c2ee20a76fa666643a8 [INFO] running `Command { std: "docker" "start" "-a" "b8621c68198019c7d23ea3640e6c155325342068949b2c2ee20a76fa666643a8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b8621c68198019c7d23ea3640e6c155325342068949b2c2ee20a76fa666643a8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b8621c68198019c7d23ea3640e6c155325342068949b2c2ee20a76fa666643a8", kill_on_drop: false }` [INFO] [stdout] b8621c68198019c7d23ea3640e6c155325342068949b2c2ee20a76fa666643a8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 71c10683e209bb2aab61936895d86f7df2318ebb174ac642603433ab9d30891b [INFO] running `Command { std: "docker" "start" "-a" "71c10683e209bb2aab61936895d86f7df2318ebb174ac642603433ab9d30891b", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling rustls v0.20.9 [INFO] [stderr] Compiling byteorder v1.5.0 [INFO] [stderr] Compiling spin v0.9.8 [INFO] [stderr] Compiling untrusted v0.9.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling subtle v2.6.1 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Compiling zerocopy v0.7.35 [INFO] [stderr] Compiling tinyvec_macros v0.1.1 [INFO] [stderr] Compiling mio v1.0.2 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling tinyvec v1.8.0 [INFO] [stderr] Compiling socket2 v0.5.7 [INFO] [stderr] Compiling ahash v0.7.8 [INFO] [stderr] Compiling futures-core v0.3.30 [INFO] [stderr] Compiling block-buffer v0.10.4 [INFO] [stderr] Compiling bytes v1.7.1 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Compiling spin v0.5.2 [INFO] [stderr] Compiling untrusted v0.7.1 [INFO] [stderr] Compiling instant v0.1.13 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling unicode-bidi v0.3.15 [INFO] [stderr] Compiling unicode-normalization v0.1.23 [INFO] [stderr] Compiling tokio v1.40.0 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling parking_lot_core v0.8.6 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling ppv-lite86 v0.2.20 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Compiling percent-encoding v2.3.1 [INFO] [stderr] Compiling webpki v0.22.4 [INFO] [stderr] Compiling sct v0.7.1 [INFO] [stderr] Compiling minimal-lexical v0.2.1 [INFO] [stderr] Compiling futures-sink v0.3.30 [INFO] [stderr] Compiling allocator-api2 v0.2.18 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling nom v7.1.3 [INFO] [stderr] Compiling hashbrown v0.14.5 [INFO] [stderr] Compiling form_urlencoded v1.2.1 [INFO] [stderr] Compiling rand_chacha v0.3.1 [INFO] [stderr] Compiling parking_lot v0.11.2 [INFO] [stderr] Compiling idna v0.5.0 [INFO] [stderr] Compiling hmac v0.12.1 [INFO] [stderr] Compiling dirs-sys v0.3.7 [INFO] [stderr] Compiling crc-catalog v2.4.0 [INFO] [stderr] Compiling unicode-properties v0.1.2 [INFO] [stderr] Compiling ryu v1.0.18 [INFO] [stderr] Compiling iana-time-zone v0.1.60 [INFO] [stderr] Compiling pin-utils v0.1.0 [INFO] [stderr] Compiling itoa v1.0.11 [INFO] [stderr] Compiling hashbrown v0.12.3 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling unicode_categories v0.1.1 [INFO] [stderr] Compiling futures-task v0.3.30 [INFO] [stderr] Compiling base64 v0.21.7 [INFO] [stderr] Compiling tokio-rustls v0.23.4 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling sqlx-rt v0.6.3 [INFO] [stderr] Compiling rustls-pemfile v1.0.4 [INFO] [stderr] Compiling sqlformat v0.2.4 [INFO] [stderr] Compiling chrono v0.4.38 [INFO] [stderr] Compiling stringprep v0.1.5 [INFO] [stderr] Compiling url v2.5.2 [INFO] [stderr] Compiling crc v3.2.1 [INFO] [stderr] Compiling crossbeam-queue v0.3.11 [INFO] [stderr] Compiling tokio-stream v0.1.15 [INFO] [stderr] Compiling dirs v4.0.0 [INFO] [stderr] Compiling hkdf v0.12.4 [INFO] [stderr] Compiling hashlink v0.8.4 [INFO] [stderr] Compiling futures-intrusive v0.4.2 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Compiling webpki-roots v0.22.6 [INFO] [stderr] Compiling sha2 v0.10.8 [INFO] [stderr] Compiling sha1 v0.10.6 [INFO] [stderr] Compiling atoi v1.0.0 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling md-5 v0.10.6 [INFO] [stderr] Compiling whoami v1.5.1 [INFO] [stderr] Compiling dotenvy v0.15.7 [INFO] [stderr] Compiling hex v0.4.3 [INFO] [stderr] Compiling pulldown-cmark v0.9.6 [INFO] [stderr] Compiling bitflags v1.3.2 [INFO] [stderr] Compiling event-listener v2.5.3 [INFO] [stderr] Compiling base64 v0.13.1 [INFO] [stderr] Compiling uuid v1.10.0 [INFO] [stderr] Checking getopts v0.2.21 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling notegraf v0.1.1 (/opt/rustwide/workdir) [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Compiling sqlx-core v0.6.3 [INFO] [stderr] Checking pulldown-cmark-to-cmark v10.0.4 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling sqlx-macros v0.6.3 [INFO] [stderr] Checking sqlx v0.6.3 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notestore/in_memory.rs:325:35 [INFO] [stdout] | [INFO] [stdout] 325 | .map(|(id, revision)| self.get_note_by_revision(id, revision).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notestore/in_memory.rs:387:12 [INFO] [stdout] | [INFO] [stdout] 372 | s: InMemoryNoteStored, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 373 | ) -> Result, NoteStoreError> { [INFO] [stdout] 374 | let note_inner = T::from(s.note_inner); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 375 | let referents = note_inner [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 378 | let references = self.get_references(&s.id); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 387 | Ok(InMemoryNoteComputed { [INFO] [stdout] | ____________^ [INFO] [stdout] 388 | | title: s.title, [INFO] [stdout] 389 | | note_inner, [INFO] [stdout] 390 | | id: s.id, [INFO] [stdout] ... | [INFO] [stdout] 399 | | metadata: s.metadata, [INFO] [stdout] 400 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notestore/in_memory.rs:405:12 [INFO] [stdout] | [INFO] [stdout] 404 | let note_stored = self.get_note_stored(loc)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 405 | Ok(Box::new(self.compute_stored_note(note_stored)?) as Box>) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notestore/in_memory.rs:415:38 [INFO] [stdout] | [INFO] [stdout] 412 | note_inner: Option, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 413 | note_metadata: NoteMetadataEditable, [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 414 | ) -> Result { [INFO] [stdout] 415 | self.update_note_helper(loc, |old_note| { [INFO] [stdout] | ______________________________________^ [INFO] [stdout] 416 | | let mut note = old_note.clone(); [INFO] [stdout] 417 | | if let Some(t) = title { [INFO] [stdout] 418 | | note.title = t; [INFO] [stdout] ... | [INFO] [stdout] 425 | | Ok(note) [INFO] [stdout] 426 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notestore/in_memory.rs:486:9 [INFO] [stdout] | [INFO] [stdout] 477 | let notes: Vec> = self [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 486 | / notes [INFO] [stdout] 487 | | .into_iter() [INFO] [stdout] 488 | | .map(|n| { [INFO] [stdout] 489 | | self.compute_stored_note(n) [INFO] [stdout] 490 | | .map(|n_computed| Box::new(n_computed) as Box>) [INFO] [stdout] 491 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notestore/in_memory.rs:489:17 [INFO] [stdout] | [INFO] [stdout] 488 | .map(|n| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 489 | self.compute_stored_note(n) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notestore/in_memory.rs:490:39 [INFO] [stdout] | [INFO] [stdout] 490 | .map(|n_computed| Box::new(n_computed) as Box>) [INFO] [stdout] | ---------- ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notestore/in_memory.rs:538:17 [INFO] [stdout] | [INFO] [stdout] 537 | .map(|x| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 538 | self.compute_stored_note(x) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notestore/in_memory.rs:539:39 [INFO] [stdout] | [INFO] [stdout] 539 | .map(|x_computed| Box::new(x_computed) as Box>) [INFO] [stdout] | ---------- ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notestore/in_memory.rs:561:47 [INFO] [stdout] | [INFO] [stdout] 561 | revisions.sort_by_key(|n| Reverse(n.get_metadata().created_at)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notestore/in_memory.rs:577:27 [INFO] [stdout] | [INFO] [stdout] 570 | let mut tags = HashSet::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 571 | let notes: Vec> = self.get_all_current_notes(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 577 | Ok(Vec::from_iter(tags.into_iter())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notestore/in_memory.rs:595:9 [INFO] [stdout] | [INFO] [stdout] 589 | fn restore>(path: P) -> Result [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 595 | serde_json::from_str(&contents).map_err(NoteStoreError::SerdeError) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notestore/in_memory.rs:624:18 [INFO] [stdout] | [INFO] [stdout] 621 | note_inner: T, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 622 | metadata: NoteMetadataEditable, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 623 | ) -> BoxFuture> { [INFO] [stdout] 624 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 625 | | let mut ims = self.ims.write().await; [INFO] [stdout] 626 | | ims.new_note(title, note_inner, metadata) [INFO] [stdout] 627 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notestore/in_memory.rs:647:18 [INFO] [stdout] | [INFO] [stdout] 644 | note_inner: Option, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 645 | note_metadata: NoteMetadataEditable, [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 646 | ) -> BoxFuture<'a, Result> { [INFO] [stdout] 647 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 648 | | let mut ims = self.ims.write().await; [INFO] [stdout] 649 | | ims.update_note(loc, title, note_inner, note_metadata) [INFO] [stdout] 650 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notestore/in_memory.rs:690:18 [INFO] [stdout] | [INFO] [stdout] 687 | note_inner: T, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 688 | metadata: NoteMetadataEditable, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 689 | ) -> BoxFuture<'a, Result> { [INFO] [stdout] 690 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 691 | | let mut ims = self.ims.write().await; [INFO] [stdout] 692 | | ims.append_note(last, title, note_inner, metadata) [INFO] [stdout] 693 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notestore/in_memory.rs:703:18 [INFO] [stdout] | [INFO] [stdout] 700 | note_inner: T, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 701 | metadata: NoteMetadataEditable, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 702 | ) -> BoxFuture<'a, Result> { [INFO] [stdout] 703 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 704 | | let mut ims = self.ims.write().await; [INFO] [stdout] 705 | | ims.add_branch(parent, title, note_inner, metadata) [INFO] [stdout] 706 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notestore/in_memory.rs:727:18 [INFO] [stdout] | [INFO] [stdout] 726 | fn backup(&self, path: Box + Send>) -> BoxFuture> { [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 727 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 728 | | let ims = self.ims.read().await; [INFO] [stdout] 729 | | ims.backup(&*path) [INFO] [stdout] 730 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notestore/in_memory.rs:734:12 [INFO] [stdout] | [INFO] [stdout] 733 | fn restore>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 734 | Ok(InMemoryStore { [INFO] [stdout] | ____________^ [INFO] [stdout] 735 | | ims: RwLock::new(InMemoryStoreInner::restore(path)?), [INFO] [stdout] 736 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notestore/postgresql/mod.rs:168:18 [INFO] [stdout] | [INFO] [stdout] 165 | note_inner: T, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 166 | metadata: NoteMetadataEditable, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 167 | ) -> BoxFuture> { [INFO] [stdout] 168 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 169 | | let mut transaction = self.db_pool.begin().await?; [INFO] [stdout] 170 | | read_write(&mut transaction).await?; [INFO] [stdout] 171 | | let loc = self [INFO] [stdout] ... | [INFO] [stdout] 175 | | loc [INFO] [stdout] 176 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notestore/postgresql/mod.rs:188:16 [INFO] [stdout] | [INFO] [stdout] 184 | let mut transaction = self.db_pool.begin().await?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 185 | read_only(&mut transaction).await?; [INFO] [stdout] 186 | let note: PostgreSQLNote = get_note_by_loc(&mut transaction, loc).await?.into_note(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 187 | transaction.commit().await?; [INFO] [stdout] 188 | Ok(Box::new(note) as Box>) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notestore/postgresql/mod.rs:199:18 [INFO] [stdout] | [INFO] [stdout] 196 | note_inner: Option, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 197 | note_metadata: NoteMetadataEditable, [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 198 | ) -> BoxFuture<'a, Result> { [INFO] [stdout] 199 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 200 | | let mut transaction = self.db_pool.begin().await?; [INFO] [stdout] 201 | | read_write(&mut transaction).await?; [INFO] [stdout] 202 | | let new_loc = update_note_helper(&mut transaction, loc, |old_note| { [INFO] [stdout] ... | [INFO] [stdout] 216 | | Ok(new_loc) [INFO] [stdout] 217 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notestore/postgresql/mod.rs:253:47 [INFO] [stdout] | [INFO] [stdout] 225 | let mut transaction = self.db_pool.begin().await?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 234 | let note: PostgreSQLNote = get_note_by_loc(&mut transaction, loc).await?.into_note(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 253 | delete_revision(transaction, loc).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notestore/postgresql/mod.rs:267:16 [INFO] [stdout] | [INFO] [stdout] 262 | let mut transaction = self.db_pool.begin().await?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 267 | Ok(notes [INFO] [stdout] | ________________^ [INFO] [stdout] 268 | | .into_iter() [INFO] [stdout] 269 | | .map(|n| Box::new(n.into_note()) as Box>) [INFO] [stdout] 270 | | .collect()) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notestore/postgresql/mod.rs:269:26 [INFO] [stdout] | [INFO] [stdout] 269 | .map(|n| Box::new(n.into_note()) as Box>) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notestore/postgresql/mod.rs:319:18 [INFO] [stdout] | [INFO] [stdout] 316 | note_inner: T, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 317 | metadata: NoteMetadataEditable, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 318 | ) -> BoxFuture<'a, Result> { [INFO] [stdout] 319 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 320 | | let mut transaction = self.db_pool.begin().await?; [INFO] [stdout] 321 | | read_write(&mut transaction).await?; [INFO] [stdout] 322 | | let last_note: PostgreSQLNote = [INFO] [stdout] ... | [INFO] [stdout] 343 | | Ok(loc) [INFO] [stdout] 344 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notestore/postgresql/mod.rs:354:18 [INFO] [stdout] | [INFO] [stdout] 351 | note_inner: T, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 352 | metadata: NoteMetadataEditable, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 353 | ) -> BoxFuture<'a, Result> { [INFO] [stdout] 354 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 355 | | let mut transaction = self.db_pool.begin().await?; [INFO] [stdout] 356 | | read_write(&mut transaction).await?; [INFO] [stdout] 357 | | let parent_uuid = parent.try_to_uuid()?; [INFO] [stdout] ... | [INFO] [stdout] 369 | | Ok(loc) [INFO] [stdout] 370 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notestore/postgresql/mod.rs:382:16 [INFO] [stdout] | [INFO] [stdout] 378 | let mut transaction = self.db_pool.begin().await?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 382 | Ok(notes [INFO] [stdout] | ________________^ [INFO] [stdout] 383 | | .into_iter() [INFO] [stdout] 384 | | .map(|n| Box::new(n.into_note()) as Box>) [INFO] [stdout] 385 | | .collect()) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notestore/postgresql/mod.rs:384:26 [INFO] [stdout] | [INFO] [stdout] 384 | .map(|n| Box::new(n.into_note()) as Box>) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notetype/plain.rs:32:16 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn split_off(mut self, at: usize) -> (Self, Self) { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | let new_body = self.body.split_off(at); [INFO] [stdout] 32 | (self, PlainNote::new(new_body)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notetype/plain.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 76 | fn from(note: PlainNote) -> String { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | serde_json::to_string(¬e).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 30 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `notegraf` (lib) due to 31 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notestore/in_memory.rs:325:35 [INFO] [stdout] | [INFO] [stdout] 325 | .map(|(id, revision)| self.get_note_by_revision(id, revision).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notestore/in_memory.rs:387:12 [INFO] [stdout] | [INFO] [stdout] 372 | s: InMemoryNoteStored, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 373 | ) -> Result, NoteStoreError> { [INFO] [stdout] 374 | let note_inner = T::from(s.note_inner); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 375 | let referents = note_inner [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 378 | let references = self.get_references(&s.id); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 387 | Ok(InMemoryNoteComputed { [INFO] [stdout] | ____________^ [INFO] [stdout] 388 | | title: s.title, [INFO] [stdout] 389 | | note_inner, [INFO] [stdout] 390 | | id: s.id, [INFO] [stdout] ... | [INFO] [stdout] 399 | | metadata: s.metadata, [INFO] [stdout] 400 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notestore/in_memory.rs:405:12 [INFO] [stdout] | [INFO] [stdout] 404 | let note_stored = self.get_note_stored(loc)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 405 | Ok(Box::new(self.compute_stored_note(note_stored)?) as Box>) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notestore/in_memory.rs:415:38 [INFO] [stdout] | [INFO] [stdout] 412 | note_inner: Option, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 413 | note_metadata: NoteMetadataEditable, [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 414 | ) -> Result { [INFO] [stdout] 415 | self.update_note_helper(loc, |old_note| { [INFO] [stdout] | ______________________________________^ [INFO] [stdout] 416 | | let mut note = old_note.clone(); [INFO] [stdout] 417 | | if let Some(t) = title { [INFO] [stdout] 418 | | note.title = t; [INFO] [stdout] ... | [INFO] [stdout] 425 | | Ok(note) [INFO] [stdout] 426 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notestore/in_memory.rs:486:9 [INFO] [stdout] | [INFO] [stdout] 477 | let notes: Vec> = self [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 486 | / notes [INFO] [stdout] 487 | | .into_iter() [INFO] [stdout] 488 | | .map(|n| { [INFO] [stdout] 489 | | self.compute_stored_note(n) [INFO] [stdout] 490 | | .map(|n_computed| Box::new(n_computed) as Box>) [INFO] [stdout] 491 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notestore/in_memory.rs:489:17 [INFO] [stdout] | [INFO] [stdout] 488 | .map(|n| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 489 | self.compute_stored_note(n) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notestore/in_memory.rs:490:39 [INFO] [stdout] | [INFO] [stdout] 490 | .map(|n_computed| Box::new(n_computed) as Box>) [INFO] [stdout] | ---------- ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notestore/in_memory.rs:538:17 [INFO] [stdout] | [INFO] [stdout] 537 | .map(|x| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 538 | self.compute_stored_note(x) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notestore/in_memory.rs:539:39 [INFO] [stdout] | [INFO] [stdout] 539 | .map(|x_computed| Box::new(x_computed) as Box>) [INFO] [stdout] | ---------- ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notestore/in_memory.rs:561:47 [INFO] [stdout] | [INFO] [stdout] 561 | revisions.sort_by_key(|n| Reverse(n.get_metadata().created_at)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notestore/in_memory.rs:577:27 [INFO] [stdout] | [INFO] [stdout] 570 | let mut tags = HashSet::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 571 | let notes: Vec> = self.get_all_current_notes(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 577 | Ok(Vec::from_iter(tags.into_iter())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notestore/in_memory.rs:595:9 [INFO] [stdout] | [INFO] [stdout] 589 | fn restore>(path: P) -> Result [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 595 | serde_json::from_str(&contents).map_err(NoteStoreError::SerdeError) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notestore/in_memory.rs:624:18 [INFO] [stdout] | [INFO] [stdout] 621 | note_inner: T, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 622 | metadata: NoteMetadataEditable, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 623 | ) -> BoxFuture> { [INFO] [stdout] 624 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 625 | | let mut ims = self.ims.write().await; [INFO] [stdout] 626 | | ims.new_note(title, note_inner, metadata) [INFO] [stdout] 627 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notestore/in_memory.rs:647:18 [INFO] [stdout] | [INFO] [stdout] 644 | note_inner: Option, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 645 | note_metadata: NoteMetadataEditable, [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 646 | ) -> BoxFuture<'a, Result> { [INFO] [stdout] 647 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 648 | | let mut ims = self.ims.write().await; [INFO] [stdout] 649 | | ims.update_note(loc, title, note_inner, note_metadata) [INFO] [stdout] 650 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notestore/in_memory.rs:690:18 [INFO] [stdout] | [INFO] [stdout] 687 | note_inner: T, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 688 | metadata: NoteMetadataEditable, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 689 | ) -> BoxFuture<'a, Result> { [INFO] [stdout] 690 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 691 | | let mut ims = self.ims.write().await; [INFO] [stdout] 692 | | ims.append_note(last, title, note_inner, metadata) [INFO] [stdout] 693 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notestore/in_memory.rs:703:18 [INFO] [stdout] | [INFO] [stdout] 700 | note_inner: T, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 701 | metadata: NoteMetadataEditable, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 702 | ) -> BoxFuture<'a, Result> { [INFO] [stdout] 703 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 704 | | let mut ims = self.ims.write().await; [INFO] [stdout] 705 | | ims.add_branch(parent, title, note_inner, metadata) [INFO] [stdout] 706 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notestore/in_memory.rs:727:18 [INFO] [stdout] | [INFO] [stdout] 726 | fn backup(&self, path: Box + Send>) -> BoxFuture> { [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 727 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 728 | | let ims = self.ims.read().await; [INFO] [stdout] 729 | | ims.backup(&*path) [INFO] [stdout] 730 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notestore/in_memory.rs:734:12 [INFO] [stdout] | [INFO] [stdout] 733 | fn restore>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 734 | Ok(InMemoryStore { [INFO] [stdout] | ____________^ [INFO] [stdout] 735 | | ims: RwLock::new(InMemoryStoreInner::restore(path)?), [INFO] [stdout] 736 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notestore/postgresql/mod.rs:168:18 [INFO] [stdout] | [INFO] [stdout] 165 | note_inner: T, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 166 | metadata: NoteMetadataEditable, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 167 | ) -> BoxFuture> { [INFO] [stdout] 168 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 169 | | let mut transaction = self.db_pool.begin().await?; [INFO] [stdout] 170 | | read_write(&mut transaction).await?; [INFO] [stdout] 171 | | let loc = self [INFO] [stdout] ... | [INFO] [stdout] 175 | | loc [INFO] [stdout] 176 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notestore/postgresql/mod.rs:188:16 [INFO] [stdout] | [INFO] [stdout] 184 | let mut transaction = self.db_pool.begin().await?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 185 | read_only(&mut transaction).await?; [INFO] [stdout] 186 | let note: PostgreSQLNote = get_note_by_loc(&mut transaction, loc).await?.into_note(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 187 | transaction.commit().await?; [INFO] [stdout] 188 | Ok(Box::new(note) as Box>) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notestore/postgresql/mod.rs:199:18 [INFO] [stdout] | [INFO] [stdout] 196 | note_inner: Option, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 197 | note_metadata: NoteMetadataEditable, [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 198 | ) -> BoxFuture<'a, Result> { [INFO] [stdout] 199 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 200 | | let mut transaction = self.db_pool.begin().await?; [INFO] [stdout] 201 | | read_write(&mut transaction).await?; [INFO] [stdout] 202 | | let new_loc = update_note_helper(&mut transaction, loc, |old_note| { [INFO] [stdout] ... | [INFO] [stdout] 216 | | Ok(new_loc) [INFO] [stdout] 217 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notestore/postgresql/mod.rs:253:47 [INFO] [stdout] | [INFO] [stdout] 225 | let mut transaction = self.db_pool.begin().await?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 234 | let note: PostgreSQLNote = get_note_by_loc(&mut transaction, loc).await?.into_note(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 253 | delete_revision(transaction, loc).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notestore/postgresql/mod.rs:267:16 [INFO] [stdout] | [INFO] [stdout] 262 | let mut transaction = self.db_pool.begin().await?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 267 | Ok(notes [INFO] [stdout] | ________________^ [INFO] [stdout] 268 | | .into_iter() [INFO] [stdout] 269 | | .map(|n| Box::new(n.into_note()) as Box>) [INFO] [stdout] 270 | | .collect()) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notestore/postgresql/mod.rs:269:26 [INFO] [stdout] | [INFO] [stdout] 269 | .map(|n| Box::new(n.into_note()) as Box>) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notestore/postgresql/mod.rs:319:18 [INFO] [stdout] | [INFO] [stdout] 316 | note_inner: T, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 317 | metadata: NoteMetadataEditable, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 318 | ) -> BoxFuture<'a, Result> { [INFO] [stdout] 319 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 320 | | let mut transaction = self.db_pool.begin().await?; [INFO] [stdout] 321 | | read_write(&mut transaction).await?; [INFO] [stdout] 322 | | let last_note: PostgreSQLNote = [INFO] [stdout] ... | [INFO] [stdout] 343 | | Ok(loc) [INFO] [stdout] 344 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notestore/postgresql/mod.rs:354:18 [INFO] [stdout] | [INFO] [stdout] 351 | note_inner: T, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 352 | metadata: NoteMetadataEditable, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 353 | ) -> BoxFuture<'a, Result> { [INFO] [stdout] 354 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 355 | | let mut transaction = self.db_pool.begin().await?; [INFO] [stdout] 356 | | read_write(&mut transaction).await?; [INFO] [stdout] 357 | | let parent_uuid = parent.try_to_uuid()?; [INFO] [stdout] ... | [INFO] [stdout] 369 | | Ok(loc) [INFO] [stdout] 370 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notestore/postgresql/mod.rs:382:16 [INFO] [stdout] | [INFO] [stdout] 378 | let mut transaction = self.db_pool.begin().await?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 382 | Ok(notes [INFO] [stdout] | ________________^ [INFO] [stdout] 383 | | .into_iter() [INFO] [stdout] 384 | | .map(|n| Box::new(n.into_note()) as Box>) [INFO] [stdout] 385 | | .collect()) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notestore/postgresql/mod.rs:384:26 [INFO] [stdout] | [INFO] [stdout] 384 | .map(|n| Box::new(n.into_note()) as Box>) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notetype/plain.rs:32:16 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn split_off(mut self, at: usize) -> (Self, Self) { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | let new_body = self.body.split_off(at); [INFO] [stdout] 32 | (self, PlainNote::new(new_body)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notetype/plain.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 76 | fn from(note: PlainNote) -> String { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | serde_json::to_string(¬e).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 30 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `notegraf` (lib test) due to 31 previous errors [INFO] running `Command { std: "docker" "inspect" "71c10683e209bb2aab61936895d86f7df2318ebb174ac642603433ab9d30891b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "71c10683e209bb2aab61936895d86f7df2318ebb174ac642603433ab9d30891b", kill_on_drop: false }` [INFO] [stdout] 71c10683e209bb2aab61936895d86f7df2318ebb174ac642603433ab9d30891b