[INFO] fetching crate nostr-nostd 0.2.1... [INFO] checking nostr-nostd-0.2.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate nostr-nostd 0.2.1 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate nostr-nostd 0.2.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate nostr-nostd 0.2.1 [INFO] finished tweaking crates.io crate nostr-nostd 0.2.1 [INFO] tweaked toml for crates.io crate nostr-nostd 0.2.1 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 33 packages to latest compatible versions [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding hash32 v0.2.1 (latest: v0.3.1) [INFO] [stderr] Adding heapless v0.7.17 (latest: v0.8.0) [INFO] [stderr] Adding secp256k1 v0.27.0 (latest: v0.29.0) [INFO] [stderr] Adding secp256k1-sys v0.8.1 (latest: v0.10.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4499463656cf0070e0ac35ca772796fdf57124268655dfccf4da97a018ea08bd [INFO] running `Command { std: "docker" "start" "-a" "4499463656cf0070e0ac35ca772796fdf57124268655dfccf4da97a018ea08bd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4499463656cf0070e0ac35ca772796fdf57124268655dfccf4da97a018ea08bd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4499463656cf0070e0ac35ca772796fdf57124268655dfccf4da97a018ea08bd", kill_on_drop: false }` [INFO] [stdout] 4499463656cf0070e0ac35ca772796fdf57124268655dfccf4da97a018ea08bd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3ace2969f6196fc5634f289aea5ec3960171d6a0efcbcf17c13f5c90a0d4eac1 [INFO] running `Command { std: "docker" "start" "-a" "3ace2969f6196fc5634f289aea5ec3960171d6a0efcbcf17c13f5c90a0d4eac1", kill_on_drop: false }` [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking base64ct v1.6.0 [INFO] [stderr] Checking base16ct v0.2.0 [INFO] [stderr] Checking hash32 v0.2.1 [INFO] [stderr] Compiling secp256k1-sys v0.8.1 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Compiling heapless v0.7.17 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking cbc v0.1.2 [INFO] [stderr] Checking secp256k1 v0.27.0 [INFO] [stderr] Checking nostr-nostd v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:218:27 [INFO] [stdout] | [INFO] [stdout] 210 | pub fn add_tag(mut self, tag: String) -> NoteBuilder { [INFO] [stdout] | -------- --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 211 | let next_tags = self.build_status.tags.next(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 218 | build_status: BuildStatus { tags: next_tags }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:260:12 [INFO] [stdout] | [INFO] [stdout] 243 | mut self, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 247 | let mut tags = Vec::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 248 | let mut challenge_string: String = String::from("challenge,"); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 253 | let mut relay_str: String = String::from("relay,"); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 260 | Ok(NoteBuilder { [INFO] [stdout] | ____________^ [INFO] [stdout] 261 | | keypair: self.keypair, [INFO] [stdout] 262 | | note: self.note, [INFO] [stdout] 263 | | build_status: BuildStatus { tags: TwoTags }, [INFO] [stdout] 264 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:284:12 [INFO] [stdout] | [INFO] [stdout] 271 | mut self, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 280 | let encrypted = nip04::encrypt(&self.keypair.secret_key(), &pubkey, content, iv)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 281 | self.note.content = Some(encrypted); [INFO] [stdout] 282 | let mut tag = String::from("p,"); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 283 | tag.push_str(rcvr_pubkey).expect("impossible"); [INFO] [stdout] 284 | Ok(self.add_tag(tag)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:309:12 [INFO] [stdout] | [INFO] [stdout] 305 | let sig_obj = secp256k1::Secp256k1::preallocated_new(&mut buf) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 309 | Ok(NoteBuilder { [INFO] [stdout] | ____________^ [INFO] [stdout] 310 | | build_status: BuildStatus { tags: ZeroTags }, [INFO] [stdout] 311 | | keypair: key_pair, [INFO] [stdout] 312 | | note: Note { [INFO] [stdout] ... | [INFO] [stdout] 320 | | }, [INFO] [stdout] 321 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:588:12 [INFO] [stdout] | [INFO] [stdout] 584 | let mut search_tag: String<10> = String::from(tag); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 588 | Ok(self [INFO] [stdout] | ____________^ [INFO] [stdout] 589 | | .tags [INFO] [stdout] 590 | | .iter() [INFO] [stdout] 591 | | .filter(|my_tag| my_tag.starts_with(search_tag.as_str())) [INFO] [stdout] ... | [INFO] [stdout] 598 | | }) [INFO] [stdout] 599 | | .collect()) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse_json.rs:201:12 [INFO] [stdout] | [INFO] [stdout] 61 | let value: String<1000> = remove_whitespace(value)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 109 | let mut locs: Vec = Vec::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | let content = if content_data.len() > 0 { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 183 | let mut tags = Vec::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 201 | Ok(Note { [INFO] [stdout] | ____________^ [INFO] [stdout] 202 | | id, [INFO] [stdout] 203 | | pubkey, [INFO] [stdout] 204 | | created_at, [INFO] [stdout] ... | [INFO] [stdout] 208 | | sig, [INFO] [stdout] 209 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nostr-nostd` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:218:27 [INFO] [stdout] | [INFO] [stdout] 210 | pub fn add_tag(mut self, tag: String) -> NoteBuilder { [INFO] [stdout] | -------- --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 211 | let next_tags = self.build_status.tags.next(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 218 | build_status: BuildStatus { tags: next_tags }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:260:12 [INFO] [stdout] | [INFO] [stdout] 243 | mut self, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 247 | let mut tags = Vec::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 248 | let mut challenge_string: String = String::from("challenge,"); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 253 | let mut relay_str: String = String::from("relay,"); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 260 | Ok(NoteBuilder { [INFO] [stdout] | ____________^ [INFO] [stdout] 261 | | keypair: self.keypair, [INFO] [stdout] 262 | | note: self.note, [INFO] [stdout] 263 | | build_status: BuildStatus { tags: TwoTags }, [INFO] [stdout] 264 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:284:12 [INFO] [stdout] | [INFO] [stdout] 271 | mut self, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 280 | let encrypted = nip04::encrypt(&self.keypair.secret_key(), &pubkey, content, iv)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 281 | self.note.content = Some(encrypted); [INFO] [stdout] 282 | let mut tag = String::from("p,"); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 283 | tag.push_str(rcvr_pubkey).expect("impossible"); [INFO] [stdout] 284 | Ok(self.add_tag(tag)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:309:12 [INFO] [stdout] | [INFO] [stdout] 305 | let sig_obj = secp256k1::Secp256k1::preallocated_new(&mut buf) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 309 | Ok(NoteBuilder { [INFO] [stdout] | ____________^ [INFO] [stdout] 310 | | build_status: BuildStatus { tags: ZeroTags }, [INFO] [stdout] 311 | | keypair: key_pair, [INFO] [stdout] 312 | | note: Note { [INFO] [stdout] ... | [INFO] [stdout] 320 | | }, [INFO] [stdout] 321 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:588:12 [INFO] [stdout] | [INFO] [stdout] 584 | let mut search_tag: String<10> = String::from(tag); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 588 | Ok(self [INFO] [stdout] | ____________^ [INFO] [stdout] 589 | | .tags [INFO] [stdout] 590 | | .iter() [INFO] [stdout] 591 | | .filter(|my_tag| my_tag.starts_with(search_tag.as_str())) [INFO] [stdout] ... | [INFO] [stdout] 598 | | }) [INFO] [stdout] 599 | | .collect()) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse_json.rs:201:12 [INFO] [stdout] | [INFO] [stdout] 61 | let value: String<1000> = remove_whitespace(value)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 109 | let mut locs: Vec = Vec::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | let content = if content_data.len() > 0 { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 183 | let mut tags = Vec::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 201 | Ok(Note { [INFO] [stdout] | ____________^ [INFO] [stdout] 202 | | id, [INFO] [stdout] 203 | | pubkey, [INFO] [stdout] 204 | | created_at, [INFO] [stdout] ... | [INFO] [stdout] 208 | | sig, [INFO] [stdout] 209 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nostr-nostd` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "3ace2969f6196fc5634f289aea5ec3960171d6a0efcbcf17c13f5c90a0d4eac1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3ace2969f6196fc5634f289aea5ec3960171d6a0efcbcf17c13f5c90a0d4eac1", kill_on_drop: false }` [INFO] [stdout] 3ace2969f6196fc5634f289aea5ec3960171d6a0efcbcf17c13f5c90a0d4eac1