[INFO] fetching crate noodles-bgzf 0.32.0... [INFO] checking noodles-bgzf-0.32.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate noodles-bgzf 0.32.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate noodles-bgzf 0.32.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate noodles-bgzf 0.32.0 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate noodles-bgzf 0.32.0 [INFO] tweaked toml for crates.io crate noodles-bgzf 0.32.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate noodles-bgzf 0.32.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d74a1211d6e9cf8d4925c2e9baba6c68f795e002ed0c29aeb84742e029472fb7 [INFO] running `Command { std: "docker" "start" "-a" "d74a1211d6e9cf8d4925c2e9baba6c68f795e002ed0c29aeb84742e029472fb7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d74a1211d6e9cf8d4925c2e9baba6c68f795e002ed0c29aeb84742e029472fb7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d74a1211d6e9cf8d4925c2e9baba6c68f795e002ed0c29aeb84742e029472fb7", kill_on_drop: false }` [INFO] [stdout] d74a1211d6e9cf8d4925c2e9baba6c68f795e002ed0c29aeb84742e029472fb7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 45bdaf2eafaaf47ef4387d1475be338e8cb3c7ec4dec2e6a50d63e61c17fe7af [INFO] running `Command { std: "docker" "start" "-a" "45bdaf2eafaaf47ef4387d1475be338e8cb3c7ec4dec2e6a50d63e61c17fe7af", kill_on_drop: false }` [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Checking bytes v1.6.1 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.71 [INFO] [stderr] Checking flate2 v1.0.30 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking noodles-bgzf v0.32.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gzi/reader.rs:100:15 [INFO] [stdout] | [INFO] [stdout] 100 | match self.inner.read_u8() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/indexed_reader.rs:76:20 [INFO] [stdout] | [INFO] [stdout] 74 | pub fn new(inner: R, index: gzi::Index) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | Self { [INFO] [stdout] 76 | inner: Reader::new(inner), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/indexed_reader/builder.rs:40:12 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn build_from_path

(self, src: P) -> io::Result> [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | let inner = self.reader_builder.build_from_path(src)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | [INFO] [stdout] 40 | Ok(IndexedReader { inner, index }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/indexed_reader/builder.rs:54:12 [INFO] [stdout] | [INFO] [stdout] 44 | pub fn build_from_reader(self, reader: R) -> io::Result> [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | let inner = self.reader_builder.build_from_reader(reader); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | [INFO] [stdout] 54 | Ok(IndexedReader { inner, index }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/multithreaded_reader.rs:142:20 [INFO] [stdout] | [INFO] [stdout] 140 | pub fn with_worker_count(worker_count: NonZeroUsize, inner: R) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 141 | Self { [INFO] [stdout] 142 | state: State::Paused(inner), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/multithreaded_reader.rs:385:19 [INFO] [stdout] | [INFO] [stdout] 375 | mut reader: R, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 376 | inflate_tx: InflateTx, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 377 | read_tx: ReadTx, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 378 | recycle_rx: RecycleRx, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 385 | thread::spawn(move || { [INFO] [stdout] | ___________________^ [INFO] [stdout] 386 | | while let Ok(mut buffer) = recycle_rx.recv() { [INFO] [stdout] 387 | | match read_frame_into(&mut reader, &mut buffer.buf) { [INFO] [stdout] 388 | | Ok(result) if result.is_none() => break, [INFO] [stdout] ... | [INFO] [stdout] 399 | | Ok(reader) [INFO] [stdout] 400 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/multithreaded_reader.rs:410:27 [INFO] [stdout] | [INFO] [stdout] 408 | let inflate_rx = inflate_rx.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 409 | [INFO] [stdout] 410 | thread::spawn(move || { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 411 | | while let Ok((mut buffer, buffered_tx)) = inflate_rx.recv() { [INFO] [stdout] 412 | | let result = parse_block(&buffer.buf, &mut buffer.block).map(|_| buffer); [INFO] [stdout] 413 | | buffered_tx.send(result).unwrap(); [INFO] [stdout] 414 | | } [INFO] [stdout] 415 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/multithreaded_writer.rs:190:19 [INFO] [stdout] | [INFO] [stdout] 184 | fn spawn_writer(mut writer: W, write_rx: WriteRx) -> JoinHandle> [INFO] [stdout] | ------------- ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 190 | thread::spawn(move || { [INFO] [stdout] | ___________________^ [INFO] [stdout] 191 | | while let Ok(buffered_rx) = write_rx.recv() { [INFO] [stdout] 192 | | if let Ok(result) = buffered_rx.recv() { [INFO] [stdout] 193 | | let (compressed_data, crc32, uncompressed_len) = result?; [INFO] [stdout] ... | [INFO] [stdout] 200 | | Ok(writer) [INFO] [stdout] 201 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/multithreaded_writer.rs:218:27 [INFO] [stdout] | [INFO] [stdout] 216 | let deflate_rx = deflate_rx.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 217 | [INFO] [stdout] 218 | thread::spawn(move || { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 219 | | while let Ok((src, buffered_tx)) = deflate_rx.recv() { [INFO] [stdout] 220 | | let result = compress(&src, compression_level); [INFO] [stdout] 221 | | buffered_tx.send(result).ok(); [INFO] [stdout] 222 | | } [INFO] [stdout] 223 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/multithreaded_writer/builder.rs:67:20 [INFO] [stdout] | [INFO] [stdout] 51 | pub fn build_from_writer(self, writer: W) -> MultithreadedWriter [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | let (write_tx, write_rx) = crossbeam_channel::bounded(worker_count); [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | let (deflate_tx, deflate_rx) = crossbeam_channel::bounded(worker_count); [INFO] [stdout] | ---------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | [INFO] [stdout] 62 | let writer_handle = spawn_writer(writer, write_rx); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | let deflater_handles = [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | state: State::Running { [INFO] [stdout] | ____________________^ [INFO] [stdout] 68 | | writer_handle, [INFO] [stdout] 69 | | deflater_handles, [INFO] [stdout] 70 | | write_tx, [INFO] [stdout] 71 | | deflate_tx, [INFO] [stdout] 72 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/multithreaded_writer/builder.rs:73:18 [INFO] [stdout] | [INFO] [stdout] 51 | pub fn build_from_writer(self, writer: W) -> MultithreadedWriter [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | let (write_tx, write_rx) = crossbeam_channel::bounded(worker_count); [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | let (deflate_tx, deflate_rx) = crossbeam_channel::bounded(worker_count); [INFO] [stdout] | ---------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | [INFO] [stdout] 62 | let writer_handle = spawn_writer(writer, write_rx); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | let deflater_handles = [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | buf: BytesMut::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader/builder.rs:30:12 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn build_from_path

(self, src: P) -> io::Result> [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | let file = File::open(src)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | Ok(self.build_from_reader(file)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writer.rs:119:9 [INFO] [stdout] | [INFO] [stdout] 118 | pub fn into_inner(mut self) -> W { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 119 | self.inner.take().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writer/builder.rs:43:20 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn build_with_writer(self, writer: W) -> Writer [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | inner: Some(writer), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `noodles-bgzf` (lib) due to 15 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "45bdaf2eafaaf47ef4387d1475be338e8cb3c7ec4dec2e6a50d63e61c17fe7af", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "45bdaf2eafaaf47ef4387d1475be338e8cb3c7ec4dec2e6a50d63e61c17fe7af", kill_on_drop: false }` [INFO] [stdout] 45bdaf2eafaaf47ef4387d1475be338e8cb3c7ec4dec2e6a50d63e61c17fe7af