[INFO] fetching crate non_blocking_mutex 3.1.3... [INFO] checking non_blocking_mutex-3.1.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate non_blocking_mutex 3.1.3 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate non_blocking_mutex 3.1.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate non_blocking_mutex 3.1.3 [INFO] finished tweaking crates.io crate non_blocking_mutex 3.1.3 [INFO] tweaked toml for crates.io crate non_blocking_mutex 3.1.3 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 72 packages to latest compatible versions [INFO] [stderr] Adding anes v0.1.6 (latest: v0.2.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 10b37044851b7126c5d2baebd17790289944fcbcc5b93ad2493acf4d10c7059e [INFO] running `Command { std: "docker" "start" "-a" "10b37044851b7126c5d2baebd17790289944fcbcc5b93ad2493acf4d10c7059e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "10b37044851b7126c5d2baebd17790289944fcbcc5b93ad2493acf4d10c7059e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "10b37044851b7126c5d2baebd17790289944fcbcc5b93ad2493acf4d10c7059e", kill_on_drop: false }` [INFO] [stdout] 10b37044851b7126c5d2baebd17790289944fcbcc5b93ad2493acf4d10c7059e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 524a9bc5afecd680a50ae1cc2d20bcf67ad2d9838e664a0c9515c7997080f1b9 [INFO] running `Command { std: "docker" "start" "-a" "524a9bc5afecd680a50ae1cc2d20bcf67ad2d9838e664a0c9515c7997080f1b9", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking plotters-backend v0.3.6 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking nameof v1.2.2 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking plotters-svg v0.3.6 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking sharded_queue v2.0.1 [INFO] [stderr] Checking non_blocking_mutex v3.1.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/dynamic_non_blocking_mutex.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 28 | / /// Note that if [`fetch_sub`] != 1 [INFO] [stdout] 29 | | /// => some thread entered first if block in method [INFO] [stdout] 30 | | /// => [ShardedQueue::push_back] is guaranteed to be called [INFO] [stdout] 31 | | /// => [ShardedQueue::pop_front_or_spin_wait_item] will not deadlock while spins until it gets item [INFO] [stdout] 32 | | /// [INFO] [stdout] 33 | | /// Notice that we run action first, and only then decrement count [INFO] [stdout] 34 | | /// with releasing(pushing) memory changes, even if it looks otherwise [INFO] [stdout] | |__________________________________________________________________________________^ [INFO] [stdout] 35 | / while self.task_count.fetch_sub(1, Ordering::Release) != 1 { [INFO] [stdout] 36 | | self.task_queue [INFO] [stdout] 37 | | .pop_front_or_spin_wait_item() [INFO] [stdout] 38 | | .run_with_state(unsafe { MutexGuard::new(&self.unsafe_state) }); [INFO] [stdout] 39 | | } [INFO] [stdout] | |_____________- rustdoc does not generate documentation for expressions [INFO] [stdout] | [INFO] [stdout] = help: use `//` for a plain comment [INFO] [stdout] = note: `#[warn(unused_doc_comments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::non_blocking_mutex::NonBlockingMutex` [INFO] [stdout] --> src/extensions/run_if_first_or_schedule_to_run_last.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::non_blocking_mutex::NonBlockingMutex; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/non_blocking_mutex.rs:311:13 [INFO] [stdout] | [INFO] [stdout] 311 | / /// Note that if [`fetch_sub`] != 1 [INFO] [stdout] 312 | | /// => some thread entered first if block in method [INFO] [stdout] 313 | | /// => [ShardedQueue::push_back] is guaranteed to be called [INFO] [stdout] 314 | | /// => [ShardedQueue::pop_front_or_spin_wait_item] will not deadlock while spins until it gets item [INFO] [stdout] 315 | | /// [INFO] [stdout] 316 | | /// Notice that we run action first, and only then decrement count [INFO] [stdout] 317 | | /// with releasing(pushing) memory changes, even if it looks otherwise [INFO] [stdout] | |__________________________________________________________________________________^ [INFO] [stdout] 318 | / while self.task_count.fetch_sub(1, Ordering::Release) != 1 { [INFO] [stdout] 319 | | self.task_queue [INFO] [stdout] 320 | | .pop_front_or_spin_wait_item() [INFO] [stdout] 321 | | .run_with_state(unsafe { MutexGuard::new(&self.unsafe_state) }); [INFO] [stdout] 322 | | } [INFO] [stdout] | |_____________- rustdoc does not generate documentation for expressions [INFO] [stdout] | [INFO] [stdout] = help: use `//` for a plain comment [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stdout] warning: struct `NonBlockingMutexSendSyncImplementationDocTests` is never constructed [INFO] [stdout] --> src/non_blocking_mutex.rs:646:8 [INFO] [stdout] | [INFO] [stdout] 646 | struct NonBlockingMutexSendSyncImplementationDocTests {} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dynamic_non_blocking_mutex_task.rs:13:33 [INFO] [stdout] | [INFO] [stdout] 10 | run_with_state: impl FnOnce(MutexGuard) + Send + 'captured_variables, [INFO] [stdout] | --------------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 13 | run_with_state_box: Box::new(run_with_state), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/non_blocking_mutex.rs:296:25 [INFO] [stdout] | [INFO] [stdout] 293 | pub fn new(max_concurrent_thread_count: usize, state: State) -> Self { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 296 | task_queue: ShardedQueue::new(max_concurrent_thread_count), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/non_blocking_mutex.rs:297:27 [INFO] [stdout] | [INFO] [stdout] 293 | pub fn new(max_concurrent_thread_count: usize, state: State) -> Self { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 297 | unsafe_state: UnsafeCell::new(state), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `non_blocking_mutex` (lib) due to 4 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "524a9bc5afecd680a50ae1cc2d20bcf67ad2d9838e664a0c9515c7997080f1b9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "524a9bc5afecd680a50ae1cc2d20bcf67ad2d9838e664a0c9515c7997080f1b9", kill_on_drop: false }` [INFO] [stdout] 524a9bc5afecd680a50ae1cc2d20bcf67ad2d9838e664a0c9515c7997080f1b9