[INFO] fetching crate nom-rule 0.3.1... [INFO] checking nom-rule-0.3.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate nom-rule 0.3.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate nom-rule 0.3.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate nom-rule 0.3.1 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate nom-rule 0.3.1 [INFO] tweaked toml for crates.io crate nom-rule 0.3.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 17 packages to latest compatible versions [INFO] [stderr] Adding logos v0.12.1 (latest: v0.14.1) [INFO] [stderr] Adding logos-derive v0.12.1 (latest: v0.14.1) [INFO] [stderr] Adding pratt v0.3.0 (latest: v0.4.0) [INFO] [stderr] Adding regex-syntax v0.6.29 (latest: v0.8.4) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8c51211936fdc4838d22e4200e7f62aed2e804fcb040af252e5edd299ba4048f [INFO] running `Command { std: "docker" "start" "-a" "8c51211936fdc4838d22e4200e7f62aed2e804fcb040af252e5edd299ba4048f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8c51211936fdc4838d22e4200e7f62aed2e804fcb040af252e5edd299ba4048f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8c51211936fdc4838d22e4200e7f62aed2e804fcb040af252e5edd299ba4048f", kill_on_drop: false }` [INFO] [stdout] 8c51211936fdc4838d22e4200e7f62aed2e804fcb040af252e5edd299ba4048f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e7f12b52d0b86584c588b22443a1b52df598f5ba53930062996a21f0b59374da [INFO] running `Command { std: "docker" "start" "-a" "e7f12b52d0b86584c588b22443a1b52df598f5ba53930062996a21f0b59374da", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Compiling regex-syntax v0.6.29 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling beef v0.5.2 [INFO] [stderr] Compiling minimal-lexical v0.2.1 [INFO] [stderr] Checking pratt v0.3.0 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking nom-rule v0.3.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn rule(tokens: proc_macro::TokenStream) -> proc_macro::TokenStream { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | let tokens: TokenStream = tokens.into(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | let i: Vec = tokens.into_iter().collect(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | [INFO] [stdout] 23 | let (i, (match_text, _, match_token, _)) = [INFO] [stdout] | ---------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | let terminal = CustomTerminal { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | let rule = parse_rule(i.iter().cloned().collect()); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | rule.check_return_type(); [INFO] [stdout] 33 | rule.to_token_stream(&terminal).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:96:20 [INFO] [stdout] | [INFO] [stdout] 96 | move |i| match i.get(0).and_then(|token| match token { [INFO] [stdout] | ____________________^ [INFO] [stdout] 97 | | TokenTree::Punct(p) if p.as_char() == punct => Some(token.clone()), [INFO] [stdout] 98 | | _ => None, [INFO] [stdout] 99 | | }) { [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:148:20 [INFO] [stdout] | [INFO] [stdout] 141 | |(head, tail)| { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | let mut segments = vec![head.clone()]; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 148 | (span, Path { segments }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:211:5 [INFO] [stdout] | [INFO] [stdout] 204 | let context = map(tuple((match_punct(':'), literal)), |(colon, msg)| { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 211 | / alt(( [INFO] [stdout] 212 | | map(match_punct('|'), |token| WithSpan { [INFO] [stdout] 213 | | span: token.span(), [INFO] [stdout] 214 | | elem: RuleElement::Choice, [INFO] [stdout] ... | [INFO] [stdout] 257 | | context, [INFO] [stdout] 258 | | ))(i) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:196:12 [INFO] [stdout] | [INFO] [stdout] 181 | let (i, hashtag) = match_punct('#')(i)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 182 | let (i, (path_span, fn_path)) = path(i)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 183 | let (i, args) = opt(verify(group, |g| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 196 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 197 | | i, [INFO] [stdout] 198 | | WithSpan { [INFO] [stdout] 199 | | elem: RuleElement::ExternalFunction(fn_path, args), [INFO] [stdout] 200 | | span, [INFO] [stdout] 201 | | }, [INFO] [stdout] 202 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:207:19 [INFO] [stdout] | [INFO] [stdout] 204 | let context = map(tuple((match_punct(':'), literal)), |(colon, msg)| { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 207 | elem: RuleElement::Context(msg), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:214:19 [INFO] [stdout] | [INFO] [stdout] 212 | map(match_punct('|'), |token| WithSpan { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 213 | span: token.span(), [INFO] [stdout] 214 | elem: RuleElement::Choice, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:218:19 [INFO] [stdout] | [INFO] [stdout] 216 | map(match_punct('*'), |token| WithSpan { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 217 | span: token.span(), [INFO] [stdout] 218 | elem: RuleElement::Many0, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:222:19 [INFO] [stdout] | [INFO] [stdout] 220 | map(match_punct('+'), |token| WithSpan { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 221 | span: token.span(), [INFO] [stdout] 222 | elem: RuleElement::Many1, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:226:19 [INFO] [stdout] | [INFO] [stdout] 224 | map(match_punct('?'), |token| WithSpan { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 225 | span: token.span(), [INFO] [stdout] 226 | elem: RuleElement::Optional, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:230:19 [INFO] [stdout] | [INFO] [stdout] 228 | map(match_punct('^'), |token| WithSpan { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 229 | span: token.span(), [INFO] [stdout] 230 | elem: RuleElement::Cut, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:234:19 [INFO] [stdout] | [INFO] [stdout] 232 | map(match_punct('&'), |token| WithSpan { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 233 | span: token.span(), [INFO] [stdout] 234 | elem: RuleElement::Peek, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:238:19 [INFO] [stdout] | [INFO] [stdout] 236 | map(match_punct('!'), |token| WithSpan { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 237 | span: token.span(), [INFO] [stdout] 238 | elem: RuleElement::Not, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:242:19 [INFO] [stdout] | [INFO] [stdout] 240 | map(match_punct('~'), |token| WithSpan { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 241 | span: token.span(), [INFO] [stdout] 242 | elem: RuleElement::Sequence, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:246:19 [INFO] [stdout] | [INFO] [stdout] 246 | elem: RuleElement::MatchText(lit), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:250:19 [INFO] [stdout] | [INFO] [stdout] 248 | map(path, |(span, p)| WithSpan { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 249 | span, [INFO] [stdout] 250 | elem: RuleElement::MatchToken(p), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:254:19 [INFO] [stdout] | [INFO] [stdout] 252 | map(group, |group| WithSpan { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 253 | span: group.span(), [INFO] [stdout] 254 | elem: RuleElement::SubRule(parse_rule(group.stream())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 17 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nom-rule` (lib) due to 18 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "e7f12b52d0b86584c588b22443a1b52df598f5ba53930062996a21f0b59374da", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e7f12b52d0b86584c588b22443a1b52df598f5ba53930062996a21f0b59374da", kill_on_drop: false }` [INFO] [stdout] e7f12b52d0b86584c588b22443a1b52df598f5ba53930062996a21f0b59374da