[INFO] fetching crate noise_sv2 1.1.0... [INFO] checking noise_sv2-1.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate noise_sv2 1.1.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate noise_sv2 1.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate noise_sv2 1.1.0 [INFO] finished tweaking crates.io crate noise_sv2 1.1.0 [INFO] tweaked toml for crates.io crate noise_sv2 1.1.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 54 packages to latest compatible versions [INFO] [stderr] Adding bitcoin-internals v0.2.0 (latest: v0.3.0) [INFO] [stderr] Adding bitcoin_hashes v0.13.0 (latest: v0.14.0) [INFO] [stderr] Adding const_sv2 v0.1.3 (latest: v2.0.0) [INFO] [stderr] Adding env_logger v0.8.4 (latest: v0.11.5) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding hex-conservative v0.1.2 (latest: v0.2.1) [INFO] [stderr] Adding secp256k1 v0.28.2 (latest: v0.29.0) [INFO] [stderr] Adding secp256k1-sys v0.9.2 (latest: v0.10.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 78d56500a530ab2969572c054a65046c52e0af5520860d44d94c8250e65149d9 [INFO] running `Command { std: "docker" "start" "-a" "78d56500a530ab2969572c054a65046c52e0af5520860d44d94c8250e65149d9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "78d56500a530ab2969572c054a65046c52e0af5520860d44d94c8250e65149d9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "78d56500a530ab2969572c054a65046c52e0af5520860d44d94c8250e65149d9", kill_on_drop: false }` [INFO] [stdout] 78d56500a530ab2969572c054a65046c52e0af5520860d44d94c8250e65149d9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 64676f3c290f94f5fb05abf7eb85b04e4762045b62bd90d750d8070df91884d7 [INFO] running `Command { std: "docker" "start" "-a" "64676f3c290f94f5fb05abf7eb85b04e4762045b62bd90d750d8070df91884d7", kill_on_drop: false }` [INFO] [stderr] Compiling bitcoin-internals v0.2.0 [INFO] [stderr] Checking opaque-debug v0.3.1 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking hex-conservative v0.1.2 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling secp256k1-sys v0.9.2 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking bitcoin_hashes v0.13.0 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking polyval v0.6.2 [INFO] [stderr] Checking poly1305 v0.8.0 [INFO] [stderr] Checking ctr v0.9.2 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking chacha20 v0.9.1 [INFO] [stderr] Checking ghash v0.5.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking chacha20poly1305 v0.10.1 [INFO] [stderr] Checking aes-gcm v0.10.3 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking secp256k1 v0.28.2 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling quickcheck_macros v1.0.0 [INFO] [stderr] Checking env_logger v0.8.4 [INFO] [stderr] Checking const_sv2 v0.1.3 [INFO] [stderr] Checking noise_sv2 v1.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: methods `into_aesg` and `into_chacha` are never used [INFO] [stdout] --> src/cipher_state.rs:26:8 [INFO] [stdout] | [INFO] [stdout] 7 | pub trait CipherState [INFO] [stdout] | ----------- methods in this trait [INFO] [stdout] ... [INFO] [stdout] 26 | fn into_aesg(mut self) -> Option> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 33 | fn into_chacha(mut self) -> Option> { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `name`, `hkdf_3`, and `ecdh` are never used [INFO] [stdout] --> src/handshake.rs:10:8 [INFO] [stdout] | [INFO] [stdout] 9 | pub trait HandshakeOp: CipherState { [INFO] [stdout] | ----------- associated items in this trait [INFO] [stdout] 10 | fn name(&self) -> String; [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 69 | fn hkdf_3( [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 109 | fn ecdh(private: &[u8], public: &[u8]) -> [u8; 32] { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking quickcheck v1.0.3 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cipher_state.rs:30:14 [INFO] [stdout] | [INFO] [stdout] 26 | fn into_aesg(mut self) -> Option> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | let c = Aes256Gcm::from_key(k); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | Some(Cipher::from_cipher(c)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cipher_state.rs:37:14 [INFO] [stdout] | [INFO] [stdout] 33 | fn into_chacha(mut self) -> Option> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | let c = ChaCha20Poly1305::from_key(k); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | Some(Cipher::from_cipher(c)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cipher_state.rs:201:21 [INFO] [stdout] | [INFO] [stdout] 197 | pub fn from_key_and_cipher(k: [u8; 32], c: C) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 201 | cipher: Some(c), [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cipher_state.rs:211:21 [INFO] [stdout] | [INFO] [stdout] 207 | pub fn from_cipher(c: C) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 211 | cipher: Some(c), [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/responder.rs:258:12 [INFO] [stdout] | [INFO] [stdout] 243 | let c1 = ChaCha20Poly1305::new(&temp_k1.into()); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 244 | let c2 = ChaCha20Poly1305::new(&temp_k2.into()); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 245 | let c1: Cipher = Cipher::from_key_and_cipher(temp_k1, c1); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 246 | let c2: Cipher = Cipher::from_key_and_cipher(temp_k2, c2); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 250 | let mut encryptor = GenericCipher::ChaCha20Poly1305(c2); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 251 | let mut decryptor = GenericCipher::ChaCha20Poly1305(c1); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 254 | let codec = crate::NoiseCodec { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 258 | Ok((to_send, codec)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `noise_sv2` (lib) due to 6 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "64676f3c290f94f5fb05abf7eb85b04e4762045b62bd90d750d8070df91884d7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "64676f3c290f94f5fb05abf7eb85b04e4762045b62bd90d750d8070df91884d7", kill_on_drop: false }` [INFO] [stdout] 64676f3c290f94f5fb05abf7eb85b04e4762045b62bd90d750d8070df91884d7