[INFO] fetching crate noise-algebra 0.1.26... [INFO] checking noise-algebra-0.1.26 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate noise-algebra 0.1.26 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate noise-algebra 0.1.26 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate noise-algebra 0.1.26 [INFO] finished tweaking crates.io crate noise-algebra 0.1.26 [INFO] tweaked toml for crates.io crate noise-algebra 0.1.26 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 86 packages to latest compatible versions [INFO] [stderr] Adding anes v0.1.6 (latest: v0.2.0) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding ndarray v0.15.6 (latest: v0.16.1) [INFO] [stderr] Adding paste v0.1.18 (latest: v1.0.15) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 154e6b8c9d6f62ebedced4a483ea79d5dfba5250bfc02575895c19339d95269a [INFO] running `Command { std: "docker" "start" "-a" "154e6b8c9d6f62ebedced4a483ea79d5dfba5250bfc02575895c19339d95269a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "154e6b8c9d6f62ebedced4a483ea79d5dfba5250bfc02575895c19339d95269a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "154e6b8c9d6f62ebedced4a483ea79d5dfba5250bfc02575895c19339d95269a", kill_on_drop: false }` [INFO] [stdout] 154e6b8c9d6f62ebedced4a483ea79d5dfba5250bfc02575895c19339d95269a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5507096864c4ea6d15ea99f3cd5f00357bad28b466c534a5e5ec80c027466bba [INFO] running `Command { std: "docker" "start" "-a" "5507096864c4ea6d15ea99f3cd5f00357bad28b466c534a5e5ec80c027466bba", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling paste-impl v0.1.18 [INFO] [stderr] Compiling matrixmultiply v0.3.9 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Checking plotters-backend v0.3.6 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Checking rand_xorshift v0.3.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking is-terminal v0.4.13 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking plotters-svg v0.3.6 [INFO] [stderr] Checking paste v0.1.18 [INFO] [stderr] Checking plotters v0.3.6 [INFO] [stderr] Checking simdeez v1.0.8 [INFO] [stderr] Checking noise v0.9.0 [INFO] [stderr] Checking ndarray v0.15.6 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking clap v4.5.16 [INFO] [stderr] Checking simdnoise v3.1.6 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking noise-algebra v0.1.26 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `n` [INFO] [stdout] --> src/algebra/erode.rs:11:20 [INFO] [stdout] | [INFO] [stdout] 11 | fn erode(self, n: NoiseSource<2>, strength: f32, octave: usize) -> (Array2, Array2, Array2) { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_n` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `strength` [INFO] [stdout] --> src/algebra/erode.rs:11:39 [INFO] [stdout] | [INFO] [stdout] 11 | fn erode(self, n: NoiseSource<2>, strength: f32, octave: usize) -> (Array2, Array2, Array2) { [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_strength` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `octave` [INFO] [stdout] --> src/algebra/erode.rs:11:54 [INFO] [stdout] | [INFO] [stdout] 11 | fn erode(self, n: NoiseSource<2>, strength: f32, octave: usize) -> (Array2, Array2, Array2) { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_octave` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `erode` is never used [INFO] [stdout] --> src/algebra/erode.rs:6:8 [INFO] [stdout] | [INFO] [stdout] 5 | pub trait ErosionTrait { [INFO] [stdout] | ------------ method in this trait [INFO] [stdout] 6 | fn erode(self, n: NoiseSource<2>, strength: f32, octaves: usize) -> (Array2, Array2, Array2); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/algebra/add.rs:10:20 [INFO] [stdout] | [INFO] [stdout] 8 | fn add(self, rhs: Signal>) -> Self::Output { [INFO] [stdout] | ---- -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 9 | Signal { [INFO] [stdout] 10 | value: self.value + rhs.value, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/algebra/add.rs:21:20 [INFO] [stdout] | [INFO] [stdout] 19 | fn add(self, rhs: &Signal>) -> Self::Output { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | Signal { [INFO] [stdout] 21 | value: self.value + &rhs.value, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/algebra/add.rs:32:20 [INFO] [stdout] | [INFO] [stdout] 30 | fn add(self, rhs: Signal>) -> Self::Output { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | Signal { [INFO] [stdout] 32 | value: &self.value + rhs.value, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/algebra/sub.rs:11:20 [INFO] [stdout] | [INFO] [stdout] 9 | fn sub(self, rhs: Signal>) -> Self::Output { [INFO] [stdout] | ---- -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 10 | Signal { [INFO] [stdout] 11 | value: self.value - rhs.value, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/algebra/sub.rs:22:20 [INFO] [stdout] | [INFO] [stdout] 20 | fn sub(self, rhs: &Signal>) -> Self::Output { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | Signal { [INFO] [stdout] 22 | value: self.value - &rhs.value, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/algebra/mul.rs:10:20 [INFO] [stdout] | [INFO] [stdout] 8 | fn mul(self, rhs: Signal>) -> Self::Output { [INFO] [stdout] | ---- -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 9 | Signal { [INFO] [stdout] 10 | value: self.value * rhs.value, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/algebra/mul.rs:21:20 [INFO] [stdout] | [INFO] [stdout] 19 | fn mul(self, rhs: &Signal>) -> Self::Output { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | Signal { [INFO] [stdout] 21 | value: self.value * &rhs.value, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/algebra/mul.rs:32:20 [INFO] [stdout] | [INFO] [stdout] 30 | fn mul(self, rhs: f32) -> Self::Output { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | Signal { [INFO] [stdout] 32 | value: self.value * rhs, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/algebra/not.rs:10:20 [INFO] [stdout] | [INFO] [stdout] 8 | fn not(self) -> Self::Output { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 9 | Signal { [INFO] [stdout] 10 | value: self.amp - self.value, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/algebra/threshold.rs:7:20 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn threshold(self, t: f32) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 6 | Signal { [INFO] [stdout] 7 | value: 1.0 / (1.0 + (-64. * (self.value - t + 0.1)).map(|v| v.exp())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/algebra/quantize.rs:7:20 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn quantize(self, step: f32) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 6 | Signal { [INFO] [stdout] 7 | value: (self.value*step).map(|v| v.floor())/step, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `noise-algebra` (lib) due to 12 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "5507096864c4ea6d15ea99f3cd5f00357bad28b466c534a5e5ec80c027466bba", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5507096864c4ea6d15ea99f3cd5f00357bad28b466c534a5e5ec80c027466bba", kill_on_drop: false }` [INFO] [stdout] 5507096864c4ea6d15ea99f3cd5f00357bad28b466c534a5e5ec80c027466bba