[INFO] fetching crate nodium-events 0.1.2... [INFO] checking nodium-events-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate nodium-events 0.1.2 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate nodium-events 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate nodium-events 0.1.2 [INFO] finished tweaking crates.io crate nodium-events 0.1.2 [INFO] tweaked toml for crates.io crate nodium-events 0.1.2 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 49 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding env_logger v0.9.3 (latest: v0.11.5) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 032af20484bd074a96cdbbb3d3c522e138bf3f982976e68b85626045c5d7cff8 [INFO] running `Command { std: "docker" "start" "-a" "032af20484bd074a96cdbbb3d3c522e138bf3f982976e68b85626045c5d7cff8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "032af20484bd074a96cdbbb3d3c522e138bf3f982976e68b85626045c5d7cff8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "032af20484bd074a96cdbbb3d3c522e138bf3f982976e68b85626045c5d7cff8", kill_on_drop: false }` [INFO] [stdout] 032af20484bd074a96cdbbb3d3c522e138bf3f982976e68b85626045c5d7cff8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c72a52804204b3a2f4c38b24e1e7942ea88d97fabc36e8e7c8b30b26b95e57ef [INFO] running `Command { std: "docker" "start" "-a" "c72a52804204b3a2f4c38b24e1e7942ea88d97fabc36e8e7c8b30b26b95e57ef", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking env_logger v0.9.3 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking nodium-events v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bus.rs:17:16 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn new(event_notifier: EventNotifier) -> Arc> { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | Arc::new(Mutex::new(Self { [INFO] [stdout] | ________________^ [INFO] [stdout] 18 | | event_handlers: RwLock::new(HashMap::new()), [INFO] [stdout] 19 | | event_notifier, [INFO] [stdout] 20 | | })) [INFO] [stdout] | |________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/bus.rs:35:36 [INFO] [stdout] | [INFO] [stdout] 35 | let handler = handler.clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Box` does not implement `Clone`, so calling `clone` on `&Box` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 35 - let handler = handler.clone(); [INFO] [stdout] 35 + let handler = handler; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nodium-events` (lib) due to 2 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bus.rs:17:16 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn new(event_notifier: EventNotifier) -> Arc> { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | Arc::new(Mutex::new(Self { [INFO] [stdout] | ________________^ [INFO] [stdout] 18 | | event_handlers: RwLock::new(HashMap::new()), [INFO] [stdout] 19 | | event_notifier, [INFO] [stdout] 20 | | })) [INFO] [stdout] | |________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/bus.rs:35:36 [INFO] [stdout] | [INFO] [stdout] 35 | let handler = handler.clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Box` does not implement `Clone`, so calling `clone` on `&Box` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 35 - let handler = handler.clone(); [INFO] [stdout] 35 + let handler = handler; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nodium-events` (lib test) due to 2 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "c72a52804204b3a2f4c38b24e1e7942ea88d97fabc36e8e7c8b30b26b95e57ef", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c72a52804204b3a2f4c38b24e1e7942ea88d97fabc36e8e7c8b30b26b95e57ef", kill_on_drop: false }` [INFO] [stdout] c72a52804204b3a2f4c38b24e1e7942ea88d97fabc36e8e7c8b30b26b95e57ef