[INFO] fetching crate nobs-vk 0.2.0... [INFO] checking nobs-vk-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate nobs-vk 0.2.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate nobs-vk 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate nobs-vk 0.2.0 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate nobs-vk 0.2.0 [INFO] tweaked toml for crates.io crate nobs-vk 0.2.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 4 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bcc05ef5360381a53521d41b3b33007215d4b254b7da462ad9929a40cb2ba164 [INFO] running `Command { std: "docker" "start" "-a" "bcc05ef5360381a53521d41b3b33007215d4b254b7da462ad9929a40cb2ba164", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bcc05ef5360381a53521d41b3b33007215d4b254b7da462ad9929a40cb2ba164", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bcc05ef5360381a53521d41b3b33007215d4b254b7da462ad9929a40cb2ba164", kill_on_drop: false }` [INFO] [stdout] bcc05ef5360381a53521d41b3b33007215d4b254b7da462ad9929a40cb2ba164 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e12584fc99e341c16d39328a0c03fe9471aa0991aa0f8ba6254cbf29ac8d8691 [INFO] running `Command { std: "docker" "start" "-a" "e12584fc99e341c16d39328a0c03fe9471aa0991aa0f8ba6254cbf29ac8d8691", kill_on_drop: false }` [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking shared_library v0.1.9 [INFO] [stderr] Checking nobs-vk v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated function `std::mem::uninitialized`: use `mem::MaybeUninit` instead [INFO] [stdout] --> src/device/physical_device.rs:79:43 [INFO] [stdout] | [INFO] [stdout] 79 | let mut features = unsafe { std::mem::uninitialized() }; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::mem::uninitialized`: use `mem::MaybeUninit` instead [INFO] [stdout] --> src/device/physical_device.rs:82:45 [INFO] [stdout] | [INFO] [stdout] 82 | let mut properties = unsafe { std::mem::uninitialized() }; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::mem::uninitialized`: use `mem::MaybeUninit` instead [INFO] [stdout] --> src/device/physical_device.rs:79:43 [INFO] [stdout] | [INFO] [stdout] 79 | let mut features = unsafe { std::mem::uninitialized() }; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::mem::uninitialized`: use `mem::MaybeUninit` instead [INFO] [stdout] --> src/device/physical_device.rs:82:45 [INFO] [stdout] | [INFO] [stdout] 82 | let mut properties = unsafe { std::mem::uninitialized() }; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `extern` fn uses type `[f32; 4]`, which is not FFI-safe [INFO] [stdout] --> src/lib.rs:7371:95 [INFO] [stdout] | [INFO] [stdout] 7371 | extern "system" fn CmdSetBlendConstants_panic(_commandBuffer: CommandBuffer, _blendConstants: [f32; 4]){ [INFO] [stdout] | ^^^^^^^^ not FFI-safe [INFO] [stdout] | [INFO] [stdout] = help: consider passing a pointer to the array [INFO] [stdout] = note: passing raw arrays by value is not FFI-safe [INFO] [stdout] = note: `#[warn(improper_ctypes_definitions)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `extern` fn uses type `[f32; 4]`, which is not FFI-safe [INFO] [stdout] --> src/lib.rs:7371:95 [INFO] [stdout] | [INFO] [stdout] 7371 | extern "system" fn CmdSetBlendConstants_panic(_commandBuffer: CommandBuffer, _blendConstants: [f32; 4]){ [INFO] [stdout] | ^^^^^^^^ not FFI-safe [INFO] [stdout] | [INFO] [stdout] = help: consider passing a pointer to the array [INFO] [stdout] = note: passing raw arrays by value is not FFI-safe [INFO] [stdout] = note: `#[warn(improper_ctypes_definitions)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/device/physical_device.rs:44:38 [INFO] [stdout] | [INFO] [stdout] 44 | let layer_cstr = layer.map(|n| CString::new(n).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/device/physical_device.rs:44:38 [INFO] [stdout] | [INFO] [stdout] 44 | let layer_cstr = layer.map(|n| CString::new(n).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `PhysicalDeviceFeatures` does not permit being left uninitialized [INFO] [stdout] --> src/device/physical_device.rs:79:33 [INFO] [stdout] | [INFO] [stdout] 79 | let mut features = unsafe { std::mem::uninitialized() }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] note: integers must be initialized (in this struct field) [INFO] [stdout] --> src/lib.rs:3231:3 [INFO] [stdout] | [INFO] [stdout] 3231 | pub robustBufferAccess: Bool32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(invalid_value)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `PhysicalDeviceFeatures` does not permit being left uninitialized [INFO] [stdout] --> src/device/physical_device.rs:79:33 [INFO] [stdout] | [INFO] [stdout] 79 | let mut features = unsafe { std::mem::uninitialized() }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] note: integers must be initialized (in this struct field) [INFO] [stdout] --> src/lib.rs:3231:3 [INFO] [stdout] | [INFO] [stdout] 3231 | pub robustBufferAccess: Bool32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(invalid_value)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `PhysicalDeviceProperties` does not permit being left uninitialized [INFO] [stdout] --> src/device/physical_device.rs:82:35 [INFO] [stdout] | [INFO] [stdout] 82 | let mut properties = unsafe { std::mem::uninitialized() }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] note: integers must be initialized (in this struct field) [INFO] [stdout] --> src/lib.rs:2262:3 [INFO] [stdout] | [INFO] [stdout] 2262 | pub apiVersion: u32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `PhysicalDeviceProperties` does not permit being left uninitialized [INFO] [stdout] --> src/device/physical_device.rs:82:35 [INFO] [stdout] | [INFO] [stdout] 82 | let mut properties = unsafe { std::mem::uninitialized() }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] note: integers must be initialized (in this struct field) [INFO] [stdout] --> src/lib.rs:2262:3 [INFO] [stdout] | [INFO] [stdout] 2262 | pub apiVersion: u32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function pointers are not nullable, so checking them for null will always return false [INFO] [stdout] --> src/instance.rs:37:11 [INFO] [stdout] | [INFO] [stdout] 37 | if !(ptr as *const c_void).is_null() { [INFO] [stdout] | ^---^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | expression has type `extern "system" fn()` [INFO] [stdout] | [INFO] [stdout] = help: wrap the function pointer inside an `Option` and use `Option::is_none` to check for null pointer value [INFO] [stdout] = note: `#[warn(useless_ptr_null_checks)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function pointers are not nullable, so checking them for null will always return false [INFO] [stdout] --> src/instance.rs:37:11 [INFO] [stdout] | [INFO] [stdout] 37 | if !(ptr as *const c_void).is_null() { [INFO] [stdout] | ^---^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | expression has type `extern "system" fn()` [INFO] [stdout] | [INFO] [stdout] = help: wrap the function pointer inside an `Option` and use `Option::is_none` to check for null pointer value [INFO] [stdout] = note: `#[warn(useless_ptr_null_checks)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/instance.rs:207:36 [INFO] [stdout] | [INFO] [stdout] 207 | let layer_cstr = layer.map(|n| CString::new(n).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/instance.rs:207:36 [INFO] [stdout] | [INFO] [stdout] 207 | let layer_cstr = layer.map(|n| CString::new(n).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/instance.rs:314:8 [INFO] [stdout] | [INFO] [stdout] 263 | pub fn create(&mut self, vklib: std::boxed::Box) -> Result { [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 314 | Ok(Instance { [INFO] [stdout] | ________^ [INFO] [stdout] 315 | | vklib, [INFO] [stdout] 316 | | debug_callback, [INFO] [stdout] 317 | | handle, [INFO] [stdout] 318 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/instance.rs:314:8 [INFO] [stdout] | [INFO] [stdout] 263 | pub fn create(&mut self, vklib: std::boxed::Box) -> Result { [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 314 | Ok(Instance { [INFO] [stdout] | ________^ [INFO] [stdout] 315 | | vklib, [INFO] [stdout] 316 | | debug_callback, [INFO] [stdout] 317 | | handle, [INFO] [stdout] 318 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function pointers are not nullable, so checking them for null will always return false [INFO] [stdout] --> src/instance.rs:300:11 [INFO] [stdout] | [INFO] [stdout] 300 | if !(ptr as *const c_void).is_null() { [INFO] [stdout] | ^---^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | expression has type `extern "system" fn()` [INFO] [stdout] | [INFO] [stdout] = help: wrap the function pointer inside an `Option` and use `Option::is_none` to check for null pointer value [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function pointers are not nullable, so checking them for null will always return false [INFO] [stdout] --> src/instance.rs:300:11 [INFO] [stdout] | [INFO] [stdout] 300 | if !(ptr as *const c_void).is_null() { [INFO] [stdout] | ^---^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | expression has type `extern "system" fn()` [INFO] [stdout] | [INFO] [stdout] = help: wrap the function pointer inside an `Option` and use `Option::is_none` to check for null pointer value [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nobs-vk` (lib) due to 4 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `nobs-vk` (lib test) due to 4 previous errors; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "e12584fc99e341c16d39328a0c03fe9471aa0991aa0f8ba6254cbf29ac8d8691", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e12584fc99e341c16d39328a0c03fe9471aa0991aa0f8ba6254cbf29ac8d8691", kill_on_drop: false }` [INFO] [stdout] e12584fc99e341c16d39328a0c03fe9471aa0991aa0f8ba6254cbf29ac8d8691