[INFO] fetching crate noa 0.0.2... [INFO] checking noa-0.0.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate noa 0.0.2 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate noa 0.0.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate noa 0.0.2 [INFO] finished tweaking crates.io crate noa 0.0.2 [INFO] tweaked toml for crates.io crate noa 0.0.2 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate noa 0.0.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a93ff38bb3c67185b1548b4beeb538b37d5e8d93e410d285e5ccd580eb8c85ee [INFO] running `Command { std: "docker" "start" "-a" "a93ff38bb3c67185b1548b4beeb538b37d5e8d93e410d285e5ccd580eb8c85ee", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a93ff38bb3c67185b1548b4beeb538b37d5e8d93e410d285e5ccd580eb8c85ee", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a93ff38bb3c67185b1548b4beeb538b37d5e8d93e410d285e5ccd580eb8c85ee", kill_on_drop: false }` [INFO] [stdout] a93ff38bb3c67185b1548b4beeb538b37d5e8d93e410d285e5ccd580eb8c85ee [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b08d5823f1c6ef7a3f175dea4bdb24c2e3c55378fe0e61c7e28c76e464a81b59 [INFO] running `Command { std: "docker" "start" "-a" "b08d5823f1c6ef7a3f175dea4bdb24c2e3c55378fe0e61c7e28c76e464a81b59", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.62 [INFO] [stderr] Compiling cc v1.0.45 [INFO] [stderr] Compiling proc-macro2 v1.0.5 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling syn v1.0.5 [INFO] [stderr] Compiling memchr v2.2.1 [INFO] [stderr] Compiling byteorder v1.3.2 [INFO] [stderr] Compiling bitflags v1.2.0 [INFO] [stderr] Compiling cfg-if v0.1.10 [INFO] [stderr] Compiling glob v0.3.0 [INFO] [stderr] Compiling version_check v0.1.5 [INFO] [stderr] Compiling failure_derive v0.1.6 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling rustc-demangle v0.1.16 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling thread_local v0.3.6 [INFO] [stderr] Compiling regex-syntax v0.6.12 [INFO] [stderr] Compiling quick-error v1.2.2 [INFO] [stderr] Compiling unicode-width v0.1.6 [INFO] [stderr] Compiling humantime v1.3.0 [INFO] [stderr] Compiling textwrap v0.11.0 [INFO] [stderr] Compiling nom v4.2.3 [INFO] [stderr] Compiling bindgen v0.50.1 [INFO] [stderr] Compiling termcolor v1.0.5 [INFO] [stderr] Compiling ansi_term v0.11.0 [INFO] [stderr] Compiling clang-sys v0.28.1 [INFO] [stderr] Compiling vec_map v0.8.1 [INFO] [stderr] Compiling strsim v0.8.0 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Compiling atty v0.2.13 [INFO] [stderr] Compiling serde v1.0.101 [INFO] [stderr] Compiling peeking_take_while v0.1.2 [INFO] [stderr] Compiling shlex v0.1.1 [INFO] [stderr] Compiling pkg-config v0.3.16 [INFO] [stderr] Compiling crc32fast v1.2.0 [INFO] [stderr] Compiling ryu v1.0.2 [INFO] [stderr] Compiling autocfg v0.1.6 [INFO] [stderr] Checking safemem v0.3.2 [INFO] [stderr] Checking adler32 v1.0.4 [INFO] [stderr] Compiling clap v2.33.0 [INFO] [stderr] Compiling unicode-segmentation v1.3.0 [INFO] [stderr] Compiling fxhash v0.2.1 [INFO] [stderr] Checking base64 v0.10.1 [INFO] [stderr] Checking miniz_oxide v0.3.3 [INFO] [stderr] Checking line-wrap v0.1.1 [INFO] [stderr] Compiling aho-corasick v0.7.6 [INFO] [stderr] Compiling bincode v1.2.0 [INFO] [stderr] Compiling heck v0.3.1 [INFO] [stderr] Checking xml-rs v0.8.0 [INFO] [stderr] Checking same-file v1.0.5 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking arc-swap v0.4.3 [INFO] [stderr] Checking itoa v0.4.4 [INFO] [stderr] Checking linked-hash-map v0.5.2 [INFO] [stderr] Checking walkdir v2.2.9 [INFO] [stderr] Checking flate2 v1.0.12 [INFO] [stderr] Checking dirs-sys v0.3.4 [INFO] [stderr] Checking yaml-rust v0.4.3 [INFO] [stderr] Checking lazycell v1.2.1 [INFO] [stderr] Checking numtoa v0.1.0 [INFO] [stderr] Compiling cexpr v0.3.5 [INFO] [stderr] Checking signal-hook-registry v1.1.1 [INFO] [stderr] Compiling backtrace-sys v0.1.31 [INFO] [stderr] Compiling libloading v0.5.2 [INFO] [stderr] Checking fnv v1.0.6 [INFO] [stderr] Checking dirs v2.0.2 [INFO] [stderr] Checking termion v1.5.3 [INFO] [stderr] Checking difference v2.0.0 [INFO] [stderr] Checking pretty_assertions v0.6.1 [INFO] [stderr] Checking signal-hook v0.1.10 [INFO] [stderr] Compiling backtrace v0.3.38 [INFO] [stderr] Compiling regex v1.3.1 [INFO] [stderr] Compiling env_logger v0.6.2 [INFO] [stderr] Checking plist v0.4.2 [INFO] [stderr] Checking serde_json v1.0.41 [INFO] [stderr] Compiling synstructure v0.12.1 [INFO] [stderr] Compiling proc-macro-error v0.2.6 [INFO] [stderr] Compiling serde_derive v1.0.101 [INFO] [stderr] Compiling structopt-derive v0.3.3 [INFO] [stderr] Compiling failure v0.1.6 [INFO] [stderr] Compiling which v2.0.1 [INFO] [stderr] Checking structopt v0.3.3 [INFO] [stderr] Compiling onig_sys v69.2.0 [INFO] [stderr] Checking onig v5.0.0 [INFO] [stderr] Checking syntect v3.3.0 [INFO] [stderr] Checking noa v0.0.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/editor.rs:117:21 [INFO] [stdout] | [INFO] [stdout] 103 | pub fn new(ui: impl FrontEnd + 'u) -> Editor<'u> { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | let scratch_file = Rc::new(RefCell::new(File::pseudo_file("*scratch*"))); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | let scratch_view = View::new(scratch_file); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | let (tx, rx) = mpsc::channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | Editor { [INFO] [stdout] 117 | screen: Screen::new(scratch_view, ui.get_screen_size()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/editor.rs:118:26 [INFO] [stdout] | [INFO] [stdout] 103 | pub fn new(ui: impl FrontEnd + 'u) -> Editor<'u> { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | let scratch_file = Rc::new(RefCell::new(File::pseudo_file("*scratch*"))); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | let scratch_view = View::new(scratch_file); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | let (tx, rx) = mpsc::channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | event_queue: EventQueue { tx, rx }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/editor.rs:120:17 [INFO] [stdout] | [INFO] [stdout] 103 | pub fn new(ui: impl FrontEnd + 'u) -> Editor<'u> { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | let scratch_file = Rc::new(RefCell::new(File::pseudo_file("*scratch*"))); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | let scratch_view = View::new(scratch_file); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | let (tx, rx) = mpsc::channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | ui: Box::new(ui), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/editor.rs:121:20 [INFO] [stdout] | [INFO] [stdout] 103 | pub fn new(ui: impl FrontEnd + 'u) -> Editor<'u> { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | let scratch_file = Rc::new(RefCell::new(File::pseudo_file("*scratch*"))); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | let scratch_view = View::new(scratch_file); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | let (tx, rx) = mpsc::channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | files: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/editor.rs:122:22 [INFO] [stdout] | [INFO] [stdout] 103 | pub fn new(ui: impl FrontEnd + 'u) -> Editor<'u> { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | let scratch_file = Rc::new(RefCell::new(File::pseudo_file("*scratch*"))); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | let scratch_view = View::new(scratch_file); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | let (tx, rx) = mpsc::channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 122 | plugins: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/editor.rs:124:23 [INFO] [stdout] | [INFO] [stdout] 103 | pub fn new(ui: impl FrontEnd + 'u) -> Editor<'u> { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | let scratch_file = Rc::new(RefCell::new(File::pseudo_file("*scratch*"))); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | let scratch_view = View::new(scratch_file); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | let (tx, rx) = mpsc::channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | handlers: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file.rs:51:12 [INFO] [stdout] | [INFO] [stdout] 30 | let handle = fs::OpenOptions::new() [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | Ok(handle) => Buffer::from_file(name, &handle)?, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | Err(err) => { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | Ok(File { [INFO] [stdout] | ____________^ [INFO] [stdout] 52 | | path: Some(path.to_owned()), [INFO] [stdout] 53 | | buffer, [INFO] [stdout] 54 | | highlight: None, [INFO] [stdout] 55 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/editor.rs:117:21 [INFO] [stdout] | [INFO] [stdout] 103 | pub fn new(ui: impl FrontEnd + 'u) -> Editor<'u> { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | let scratch_file = Rc::new(RefCell::new(File::pseudo_file("*scratch*"))); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | let scratch_view = View::new(scratch_file); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | let (tx, rx) = mpsc::channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | Editor { [INFO] [stdout] 117 | screen: Screen::new(scratch_view, ui.get_screen_size()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/editor.rs:118:26 [INFO] [stdout] | [INFO] [stdout] 103 | pub fn new(ui: impl FrontEnd + 'u) -> Editor<'u> { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | let scratch_file = Rc::new(RefCell::new(File::pseudo_file("*scratch*"))); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | let scratch_view = View::new(scratch_file); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | let (tx, rx) = mpsc::channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | event_queue: EventQueue { tx, rx }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/editor.rs:120:17 [INFO] [stdout] | [INFO] [stdout] 103 | pub fn new(ui: impl FrontEnd + 'u) -> Editor<'u> { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | let scratch_file = Rc::new(RefCell::new(File::pseudo_file("*scratch*"))); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | let scratch_view = View::new(scratch_file); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | let (tx, rx) = mpsc::channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | ui: Box::new(ui), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/editor.rs:121:20 [INFO] [stdout] | [INFO] [stdout] 103 | pub fn new(ui: impl FrontEnd + 'u) -> Editor<'u> { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | let scratch_file = Rc::new(RefCell::new(File::pseudo_file("*scratch*"))); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | let scratch_view = View::new(scratch_file); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | let (tx, rx) = mpsc::channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | files: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/editor.rs:122:22 [INFO] [stdout] | [INFO] [stdout] 103 | pub fn new(ui: impl FrontEnd + 'u) -> Editor<'u> { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | let scratch_file = Rc::new(RefCell::new(File::pseudo_file("*scratch*"))); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | let scratch_view = View::new(scratch_file); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | let (tx, rx) = mpsc::channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 122 | plugins: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/editor.rs:124:23 [INFO] [stdout] | [INFO] [stdout] 103 | pub fn new(ui: impl FrontEnd + 'u) -> Editor<'u> { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | let scratch_file = Rc::new(RefCell::new(File::pseudo_file("*scratch*"))); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | let scratch_view = View::new(scratch_file); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | let (tx, rx) = mpsc::channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | handlers: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file.rs:51:12 [INFO] [stdout] | [INFO] [stdout] 30 | let handle = fs::OpenOptions::new() [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | Ok(handle) => Buffer::from_file(name, &handle)?, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | Err(err) => { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | Ok(File { [INFO] [stdout] | ____________^ [INFO] [stdout] 52 | | path: Some(path.to_owned()), [INFO] [stdout] 53 | | buffer, [INFO] [stdout] 54 | | highlight: None, [INFO] [stdout] 55 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/screen.rs:107:9 [INFO] [stdout] | [INFO] [stdout] 107 | drop(buffer); [INFO] [stdout] | ^^^^^------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&Buffer` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 107 - drop(buffer); [INFO] [stdout] 107 + let _ = buffer; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/screen.rs:337:21 [INFO] [stdout] | [INFO] [stdout] 330 | pub fn new(view: View, size: RectSize) -> Screen { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 331 | let panel = Panel::new(Position::new(0, 0), size, view); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 337 | finder: MenuBox::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/screen.rs:107:9 [INFO] [stdout] | [INFO] [stdout] 107 | drop(buffer); [INFO] [stdout] | ^^^^^------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&Buffer` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 107 - drop(buffer); [INFO] [stdout] 107 + let _ = buffer; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/screen.rs:337:21 [INFO] [stdout] | [INFO] [stdout] 330 | pub fn new(view: View, size: RectSize) -> Screen { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 331 | let panel = Panel::new(Position::new(0, 0), size, view); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 337 | finder: MenuBox::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `noa` (bin "noa" test) due to 9 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `noa` (bin "noa") due to 9 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "b08d5823f1c6ef7a3f175dea4bdb24c2e3c55378fe0e61c7e28c76e464a81b59", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b08d5823f1c6ef7a3f175dea4bdb24c2e3c55378fe0e61c7e28c76e464a81b59", kill_on_drop: false }` [INFO] [stdout] b08d5823f1c6ef7a3f175dea4bdb24c2e3c55378fe0e61c7e28c76e464a81b59