[INFO] fetching crate nitrokey 0.9.0... [INFO] checking nitrokey-0.9.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate nitrokey 0.9.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate nitrokey 0.9.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate nitrokey 0.9.0 [INFO] finished tweaking crates.io crate nitrokey 0.9.0 [INFO] tweaked toml for crates.io crate nitrokey 0.9.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate nitrokey 0.9.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a99ffa95b1ff813511e16ee4465e78307ced21da397b3b414c4c285f4c2b40ef [INFO] running `Command { std: "docker" "start" "-a" "a99ffa95b1ff813511e16ee4465e78307ced21da397b3b414c4c285f4c2b40ef", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a99ffa95b1ff813511e16ee4465e78307ced21da397b3b414c4c285f4c2b40ef", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a99ffa95b1ff813511e16ee4465e78307ced21da397b3b414c4c285f4c2b40ef", kill_on_drop: false }` [INFO] [stdout] a99ffa95b1ff813511e16ee4465e78307ced21da397b3b414c4c285f4c2b40ef [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2454f12ad2d0f305731571e1efc5a911cd9d7fb2adc5581789b57f407c6d16a8 [INFO] running `Command { std: "docker" "start" "-a" "2454f12ad2d0f305731571e1efc5a911cd9d7fb2adc5581789b57f407c6d16a8", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.23 [INFO] [stderr] Compiling libc v0.2.77 [INFO] [stderr] Compiling getrandom v0.1.15 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling cc v1.0.60 [INFO] [stderr] Compiling syn v1.0.42 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking nitrokey-test-state v0.1.0 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Compiling nitrokey-sys v3.6.0 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Compiling nitrokey-test v0.3.2 [INFO] [stderr] Checking nitrokey v0.9.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/otp.rs:411:12 [INFO] [stdout] | [INFO] [stdout] 406 | let name = get_cstring(data.name)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 407 | let secret = get_cstring(data.secret)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 408 | let use_token_id = data.token_id.is_some(); [INFO] [stdout] 409 | let token_id = get_cstring(data.token_id.unwrap_or_else(String::new))?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 410 | [INFO] [stdout] 411 | Ok(RawOtpSlotData { [INFO] [stdout] | ____________^ [INFO] [stdout] 412 | | number: data.number, [INFO] [stdout] 413 | | name, [INFO] [stdout] 414 | | secret, [INFO] [stdout] ... | [INFO] [stdout] 418 | | token_id, [INFO] [stdout] 419 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:68:27 [INFO] [stdout] | [INFO] [stdout] 67 | pub fn result_or_error(value: T) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | get_last_result().and(Ok(value)) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:79:8 [INFO] [stdout] | [INFO] [stdout] 71 | pub fn get_struct(f: F) -> Result [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | let mut out = T::default(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | get_command_result(f(&mut out))?; [INFO] [stdout] 79 | Ok(out.into()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:113:5 [INFO] [stdout] | [INFO] [stdout] 112 | pub fn get_cstring>>(s: T) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | CString::new(s).map_err(|_| LibraryError::InvalidString.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nitrokey` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/otp.rs:411:12 [INFO] [stdout] | [INFO] [stdout] 406 | let name = get_cstring(data.name)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 407 | let secret = get_cstring(data.secret)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 408 | let use_token_id = data.token_id.is_some(); [INFO] [stdout] 409 | let token_id = get_cstring(data.token_id.unwrap_or_else(String::new))?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 410 | [INFO] [stdout] 411 | Ok(RawOtpSlotData { [INFO] [stdout] | ____________^ [INFO] [stdout] 412 | | number: data.number, [INFO] [stdout] 413 | | name, [INFO] [stdout] 414 | | secret, [INFO] [stdout] ... | [INFO] [stdout] 418 | | token_id, [INFO] [stdout] 419 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:68:27 [INFO] [stdout] | [INFO] [stdout] 67 | pub fn result_or_error(value: T) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | get_last_result().and(Ok(value)) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:79:8 [INFO] [stdout] | [INFO] [stdout] 71 | pub fn get_struct(f: F) -> Result [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | let mut out = T::default(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | get_command_result(f(&mut out))?; [INFO] [stdout] 79 | Ok(out.into()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:113:5 [INFO] [stdout] | [INFO] [stdout] 112 | pub fn get_cstring>>(s: T) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | CString::new(s).map_err(|_| LibraryError::InvalidString.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nitrokey` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "2454f12ad2d0f305731571e1efc5a911cd9d7fb2adc5581789b57f407c6d16a8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2454f12ad2d0f305731571e1efc5a911cd9d7fb2adc5581789b57f407c6d16a8", kill_on_drop: false }` [INFO] [stdout] 2454f12ad2d0f305731571e1efc5a911cd9d7fb2adc5581789b57f407c6d16a8