[INFO] fetching crate nitrocli 0.4.1... [INFO] checking nitrocli-0.4.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate nitrocli 0.4.1 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate nitrocli 0.4.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate nitrocli 0.4.1 [INFO] finished tweaking crates.io crate nitrocli 0.4.1 [INFO] tweaked toml for crates.io crate nitrocli 0.4.1 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate nitrocli 0.4.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0a81fb8cf3a33a23bb2157d3be99f07a88e31b3df178a5fe0ed43248f9f68cf5 [INFO] running `Command { std: "docker" "start" "-a" "0a81fb8cf3a33a23bb2157d3be99f07a88e31b3df178a5fe0ed43248f9f68cf5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0a81fb8cf3a33a23bb2157d3be99f07a88e31b3df178a5fe0ed43248f9f68cf5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0a81fb8cf3a33a23bb2157d3be99f07a88e31b3df178a5fe0ed43248f9f68cf5", kill_on_drop: false }` [INFO] [stdout] 0a81fb8cf3a33a23bb2157d3be99f07a88e31b3df178a5fe0ed43248f9f68cf5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9fdb47fcfdaac011dcc0f6754ee74e60d21d86f38fe2248137ac2e2412eecf16 [INFO] running `Command { std: "docker" "start" "-a" "9fdb47fcfdaac011dcc0f6754ee74e60d21d86f38fe2248137ac2e2412eecf16", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.26 [INFO] [stderr] Compiling libc v0.2.94 [INFO] [stderr] Compiling syn v1.0.72 [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Compiling serde_derive v1.0.125 [INFO] [stderr] Compiling getrandom v0.2.2 [INFO] [stderr] Compiling cc v1.0.67 [INFO] [stderr] Compiling getrandom v0.1.16 [INFO] [stderr] Compiling serde v1.0.125 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling unicode-segmentation v1.7.1 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling anyhow v1.0.40 [INFO] [stderr] Compiling memchr v2.4.0 [INFO] [stderr] Checking numtoa v0.1.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Checking base32 v0.4.0 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking nitrokey-test-state v0.1.0 [INFO] [stderr] Checking progressing v3.0.2 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling heck v0.3.2 [INFO] [stderr] Compiling nitrokey-sys v3.6.0 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking dirs-sys v0.3.6 [INFO] [stderr] Checking termion v1.5.6 [INFO] [stderr] Checking rand_core v0.6.2 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking directories v3.0.2 [INFO] [stderr] Checking rand_chacha v0.3.0 [INFO] [stderr] Checking rand v0.8.3 [INFO] [stderr] Checking tempfile v3.2.0 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Compiling merge_derive v0.1.0 [INFO] [stderr] Compiling structopt-derive v0.4.14 [INFO] [stderr] Compiling nitrokey-test v0.5.0 [INFO] [stderr] Checking merge v0.1.0 [INFO] [stderr] Checking structopt v0.3.21 [INFO] [stderr] Checking toml v0.5.8 [INFO] [stderr] Checking envy v0.4.2 [INFO] [stderr] Checking nitrokey v0.9.0 [INFO] [stderr] Checking nitrocli v0.4.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: lint `illegal_floating_point_literal_pattern` has been removed: no longer a warning, float patterns behave the same as `==` [INFO] [stdout] --> src/main.rs:11:3 [INFO] [stdout] | [INFO] [stdout] 11 | illegal_floating_point_literal_pattern, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `private_in_public` has been removed: replaced with another group of lints, see RFC for more information [INFO] [stdout] --> src/main.rs:22:3 [INFO] [stdout] | [INFO] [stdout] 22 | private_in_public, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `safe_packed_borrows` has been removed: converted into hard error, see issue #82523 for more information [INFO] [stdout] --> src/main.rs:27:3 [INFO] [stdout] | [INFO] [stdout] 27 | safe_packed_borrows, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/main.rs:24:3 [INFO] [stdout] | [INFO] [stdout] 24 | renamed_and_removed_lints, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unknown lint: `where_clauses_object_safety` [INFO] [stdout] --> src/main.rs:44:3 [INFO] [stdout] | [INFO] [stdout] 44 | where_clauses_object_safety, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unknown_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: rule #2 of macro `tr` is never used [INFO] [stdout] --> src/arg_util.rs:18:3 [INFO] [stdout] | [INFO] [stdout] 18 | ($dst:tt) => {}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/main.rs:38:3 [INFO] [stdout] | [INFO] [stdout] 38 | unused, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] = note: `#[warn(unused_macro_rules)]` implied by `#[warn(unused)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `illegal_floating_point_literal_pattern` has been removed: no longer a warning, float patterns behave the same as `==` [INFO] [stdout] --> src/main.rs:11:3 [INFO] [stdout] | [INFO] [stdout] 11 | illegal_floating_point_literal_pattern, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `private_in_public` has been removed: replaced with another group of lints, see RFC for more information [INFO] [stdout] --> src/main.rs:22:3 [INFO] [stdout] | [INFO] [stdout] 22 | private_in_public, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `safe_packed_borrows` has been removed: converted into hard error, see issue #82523 for more information [INFO] [stdout] --> src/main.rs:27:3 [INFO] [stdout] | [INFO] [stdout] 27 | safe_packed_borrows, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/main.rs:24:3 [INFO] [stdout] | [INFO] [stdout] 24 | renamed_and_removed_lints, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unknown lint: `where_clauses_object_safety` [INFO] [stdout] --> src/main.rs:44:3 [INFO] [stdout] | [INFO] [stdout] 44 | where_clauses_object_safety, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unknown_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: rule #2 of macro `tr` is never used [INFO] [stdout] --> src/arg_util.rs:18:3 [INFO] [stdout] | [INFO] [stdout] 18 | ($dst:tt) => {}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/main.rs:38:3 [INFO] [stdout] | [INFO] [stdout] 38 | unused, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] = note: `#[warn(unused_macro_rules)]` implied by `#[warn(unused)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/tests/run.rs:115:19 [INFO] [stdout] | [INFO] [stdout] 115 | assert_eq!(Some(crate::args::DeviceModel::Pro), config.model); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/main.rs:42:3 [INFO] [stdout] | [INFO] [stdout] 42 | unused_qualifications, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 115 - assert_eq!(Some(crate::args::DeviceModel::Pro), config.model); [INFO] [stdout] 115 + assert_eq!(Some(args::DeviceModel::Pro), config.model); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:116:9 [INFO] [stdout] | [INFO] [stdout] 115 | let clap = args::Args::clap().version(version.as_str()); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | match clap.get_matches_from_safe(argv.iter()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands.rs:119:3 [INFO] [stdout] | [INFO] [stdout] 119 | / manager [INFO] [stdout] 120 | | .connect_path(device_info.path.deref()) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands.rs:177:48 [INFO] [stdout] | [INFO] [stdout] 171 | fn with_password_safe(ctx: &mut Context<'_>, mut op: F) -> anyhow::Result<()> [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | with_device(ctx, |ctx, mut device| { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | let pin_entry = pinentry::PinEntry::from(args::PinType::User, &device)?; [INFO] [stdout] 177 | try_with_pin_and_data(ctx, &pin_entry, (), move |ctx, _, pin| { [INFO] [stdout] | ________________________________________________^ [INFO] [stdout] 178 | | let pws = device.get_password_safe(pin).or_else(|err| { [INFO] [stdout] 179 | | Err(err) [INFO] [stdout] 180 | | .context("Could not access the password safe") [INFO] [stdout] ... | [INFO] [stdout] 184 | | op(ctx, pws).map_err(|err| ((), err)) [INFO] [stdout] 185 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands.rs:184:7 [INFO] [stdout] | [INFO] [stdout] 171 | fn with_password_safe(ctx: &mut Context<'_>, mut op: F) -> anyhow::Result<()> [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | with_device(ctx, |ctx, mut device| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 178 | let pws = device.get_password_safe(pin).or_else(|err| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 184 | op(ctx, pws).map_err(|err| ((), err)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands.rs:215:5 [INFO] [stdout] | [INFO] [stdout] 214 | authenticate(ctx, device, args::PinType::User, |_ctx, device, pin| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 215 | device.authenticate_user(pin).or_else(|(x, err)| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands.rs:216:7 [INFO] [stdout] | [INFO] [stdout] 215 | device.authenticate_user(pin).or_else(|(x, err)| { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 216 | / Err(err) [INFO] [stdout] 217 | | .context("Failed to authenticate as user") [INFO] [stdout] | |__________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands.rs:218:18 [INFO] [stdout] | [INFO] [stdout] 215 | device.authenticate_user(pin).or_else(|(x, err)| { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 218 | .map_err(|err| (x, err)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands.rs:232:5 [INFO] [stdout] | [INFO] [stdout] 231 | authenticate(ctx, device, args::PinType::Admin, |_ctx, device, pin| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 232 | device.authenticate_admin(pin).or_else(|(x, err)| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands.rs:233:7 [INFO] [stdout] | [INFO] [stdout] 232 | device.authenticate_admin(pin).or_else(|(x, err)| { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 233 | / Err(err) [INFO] [stdout] 234 | | .context("Failed to authenticate as admin") [INFO] [stdout] | |___________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands.rs:235:18 [INFO] [stdout] | [INFO] [stdout] 232 | device.authenticate_admin(pin).or_else(|(x, err)| { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 235 | .map_err(|err| (x, err)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:111:3 [INFO] [stdout] | [INFO] [stdout] 111 | toml::from_str(&s) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pinentry.rs:264:3 [INFO] [stdout] | [INFO] [stdout] 264 | parse_pinentry_pin(response).context("Failed to parse pinentry secret") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nitrocli` (bin "nitrocli") due to 13 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:116:9 [INFO] [stdout] | [INFO] [stdout] 115 | let clap = args::Args::clap().version(version.as_str()); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | match clap.get_matches_from_safe(argv.iter()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands.rs:119:3 [INFO] [stdout] | [INFO] [stdout] 119 | / manager [INFO] [stdout] 120 | | .connect_path(device_info.path.deref()) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands.rs:177:48 [INFO] [stdout] | [INFO] [stdout] 171 | fn with_password_safe(ctx: &mut Context<'_>, mut op: F) -> anyhow::Result<()> [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | with_device(ctx, |ctx, mut device| { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | let pin_entry = pinentry::PinEntry::from(args::PinType::User, &device)?; [INFO] [stdout] 177 | try_with_pin_and_data(ctx, &pin_entry, (), move |ctx, _, pin| { [INFO] [stdout] | ________________________________________________^ [INFO] [stdout] 178 | | let pws = device.get_password_safe(pin).or_else(|err| { [INFO] [stdout] 179 | | Err(err) [INFO] [stdout] 180 | | .context("Could not access the password safe") [INFO] [stdout] ... | [INFO] [stdout] 184 | | op(ctx, pws).map_err(|err| ((), err)) [INFO] [stdout] 185 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands.rs:184:7 [INFO] [stdout] | [INFO] [stdout] 171 | fn with_password_safe(ctx: &mut Context<'_>, mut op: F) -> anyhow::Result<()> [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | with_device(ctx, |ctx, mut device| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 178 | let pws = device.get_password_safe(pin).or_else(|err| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 184 | op(ctx, pws).map_err(|err| ((), err)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands.rs:215:5 [INFO] [stdout] | [INFO] [stdout] 214 | authenticate(ctx, device, args::PinType::User, |_ctx, device, pin| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 215 | device.authenticate_user(pin).or_else(|(x, err)| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands.rs:216:7 [INFO] [stdout] | [INFO] [stdout] 215 | device.authenticate_user(pin).or_else(|(x, err)| { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 216 | / Err(err) [INFO] [stdout] 217 | | .context("Failed to authenticate as user") [INFO] [stdout] | |__________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands.rs:218:18 [INFO] [stdout] | [INFO] [stdout] 215 | device.authenticate_user(pin).or_else(|(x, err)| { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 218 | .map_err(|err| (x, err)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands.rs:232:5 [INFO] [stdout] | [INFO] [stdout] 231 | authenticate(ctx, device, args::PinType::Admin, |_ctx, device, pin| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 232 | device.authenticate_admin(pin).or_else(|(x, err)| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands.rs:233:7 [INFO] [stdout] | [INFO] [stdout] 232 | device.authenticate_admin(pin).or_else(|(x, err)| { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 233 | / Err(err) [INFO] [stdout] 234 | | .context("Failed to authenticate as admin") [INFO] [stdout] | |___________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands.rs:235:18 [INFO] [stdout] | [INFO] [stdout] 232 | device.authenticate_admin(pin).or_else(|(x, err)| { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 235 | .map_err(|err| (x, err)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:111:3 [INFO] [stdout] | [INFO] [stdout] 111 | toml::from_str(&s) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pinentry.rs:264:3 [INFO] [stdout] | [INFO] [stdout] 264 | parse_pinentry_pin(response).context("Failed to parse pinentry secret") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests/mod.rs:135:6 [INFO] [stdout] | [INFO] [stdout] 102 | fn do_run(&mut self, args: &[&str], f: F) -> (R, Vec, Vec) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 135 | (f(ctx, args), stdout, stderr) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nitrocli` (bin "nitrocli" test) due to 14 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "9fdb47fcfdaac011dcc0f6754ee74e60d21d86f38fe2248137ac2e2412eecf16", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9fdb47fcfdaac011dcc0f6754ee74e60d21d86f38fe2248137ac2e2412eecf16", kill_on_drop: false }` [INFO] [stdout] 9fdb47fcfdaac011dcc0f6754ee74e60d21d86f38fe2248137ac2e2412eecf16