[INFO] fetching crate nitox 0.1.9... [INFO] checking nitox-0.1.9 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate nitox 0.1.9 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate nitox 0.1.9 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate nitox 0.1.9 [INFO] finished tweaking crates.io crate nitox 0.1.9 [INFO] tweaked toml for crates.io crate nitox 0.1.9 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 182 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding bytes v0.4.12 (latest: v1.7.1) [INFO] [stderr] Adding cast v0.2.7 (latest: v0.3.0) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding clap v2.34.0 (latest: v4.5.16) [INFO] [stderr] Adding cloudabi v0.0.3 (latest: v0.1.0) [INFO] [stderr] Adding core-foundation v0.9.4 (latest: v0.10.0) [INFO] [stderr] Adding criterion v0.2.11 (latest: v0.5.1) [INFO] [stderr] Adding criterion-plot v0.3.1 (latest: v0.5.0) [INFO] [stderr] Adding crossbeam-deque v0.7.4 (latest: v0.8.5) [INFO] [stderr] Adding crossbeam-epoch v0.8.2 (latest: v0.9.18) [INFO] [stderr] Adding crossbeam-queue v0.2.3 (latest: v0.3.11) [INFO] [stderr] Adding crossbeam-utils v0.7.2 (latest: v0.8.20) [INFO] [stderr] Adding darling v0.9.0 (latest: v0.20.10) [INFO] [stderr] Adding darling_core v0.9.0 (latest: v0.20.10) [INFO] [stderr] Adding darling_macro v0.9.0 (latest: v0.20.10) [INFO] [stderr] Adding derive_builder v0.7.2 (latest: v0.20.1) [INFO] [stderr] Adding derive_builder_core v0.5.0 (latest: v0.20.1) [INFO] [stderr] Adding env_logger v0.6.2 (latest: v0.11.5) [INFO] [stderr] Adding foreign-types v0.3.2 (latest: v0.5.0) [INFO] [stderr] Adding foreign-types-shared v0.1.1 (latest: v0.3.1) [INFO] [stderr] Adding futures v0.1.31 (latest: v0.3.30) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding humantime v1.3.0 (latest: v2.1.0) [INFO] [stderr] Adding idna v0.1.5 (latest: v1.0.2) [INFO] [stderr] Adding itertools v0.8.2 (latest: v0.13.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding lock_api v0.1.5 (latest: v0.4.12) [INFO] [stderr] Adding lock_api v0.3.4 (latest: v0.4.12) [INFO] [stderr] Adding memoffset v0.5.6 (latest: v0.9.1) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding mio v0.6.23 (latest: v1.0.2) [INFO] [stderr] Adding miow v0.2.2 (latest: v0.6.0) [INFO] [stderr] Adding parking_lot v0.6.4 (latest: v0.12.3) [INFO] [stderr] Adding parking_lot v0.9.0 (latest: v0.12.3) [INFO] [stderr] Adding parking_lot_core v0.3.1 (latest: v0.9.10) [INFO] [stderr] Adding parking_lot_core v0.6.3 (latest: v0.9.10) [INFO] [stderr] Adding percent-encoding v1.0.1 (latest: v2.3.1) [INFO] [stderr] Adding proc-macro2 v0.4.30 (latest: v1.0.86) [INFO] [stderr] Adding quick-error v1.2.3 (latest: v2.0.1) [INFO] [stderr] Adding quote v0.6.13 (latest: v1.0.37) [INFO] [stderr] Adding rand v0.5.6 (latest: v0.8.5) [INFO] [stderr] Adding rand_core v0.3.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (latest: v0.6.4) [INFO] [stderr] Adding rand_os v0.1.3 (latest: v0.2.2) [INFO] [stderr] Adding rand_xoshiro v0.1.0 (latest: v0.6.0) [INFO] [stderr] Adding rdrand v0.4.0 (latest: v0.8.3) [INFO] [stderr] Adding redox_syscall v0.1.57 (latest: v0.5.3) [INFO] [stderr] Adding rustc_version v0.2.3 (latest: v0.4.1) [INFO] [stderr] Adding scopeguard v0.3.3 (latest: v1.2.0) [INFO] [stderr] Adding semver v0.9.0 (latest: v1.0.23) [INFO] [stderr] Adding semver-parser v0.7.0 (latest: v0.10.2) [INFO] [stderr] Adding smallvec v0.6.14 (latest: v1.13.2) [INFO] [stderr] Adding strsim v0.7.0 (latest: v0.11.1) [INFO] [stderr] Adding syn v0.15.44 (latest: v2.0.77) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding synstructure v0.12.6 (latest: v0.13.1) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] [stderr] Adding tokio v0.1.22 (latest: v1.40.0) [INFO] [stderr] Adding tokio-tls v0.2.1 (latest: v0.3.1) [INFO] [stderr] Adding unicode-xid v0.1.0 (latest: v0.2.5) [INFO] [stderr] Adding url v1.7.2 (latest: v2.5.2) [INFO] [stderr] Adding winapi v0.2.8 (latest: v0.3.9) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3a6f54d690db8590f264dd58f8dba0b1fe52670bf390ec518db708c36e9c5a71 [INFO] running `Command { std: "docker" "start" "-a" "3a6f54d690db8590f264dd58f8dba0b1fe52670bf390ec518db708c36e9c5a71", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3a6f54d690db8590f264dd58f8dba0b1fe52670bf390ec518db708c36e9c5a71", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3a6f54d690db8590f264dd58f8dba0b1fe52670bf390ec518db708c36e9c5a71", kill_on_drop: false }` [INFO] [stdout] 3a6f54d690db8590f264dd58f8dba0b1fe52670bf390ec518db708c36e9c5a71 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 39e91c4a6a3b684868f0b0f9dcf21f4cda45b7cb9bb09c1db6824f10c141b9fc [INFO] running `Command { std: "docker" "start" "-a" "39e91c4a6a3b684868f0b0f9dcf21f4cda45b7cb9bb09c1db6824f10c141b9fc", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking futures v0.1.31 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Compiling memoffset v0.5.6 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Compiling strsim v0.7.0 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking lock_api v0.3.4 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Checking smallvec v0.6.14 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Checking gimli v0.29.0 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Compiling failure_derive v0.1.8 [INFO] [stderr] Compiling unicode-xid v0.2.5 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Compiling parking_lot_core v0.6.3 [INFO] [stderr] Compiling parking_lot v0.9.0 [INFO] [stderr] Compiling parking_lot_core v0.3.1 [INFO] [stderr] Checking owning_ref v0.4.1 [INFO] [stderr] Compiling cast v0.2.7 [INFO] [stderr] Checking crossbeam-queue v0.2.3 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Checking matches v0.1.10 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Checking scopeguard v0.3.3 [INFO] [stderr] Compiling derive_builder v0.7.2 [INFO] [stderr] Checking lock_api v0.1.5 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking itertools v0.8.2 [INFO] [stderr] Checking crossbeam-deque v0.7.4 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking percent-encoding v1.0.1 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking tokio-executor v0.1.10 [INFO] [stderr] Checking tokio-sync v0.1.8 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking rand_xoshiro v0.1.0 [INFO] [stderr] Checking tokio-current-thread v0.1.7 [INFO] [stderr] Checking idna v0.1.5 [INFO] [stderr] Checking tokio-timer v0.2.13 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking bytes v0.4.12 [INFO] [stderr] Checking net2 v0.2.39 [INFO] [stderr] Checking openssl-sys v0.9.103 [INFO] [stderr] Checking rand v0.5.6 [INFO] [stderr] Checking tokio-threadpool v0.1.18 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking tokio-io v0.1.13 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking url v1.7.2 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Checking criterion-plot v0.3.1 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking tokio-codec v0.1.2 [INFO] [stderr] Checking tokio-fs v0.1.7 [INFO] [stderr] Checking addr2line v0.22.0 [INFO] [stderr] Checking tokio-reactor v0.1.12 [INFO] [stderr] Checking mio-uds v0.6.8 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Checking tokio-tcp v0.1.4 [INFO] [stderr] Checking tokio-udp v0.1.6 [INFO] [stderr] Checking tokio-uds v0.2.7 [INFO] [stderr] Checking openssl v0.10.66 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking tokio v0.1.22 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking criterion v0.2.11 [INFO] [stderr] Checking env_logger v0.6.2 [INFO] [stderr] Compiling darling_core v0.9.0 [INFO] [stderr] Checking failure v0.1.8 [INFO] [stderr] Compiling darling_macro v0.9.0 [INFO] [stderr] Compiling darling v0.9.0 [INFO] [stderr] Compiling derive_builder_core v0.5.0 [INFO] [stderr] Checking native-tls v0.2.12 [INFO] [stderr] Checking tokio-tls v0.2.1 [INFO] [stderr] Checking nitox v0.1.9 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/client.rs:297:25 [INFO] [stdout] | [INFO] [stdout] 297 | if let Some(mut s) = (*self.rx.subs_tx.write()).get_mut(&cmd.sid) { [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/client.rs:297:25 [INFO] [stdout] | [INFO] [stdout] 297 | if let Some(mut s) = (*self.rx.subs_tx.write()).get_mut(&cmd.sid) { [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `other_tx` is never read [INFO] [stdout] --> src/client.rs:73:5 [INFO] [stdout] | [INFO] [stdout] 72 | struct NatsClientMultiplexer { [INFO] [stdout] | --------------------- field in this struct [INFO] [stdout] 73 | other_tx: Arc>, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `NatsClientMultiplexer` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:8:28 [INFO] [stdout] | [INFO] [stdout] 7 | fn from(s: $type) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 8 | $targetvar(s.into()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 87 | from_error!(protocol::CommandError, NatsError, NatsError::ProtocolError); [INFO] [stdout] | ------------------------------------------------------------------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `from_error` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:8:28 [INFO] [stdout] | [INFO] [stdout] 7 | fn from(s: $type) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 8 | $targetvar(s.into()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 89 | from_error!(::native_tls::Error, NatsError, NatsError::TlsError); [INFO] [stdout] | ---------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `from_error` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:8:28 [INFO] [stdout] | [INFO] [stdout] 7 | fn from(s: $type) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 8 | $targetvar(s.into()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/protocol/error.rs:36:1 [INFO] [stdout] | [INFO] [stdout] 36 | from_error!(json::Error, CommandError, CommandError::JsonError); [INFO] [stdout] | --------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `from_error` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/client/pub_cmd.rs:50:12 [INFO] [stdout] | [INFO] [stdout] 37 | fn into_vec(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | let mut bytes = BytesMut::with_capacity(cmd_str.len() + self.payload.len() + 2); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | Ok(bytes.freeze()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/server/message.rs:44:12 [INFO] [stdout] | [INFO] [stdout] 31 | fn into_vec(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let mut bytes = BytesMut::with_capacity(cmd_str.len() + self.payload.len() + 2); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | Ok(bytes.freeze()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/op.rs:44:12 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn into_bytes(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | Ok(match self { [INFO] [stdout] | ____________^ [INFO] [stdout] 45 | | Op::INFO(si) => si.into_vec()?, [INFO] [stdout] 46 | | Op::CONNECT(con) => con.into_vec()?, [INFO] [stdout] 47 | | Op::PUB(pc) => pc.into_vec()?, [INFO] [stdout] ... | [INFO] [stdout] 54 | | Op::ERR(se) => format!("-ERR {}\r\n", se).as_bytes().into(), [INFO] [stdout] 55 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net/mod.rs:24:20 [INFO] [stdout] | [INFO] [stdout] 18 | NatsConnectionInner::connect_tcp(&addr).map(move |socket| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | state: Arc::new(RwLock::new(NatsConnectionState::Connected)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net/mod.rs:25:20 [INFO] [stdout] | [INFO] [stdout] 18 | NatsConnectionInner::connect_tcp(&addr).map(move |socket| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | inner: Arc::new(RwLock::new(socket.into())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net/mod.rs:43:24 [INFO] [stdout] | [INFO] [stdout] 37 | }).map(move |socket| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | state: Arc::new(RwLock::new(NatsConnectionState::Connected)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net/mod.rs:44:24 [INFO] [stdout] | [INFO] [stdout] 37 | }).map(move |socket| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | inner: Arc::new(RwLock::new(socket.into())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net/connection.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 54 | let inner_arc = Arc::clone(&self.inner); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | let inner_state = Arc::clone(&self.state); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | / NatsConnectionInner::connect_tcp(&self.addr) [INFO] [stdout] 59 | | .and_then(move |socket| { [INFO] [stdout] 60 | | if is_tls { [INFO] [stdout] 61 | | Either::A( [INFO] [stdout] ... | [INFO] [stdout] 68 | | } [INFO] [stdout] 69 | | }).and_then(move |inner| { [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net/connection.rs:69:25 [INFO] [stdout] | [INFO] [stdout] 54 | let inner_arc = Arc::clone(&self.inner); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | let inner_state = Arc::clone(&self.state); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | }).and_then(move |inner| { [INFO] [stdout] | _________________________^ [INFO] [stdout] 70 | | { [INFO] [stdout] 71 | | *inner_arc.write() = inner; [INFO] [stdout] 72 | | *inner_state.write() = NatsConnectionState::Connected; [INFO] [stdout] ... | [INFO] [stdout] 75 | | Ok(()) [INFO] [stdout] 76 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net/connection_inner.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 31 | socket: TcpStream, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | ) -> impl Future, Error = NatsError> { [INFO] [stdout] 33 | let tls_connector = NativeTlsConnector::builder().build().unwrap(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | let tls_stream: TlsConnector = tls_connector.into(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | debug!(target: "nitox", "Connecting to {} through TLS over TCP", host); [INFO] [stdout] 36 | tls_stream.connect(&host, socket).from_err() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net/connection_inner.rs:42:34 [INFO] [stdout] | [INFO] [stdout] 41 | fn from(socket: TcpStream) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | NatsConnectionInner::Tcp(Box::new(OpCodec::default().framed(socket))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net/connection_inner.rs:48:34 [INFO] [stdout] | [INFO] [stdout] 47 | fn from(socket: TlsStream) -> Self { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | NatsConnectionInner::Tls(Box::new(OpCodec::default().framed(socket))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn send(&self, op: Op) -> impl Future { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | //let _verbose = self.verbose.clone(); [INFO] [stdout] 56 | / self.tx [INFO] [stdout] 57 | | .unbounded_send(op) [INFO] [stdout] 58 | | .map_err(|_| NatsError::InnerBrokenChain) [INFO] [stdout] | |_____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:112:10 [INFO] [stdout] | [INFO] [stdout] 78 | pub fn new(stream: NatsStream) -> (Self, mpsc::UnboundedReceiver) { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | let subs_tx: Arc>> = [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | let (other_tx, other_rx) = mpsc::unbounded(); [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | let other_tx = Arc::new(other_tx); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | [INFO] [stdout] 85 | let stx_inner = Arc::clone(&subs_tx); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | let otx_inner = Arc::clone(&other_tx); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | let work_tx = stream [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | (NatsClientMultiplexer { subs_tx, other_tx }, other_rx) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:202:9 [INFO] [stdout] | [INFO] [stdout] 193 | let cluster_sa = if let Ok(sockaddr) = SocketAddr::from_str(&cluster_uri) { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 198 | Err(e) => Err(NatsError::UriDNSResolveError(Some(e))), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 202 | / future::result(cluster_sa) [INFO] [stdout] 203 | | .from_err() [INFO] [stdout] 204 | | .and_then(move |cluster_sa| { [INFO] [stdout] 205 | | if tls_required { [INFO] [stdout] ... | [INFO] [stdout] 215 | | } [INFO] [stdout] 216 | | }).and_then(|either| either) [INFO] [stdout] | |________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:263:9 [INFO] [stdout] | [INFO] [stdout] 262 | pub fn connect(self) -> impl Future + Send + Sync { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 263 | / self.tx [INFO] [stdout] 264 | | .send(Op::CONNECT(self.opts.connect_command.clone())) [INFO] [stdout] | |_________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:265:23 [INFO] [stdout] | [INFO] [stdout] 262 | pub fn connect(self) -> impl Future + Send + Sync { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 265 | .and_then(move |_| future::ok(self)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:276:9 [INFO] [stdout] | [INFO] [stdout] 275 | pub fn send(self, op: Op) -> impl Future { [INFO] [stdout] | ---- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 276 | self.tx.send(op).and_then(move |_| future::ok(self)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:276:35 [INFO] [stdout] | [INFO] [stdout] 275 | pub fn send(self, op: Op) -> impl Future { [INFO] [stdout] | ---- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 276 | self.tx.send(op).and_then(move |_| future::ok(self)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:289:19 [INFO] [stdout] | [INFO] [stdout] 282 | pub fn publish(&self, cmd: PubCommand) -> impl Future + Send + Sync { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 289 | Either::B(self.tx.send(Op::PUB(cmd))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:315:9 [INFO] [stdout] | [INFO] [stdout] 313 | let inner_rx = self.rx.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 314 | let sid = cmd.sid.clone(); [INFO] [stdout] 315 | self.tx.send(Op::SUB(cmd)).and_then(move |_| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:315:45 [INFO] [stdout] | [INFO] [stdout] 313 | let inner_rx = self.rx.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 314 | let sid = cmd.sid.clone(); [INFO] [stdout] 315 | self.tx.send(Op::SUB(cmd)).and_then(move |_| { [INFO] [stdout] | _____________________________________________^ [INFO] [stdout] 316 | | let stream = inner_rx.for_sid(sid.clone()).and_then(move |msg| { [INFO] [stdout] 317 | | { [INFO] [stdout] 318 | | let mut stx = inner_rx.subs_tx.write(); [INFO] [stdout] ... | [INFO] [stdout] 343 | | future::ok(stream) [INFO] [stdout] 344 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:399:13 [INFO] [stdout] | [INFO] [stdout] 353 | payload: Bytes, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 362 | let pub_cmd = PubCommand { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 381 | let tx1 = self.tx.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 382 | let tx2 = self.tx.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 383 | let rx_arc = Arc::clone(&self.rx); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 384 | [INFO] [stdout] 385 | let stream = self [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 399 | / self.tx [INFO] [stdout] 400 | | .send(Op::SUB(sub_cmd)) [INFO] [stdout] 401 | | .and_then(move |_| tx1.send(Op::UNSUB(unsub_cmd))) [INFO] [stdout] 402 | | .and_then(move |_| tx2.send(Op::PUB(pub_cmd))) [INFO] [stdout] 403 | | .and_then(move |_| stream), [INFO] [stdout] | |__________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:401:45 [INFO] [stdout] | [INFO] [stdout] 381 | let tx1 = self.tx.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 401 | .and_then(move |_| tx1.send(Op::UNSUB(unsub_cmd))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:402:45 [INFO] [stdout] | [INFO] [stdout] 362 | let pub_cmd = PubCommand { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 382 | let tx2 = self.tx.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 402 | .and_then(move |_| tx2.send(Op::PUB(pub_cmd))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `other_tx` is never read [INFO] [stdout] --> src/client.rs:73:5 [INFO] [stdout] | [INFO] [stdout] 72 | struct NatsClientMultiplexer { [INFO] [stdout] | --------------------- field in this struct [INFO] [stdout] 73 | other_tx: Arc>, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `NatsClientMultiplexer` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:8:28 [INFO] [stdout] | [INFO] [stdout] 7 | fn from(s: $type) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 8 | $targetvar(s.into()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 87 | from_error!(protocol::CommandError, NatsError, NatsError::ProtocolError); [INFO] [stdout] | ------------------------------------------------------------------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `from_error` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:8:28 [INFO] [stdout] | [INFO] [stdout] 7 | fn from(s: $type) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 8 | $targetvar(s.into()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 89 | from_error!(::native_tls::Error, NatsError, NatsError::TlsError); [INFO] [stdout] | ---------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `from_error` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:8:28 [INFO] [stdout] | [INFO] [stdout] 7 | fn from(s: $type) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 8 | $targetvar(s.into()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/protocol/error.rs:36:1 [INFO] [stdout] | [INFO] [stdout] 36 | from_error!(json::Error, CommandError, CommandError::JsonError); [INFO] [stdout] | --------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `from_error` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/client/pub_cmd.rs:50:12 [INFO] [stdout] | [INFO] [stdout] 37 | fn into_vec(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | let mut bytes = BytesMut::with_capacity(cmd_str.len() + self.payload.len() + 2); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | Ok(bytes.freeze()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/server/message.rs:44:12 [INFO] [stdout] | [INFO] [stdout] 31 | fn into_vec(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let mut bytes = BytesMut::with_capacity(cmd_str.len() + self.payload.len() + 2); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | Ok(bytes.freeze()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/op.rs:44:12 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn into_bytes(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | Ok(match self { [INFO] [stdout] | ____________^ [INFO] [stdout] 45 | | Op::INFO(si) => si.into_vec()?, [INFO] [stdout] 46 | | Op::CONNECT(con) => con.into_vec()?, [INFO] [stdout] 47 | | Op::PUB(pc) => pc.into_vec()?, [INFO] [stdout] ... | [INFO] [stdout] 54 | | Op::ERR(se) => format!("-ERR {}\r\n", se).as_bytes().into(), [INFO] [stdout] 55 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net/mod.rs:24:20 [INFO] [stdout] | [INFO] [stdout] 18 | NatsConnectionInner::connect_tcp(&addr).map(move |socket| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | state: Arc::new(RwLock::new(NatsConnectionState::Connected)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net/mod.rs:25:20 [INFO] [stdout] | [INFO] [stdout] 18 | NatsConnectionInner::connect_tcp(&addr).map(move |socket| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | inner: Arc::new(RwLock::new(socket.into())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net/mod.rs:43:24 [INFO] [stdout] | [INFO] [stdout] 37 | }).map(move |socket| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | state: Arc::new(RwLock::new(NatsConnectionState::Connected)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net/mod.rs:44:24 [INFO] [stdout] | [INFO] [stdout] 37 | }).map(move |socket| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | inner: Arc::new(RwLock::new(socket.into())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net/connection.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 54 | let inner_arc = Arc::clone(&self.inner); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | let inner_state = Arc::clone(&self.state); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | / NatsConnectionInner::connect_tcp(&self.addr) [INFO] [stdout] 59 | | .and_then(move |socket| { [INFO] [stdout] 60 | | if is_tls { [INFO] [stdout] 61 | | Either::A( [INFO] [stdout] ... | [INFO] [stdout] 68 | | } [INFO] [stdout] 69 | | }).and_then(move |inner| { [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net/connection.rs:69:25 [INFO] [stdout] | [INFO] [stdout] 54 | let inner_arc = Arc::clone(&self.inner); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | let inner_state = Arc::clone(&self.state); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | }).and_then(move |inner| { [INFO] [stdout] | _________________________^ [INFO] [stdout] 70 | | { [INFO] [stdout] 71 | | *inner_arc.write() = inner; [INFO] [stdout] 72 | | *inner_state.write() = NatsConnectionState::Connected; [INFO] [stdout] ... | [INFO] [stdout] 75 | | Ok(()) [INFO] [stdout] 76 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net/connection_inner.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 31 | socket: TcpStream, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | ) -> impl Future, Error = NatsError> { [INFO] [stdout] 33 | let tls_connector = NativeTlsConnector::builder().build().unwrap(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | let tls_stream: TlsConnector = tls_connector.into(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | debug!(target: "nitox", "Connecting to {} through TLS over TCP", host); [INFO] [stdout] 36 | tls_stream.connect(&host, socket).from_err() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net/connection_inner.rs:42:34 [INFO] [stdout] | [INFO] [stdout] 41 | fn from(socket: TcpStream) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | NatsConnectionInner::Tcp(Box::new(OpCodec::default().framed(socket))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net/connection_inner.rs:48:34 [INFO] [stdout] | [INFO] [stdout] 47 | fn from(socket: TlsStream) -> Self { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | NatsConnectionInner::Tls(Box::new(OpCodec::default().framed(socket))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn send(&self, op: Op) -> impl Future { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | //let _verbose = self.verbose.clone(); [INFO] [stdout] 56 | / self.tx [INFO] [stdout] 57 | | .unbounded_send(op) [INFO] [stdout] 58 | | .map_err(|_| NatsError::InnerBrokenChain) [INFO] [stdout] | |_____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:112:10 [INFO] [stdout] | [INFO] [stdout] 78 | pub fn new(stream: NatsStream) -> (Self, mpsc::UnboundedReceiver) { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | let subs_tx: Arc>> = [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | let (other_tx, other_rx) = mpsc::unbounded(); [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | let other_tx = Arc::new(other_tx); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | [INFO] [stdout] 85 | let stx_inner = Arc::clone(&subs_tx); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | let otx_inner = Arc::clone(&other_tx); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | let work_tx = stream [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | (NatsClientMultiplexer { subs_tx, other_tx }, other_rx) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:202:9 [INFO] [stdout] | [INFO] [stdout] 193 | let cluster_sa = if let Ok(sockaddr) = SocketAddr::from_str(&cluster_uri) { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 198 | Err(e) => Err(NatsError::UriDNSResolveError(Some(e))), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 202 | / future::result(cluster_sa) [INFO] [stdout] 203 | | .from_err() [INFO] [stdout] 204 | | .and_then(move |cluster_sa| { [INFO] [stdout] 205 | | if tls_required { [INFO] [stdout] ... | [INFO] [stdout] 215 | | } [INFO] [stdout] 216 | | }).and_then(|either| either) [INFO] [stdout] | |________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:263:9 [INFO] [stdout] | [INFO] [stdout] 262 | pub fn connect(self) -> impl Future + Send + Sync { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 263 | / self.tx [INFO] [stdout] 264 | | .send(Op::CONNECT(self.opts.connect_command.clone())) [INFO] [stdout] | |_________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:265:23 [INFO] [stdout] | [INFO] [stdout] 262 | pub fn connect(self) -> impl Future + Send + Sync { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 265 | .and_then(move |_| future::ok(self)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:276:9 [INFO] [stdout] | [INFO] [stdout] 275 | pub fn send(self, op: Op) -> impl Future { [INFO] [stdout] | ---- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 276 | self.tx.send(op).and_then(move |_| future::ok(self)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:276:35 [INFO] [stdout] | [INFO] [stdout] 275 | pub fn send(self, op: Op) -> impl Future { [INFO] [stdout] | ---- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 276 | self.tx.send(op).and_then(move |_| future::ok(self)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:289:19 [INFO] [stdout] | [INFO] [stdout] 282 | pub fn publish(&self, cmd: PubCommand) -> impl Future + Send + Sync { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 289 | Either::B(self.tx.send(Op::PUB(cmd))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:315:9 [INFO] [stdout] | [INFO] [stdout] 313 | let inner_rx = self.rx.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 314 | let sid = cmd.sid.clone(); [INFO] [stdout] 315 | self.tx.send(Op::SUB(cmd)).and_then(move |_| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:315:45 [INFO] [stdout] | [INFO] [stdout] 313 | let inner_rx = self.rx.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 314 | let sid = cmd.sid.clone(); [INFO] [stdout] 315 | self.tx.send(Op::SUB(cmd)).and_then(move |_| { [INFO] [stdout] | _____________________________________________^ [INFO] [stdout] 316 | | let stream = inner_rx.for_sid(sid.clone()).and_then(move |msg| { [INFO] [stdout] 317 | | { [INFO] [stdout] 318 | | let mut stx = inner_rx.subs_tx.write(); [INFO] [stdout] ... | [INFO] [stdout] 343 | | future::ok(stream) [INFO] [stdout] 344 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:399:13 [INFO] [stdout] | [INFO] [stdout] 353 | payload: Bytes, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 362 | let pub_cmd = PubCommand { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 381 | let tx1 = self.tx.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 382 | let tx2 = self.tx.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 383 | let rx_arc = Arc::clone(&self.rx); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 384 | [INFO] [stdout] 385 | let stream = self [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 399 | / self.tx [INFO] [stdout] 400 | | .send(Op::SUB(sub_cmd)) [INFO] [stdout] 401 | | .and_then(move |_| tx1.send(Op::UNSUB(unsub_cmd))) [INFO] [stdout] 402 | | .and_then(move |_| tx2.send(Op::PUB(pub_cmd))) [INFO] [stdout] 403 | | .and_then(move |_| stream), [INFO] [stdout] | |__________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:401:45 [INFO] [stdout] | [INFO] [stdout] 381 | let tx1 = self.tx.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 401 | .and_then(move |_| tx1.send(Op::UNSUB(unsub_cmd))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:402:45 [INFO] [stdout] | [INFO] [stdout] 362 | let pub_cmd = PubCommand { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 382 | let tx2 = self.tx.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 402 | .and_then(move |_| tx2.send(Op::PUB(pub_cmd))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 28 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 28 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nitox` (lib) due to 29 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `nitox` (lib test) due to 29 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "39e91c4a6a3b684868f0b0f9dcf21f4cda45b7cb9bb09c1db6824f10c141b9fc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "39e91c4a6a3b684868f0b0f9dcf21f4cda45b7cb9bb09c1db6824f10c141b9fc", kill_on_drop: false }` [INFO] [stdout] 39e91c4a6a3b684868f0b0f9dcf21f4cda45b7cb9bb09c1db6824f10c141b9fc