[INFO] fetching crate nine-memfs 0.2.0... [INFO] checking nine-memfs-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate nine-memfs 0.2.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate nine-memfs 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate nine-memfs 0.2.0 [INFO] finished tweaking crates.io crate nine-memfs 0.2.0 [INFO] tweaked toml for crates.io crate nine-memfs 0.2.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 27 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding nine v0.4.0 (latest: v0.5.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding synstructure v0.12.6 (latest: v0.13.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1c95a29423d70d28f49772963fd9ae49875176deb48d53fb80befec7647f6500 [INFO] running `Command { std: "docker" "start" "-a" "1c95a29423d70d28f49772963fd9ae49875176deb48d53fb80befec7647f6500", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1c95a29423d70d28f49772963fd9ae49875176deb48d53fb80befec7647f6500", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1c95a29423d70d28f49772963fd9ae49875176deb48d53fb80befec7647f6500", kill_on_drop: false }` [INFO] [stdout] 1c95a29423d70d28f49772963fd9ae49875176deb48d53fb80befec7647f6500 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] dc134107db71e298496b9e0d8bea5ad5e549cab1904a94819ee8dd21c8f092b5 [INFO] running `Command { std: "docker" "start" "-a" "dc134107db71e298496b9e0d8bea5ad5e549cab1904a94819ee8dd21c8f092b5", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling failure_derive v0.1.8 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking gimli v0.29.0 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking addr2line v0.22.0 [INFO] [stderr] Checking failure v0.1.8 [INFO] [stderr] Checking nine v0.4.0 [INFO] [stderr] Checking nine-memfs v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/server/errors.rs:22:32 [INFO] [stdout] | [INFO] [stdout] 22 | fn cause(&self) -> Option<&Fail> { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 22 | fn cause(&self) -> Option<&dyn Fail> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/server/errors.rs:59:32 [INFO] [stdout] | [INFO] [stdout] 59 | fn cause(&self) -> Option<&Fail> { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 59 | fn cause(&self) -> Option<&dyn Fail> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/server/errors.rs:22:32 [INFO] [stdout] | [INFO] [stdout] 22 | fn cause(&self) -> Option<&Fail> { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 22 | fn cause(&self) -> Option<&dyn Fail> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/server/errors.rs:59:32 [INFO] [stdout] | [INFO] [stdout] 59 | fn cause(&self) -> Option<&Fail> { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 59 | fn cause(&self) -> Option<&dyn Fail> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/main.rs:104:28 [INFO] [stdout] | [INFO] [stdout] 104 | panic!(derror) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 104 | panic!("{}", derror) [INFO] [stdout] | +++++ [INFO] [stdout] help: or use std::panic::panic_any instead [INFO] [stdout] | [INFO] [stdout] 104 | std::panic::panic_any(derror) [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/mod.rs:190:9 [INFO] [stdout] | [INFO] [stdout] 184 | wname: I, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 190 | / Walker { [INFO] [stdout] 191 | | current_file: self, [INFO] [stdout] 192 | | file_tree: all_files, [INFO] [stdout] 193 | | wname: wname.fuse(), [INFO] [stdout] 194 | | }.fuse() [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/mod.rs:449:9 [INFO] [stdout] | [INFO] [stdout] 444 | fn walk_from(&self, path: u64, wname: I) -> impl FusedIterator [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 449 | / Walker { [INFO] [stdout] 450 | | current_file: self.all_files.get(&path).unwrap(), [INFO] [stdout] 451 | | file_tree: &self.all_files, [INFO] [stdout] 452 | | wname: wname.into_iter().fuse(), [INFO] [stdout] 453 | | }.fuse() [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/errors.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 80 | pub fn rerr>(s: S) -> NineResult { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | Err(ServerFail::NonFatal(NonFatalError { [INFO] [stdout] | _________^ [INFO] [stdout] 82 | | msg: s.into(), [INFO] [stdout] 83 | | cause: None, [INFO] [stdout] 84 | | })) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 11 | examiner: F, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 17 | let mut cow = Cow::Borrowed(current); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | [INFO] [stdout] 19 | (examiner)(&mut cow).map(|_| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:19:30 [INFO] [stdout] | [INFO] [stdout] 11 | examiner: F, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 17 | let mut cow = Cow::Borrowed(current); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | [INFO] [stdout] 19 | (examiner)(&mut cow).map(|_| { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 20 | | if let Cow::Owned(x) = cow { [INFO] [stdout] 21 | | Some(x) [INFO] [stdout] 22 | | } else { [INFO] [stdout] 23 | | None [INFO] [stdout] 24 | | } [INFO] [stdout] 25 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nine-memfs` (bin "nine-memfs") due to 6 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/main.rs:104:28 [INFO] [stdout] | [INFO] [stdout] 104 | panic!(derror) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 104 | panic!("{}", derror) [INFO] [stdout] | +++++ [INFO] [stdout] help: or use std::panic::panic_any instead [INFO] [stdout] | [INFO] [stdout] 104 | std::panic::panic_any(derror) [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/mod.rs:190:9 [INFO] [stdout] | [INFO] [stdout] 184 | wname: I, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 190 | / Walker { [INFO] [stdout] 191 | | current_file: self, [INFO] [stdout] 192 | | file_tree: all_files, [INFO] [stdout] 193 | | wname: wname.fuse(), [INFO] [stdout] 194 | | }.fuse() [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/mod.rs:449:9 [INFO] [stdout] | [INFO] [stdout] 444 | fn walk_from(&self, path: u64, wname: I) -> impl FusedIterator [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 449 | / Walker { [INFO] [stdout] 450 | | current_file: self.all_files.get(&path).unwrap(), [INFO] [stdout] 451 | | file_tree: &self.all_files, [INFO] [stdout] 452 | | wname: wname.into_iter().fuse(), [INFO] [stdout] 453 | | }.fuse() [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/errors.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 80 | pub fn rerr>(s: S) -> NineResult { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | Err(ServerFail::NonFatal(NonFatalError { [INFO] [stdout] | _________^ [INFO] [stdout] 82 | | msg: s.into(), [INFO] [stdout] 83 | | cause: None, [INFO] [stdout] 84 | | })) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 11 | examiner: F, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 17 | let mut cow = Cow::Borrowed(current); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | [INFO] [stdout] 19 | (examiner)(&mut cow).map(|_| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:19:30 [INFO] [stdout] | [INFO] [stdout] 11 | examiner: F, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 17 | let mut cow = Cow::Borrowed(current); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | [INFO] [stdout] 19 | (examiner)(&mut cow).map(|_| { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 20 | | if let Cow::Owned(x) = cow { [INFO] [stdout] 21 | | Some(x) [INFO] [stdout] 22 | | } else { [INFO] [stdout] 23 | | None [INFO] [stdout] 24 | | } [INFO] [stdout] 25 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nine-memfs` (bin "nine-memfs" test) due to 6 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "dc134107db71e298496b9e0d8bea5ad5e549cab1904a94819ee8dd21c8f092b5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dc134107db71e298496b9e0d8bea5ad5e549cab1904a94819ee8dd21c8f092b5", kill_on_drop: false }` [INFO] [stdout] dc134107db71e298496b9e0d8bea5ad5e549cab1904a94819ee8dd21c8f092b5