[INFO] fetching crate nickel_postgres 0.2.0... [INFO] checking nickel_postgres-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate nickel_postgres 0.2.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate nickel_postgres 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-4-tc2/source/.cargo/config [INFO] started tweaking crates.io crate nickel_postgres 0.2.0 [INFO] finished tweaking crates.io crate nickel_postgres 0.2.0 [INFO] tweaked toml for crates.io crate nickel_postgres 0.2.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 68 packages to latest compatible versions [INFO] [stderr] Adding aho-corasick v0.5.3 (latest: v1.1.3) [INFO] [stderr] Adding byteorder v0.5.3 (latest: v1.5.0) [INFO] [stderr] Adding cookie v0.2.5 (latest: v0.18.1) [INFO] [stderr] Adding hex v0.2.0 (latest: v0.4.3) [INFO] [stderr] Adding hpack v0.2.0 (latest: v0.3.0) [INFO] [stderr] Adding hyper v0.8.1 (latest: v1.4.1) [INFO] [stderr] Adding idna v0.1.5 (latest: v1.0.2) [INFO] [stderr] Adding language-tags v0.2.2 (latest: v0.3.2) [INFO] [stderr] Adding lazy_static v0.1.16 (latest: v1.5.0) [INFO] [stderr] Adding log v0.3.9 (latest: v0.4.22) [INFO] [stderr] Adding memchr v0.1.11 (latest: v2.7.4) [INFO] [stderr] Adding mime v0.2.6 (latest: v0.3.17) [INFO] [stderr] Adding mustache v0.6.3 (latest: v0.9.0) [INFO] [stderr] Adding nickel v0.8.1 (latest: v0.11.0) [INFO] [stderr] Adding num_cpus v0.2.13 (latest: v1.16.0) [INFO] [stderr] Adding percent-encoding v1.0.1 (latest: v2.3.1) [INFO] [stderr] Adding phf v0.7.15 (latest: v0.11.2) [INFO] [stderr] Adding phf_shared v0.7.15 (latest: v0.11.2) [INFO] [stderr] Adding postgres v0.11.12 (latest: v0.19.8) [INFO] [stderr] Adding r2d2 v0.7.4 (latest: v0.8.10) [INFO] [stderr] Adding r2d2_postgres v0.10.1 (latest: v0.18.1) [INFO] [stderr] Adding rand v0.3.23 (latest: v0.8.5) [INFO] [stderr] Adding rand v0.4.6 (latest: v0.8.5) [INFO] [stderr] Adding rand_core v0.3.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (latest: v0.6.4) [INFO] [stderr] Adding rdrand v0.4.0 (latest: v0.8.3) [INFO] [stderr] Adding regex v0.1.80 (latest: v1.10.6) [INFO] [stderr] Adding regex-syntax v0.3.9 (latest: v0.8.4) [INFO] [stderr] Adding scheduled-thread-pool v0.1.0 (latest: v0.2.7) [INFO] [stderr] Adding thread-id v2.0.0 (latest: v4.2.2) [INFO] [stderr] Adding thread_local v0.2.7 (latest: v1.1.8) [INFO] [stderr] Adding time v0.1.45 (latest: v0.3.36) [INFO] [stderr] Adding traitobject v0.0.1 (latest: v0.1.0) [INFO] [stderr] Adding unicase v1.4.2 (latest: v2.7.0) [INFO] [stderr] Adding unicode-bidi v0.2.6 (latest: v0.3.15) [INFO] [stderr] Adding url v0.5.10 (latest: v2.5.2) [INFO] [stderr] Adding url v1.7.2 (latest: v2.5.2) [INFO] [stderr] Adding utf8-ranges v0.1.3 (latest: v1.0.5) [INFO] [stderr] Adding uuid v0.2.3 (latest: v1.10.0) [INFO] [stderr] Adding version_check v0.1.5 (latest: v0.9.5) [INFO] [stderr] Adding wasi v0.10.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding winapi v0.2.8 (latest: v0.3.9) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7ec8cc62384238daa6e2d6ee5ff4d8aea0142b7c77add9c93a13b4329caff960 [INFO] running `Command { std: "docker" "start" "-a" "7ec8cc62384238daa6e2d6ee5ff4d8aea0142b7c77add9c93a13b4329caff960", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7ec8cc62384238daa6e2d6ee5ff4d8aea0142b7c77add9c93a13b4329caff960", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7ec8cc62384238daa6e2d6ee5ff4d8aea0142b7c77add9c93a13b4329caff960", kill_on_drop: false }` [INFO] [stdout] 7ec8cc62384238daa6e2d6ee5ff4d8aea0142b7c77add9c93a13b4329caff960 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d6ad14c99421d8300463c0cb082ed7fc8eb0c93b6da4668968852982b3f3bc24 [INFO] running `Command { std: "docker" "start" "-a" "d6ad14c99421d8300463c0cb082ed7fc8eb0c93b6da4668968852982b3f3bc24", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Compiling winapi-build v0.1.1 [INFO] [stderr] Checking matches v0.1.10 [INFO] [stderr] Compiling version_check v0.1.5 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking winapi v0.2.8 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking traitobject v0.1.0 [INFO] [stderr] Checking percent-encoding v1.0.1 [INFO] [stderr] Compiling kernel32-sys v0.2.2 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Checking rustc-serialize v0.3.25 [INFO] [stderr] Checking unsafe-any v0.4.2 [INFO] [stderr] Checking unicode-bidi v0.2.6 [INFO] [stderr] Compiling unicase v1.4.2 [INFO] [stderr] Checking hpack v0.2.0 [INFO] [stderr] Checking thread-id v2.0.0 [INFO] [stderr] Checking time v0.1.45 [INFO] [stderr] Checking memchr v0.1.11 [INFO] [stderr] Checking phf_shared v0.7.15 [INFO] [stderr] Checking antidote v1.0.0 [INFO] [stderr] Checking aho-corasick v0.5.3 [INFO] [stderr] Checking scheduled-thread-pool v0.1.0 [INFO] [stderr] Checking rand v0.3.23 [INFO] [stderr] Checking phf v0.7.15 [INFO] [stderr] Checking solicit v0.4.4 [INFO] [stderr] Checking uuid v0.2.3 [INFO] [stderr] Checking thread_local v0.2.7 [INFO] [stderr] Checking mime v0.2.6 [INFO] [stderr] Checking typemap v0.3.3 [INFO] [stderr] Checking num_cpus v0.2.13 [INFO] [stderr] Checking utf8-ranges v0.1.3 [INFO] [stderr] Checking hex v0.2.0 [INFO] [stderr] Checking bufstream v0.1.4 [INFO] [stderr] Checking regex-syntax v0.3.9 [INFO] [stderr] Checking language-tags v0.2.2 [INFO] [stderr] Checking traitobject v0.0.1 [INFO] [stderr] Checking byteorder v0.5.3 [INFO] [stderr] Checking typeable v0.1.2 [INFO] [stderr] Checking plugin v0.2.6 [INFO] [stderr] Checking r2d2 v0.7.4 [INFO] [stderr] Checking lazy_static v0.1.16 [INFO] [stderr] Checking postgres v0.11.12 [INFO] [stderr] Checking groupable v0.2.0 [INFO] [stderr] Checking modifier v0.1.0 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking regex v0.1.80 [INFO] [stderr] Checking idna v0.1.5 [INFO] [stderr] Checking url v1.7.2 [INFO] [stderr] Checking r2d2_postgres v0.10.1 [INFO] [stderr] Checking url v0.5.10 [INFO] [stderr] Checking mustache v0.6.3 [INFO] [stderr] Checking cookie v0.2.5 [INFO] [stderr] Checking hyper v0.8.1 [INFO] [stderr] Checking nickel v0.8.1 [INFO] [stderr] Checking nickel_postgres v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/middleware.rs:19:23 [INFO] [stdout] | [INFO] [stdout] 19 | let manager = try!(PostgresConnectionManager::new(db_url, SslMode::None)); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/middleware.rs:20:20 [INFO] [stdout] | [INFO] [stdout] 20 | let pool = try!(Pool::new(Config::default(), manager)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/middleware.rs:18:64 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn new(db_url: &str) -> Result> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 18 | pub fn new(db_url: &str) -> Result> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/middleware.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 19 | let manager = try!(PostgresConnectionManager::new(db_url, SslMode::None)); [INFO] [stdout] | ------- ----------------------------------------------------------- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | let pool = try!(Pool::new(Config::default(), manager)); [INFO] [stdout] | ---- ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | [INFO] [stdout] 22 | Ok(PostgresMiddleware { pool: pool }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/middleware.rs:39:12 [INFO] [stdout] | [INFO] [stdout] 36 | fn invoke<'mw, 'conn>(&self, req: &mut Request<'mw, 'conn, D>, res: Response<'mw, D>) -> MiddlewareResult<'mw, D> { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | Ok(Continue(res)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/middleware.rs:19:23 [INFO] [stdout] | [INFO] [stdout] 19 | let manager = try!(PostgresConnectionManager::new(db_url, SslMode::None)); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/middleware.rs:20:20 [INFO] [stdout] | [INFO] [stdout] 20 | let pool = try!(Pool::new(Config::default(), manager)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nickel_postgres` (lib test) due to 3 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/middleware.rs:18:64 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn new(db_url: &str) -> Result> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 18 | pub fn new(db_url: &str) -> Result> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/middleware.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 19 | let manager = try!(PostgresConnectionManager::new(db_url, SslMode::None)); [INFO] [stdout] | ------- ----------------------------------------------------------- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | let pool = try!(Pool::new(Config::default(), manager)); [INFO] [stdout] | ---- ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | [INFO] [stdout] 22 | Ok(PostgresMiddleware { pool: pool }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/middleware.rs:39:12 [INFO] [stdout] | [INFO] [stdout] 36 | fn invoke<'mw, 'conn>(&self, req: &mut Request<'mw, 'conn, D>, res: Response<'mw, D>) -> MiddlewareResult<'mw, D> { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | Ok(Continue(res)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nickel_postgres` (lib) due to 3 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "d6ad14c99421d8300463c0cb082ed7fc8eb0c93b6da4668968852982b3f3bc24", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d6ad14c99421d8300463c0cb082ed7fc8eb0c93b6da4668968852982b3f3bc24", kill_on_drop: false }` [INFO] [stdout] d6ad14c99421d8300463c0cb082ed7fc8eb0c93b6da4668968852982b3f3bc24