[INFO] fetching crate nichi 0.5.1... [INFO] checking nichi-0.5.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate nichi 0.5.1 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate nichi 0.5.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate nichi 0.5.1 [INFO] finished tweaking crates.io crate nichi 0.5.1 [INFO] tweaked toml for crates.io crate nichi 0.5.1 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 20 packages to latest compatible versions [INFO] [stderr] Adding convert_case v0.4.0 (latest: v0.6.0) [INFO] [stderr] Adding derive_more v0.99.18 (latest: v1.0.0) [INFO] [stderr] Adding virtue v0.0.13 (latest: v0.0.17) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d02e0377ea098b386ca339205f2390d49ca75fd6d82b06ef786dadd55706f4a9 [INFO] running `Command { std: "docker" "start" "-a" "d02e0377ea098b386ca339205f2390d49ca75fd6d82b06ef786dadd55706f4a9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d02e0377ea098b386ca339205f2390d49ca75fd6d82b06ef786dadd55706f4a9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d02e0377ea098b386ca339205f2390d49ca75fd6d82b06ef786dadd55706f4a9", kill_on_drop: false }` [INFO] [stdout] d02e0377ea098b386ca339205f2390d49ca75fd6d82b06ef786dadd55706f4a9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b9463ee27e637b6c0a441335a293b6d028db8dd170f7ca0c221d51276f73d390 [INFO] running `Command { std: "docker" "start" "-a" "b9463ee27e637b6c0a441335a293b6d028db8dd170f7ca0c221d51276f73d390", kill_on_drop: false }` [INFO] [stderr] Compiling virtue v0.0.13 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling bincode_derive v2.0.0-rc.3 [INFO] [stderr] Checking bincode v2.0.0-rc.3 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking nichi v0.5.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: lint `private_in_public` has been removed: replaced with another group of lints, see RFC for more information [INFO] [stdout] --> src/lib.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | private_in_public, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Into` [INFO] [stdout] --> src/year.rs:6:2 [INFO] [stdout] | [INFO] [stdout] 6 | Into, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::day::Day` [INFO] [stdout] --> src/year.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | use crate::day::Day; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::weekday::Weekday` [INFO] [stdout] --> src/year.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | use crate::weekday::Weekday; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Date`, `Day`, `Weekday`, and `Year` [INFO] [stdout] --> src/free.rs:2:13 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::{Date,Year,Month,Day,DaysInMonth,Weekday}; [INFO] [stdout] | ^^^^ ^^^^ ^^^ ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `private_in_public` has been removed: replaced with another group of lints, see RFC for more information [INFO] [stdout] --> src/lib.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | private_in_public, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Into` [INFO] [stdout] --> src/year.rs:6:2 [INFO] [stdout] | [INFO] [stdout] 6 | Into, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::day::Day` [INFO] [stdout] --> src/year.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | use crate::day::Day; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::weekday::Weekday` [INFO] [stdout] --> src/year.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | use crate::weekday::Weekday; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Date`, `Day`, `Weekday`, and `Year` [INFO] [stdout] --> src/free.rs:2:13 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::{Date,Year,Month,Day,DaysInMonth,Weekday}; [INFO] [stdout] | ^^^^ ^^^^ ^^^ ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/date.rs:290:42 [INFO] [stdout] | [INFO] [stdout] 290 | static ISO: Lazy = Lazy::new(|| Regex::new(r"[1-9]\d{3}.\d{1,2}.\d{1,2}").unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/date.rs:291:44 [INFO] [stdout] | [INFO] [stdout] 291 | static ISO_1: Lazy = Lazy::new(|| Regex::new(r"[1-9]\d{3}.(0[1-9]|1[012]).(0[1-9]|[12][0-9]|30|31)").unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/date.rs:292:44 [INFO] [stdout] | [INFO] [stdout] 292 | static ISO_2: Lazy = Lazy::new(|| Regex::new(r"[1-9]\d{3}.[1-9].(0[1-9]|[12][0-9]|30|31)").unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/date.rs:293:44 [INFO] [stdout] | [INFO] [stdout] 293 | static ISO_3: Lazy = Lazy::new(|| Regex::new(r"[1-9]\d{3}.(0[1-9]|1[012]).[1-9]").unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/date.rs:294:44 [INFO] [stdout] | [INFO] [stdout] 294 | static ISO_4: Lazy = Lazy::new(|| Regex::new(r"[1-9]\d{3}.[1-9].[1-9]").unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/date.rs:341:43 [INFO] [stdout] | [INFO] [stdout] 341 | static YEAR: Lazy = Lazy::new(|| Regex::new(r"\d{4}").unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/date.rs:343:44 [INFO] [stdout] | [INFO] [stdout] 343 | static MONTH: Lazy = Lazy::new(|| Regex::new( [INFO] [stdout] | __________________________________________________^ [INFO] [stdout] 344 | | r"Jan|jan|JAN|Feb|feb|FEB|Mar|mar|MAR|Apr|apr|APR|Jun|jun|JUN|Jul|jul|JUL|Aug|aug|AUG|Sep|sep|SEP|Oct|oct|OCT|Nov|nov|NOV|Dec|dec|DEC" [INFO] [stdout] 345 | | ).unwrap()); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/date.rs:348:42 [INFO] [stdout] | [INFO] [stdout] 348 | static DAY: Lazy = Lazy::new(|| Regex::new(r"(\d{2}|\d{1})[A-Za-z]{2}|\b\d{2}\b|\b\d{1}\b").unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/date.rs:290:42 [INFO] [stdout] | [INFO] [stdout] 290 | static ISO: Lazy = Lazy::new(|| Regex::new(r"[1-9]\d{3}.\d{1,2}.\d{1,2}").unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/date.rs:291:44 [INFO] [stdout] | [INFO] [stdout] 291 | static ISO_1: Lazy = Lazy::new(|| Regex::new(r"[1-9]\d{3}.(0[1-9]|1[012]).(0[1-9]|[12][0-9]|30|31)").unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/date.rs:292:44 [INFO] [stdout] | [INFO] [stdout] 292 | static ISO_2: Lazy = Lazy::new(|| Regex::new(r"[1-9]\d{3}.[1-9].(0[1-9]|[12][0-9]|30|31)").unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/date.rs:293:44 [INFO] [stdout] | [INFO] [stdout] 293 | static ISO_3: Lazy = Lazy::new(|| Regex::new(r"[1-9]\d{3}.(0[1-9]|1[012]).[1-9]").unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/date.rs:294:44 [INFO] [stdout] | [INFO] [stdout] 294 | static ISO_4: Lazy = Lazy::new(|| Regex::new(r"[1-9]\d{3}.[1-9].[1-9]").unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/date.rs:341:43 [INFO] [stdout] | [INFO] [stdout] 341 | static YEAR: Lazy = Lazy::new(|| Regex::new(r"\d{4}").unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/date.rs:343:44 [INFO] [stdout] | [INFO] [stdout] 343 | static MONTH: Lazy = Lazy::new(|| Regex::new( [INFO] [stdout] | __________________________________________________^ [INFO] [stdout] 344 | | r"Jan|jan|JAN|Feb|feb|FEB|Mar|mar|MAR|Apr|apr|APR|Jun|jun|JUN|Jul|jul|JUL|Aug|aug|AUG|Sep|sep|SEP|Oct|oct|OCT|Nov|nov|NOV|Dec|dec|DEC" [INFO] [stdout] 345 | | ).unwrap()); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/date.rs:348:42 [INFO] [stdout] | [INFO] [stdout] 348 | static DAY: Lazy = Lazy::new(|| Regex::new(r"(\d{2}|\d{1})[A-Za-z]{2}|\b\d{2}\b|\b\d{1}\b").unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nichi` (lib) due to 9 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `nichi` (lib test) due to 9 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "b9463ee27e637b6c0a441335a293b6d028db8dd170f7ca0c221d51276f73d390", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b9463ee27e637b6c0a441335a293b6d028db8dd170f7ca0c221d51276f73d390", kill_on_drop: false }` [INFO] [stdout] b9463ee27e637b6c0a441335a293b6d028db8dd170f7ca0c221d51276f73d390