[INFO] fetching crate nibbletree 0.2.0... [INFO] checking nibbletree-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate nibbletree 0.2.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate nibbletree 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate nibbletree 0.2.0 [INFO] finished tweaking crates.io crate nibbletree 0.2.0 [INFO] tweaked toml for crates.io crate nibbletree 0.2.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate nibbletree 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c12eddb3e9952f02dcb2ee033e62f99c18710df2f22d2fdbc904f652b74cf0b0 [INFO] running `Command { std: "docker" "start" "-a" "c12eddb3e9952f02dcb2ee033e62f99c18710df2f22d2fdbc904f652b74cf0b0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c12eddb3e9952f02dcb2ee033e62f99c18710df2f22d2fdbc904f652b74cf0b0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c12eddb3e9952f02dcb2ee033e62f99c18710df2f22d2fdbc904f652b74cf0b0", kill_on_drop: false }` [INFO] [stdout] c12eddb3e9952f02dcb2ee033e62f99c18710df2f22d2fdbc904f652b74cf0b0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fa5cd5dd680ee63d98baab69d0287cb4a49ab343f1d896e42d6ff8a65f2bb6d6 [INFO] running `Command { std: "docker" "start" "-a" "fa5cd5dd680ee63d98baab69d0287cb4a49ab343f1d896e42d6ff8a65f2bb6d6", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling semver v1.0.21 [INFO] [stderr] Compiling radium v0.7.0 [INFO] [stderr] Compiling memchr v2.7.1 [INFO] [stderr] Checking tap v1.0.1 [INFO] [stderr] Compiling regex-syntax v0.8.2 [INFO] [stderr] Checking funty v2.0.0 [INFO] [stderr] Checking thin-vec v0.2.13 [INFO] [stderr] Compiling glob v0.3.1 [INFO] [stderr] Compiling relative-path v1.9.2 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Checking wyz v0.5.1 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking bitvec v1.0.1 [INFO] [stderr] Compiling rstest_macros v0.18.2 [INFO] [stderr] Compiling rstest_reuse v0.6.0 [INFO] [stderr] Compiling aho-corasick v1.1.2 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand_xoshiro v0.6.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling regex-automata v0.4.5 [INFO] [stderr] Checking nibbletree v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node.rs:70:18 [INFO] [stdout] | [INFO] [stdout] 66 | fn results_keys_with_prefix(&self, prefix: Key) -> impl Iterator + '_ { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | .map(move |result_key| { [INFO] [stdout] | __________________^ [INFO] [stdout] 71 | | let mut key = prefix.clone(); [INFO] [stdout] 72 | | key.extend(result_key); [INFO] [stdout] 73 | | key [INFO] [stdout] 74 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node.rs:315:9 [INFO] [stdout] | [INFO] [stdout] 314 | fn longest_match_with_prefix(&self, mut prefix: Key, mut key: KeyRef) -> Option<(Key, &T)> { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 315 | / (key.len() > self.bitmap.results_capacity()).then(|| { [INFO] [stdout] 316 | | let mut prefix = prefix.clone(); [INFO] [stdout] 317 | | let (key, remaining) = key.split_at(RESULTS_BITS_END_NODE); [INFO] [stdout] 318 | | prefix.extend(key); [INFO] [stdout] 319 | | self.get_child(key).and_then(|child| child.longest_match_with_prefix(prefix, remaining)) [INFO] [stdout] 320 | | }) [INFO] [stdout] 321 | | .flatten() [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node.rs:322:18 [INFO] [stdout] | [INFO] [stdout] 314 | fn longest_match_with_prefix(&self, mut prefix: Key, mut key: KeyRef) -> Option<(Key, &T)> { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 322 | .or_else(|| { [INFO] [stdout] | __________________^ [INFO] [stdout] 323 | | loop { [INFO] [stdout] 324 | | if let Some(result) = self.exact(key) { [INFO] [stdout] 325 | | prefix.extend(key); [INFO] [stdout] ... | [INFO] [stdout] 334 | | None [INFO] [stdout] 335 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node.rs:319:42 [INFO] [stdout] | [INFO] [stdout] 316 | let mut prefix = prefix.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 319 | self.get_child(key).and_then(|child| child.longest_match_with_prefix(prefix, remaining)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node.rs:379:36 [INFO] [stdout] | [INFO] [stdout] 378 | pub fn or_longer(&self, key: Key) -> impl Iterator + '_ { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 379 | self.or_longer_with_prefix(Key::new(), key) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node.rs:415:34 [INFO] [stdout] | [INFO] [stdout] 414 | pub fn matches(&self, key: Key) -> impl Iterator + '_ { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 415 | self.matches_with_prefix(Key::new(), key) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node_with_key.rs:202:27 [INFO] [stdout] | [INFO] [stdout] 201 | pub fn insert(&mut self, key: &K, value: T) -> Option { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 202 | self.node.insert(&key.to_key(), value) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node_with_key.rs:210:28 [INFO] [stdout] | [INFO] [stdout] 210 | .map(|(k, v)| (K::from_key_owned(k), v)) [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node_with_key.rs:214:28 [INFO] [stdout] | [INFO] [stdout] 214 | .map(|(k, v)| (K::from_key_owned(k), v)) [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node_with_key.rs:237:28 [INFO] [stdout] | [INFO] [stdout] 237 | .map(|(k, v)| (K::from_key_owned(k), v)) [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node_with_key.rs:242:28 [INFO] [stdout] | [INFO] [stdout] 242 | .map(|(k, v)| (K::from_key_owned(k), v)) [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node_with_key.rs:247:28 [INFO] [stdout] | [INFO] [stdout] 247 | .map(|(k, v)| (K::from_key_owned(k), v)) [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nibbletree` (lib) due to 13 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "fa5cd5dd680ee63d98baab69d0287cb4a49ab343f1d896e42d6ff8a65f2bb6d6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fa5cd5dd680ee63d98baab69d0287cb4a49ab343f1d896e42d6ff8a65f2bb6d6", kill_on_drop: false }` [INFO] [stdout] fa5cd5dd680ee63d98baab69d0287cb4a49ab343f1d896e42d6ff8a65f2bb6d6