[INFO] fetching crate ngen 0.1.4... [INFO] checking ngen-0.1.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ngen 0.1.4 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate ngen 0.1.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ngen 0.1.4 [INFO] finished tweaking crates.io crate ngen 0.1.4 [INFO] tweaked toml for crates.io crate ngen 0.1.4 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 34 packages to latest compatible versions [INFO] [stderr] Adding approx v0.3.2 (latest: v0.5.1) [INFO] [stderr] Adding autocfg v0.1.8 (latest: v1.3.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding cgmath v0.17.0 (latest: v0.18.0) [INFO] [stderr] Adding cloudabi v0.0.3 (latest: v0.1.0) [INFO] [stderr] Adding rand v0.6.5 (latest: v0.8.5) [INFO] [stderr] Adding rand_chacha v0.1.1 (latest: v0.3.1) [INFO] [stderr] Adding rand_core v0.3.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (latest: v0.6.4) [INFO] [stderr] Adding rand_hc v0.1.0 (latest: v0.3.2) [INFO] [stderr] Adding rand_isaac v0.1.1 (latest: v0.3.0) [INFO] [stderr] Adding rand_jitter v0.1.4 (latest: v0.4.0) [INFO] [stderr] Adding rand_os v0.1.3 (latest: v0.2.2) [INFO] [stderr] Adding rand_pcg v0.1.2 (latest: v0.3.1) [INFO] [stderr] Adding rand_xorshift v0.1.1 (latest: v0.3.0) [INFO] [stderr] Adding rdrand v0.4.0 (latest: v0.8.3) [INFO] [stderr] Adding sdl2 v0.34.5 (latest: v0.37.0) [INFO] [stderr] Adding sdl2-sys v0.34.5 (latest: v0.37.0) [INFO] [stderr] Adding version-compare v0.0.10 (latest: v0.2.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fb41bb3acb786c4ce2f9db9feeab232dcc2be7c97947fbf467d6f33f16ccc575 [INFO] running `Command { std: "docker" "start" "-a" "fb41bb3acb786c4ce2f9db9feeab232dcc2be7c97947fbf467d6f33f16ccc575", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fb41bb3acb786c4ce2f9db9feeab232dcc2be7c97947fbf467d6f33f16ccc575", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fb41bb3acb786c4ce2f9db9feeab232dcc2be7c97947fbf467d6f33f16ccc575", kill_on_drop: false }` [INFO] [stdout] fb41bb3acb786c4ce2f9db9feeab232dcc2be7c97947fbf467d6f33f16ccc575 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5e1a3a501d53dce0384f7028310693b765cad342c852043bba3f2af8915a0f9b [INFO] running `Command { std: "docker" "start" "-a" "5e1a3a501d53dce0384f7028310693b765cad342c852043bba3f2af8915a0f9b", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v0.1.8 [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Compiling cfg-if v0.1.10 [INFO] [stderr] Compiling version-compare v0.0.10 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Compiling cgmath v0.17.0 [INFO] [stderr] Compiling sdl2 v0.34.5 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Compiling sdl2-sys v0.34.5 [INFO] [stderr] Checking rand_jitter v0.1.4 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Compiling gl v0.14.0 [INFO] [stderr] Checking approx v0.3.2 [INFO] [stderr] Checking ngen v0.1.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `dim` is never read [INFO] [stdout] --> src/assets.rs:12:16 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct Sprite { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 12 | pub(crate) dim: Vec2, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Sprite` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `buttons` is never used [INFO] [stdout] --> src/input.rs:42:8 [INFO] [stdout] | [INFO] [stdout] 41 | trait Buttons: Sized { [INFO] [stdout] | ------- method in this trait [INFO] [stdout] 42 | fn buttons(&self) -> &[Button] { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:218:25 [INFO] [stdout] | [INFO] [stdout] 217 | pub fn mount(self, simulation: S) -> Result<(), String> { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 218 | self.mount_init(move |_| simulation) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arena.rs:78:12 [INFO] [stdout] | [INFO] [stdout] 76 | let memory = RawMemory::with_capacity(capacity)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | [INFO] [stdout] 78 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 79 | | memory: RefCell::new(memory), [INFO] [stdout] 80 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/renderer/opengl.rs:88:12 [INFO] [stdout] | [INFO] [stdout] 58 | let video = context.video()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | [INFO] [stdout] 60 | let canvas = video [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 89 | | canvas, [INFO] [stdout] 90 | | viewport: Viewport::new(window_width as _, window_height as _), [INFO] [stdout] 91 | | shader: VertexShader::new()?, [INFO] [stdout] 92 | | render_commands, [INFO] [stdout] 93 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/time.rs:27:12 [INFO] [stdout] | [INFO] [stdout] 23 | let subsystem = context.timer()?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 28 | | dt, [INFO] [stdout] 29 | | freq, [INFO] [stdout] 30 | | max_frame, [INFO] [stdout] ... | [INFO] [stdout] 35 | | subsystem, [INFO] [stdout] 36 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ngen` (lib test) due to 5 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `dim` is never read [INFO] [stdout] --> src/assets.rs:12:16 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct Sprite { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 12 | pub(crate) dim: Vec2, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Sprite` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `buttons` is never used [INFO] [stdout] --> src/input.rs:42:8 [INFO] [stdout] | [INFO] [stdout] 41 | trait Buttons: Sized { [INFO] [stdout] | ------- method in this trait [INFO] [stdout] 42 | fn buttons(&self) -> &[Button] { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:218:25 [INFO] [stdout] | [INFO] [stdout] 217 | pub fn mount(self, simulation: S) -> Result<(), String> { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 218 | self.mount_init(move |_| simulation) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arena.rs:78:12 [INFO] [stdout] | [INFO] [stdout] 76 | let memory = RawMemory::with_capacity(capacity)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | [INFO] [stdout] 78 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 79 | | memory: RefCell::new(memory), [INFO] [stdout] 80 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/renderer/opengl.rs:88:12 [INFO] [stdout] | [INFO] [stdout] 58 | let video = context.video()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | [INFO] [stdout] 60 | let canvas = video [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 89 | | canvas, [INFO] [stdout] 90 | | viewport: Viewport::new(window_width as _, window_height as _), [INFO] [stdout] 91 | | shader: VertexShader::new()?, [INFO] [stdout] 92 | | render_commands, [INFO] [stdout] 93 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ngen` (lib) due to 5 previous errors; 2 warnings emitted [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/time.rs:27:12 [INFO] [stdout] | [INFO] [stdout] 23 | let subsystem = context.timer()?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 28 | | dt, [INFO] [stdout] 29 | | freq, [INFO] [stdout] 30 | | max_frame, [INFO] [stdout] ... | [INFO] [stdout] 35 | | subsystem, [INFO] [stdout] 36 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "5e1a3a501d53dce0384f7028310693b765cad342c852043bba3f2af8915a0f9b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5e1a3a501d53dce0384f7028310693b765cad342c852043bba3f2af8915a0f9b", kill_on_drop: false }` [INFO] [stdout] 5e1a3a501d53dce0384f7028310693b765cad342c852043bba3f2af8915a0f9b