[INFO] fetching crate new-home-ws281x 1.0.4... [INFO] checking new-home-ws281x-1.0.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate new-home-ws281x 1.0.4 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate new-home-ws281x 1.0.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate new-home-ws281x 1.0.4 [INFO] finished tweaking crates.io crate new-home-ws281x 1.0.4 [INFO] tweaked toml for crates.io crate new-home-ws281x 1.0.4 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate new-home-ws281x 1.0.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] db02cb7e16f019793167be7653a401e722a7dcf7e3291505c602d1614db55da6 [INFO] running `Command { std: "docker" "start" "-a" "db02cb7e16f019793167be7653a401e722a7dcf7e3291505c602d1614db55da6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "db02cb7e16f019793167be7653a401e722a7dcf7e3291505c602d1614db55da6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "db02cb7e16f019793167be7653a401e722a7dcf7e3291505c602d1614db55da6", kill_on_drop: false }` [INFO] [stdout] db02cb7e16f019793167be7653a401e722a7dcf7e3291505c602d1614db55da6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4788eb89d64ebc1ea5552bf6b8d7ebeb383779b6b245ecdb3adf5c1c3ac0911a [INFO] running `Command { std: "docker" "start" "-a" "4788eb89d64ebc1ea5552bf6b8d7ebeb383779b6b245ecdb3adf5c1c3ac0911a", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.70 [INFO] [stderr] Compiling cfg-if v0.1.10 [INFO] [stderr] Compiling proc-macro2 v1.0.13 [INFO] [stderr] Compiling getrandom v0.1.14 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling syn v1.0.23 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Compiling glob v0.2.11 [INFO] [stderr] Compiling cc v1.0.54 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Compiling ppv-lite86 v0.2.8 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling clang-sys v0.23.0 [INFO] [stderr] Compiling thread_local v1.0.1 [INFO] [stderr] Compiling quote v1.0.6 [INFO] [stderr] Compiling atty v0.2.14 [INFO] [stderr] Compiling memchr v1.0.2 [INFO] [stderr] Compiling rand_core v0.5.1 [INFO] [stderr] Compiling aho-corasick v0.7.10 [INFO] [stderr] Compiling siphasher v0.3.3 [INFO] [stderr] Compiling unicode-width v0.1.7 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling quick-error v1.2.3 [INFO] [stderr] Compiling regex-syntax v0.6.17 [INFO] [stderr] Compiling phf_shared v0.8.0 [INFO] [stderr] Compiling proc-macro2 v0.3.5 [INFO] [stderr] Compiling rand_pcg v0.2.1 [INFO] [stderr] Compiling rand_chacha v0.2.2 [INFO] [stderr] Compiling humantime v1.3.0 [INFO] [stderr] Compiling textwrap v0.11.0 [INFO] [stderr] Compiling rand v0.7.3 [INFO] [stderr] Compiling libloading v0.5.2 [INFO] [stderr] Compiling nom v3.2.1 [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling ansi_term v0.11.0 [INFO] [stderr] Compiling termcolor v1.1.0 [INFO] [stderr] Compiling serde v1.0.110 [INFO] [stderr] Compiling strsim v0.8.0 [INFO] [stderr] Compiling vec_map v0.8.2 [INFO] [stderr] Compiling bindgen v0.37.4 [INFO] [stderr] Compiling phf_generator v0.8.0 [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Compiling clap v2.33.1 [INFO] [stderr] Compiling quote v0.5.2 [INFO] [stderr] Compiling cexpr v0.2.3 [INFO] [stderr] Compiling which v1.0.5 [INFO] [stderr] Compiling ryu v1.0.4 [INFO] [stderr] Compiling peeking_take_while v0.1.2 [INFO] [stderr] Compiling phf_codegen v0.8.0 [INFO] [stderr] Checking matches v0.1.8 [INFO] [stderr] Checking smallvec v1.4.0 [INFO] [stderr] Checking unicode-normalization v0.1.12 [INFO] [stderr] Checking unicode-bidi v0.3.4 [INFO] [stderr] Compiling regex v1.3.7 [INFO] [stderr] Compiling palette v0.5.0 [INFO] [stderr] Checking itoa v0.4.5 [INFO] [stderr] Checking approx v0.3.2 [INFO] [stderr] Checking idna v0.2.0 [INFO] [stderr] Checking phf v0.8.0 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Checking url v2.1.1 [INFO] [stderr] Compiling serde_derive v1.0.110 [INFO] [stderr] Compiling palette_derive v0.5.0 [INFO] [stderr] Compiling env_logger v0.5.13 [INFO] [stderr] Compiling rs_ws281x v0.2.3 [INFO] [stderr] Checking serde_json v1.0.53 [INFO] [stderr] Checking new-home-application v0.1.3 [INFO] [stderr] Checking new-home-ws281x v1.0.4 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/services/strip_renderer.rs:24:21 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn new(controller: Arc>, interrupt_receiver: Receiver) -> Self { [INFO] [stdout] | ---------------------------------- ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | shader: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/services/render_manager.rs:32:23 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn new(strip_manager: Arc>) -> Self { [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | renderer: RwLock::new(HashMap::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/services/render_manager.rs:72:12 [INFO] [stdout] | [INFO] [stdout] 62 | let mut renderer_rw = self.renderer.write().unwrap(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | Ok(renderer_rw.get(channel).unwrap().clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/services/render_manager.rs:79:12 [INFO] [stdout] | [INFO] [stdout] 77 | let (renderer, sender) = self.build_renderer(channel)?; [INFO] [stdout] | -------- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | [INFO] [stdout] 79 | Ok(RendererInfo { [INFO] [stdout] | ____________^ [INFO] [stdout] 80 | | sender, [INFO] [stdout] 81 | | renderer: Arc::new(Mutex::new(renderer)), [INFO] [stdout] 82 | | join_handle: None, [INFO] [stdout] 83 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/services/render_manager.rs:94:12 [INFO] [stdout] | [INFO] [stdout] 91 | let (sender, receiver) = channel::(); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | let controller = self.strip_manager.read().unwrap().get_strip_controller(strip_channel.clone())?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | [INFO] [stdout] 94 | Ok((StripRenderer::new(controller, receiver), sender)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `new-home-ws281x` (bin "new-home-ws281x") due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/services/strip_renderer.rs:24:21 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn new(controller: Arc>, interrupt_receiver: Receiver) -> Self { [INFO] [stdout] | ---------------------------------- ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | shader: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/services/render_manager.rs:32:23 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn new(strip_manager: Arc>) -> Self { [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | renderer: RwLock::new(HashMap::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/services/render_manager.rs:72:12 [INFO] [stdout] | [INFO] [stdout] 62 | let mut renderer_rw = self.renderer.write().unwrap(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | Ok(renderer_rw.get(channel).unwrap().clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/services/render_manager.rs:79:12 [INFO] [stdout] | [INFO] [stdout] 77 | let (renderer, sender) = self.build_renderer(channel)?; [INFO] [stdout] | -------- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | [INFO] [stdout] 79 | Ok(RendererInfo { [INFO] [stdout] | ____________^ [INFO] [stdout] 80 | | sender, [INFO] [stdout] 81 | | renderer: Arc::new(Mutex::new(renderer)), [INFO] [stdout] 82 | | join_handle: None, [INFO] [stdout] 83 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/services/render_manager.rs:94:12 [INFO] [stdout] | [INFO] [stdout] 91 | let (sender, receiver) = channel::(); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | let controller = self.strip_manager.read().unwrap().get_strip_controller(strip_channel.clone())?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | [INFO] [stdout] 94 | Ok((StripRenderer::new(controller, receiver), sender)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `new-home-ws281x` (bin "new-home-ws281x" test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "4788eb89d64ebc1ea5552bf6b8d7ebeb383779b6b245ecdb3adf5c1c3ac0911a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4788eb89d64ebc1ea5552bf6b8d7ebeb383779b6b245ecdb3adf5c1c3ac0911a", kill_on_drop: false }` [INFO] [stdout] 4788eb89d64ebc1ea5552bf6b8d7ebeb383779b6b245ecdb3adf5c1c3ac0911a