[INFO] fetching crate new 0.0.0... [INFO] checking new-0.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate new 0.0.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate new 0.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate new 0.0.0 [INFO] finished tweaking crates.io crate new 0.0.0 [INFO] tweaked toml for crates.io crate new 0.0.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 5 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d126053960fec639206281508c3aa8fe1a0d7ca08f0bc08b783f3fa603c48a82 [INFO] running `Command { std: "docker" "start" "-a" "d126053960fec639206281508c3aa8fe1a0d7ca08f0bc08b783f3fa603c48a82", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d126053960fec639206281508c3aa8fe1a0d7ca08f0bc08b783f3fa603c48a82", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d126053960fec639206281508c3aa8fe1a0d7ca08f0bc08b783f3fa603c48a82", kill_on_drop: false }` [INFO] [stdout] d126053960fec639206281508c3aa8fe1a0d7ca08f0bc08b783f3fa603c48a82 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] dc97deee1eaf2d2a1c1df98d487c48d74737cc0ee62b7fe4df4fa020de0d3ffc [INFO] running `Command { std: "docker" "start" "-a" "dc97deee1eaf2d2a1c1df98d487c48d74737cc0ee62b7fe4df4fa020de0d3ffc", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking syn v2.0.77 [INFO] [stderr] Checking new v0.0.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `struct_token` is never read [INFO] [stdout] --> src/structs.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 16 | pub struct NewItemStruct { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 19 | pub struct_token: Struct, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `NewItemStruct` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `paren_token` is never read [INFO] [stdout] --> src/structs.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 29 | pub struct NewFields { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] 30 | pub paren_token: Brace, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `NewFields` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/structs.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 47 | let content; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | Ok(Self { paren_token: braced!(content in input), [INFO] [stdout] | ____________^ [INFO] [stdout] 49 | | named: Punctuated::parse_terminated_with(&content, NewLocal::parse)?, }) [INFO] [stdout] | |_______________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/structs.rs:101:10 [INFO] [stdout] | [INFO] [stdout] 89 | fn split(self) -> ((Option, FieldValue), Pair) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | let (ident, ty, expr) = (self.ident, self.ty, self.init.map(|(_, e)| *e)); [INFO] [stdout] | ----- -- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | let fnarg = if expr.is_none() { Some(parse_quote!( #ident : #ty )) } else { None }; [INFO] [stdout] | ----- ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | let expr = expr.unwrap_or_else(|| parse_quote!( #ident )); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | let field_value = parse_quote!( #ident : #expr ); [INFO] [stdout] | ----------- ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | let field = Field { attrs: self.attrs, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | let pair = Pair::Punctuated(field, Comma::default()); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | ((fnarg, field_value), pair) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `struct_token` is never read [INFO] [stdout] --> src/structs.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 16 | pub struct NewItemStruct { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 19 | pub struct_token: Struct, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `NewItemStruct` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `paren_token` is never read [INFO] [stdout] --> src/structs.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 29 | pub struct NewFields { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] 30 | pub paren_token: Brace, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `NewFields` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/structs.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 47 | let content; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | Ok(Self { paren_token: braced!(content in input), [INFO] [stdout] | ____________^ [INFO] [stdout] 49 | | named: Punctuated::parse_terminated_with(&content, NewLocal::parse)?, }) [INFO] [stdout] | |_______________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/structs.rs:101:10 [INFO] [stdout] | [INFO] [stdout] 89 | fn split(self) -> ((Option, FieldValue), Pair) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | let (ident, ty, expr) = (self.ident, self.ty, self.init.map(|(_, e)| *e)); [INFO] [stdout] | ----- -- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | let fnarg = if expr.is_none() { Some(parse_quote!( #ident : #ty )) } else { None }; [INFO] [stdout] | ----- ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | let expr = expr.unwrap_or_else(|| parse_quote!( #ident )); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | let field_value = parse_quote!( #ident : #expr ); [INFO] [stdout] | ----------- ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | let field = Field { attrs: self.attrs, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | let pair = Pair::Punctuated(field, Comma::default()); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | ((fnarg, field_value), pair) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `new` (lib test) due to 3 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `new` (lib) due to 3 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "dc97deee1eaf2d2a1c1df98d487c48d74737cc0ee62b7fe4df4fa020de0d3ffc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dc97deee1eaf2d2a1c1df98d487c48d74737cc0ee62b7fe4df4fa020de0d3ffc", kill_on_drop: false }` [INFO] [stdout] dc97deee1eaf2d2a1c1df98d487c48d74737cc0ee62b7fe4df4fa020de0d3ffc