[INFO] fetching crate netstat 0.7.0... [INFO] checking netstat-0.7.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate netstat 0.7.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate netstat 0.7.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate netstat 0.7.0 [INFO] finished tweaking crates.io crate netstat 0.7.0 [INFO] tweaked toml for crates.io crate netstat 0.7.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 6 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding easybench v0.1.4 (latest: v1.1.1) [INFO] [stderr] Adding humantime v1.3.0 (latest: v2.1.0) [INFO] [stderr] Adding quick-error v1.2.3 (latest: v2.0.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 90796c07d043ceb495dab606e3b872ba6b87c09c93e8af346f8b06d7a9839713 [INFO] running `Command { std: "docker" "start" "-a" "90796c07d043ceb495dab606e3b872ba6b87c09c93e8af346f8b06d7a9839713", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "90796c07d043ceb495dab606e3b872ba6b87c09c93e8af346f8b06d7a9839713", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "90796c07d043ceb495dab606e3b872ba6b87c09c93e8af346f8b06d7a9839713", kill_on_drop: false }` [INFO] [stdout] 90796c07d043ceb495dab606e3b872ba6b87c09c93e8af346f8b06d7a9839713 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 646018d3816aec23ce0a544e2d793aaa385a94d6d9e6ae8ed34ed781d944a91c [INFO] running `Command { std: "docker" "start" "-a" "646018d3816aec23ce0a544e2d793aaa385a94d6d9e6ae8ed34ed781d944a91c", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking netstat v0.7.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `self::macros::*` [INFO] [stdout] --> src/integrations/linux/ffi/mod.rs:8:9 [INFO] [stdout] | [INFO] [stdout] 8 | pub use self::macros::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::tcp_state_ext::*` [INFO] [stdout] --> src/integrations/linux/ext/mod.rs:3:9 [INFO] [stdout] | [INFO] [stdout] 3 | pub use self::tcp_state_ext::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::mem::uninitialized`: use `mem::MaybeUninit` instead [INFO] [stdout] --> src/integrations/linux/netlink_iterator.rs:79:41 [INFO] [stdout] | [INFO] [stdout] 79 | let mut sa: sockaddr_nl = std::mem::uninitialized(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/integrations/linux/api.rs:34:8 [INFO] [stdout] | [INFO] [stdout] 15 | let mut iterators = Vec::with_capacity(4); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | Ok(attach_pids(iterators.into_iter().flatten())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/integrations/linux/api.rs:41:22 [INFO] [stdout] | [INFO] [stdout] 38 | sockets_info: impl Iterator>, [INFO] [stdout] | ------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | ) -> impl Iterator> { [INFO] [stdout] 40 | let mut pids_by_inode = build_hash_of_pids_by_inode(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | sockets_info.map(move |r| { [INFO] [stdout] | ______________________^ [INFO] [stdout] 42 | | r.map(|socket_info| SocketInfo { [INFO] [stdout] 43 | | associated_pids: pids_by_inode [INFO] [stdout] 44 | | .remove(&socket_info.inode) [INFO] [stdout] ... | [INFO] [stdout] 50 | | }) [INFO] [stdout] 51 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/integrations/linux/api.rs:43:30 [INFO] [stdout] | [INFO] [stdout] 43 | associated_pids: pids_by_inode [INFO] [stdout] | ______________________________^ [INFO] [stdout] 44 | | .remove(&socket_info.inode) [INFO] [stdout] 45 | | .unwrap_or_default() [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/integrations/linux/netlink_iterator.rs:73:13 [INFO] [stdout] | [INFO] [stdout] 73 | try_close(self.socket); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 73 | let _ = try_close(self.socket); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `libc::sockaddr_nl` does not permit being left uninitialized [INFO] [stdout] --> src/integrations/linux/netlink_iterator.rs:79:31 [INFO] [stdout] | [INFO] [stdout] 79 | let mut sa: sockaddr_nl = std::mem::uninitialized(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] = note: integers must be initialized [INFO] [stdout] = note: `#[warn(invalid_value)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/integrations/linux/procfs.rs:8:25 [INFO] [stdout] | [INFO] [stdout] 8 | .filter_map(|d| d.ok()?.file_name().to_str()?.parse::().ok()); [INFO] [stdout] | - ^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `netstat` (lib) due to 5 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "646018d3816aec23ce0a544e2d793aaa385a94d6d9e6ae8ed34ed781d944a91c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "646018d3816aec23ce0a544e2d793aaa385a94d6d9e6ae8ed34ed781d944a91c", kill_on_drop: false }` [INFO] [stdout] 646018d3816aec23ce0a544e2d793aaa385a94d6d9e6ae8ed34ed781d944a91c