[INFO] fetching crate netstack 0.3.0... [INFO] checking netstack-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate netstack 0.3.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate netstack 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate netstack 0.3.0 [INFO] finished tweaking crates.io crate netstack 0.3.0 [INFO] tweaked toml for crates.io crate netstack 0.3.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 37 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding bitvec v0.17.4 (latest: v1.0.1) [INFO] [stderr] Adding block-buffer v0.7.3 (latest: v0.10.4) [INFO] [stderr] Adding block-padding v0.1.5 (latest: v0.3.3) [INFO] [stderr] Adding crypto-mac v0.7.0 (latest: v0.11.1) [INFO] [stderr] Adding digest v0.8.1 (latest: v0.10.7) [INFO] [stderr] Adding generic-array v0.12.4 (latest: v1.1.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hmac v0.7.1 (latest: v0.12.1) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding opaque-debug v0.2.3 (latest: v0.3.1) [INFO] [stderr] Adding radium v0.3.0 (latest: v1.1.0) [INFO] [stderr] Adding sha2 v0.8.2 (latest: v0.10.8) [INFO] [stderr] Adding subtle v1.0.0 (latest: v2.6.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding synstructure v0.12.6 (latest: v0.13.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 75338d69c330f397bd5da1f3557dfd85403f6eb52b382ec6e6fda8de82fa6258 [INFO] running `Command { std: "docker" "start" "-a" "75338d69c330f397bd5da1f3557dfd85403f6eb52b382ec6e6fda8de82fa6258", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "75338d69c330f397bd5da1f3557dfd85403f6eb52b382ec6e6fda8de82fa6258", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "75338d69c330f397bd5da1f3557dfd85403f6eb52b382ec6e6fda8de82fa6258", kill_on_drop: false }` [INFO] [stdout] 75338d69c330f397bd5da1f3557dfd85403f6eb52b382ec6e6fda8de82fa6258 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 236f70b1f443acdb02e53ae1d93e91c348db2cefe735c962f2482d6e7e6b2834 [INFO] running `Command { std: "docker" "start" "-a" "236f70b1f443acdb02e53ae1d93e91c348db2cefe735c962f2482d6e7e6b2834", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling shlex v1.3.0 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking gimli v0.29.0 [INFO] [stderr] Compiling unicode-xid v0.2.5 [INFO] [stderr] Checking byte-tools v0.3.1 [INFO] [stderr] Compiling failure_derive v0.1.8 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Checking subtle v1.0.0 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking generic-array v0.12.4 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking fake-simd v0.1.2 [INFO] [stderr] Checking opaque-debug v0.2.3 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking block-padding v0.1.5 [INFO] [stderr] Checking radium v0.3.0 [INFO] [stderr] Compiling cc v1.1.15 [INFO] [stderr] Checking digest v0.8.1 [INFO] [stderr] Checking block-buffer v0.7.3 [INFO] [stderr] Checking crypto-mac v0.7.0 [INFO] [stderr] Checking bitvec v0.17.4 [INFO] [stderr] Checking hmac v0.7.1 [INFO] [stderr] Checking sha2 v0.8.2 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Checking addr2line v0.22.0 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Checking failure v0.1.8 [INFO] [stderr] Checking netstack v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `SerializationError` [INFO] [stdout] --> src/serialization/writer.rs:1:25 [INFO] [stdout] | [INFO] [stdout] 1 | use super::{Serializer, SerializationError}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `SerializationError` [INFO] [stdout] --> src/serialization/writer.rs:1:25 [INFO] [stdout] | [INFO] [stdout] 1 | use super::{Serializer, SerializationError}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/packets/outgoing.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | let mut header = packet.get_header_mut(); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/packets/outgoing.rs:36:13 [INFO] [stdout] | [INFO] [stdout] 36 | let mut header = packet.get_header_mut(); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/serialization/writer.rs:18:36 [INFO] [stdout] | [INFO] [stdout] 18 | fn serialize_string(&mut self, value: &str) { unimplemented!() } [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/serialization/writer.rs:19:32 [INFO] [stdout] | [INFO] [stdout] 19 | fn serialize_u8(&mut self, value: &u8) { unimplemented!() } [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/serialization/writer.rs:20:32 [INFO] [stdout] | [INFO] [stdout] 20 | fn serialize_i8(&mut self, value: &i8) { unimplemented!() } [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/serialization/writer.rs:21:33 [INFO] [stdout] | [INFO] [stdout] 21 | fn serialize_u16(&mut self, value: &u16) { unimplemented!() } [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/serialization/writer.rs:22:33 [INFO] [stdout] | [INFO] [stdout] 22 | fn serialize_i16(&mut self, value: &i16) { unimplemented!() } [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/serialization/writer.rs:23:33 [INFO] [stdout] | [INFO] [stdout] 23 | fn serialize_u32(&mut self, value: &u32) { unimplemented!() } [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/serialization/writer.rs:24:33 [INFO] [stdout] | [INFO] [stdout] 24 | fn serialize_i32(&mut self, value: &i32) { unimplemented!() } [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/serialization/writer.rs:25:33 [INFO] [stdout] | [INFO] [stdout] 25 | fn serialize_u64(&mut self, value: &u64) { unimplemented!() } [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/serialization/writer.rs:26:33 [INFO] [stdout] | [INFO] [stdout] 26 | fn serialize_i64(&mut self, value: &i64) { unimplemented!() } [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/serialization/writer.rs:27:33 [INFO] [stdout] | [INFO] [stdout] 27 | fn serialize_f32(&mut self, value: &f32) { unimplemented!() } [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/serialization/writer.rs:28:33 [INFO] [stdout] | [INFO] [stdout] 28 | fn serialize_f64(&mut self, value: &f64) { unimplemented!() } [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `read_var_int` is never used [INFO] [stdout] --> src/serialization/reader.rs:43:8 [INFO] [stdout] | [INFO] [stdout] 11 | impl<'a> Reader<'a> { [INFO] [stdout] | ------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 43 | fn read_var_int(&mut self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `buffer` and `position` are never read [INFO] [stdout] --> src/serialization/writer.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct Writer<'a> { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 4 | buffer: &'a mut [u8], [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 5 | position: usize, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `encode` is never used [INFO] [stdout] --> src/serialization/zig_zag.rs:1:8 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn encode(value: i64) -> u64 { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `decode` is never used [INFO] [stdout] --> src/serialization/zig_zag.rs:5:8 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn decode(value: u64) -> i64 { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/mod.rs:57:29 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn new(configuration: Configuration, transport: Box, monitor: Box) -> Self { [INFO] [stdout] | ----------------------------- ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | replay_buffers: ConnectionDataList::new(max_connections), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/mod.rs:58:26 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn new(configuration: Configuration, transport: Box, monitor: Box) -> Self { [INFO] [stdout] | ----------------------------- ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | ack_buffers: ConnectionDataList::new(max_connections), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/mod.rs:59:29 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn new(configuration: Configuration, transport: Box, monitor: Box) -> Self { [INFO] [stdout] | ----------------------------- ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | replay_buffers: ConnectionDataList::new(max_connections), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/mod.rs:60:26 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn new(configuration: Configuration, transport: Box, monitor: Box) -> Self { [INFO] [stdout] | ----------------------------- ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | ack_buffers: ConnectionDataList::new(max_connections), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport/udp.rs:15:12 [INFO] [stdout] | [INFO] [stdout] 12 | let socket = UdpSocket::bind(local_address)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 15 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 16 | | socket, [INFO] [stdout] 17 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 18 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `netstack` (lib) due to 6 previous errors; 18 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/packets/outgoing.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | let mut header = packet.get_header_mut(); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/packets/outgoing.rs:36:13 [INFO] [stdout] | [INFO] [stdout] 36 | let mut header = packet.get_header_mut(); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/serialization/writer.rs:18:36 [INFO] [stdout] | [INFO] [stdout] 18 | fn serialize_string(&mut self, value: &str) { unimplemented!() } [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/serialization/writer.rs:19:32 [INFO] [stdout] | [INFO] [stdout] 19 | fn serialize_u8(&mut self, value: &u8) { unimplemented!() } [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/serialization/writer.rs:20:32 [INFO] [stdout] | [INFO] [stdout] 20 | fn serialize_i8(&mut self, value: &i8) { unimplemented!() } [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/serialization/writer.rs:21:33 [INFO] [stdout] | [INFO] [stdout] 21 | fn serialize_u16(&mut self, value: &u16) { unimplemented!() } [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/serialization/writer.rs:22:33 [INFO] [stdout] | [INFO] [stdout] 22 | fn serialize_i16(&mut self, value: &i16) { unimplemented!() } [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/serialization/writer.rs:23:33 [INFO] [stdout] | [INFO] [stdout] 23 | fn serialize_u32(&mut self, value: &u32) { unimplemented!() } [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/serialization/writer.rs:24:33 [INFO] [stdout] | [INFO] [stdout] 24 | fn serialize_i32(&mut self, value: &i32) { unimplemented!() } [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/serialization/writer.rs:25:33 [INFO] [stdout] | [INFO] [stdout] 25 | fn serialize_u64(&mut self, value: &u64) { unimplemented!() } [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/serialization/writer.rs:26:33 [INFO] [stdout] | [INFO] [stdout] 26 | fn serialize_i64(&mut self, value: &i64) { unimplemented!() } [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/serialization/writer.rs:27:33 [INFO] [stdout] | [INFO] [stdout] 27 | fn serialize_f32(&mut self, value: &f32) { unimplemented!() } [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/serialization/writer.rs:28:33 [INFO] [stdout] | [INFO] [stdout] 28 | fn serialize_f64(&mut self, value: &f64) { unimplemented!() } [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `read_var_int` is never used [INFO] [stdout] --> src/serialization/reader.rs:43:8 [INFO] [stdout] | [INFO] [stdout] 11 | impl<'a> Reader<'a> { [INFO] [stdout] | ------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 43 | fn read_var_int(&mut self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `buffer` and `position` are never read [INFO] [stdout] --> src/serialization/writer.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct Writer<'a> { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 4 | buffer: &'a mut [u8], [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 5 | position: usize, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/mod.rs:57:29 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn new(configuration: Configuration, transport: Box, monitor: Box) -> Self { [INFO] [stdout] | ----------------------------- ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | replay_buffers: ConnectionDataList::new(max_connections), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/mod.rs:58:26 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn new(configuration: Configuration, transport: Box, monitor: Box) -> Self { [INFO] [stdout] | ----------------------------- ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | ack_buffers: ConnectionDataList::new(max_connections), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/mod.rs:59:29 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn new(configuration: Configuration, transport: Box, monitor: Box) -> Self { [INFO] [stdout] | ----------------------------- ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | replay_buffers: ConnectionDataList::new(max_connections), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/mod.rs:60:26 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn new(configuration: Configuration, transport: Box, monitor: Box) -> Self { [INFO] [stdout] | ----------------------------- ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | ack_buffers: ConnectionDataList::new(max_connections), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport/udp.rs:15:12 [INFO] [stdout] | [INFO] [stdout] 12 | let socket = UdpSocket::bind(local_address)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 15 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 16 | | socket, [INFO] [stdout] 17 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 16 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `netstack` (lib test) due to 6 previous errors; 16 warnings emitted [INFO] running `Command { std: "docker" "inspect" "236f70b1f443acdb02e53ae1d93e91c348db2cefe735c962f2482d6e7e6b2834", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "236f70b1f443acdb02e53ae1d93e91c348db2cefe735c962f2482d6e7e6b2834", kill_on_drop: false }` [INFO] [stdout] 236f70b1f443acdb02e53ae1d93e91c348db2cefe735c962f2482d6e7e6b2834