[INFO] fetching crate netspeed 0.1.1... [INFO] checking netspeed-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate netspeed 0.1.1 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate netspeed 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate netspeed 0.1.1 [INFO] finished tweaking crates.io crate netspeed 0.1.1 [INFO] tweaked toml for crates.io crate netspeed 0.1.1 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate netspeed 0.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 02d2e517f0c3f312f8a758b42da8a513893c00aad806ecb58894b2e073fbb0d9 [INFO] running `Command { std: "docker" "start" "-a" "02d2e517f0c3f312f8a758b42da8a513893c00aad806ecb58894b2e073fbb0d9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "02d2e517f0c3f312f8a758b42da8a513893c00aad806ecb58894b2e073fbb0d9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "02d2e517f0c3f312f8a758b42da8a513893c00aad806ecb58894b2e073fbb0d9", kill_on_drop: false }` [INFO] [stdout] 02d2e517f0c3f312f8a758b42da8a513893c00aad806ecb58894b2e073fbb0d9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 86a7b8f9bb6ba9a1acad330d3cf7ff95df827c0ee6478df822106503dcc9e766 [INFO] running `Command { std: "docker" "start" "-a" "86a7b8f9bb6ba9a1acad330d3cf7ff95df827c0ee6478df822106503dcc9e766", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling libc v0.2.66 [INFO] [stderr] Compiling memchr v2.3.0 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking unicode-width v0.1.7 [INFO] [stderr] Compiling anyhow v1.0.26 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Checking regex-syntax v0.6.14 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Compiling num-integer v0.1.42 [INFO] [stderr] Checking aho-corasick v0.7.8 [INFO] [stderr] Checking termcolor v1.1.0 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking chrono v0.4.10 [INFO] [stderr] Checking regex v1.3.4 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking netspeed v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:36:12 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn new(addr: impl ToSocketAddrs + fmt::Debug) -> Result { [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 37 | | operator: Operator::new( [INFO] [stdout] 38 | | TcpStream::connect_timeout( [INFO] [stdout] 39 | | &addr.to_socket_addrs().unwrap().next().unwrap(), [INFO] [stdout] ... | [INFO] [stdout] 44 | | spec: NetworkSpec::default(), [INFO] [stdout] 45 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn run(mut self) -> Result<()> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | / self.check_server_status() [INFO] [stdout] 58 | | .and_then(|_| self.ping_pon()) [INFO] [stdout] 59 | | .and_then(|_| self.downstream()) [INFO] [stdout] 60 | | .and_then(|_| self.upstream()) [INFO] [stdout] | |__________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:36:12 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn new(addr: impl ToSocketAddrs + fmt::Debug) -> Result { [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 37 | | operator: Operator::new( [INFO] [stdout] 38 | | TcpStream::connect_timeout( [INFO] [stdout] 39 | | &addr.to_socket_addrs().unwrap().next().unwrap(), [INFO] [stdout] ... | [INFO] [stdout] 44 | | spec: NetworkSpec::default(), [INFO] [stdout] 45 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn run(mut self) -> Result<()> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | / self.check_server_status() [INFO] [stdout] 58 | | .and_then(|_| self.ping_pon()) [INFO] [stdout] 59 | | .and_then(|_| self.downstream()) [INFO] [stdout] 60 | | .and_then(|_| self.upstream()) [INFO] [stdout] | |__________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:112:9 [INFO] [stdout] | [INFO] [stdout] 111 | fn print_result(&mut self, mut writer: W) -> Result<()> { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | / writeln!( [INFO] [stdout] 113 | | writer, [INFO] [stdout] 114 | | "Downstream: {}", [INFO] [stdout] 115 | | self.format_throughput(&self.spec.downstream) [INFO] [stdout] ... | [INFO] [stdout] 120 | | self.format_throughput(&self.spec.upstream) [INFO] [stdout] 121 | | )) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:112:9 [INFO] [stdout] | [INFO] [stdout] 111 | fn print_result(&mut self, mut writer: W) -> Result<()> { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | / writeln!( [INFO] [stdout] 113 | | writer, [INFO] [stdout] 114 | | "Downstream: {}", [INFO] [stdout] 115 | | self.format_throughput(&self.spec.downstream) [INFO] [stdout] ... | [INFO] [stdout] 120 | | self.format_throughput(&self.spec.upstream) [INFO] [stdout] 121 | | )) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn new(addr: impl ToSocketAddrs + fmt::Debug, max_threads: u32) -> Result { [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | info!("Listening on {:?} max threads: {}", addr, max_threads); [INFO] [stdout] 31 | Ok(Server { [INFO] [stdout] | ____________^ [INFO] [stdout] 32 | | listener: TcpListener::bind(addr).context("Listener binding")?, [INFO] [stdout] 33 | | dispatcher: Arc::new(Dispatcher::new(max_threads)), [INFO] [stdout] 34 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:87:37 [INFO] [stdout] | [INFO] [stdout] 85 | fn dispatch_worker(self: &Arc, stream: TcpStream) { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | let dispatcher: Arc = Arc::clone(self); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | thread::spawn(move || match stream.peer_addr() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn new(addr: impl ToSocketAddrs + fmt::Debug, max_threads: u32) -> Result { [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | info!("Listening on {:?} max threads: {}", addr, max_threads); [INFO] [stdout] 31 | Ok(Server { [INFO] [stdout] | ____________^ [INFO] [stdout] 32 | | listener: TcpListener::bind(addr).context("Listener binding")?, [INFO] [stdout] 33 | | dispatcher: Arc::new(Dispatcher::new(max_threads)), [INFO] [stdout] 34 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:87:37 [INFO] [stdout] | [INFO] [stdout] 85 | fn dispatch_worker(self: &Arc, stream: TcpStream) { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | let dispatcher: Arc = Arc::clone(self); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | thread::spawn(move || match stream.peer_addr() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:111:9 [INFO] [stdout] | [INFO] [stdout] 110 | fn dispatch(addr: SocketAddr, stream: TcpStream) -> Result<()> { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 111 | Worker::new(addr, stream).run() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:116:23 [INFO] [stdout] | [INFO] [stdout] 113 | fn new(addr: SocketAddr, stream: TcpStream) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | operator: Operator::new(stream), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:111:9 [INFO] [stdout] | [INFO] [stdout] 110 | fn dispatch(addr: SocketAddr, stream: TcpStream) -> Result<()> { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 111 | Worker::new(addr, stream).run() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:116:23 [INFO] [stdout] | [INFO] [stdout] 113 | fn new(addr: SocketAddr, stream: TcpStream) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | operator: Operator::new(stream), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `netspeed` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `netspeed` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "86a7b8f9bb6ba9a1acad330d3cf7ff95df827c0ee6478df822106503dcc9e766", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "86a7b8f9bb6ba9a1acad330d3cf7ff95df827c0ee6478df822106503dcc9e766", kill_on_drop: false }` [INFO] [stdout] 86a7b8f9bb6ba9a1acad330d3cf7ff95df827c0ee6478df822106503dcc9e766