[INFO] fetching crate netservices 0.8.1... [INFO] checking netservices-0.8.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate netservices 0.8.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate netservices 0.8.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-2-tc2/source/rust-toolchain.toml [INFO] started tweaking crates.io crate netservices 0.8.1 [INFO] finished tweaking crates.io crate netservices 0.8.1 [INFO] tweaked toml for crates.io crate netservices 0.8.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 88 packages to latest compatible versions [INFO] [stderr] Adding base32 v0.4.0 (latest: v0.5.1) [INFO] [stderr] Adding ed25519 v1.5.3 (latest: v2.2.3) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding signature v1.6.4 (latest: v2.2.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b02d28556aa63a96d88c8c5a0d09a15130f9f87849aba06c5904697982cdbba8 [INFO] running `Command { std: "docker" "start" "-a" "b02d28556aa63a96d88c8c5a0d09a15130f9f87849aba06c5904697982cdbba8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b02d28556aa63a96d88c8c5a0d09a15130f9f87849aba06c5904697982cdbba8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b02d28556aa63a96d88c8c5a0d09a15130f9f87849aba06c5904697982cdbba8", kill_on_drop: false }` [INFO] [stdout] b02d28556aa63a96d88c8c5a0d09a15130f9f87849aba06c5904697982cdbba8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3e69ab28c88ae56cc7b879fc578ada3c0e4723d867b204eccf211cf1c8252efc [INFO] running `Command { std: "docker" "start" "-a" "3e69ab28c88ae56cc7b879fc578ada3c0e4723d867b204eccf211cf1c8252efc", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling data-encoding v2.6.0 [INFO] [stderr] Checking amplify_num v0.5.3 [INFO] [stderr] Checking signature v1.6.4 [INFO] [stderr] Checking ascii v1.1.0 [INFO] [stderr] Checking base-x v0.2.11 [INFO] [stderr] Checking ct-codecs v1.1.2 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking keccak v0.1.5 [INFO] [stderr] Checking base32 v0.4.0 [INFO] [stderr] Checking popol v3.0.0 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking ed25519 v1.5.3 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking bitcoin-io v0.1.2 [INFO] [stderr] Checking ec25519 v0.1.0 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking sha3 v0.10.8 [INFO] [stderr] Checking chacha20 v0.9.1 [INFO] [stderr] Checking hex-conservative v0.2.1 [INFO] [stderr] Checking poly1305 v0.8.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking chacha20poly1305 v0.10.1 [INFO] [stderr] Checking bitcoin_hashes v0.14.0 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Compiling amplify_syn v2.0.1 [INFO] [stderr] Compiling data-encoding-macro-internal v0.1.13 [INFO] [stderr] Compiling amplify_derive v4.0.1 [INFO] [stderr] Checking data-encoding-macro v0.1.15 [INFO] [stderr] Checking multibase v0.9.1 [INFO] [stderr] Checking amplify v4.7.0 [INFO] [stderr] Checking cyphergraphy v0.3.0 [INFO] [stderr] Checking io-reactor v0.5.2 [INFO] [stderr] Checking cypheraddr v0.4.0 [INFO] [stderr] Checking noise-framework v0.4.0 [INFO] [stderr] Checking socks5-client v0.4.1 [INFO] [stderr] Checking cyphernet v0.5.2 [INFO] [stderr] Checking netservices v0.8.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tunnel.rs:43:12 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn with(session: S, addr: impl net::ToSocketAddrs) -> Result { [INFO] [stdout] | ---------- ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | let listener = match net::TcpListener::bind(addr) { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | Err(err) => return Err((session, err)), [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | Ok(listener) => listener, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | }; [INFO] [stdout] 43 | Ok(Self { listener, session }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/listener.rs:69:12 [INFO] [stdout] | [INFO] [stdout] 67 | let socket = socket2::Socket::bind_reusable(addr)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | socket.listen(BACKLOG)?; [INFO] [stdout] 69 | Ok(TcpListener::from(socket)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session.rs:300:29 [INFO] [stdout] | [INFO] [stdout] 298 | pub fn new(session: S) -> Self [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 299 | where M: Default { [INFO] [stdout] 300 | Self::with(session, M::default()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session.rs:440:15 [INFO] [stdout] | [INFO] [stdout] 437 | fn split_io(mut self) -> Result<(Self::Read, Self::Write), SplitIoError> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 440 | match self.session.split_io() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session.rs:463:22 [INFO] [stdout] | [INFO] [stdout] 456 | fn from_split_io(read: Self::Read, write: Self::Write) -> Self { [INFO] [stdout] | ---------------- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 463 | session: S::from_split_io(read.reader, write.writer), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session.rs:662:51 [INFO] [stdout] | [INFO] [stdout] 662 | .map(|hh| NoiseArtifact::with(hh, self.get_remote_static_key())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/split.rs:113:15 [INFO] [stdout] | [INFO] [stdout] 112 | fn split_io(self) -> Result<(Self::Read, Self::Write), SplitIoError> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | match self.try_clone() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/split.rs:147:15 [INFO] [stdout] | [INFO] [stdout] 146 | fn split_io(self) -> Result<(Self::Read, Self::Write), SplitIoError> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 147 | match self.try_clone() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resource.rs:118:12 [INFO] [stdout] | [INFO] [stdout] 116 | let listener = L::bind(addr)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | listener.set_nonblocking(true)?; [INFO] [stdout] 118 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 119 | | listener, [INFO] [stdout] 120 | | _phantom: default!(), [INFO] [stdout] 121 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resource.rs:131:12 [INFO] [stdout] | [INFO] [stdout] 129 | let listener = L::bind_reusable(addr)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | listener.set_nonblocking(true)?; [INFO] [stdout] 131 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 132 | | listener, [INFO] [stdout] 133 | | _phantom: default!(), [INFO] [stdout] 134 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resource.rs:248:12 [INFO] [stdout] | [INFO] [stdout] 239 | pub fn with_session(mut session: S, link_direction: Direction) -> io::Result { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 248 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 249 | | state, [INFO] [stdout] 250 | | session, [INFO] [stdout] 251 | | link_direction, [INFO] [stdout] ... | [INFO] [stdout] 254 | | write_buffer: empty!(), [INFO] [stdout] 255 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resource.rs:287:12 [INFO] [stdout] | [INFO] [stdout] 281 | mut session: S, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 287 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 288 | | state, [INFO] [stdout] 289 | | session, [INFO] [stdout] 290 | | link_direction, [INFO] [stdout] ... | [INFO] [stdout] 293 | | write_buffer: empty!(), [INFO] [stdout] 294 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resource.rs:491:9 [INFO] [stdout] | [INFO] [stdout] 490 | let res = self.flush_buffer(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 491 | self.session.flush().and(res) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `netservices` (lib test) due to 14 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tunnel.rs:43:12 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn with(session: S, addr: impl net::ToSocketAddrs) -> Result { [INFO] [stdout] | ---------- ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | let listener = match net::TcpListener::bind(addr) { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | Err(err) => return Err((session, err)), [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | Ok(listener) => listener, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | }; [INFO] [stdout] 43 | Ok(Self { listener, session }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/listener.rs:69:12 [INFO] [stdout] | [INFO] [stdout] 67 | let socket = socket2::Socket::bind_reusable(addr)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | socket.listen(BACKLOG)?; [INFO] [stdout] 69 | Ok(TcpListener::from(socket)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session.rs:300:29 [INFO] [stdout] | [INFO] [stdout] 298 | pub fn new(session: S) -> Self [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 299 | where M: Default { [INFO] [stdout] 300 | Self::with(session, M::default()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session.rs:440:15 [INFO] [stdout] | [INFO] [stdout] 437 | fn split_io(mut self) -> Result<(Self::Read, Self::Write), SplitIoError> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 440 | match self.session.split_io() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session.rs:463:22 [INFO] [stdout] | [INFO] [stdout] 456 | fn from_split_io(read: Self::Read, write: Self::Write) -> Self { [INFO] [stdout] | ---------------- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 463 | session: S::from_split_io(read.reader, write.writer), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session.rs:662:51 [INFO] [stdout] | [INFO] [stdout] 662 | .map(|hh| NoiseArtifact::with(hh, self.get_remote_static_key())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/split.rs:113:15 [INFO] [stdout] | [INFO] [stdout] 112 | fn split_io(self) -> Result<(Self::Read, Self::Write), SplitIoError> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | match self.try_clone() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/split.rs:147:15 [INFO] [stdout] | [INFO] [stdout] 146 | fn split_io(self) -> Result<(Self::Read, Self::Write), SplitIoError> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 147 | match self.try_clone() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resource.rs:118:12 [INFO] [stdout] | [INFO] [stdout] 116 | let listener = L::bind(addr)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | listener.set_nonblocking(true)?; [INFO] [stdout] 118 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 119 | | listener, [INFO] [stdout] 120 | | _phantom: default!(), [INFO] [stdout] 121 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resource.rs:131:12 [INFO] [stdout] | [INFO] [stdout] 129 | let listener = L::bind_reusable(addr)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | listener.set_nonblocking(true)?; [INFO] [stdout] 131 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 132 | | listener, [INFO] [stdout] 133 | | _phantom: default!(), [INFO] [stdout] 134 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resource.rs:248:12 [INFO] [stdout] | [INFO] [stdout] 239 | pub fn with_session(mut session: S, link_direction: Direction) -> io::Result { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 248 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 249 | | state, [INFO] [stdout] 250 | | session, [INFO] [stdout] 251 | | link_direction, [INFO] [stdout] ... | [INFO] [stdout] 254 | | write_buffer: empty!(), [INFO] [stdout] 255 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resource.rs:287:12 [INFO] [stdout] | [INFO] [stdout] 281 | mut session: S, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 287 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 288 | | state, [INFO] [stdout] 289 | | session, [INFO] [stdout] 290 | | link_direction, [INFO] [stdout] ... | [INFO] [stdout] 293 | | write_buffer: empty!(), [INFO] [stdout] 294 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resource.rs:491:9 [INFO] [stdout] | [INFO] [stdout] 490 | let res = self.flush_buffer(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 491 | self.session.flush().and(res) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `netservices` (lib) due to 14 previous errors [INFO] running `Command { std: "docker" "inspect" "3e69ab28c88ae56cc7b879fc578ada3c0e4723d867b204eccf211cf1c8252efc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3e69ab28c88ae56cc7b879fc578ada3c0e4723d867b204eccf211cf1c8252efc", kill_on_drop: false }` [INFO] [stdout] 3e69ab28c88ae56cc7b879fc578ada3c0e4723d867b204eccf211cf1c8252efc