[INFO] fetching crate netns-rs 0.1.0... [INFO] checking netns-rs-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate netns-rs 0.1.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate netns-rs 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate netns-rs 0.1.0 [INFO] finished tweaking crates.io crate netns-rs 0.1.0 [INFO] tweaked toml for crates.io crate netns-rs 0.1.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 15 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding memoffset v0.6.5 (latest: v0.9.1) [INFO] [stderr] Adding nix v0.23.2 (latest: v0.29.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c055de2b6fc96069dc8e28d8e0a8d9a9f6681cd3ef8d282a320de8668718261c [INFO] running `Command { std: "docker" "start" "-a" "c055de2b6fc96069dc8e28d8e0a8d9a9f6681cd3ef8d282a320de8668718261c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c055de2b6fc96069dc8e28d8e0a8d9a9f6681cd3ef8d282a320de8668718261c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c055de2b6fc96069dc8e28d8e0a8d9a9f6681cd3ef8d282a320de8668718261c", kill_on_drop: false }` [INFO] [stdout] c055de2b6fc96069dc8e28d8e0a8d9a9f6681cd3ef8d282a320de8668718261c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f1d0de570fa3bd80e6367d7e7086ec42c099f28818c5c8bf70ac5e64b7ec80cf [INFO] running `Command { std: "docker" "start" "-a" "f1d0de570fa3bd80e6367d7e7086ec42c099f28818c5c8bf70ac5e64b7ec80cf", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Checking nix v0.23.2 [INFO] [stderr] Checking netns-rs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/netns.rs:230:12 [INFO] [stdout] | [INFO] [stdout] 226 | pub fn get_from_env>(ns_name: S, env: E) -> Result { [INFO] [stdout] | ---------- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 227 | let ns_path = env.persist_dir().join(ns_name.as_ref()); [INFO] [stdout] 228 | let file = File::open(&ns_path).map_err(|e| Error::OpenNsError(ns_path.clone(), e))?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 229 | [INFO] [stdout] 230 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 231 | | file, [INFO] [stdout] 232 | | path: ns_path, [INFO] [stdout] 233 | | env: Some(env), [INFO] [stdout] 234 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/netns.rs:324:8 [INFO] [stdout] | [INFO] [stdout] 320 | pub fn get_from_path>(ns_path: P) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 321 | let ns_path = ns_path.as_ref().to_path_buf(); [INFO] [stdout] 322 | let file = File::open(&ns_path).map_err(|e| Error::OpenNsError(ns_path.clone(), e))?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 323 | [INFO] [stdout] 324 | Ok(NetNs { [INFO] [stdout] | ________^ [INFO] [stdout] 325 | | file, [INFO] [stdout] 326 | | path: ns_path, [INFO] [stdout] 327 | | env: None, [INFO] [stdout] 328 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/netns.rs:336:8 [INFO] [stdout] | [INFO] [stdout] 334 | let file = File::open(&ns_path).map_err(|e| Error::OpenNsError(ns_path.clone(), e))?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 335 | [INFO] [stdout] 336 | Ok(NetNs { [INFO] [stdout] | ________^ [INFO] [stdout] 337 | | file, [INFO] [stdout] 338 | | path: ns_path, [INFO] [stdout] 339 | | env: None, [INFO] [stdout] 340 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/netns.rs:416:24 [INFO] [stdout] | [INFO] [stdout] 413 | let netns = NetNs::new(name).unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 416 | netns: Some(netns), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/netns.rs:230:12 [INFO] [stdout] | [INFO] [stdout] 226 | pub fn get_from_env>(ns_name: S, env: E) -> Result { [INFO] [stdout] | ---------- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 227 | let ns_path = env.persist_dir().join(ns_name.as_ref()); [INFO] [stdout] 228 | let file = File::open(&ns_path).map_err(|e| Error::OpenNsError(ns_path.clone(), e))?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 229 | [INFO] [stdout] 230 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 231 | | file, [INFO] [stdout] 232 | | path: ns_path, [INFO] [stdout] 233 | | env: Some(env), [INFO] [stdout] 234 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/netns.rs:324:8 [INFO] [stdout] | [INFO] [stdout] 320 | pub fn get_from_path>(ns_path: P) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 321 | let ns_path = ns_path.as_ref().to_path_buf(); [INFO] [stdout] 322 | let file = File::open(&ns_path).map_err(|e| Error::OpenNsError(ns_path.clone(), e))?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 323 | [INFO] [stdout] 324 | Ok(NetNs { [INFO] [stdout] | ________^ [INFO] [stdout] 325 | | file, [INFO] [stdout] 326 | | path: ns_path, [INFO] [stdout] 327 | | env: None, [INFO] [stdout] 328 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/netns.rs:336:8 [INFO] [stdout] | [INFO] [stdout] 334 | let file = File::open(&ns_path).map_err(|e| Error::OpenNsError(ns_path.clone(), e))?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 335 | [INFO] [stdout] 336 | Ok(NetNs { [INFO] [stdout] | ________^ [INFO] [stdout] 337 | | file, [INFO] [stdout] 338 | | path: ns_path, [INFO] [stdout] 339 | | env: None, [INFO] [stdout] 340 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `netns-rs` (lib test) due to 5 previous errors [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `netns-rs` (lib) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "f1d0de570fa3bd80e6367d7e7086ec42c099f28818c5c8bf70ac5e64b7ec80cf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f1d0de570fa3bd80e6367d7e7086ec42c099f28818c5c8bf70ac5e64b7ec80cf", kill_on_drop: false }` [INFO] [stdout] f1d0de570fa3bd80e6367d7e7086ec42c099f28818c5c8bf70ac5e64b7ec80cf