[INFO] fetching crate netmod-tcp 0.4.0... [INFO] checking netmod-tcp-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate netmod-tcp 0.4.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate netmod-tcp 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate netmod-tcp 0.4.0 [INFO] finished tweaking crates.io crate netmod-tcp 0.4.0 [INFO] tweaked toml for crates.io crate netmod-tcp 0.4.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 146 packages to latest compatible versions [INFO] [stderr] Adding as-slice v0.1.5 (latest: v0.2.1) [INFO] [stderr] Adding async-channel v1.9.0 (latest: v2.3.1) [INFO] [stderr] Adding async-io v1.13.0 (latest: v2.3.4) [INFO] [stderr] Adding async-lock v2.8.0 (latest: v3.4.0) [INFO] [stderr] Adding async-process v1.8.1 (latest: v2.2.4) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding blake2 v0.8.1 (latest: v0.10.6) [INFO] [stderr] Adding crypto-mac v0.7.0 (latest: v0.11.1) [INFO] [stderr] Adding digest v0.8.1 (latest: v0.10.7) [INFO] [stderr] Adding event-listener v2.5.3 (latest: v5.3.1) [INFO] [stderr] Adding event-listener v3.1.0 (latest: v5.3.1) [INFO] [stderr] Adding fastrand v1.9.0 (latest: v2.1.1) [INFO] [stderr] Adding futures-lite v1.13.0 (latest: v2.3.0) [INFO] [stderr] Adding generic-array v0.12.4 (latest: v1.1.0) [INFO] [stderr] Adding generic-array v0.13.3 (latest: v1.1.0) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding getrandom v0.1.16 (latest: v0.2.15) [INFO] [stderr] Adding gloo-timers v0.2.6 (latest: v0.3.0) [INFO] [stderr] Adding hash32 v0.1.1 (latest: v0.3.1) [INFO] [stderr] Adding heapless v0.5.6 (latest: v0.8.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding io-lifetimes v1.0.11 (latest: v2.0.3) [INFO] [stderr] Adding linux-raw-sys v0.3.8 (latest: v0.6.5) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding opaque-debug v0.2.3 (latest: v0.3.1) [INFO] [stderr] Adding polling v2.8.0 (latest: v3.7.3) [INFO] [stderr] Adding postcard v0.4.3 (latest: v1.0.10) [INFO] [stderr] Adding postcard-cobs v0.1.5-pre (latest: v0.2.0) [INFO] [stderr] Adding rand v0.7.3 (latest: v0.8.5) [INFO] [stderr] Adding rand_chacha v0.2.2 (latest: v0.3.1) [INFO] [stderr] Adding rand_core v0.5.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_hc v0.2.0 (latest: v0.3.2) [INFO] [stderr] Adding rustix v0.37.27 (latest: v0.38.35) [INFO] [stderr] Adding socket2 v0.4.10 (latest: v0.5.7) [INFO] [stderr] Adding subtle v1.0.0 (latest: v2.6.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding wasi v0.9.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.48.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6245e975b5b811cc616f245a6ab36e9a7d08bdb4e12bcfa8b90d891544646db4 [INFO] running `Command { std: "docker" "start" "-a" "6245e975b5b811cc616f245a6ab36e9a7d08bdb4e12bcfa8b90d891544646db4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6245e975b5b811cc616f245a6ab36e9a7d08bdb4e12bcfa8b90d891544646db4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6245e975b5b811cc616f245a6ab36e9a7d08bdb4e12bcfa8b90d891544646db4", kill_on_drop: false }` [INFO] [stdout] 6245e975b5b811cc616f245a6ab36e9a7d08bdb4e12bcfa8b90d891544646db4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2e19e49bda2e8c2b3db685e0b878fddec05da6e7a9e816925ca78204d58a6a40 [INFO] running `Command { std: "docker" "start" "-a" "2e19e49bda2e8c2b3db685e0b878fddec05da6e7a9e816925ca78204d58a6a40", kill_on_drop: false }` [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Checking generic-array v0.12.4 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking getrandom v0.1.16 [INFO] [stderr] Checking generic-array v0.13.3 [INFO] [stderr] Compiling heapless v0.5.6 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking hash32 v0.1.1 [INFO] [stderr] Checking subtle v1.0.0 [INFO] [stderr] Checking futures-lite v1.13.0 [INFO] [stderr] Checking as-slice v0.1.5 [INFO] [stderr] Checking crypto-mac v0.7.0 [INFO] [stderr] Checking polling v2.8.0 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking digest v0.8.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking byte-tools v0.3.1 [INFO] [stderr] Checking opaque-debug v0.2.3 [INFO] [stderr] Checking postcard-cobs v0.1.5-pre [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking blake2 v0.8.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling async-attributes v1.1.2 [INFO] [stderr] Checking async-io v1.13.0 [INFO] [stderr] Checking kv-log-macro v1.0.7 [INFO] [stderr] Checking twox-hash v1.6.3 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking tracing-futures v0.2.5 [INFO] [stderr] Checking ratman-identity v0.6.2 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking postcard v0.4.3 [INFO] [stderr] Checking polling v3.7.3 [INFO] [stderr] Checking conjoiner-engine v1.2.3 [INFO] [stderr] Checking ratman-netmod v0.5.1 [INFO] [stderr] Checking async-io v2.3.4 [INFO] [stderr] Checking async-signal v0.2.10 [INFO] [stderr] Checking async-global-executor v2.4.1 [INFO] [stderr] Checking async-process v1.8.1 [INFO] [stderr] Checking async-std v1.12.0 [INFO] [stderr] Checking netmod-tcp v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:102:17 [INFO] [stdout] | [INFO] [stdout] 102 | let mut parts: Vec<_> = p.split(|x| x == ' ').collect(); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:102:17 [INFO] [stdout] | [INFO] [stdout] 102 | let mut parts: Vec<_> = p.split(|x| x == ' ').collect(); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/server.rs:156:17 [INFO] [stdout] | [INFO] [stdout] 156 | (state, packet) => panic!(format!("state={:?}, packet={:?}", state, packet)), [INFO] [stdout] | ^^^^^^^^^^^^^^^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/server.rs:156:17 [INFO] [stdout] | [INFO] [stdout] 150 | (_, Frame(f)) => self.handle_frame(peer.id, f).await, [INFO] [stdout] | ------------- matches some of the same values [INFO] [stdout] 151 | (state, Hello { port, _type }) => { [INFO] [stdout] | ------------------------------ matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 155 | (_, Ack) => trace!("Received ACK packet on wrong i/o stream. woops"), [INFO] [stdout] | -------- matches some of the same values [INFO] [stdout] 156 | (state, packet) => panic!(format!("state={:?}, packet={:?}", state, packet)), [INFO] [stdout] | ^^^^^^^^^^^^^^^ collectively making this unreachable [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/server.rs:156:17 [INFO] [stdout] | [INFO] [stdout] 156 | (state, packet) => panic!(format!("state={:?}, packet={:?}", state, packet)), [INFO] [stdout] | ^^^^^^^^^^^^^^^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/server.rs:156:17 [INFO] [stdout] | [INFO] [stdout] 150 | (_, Frame(f)) => self.handle_frame(peer.id, f).await, [INFO] [stdout] | ------------- matches some of the same values [INFO] [stdout] 151 | (state, Hello { port, _type }) => { [INFO] [stdout] | ------------------------------ matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 155 | (_, Ack) => trace!("Received ACK packet on wrong i/o stream. woops"), [INFO] [stdout] | -------- matches some of the same values [INFO] [stdout] 156 | (state, packet) => panic!(format!("state={:?}, packet={:?}", state, packet)), [INFO] [stdout] | ^^^^^^^^^^^^^^^ collectively making this unreachable [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proto.rs:68:34 [INFO] [stdout] | [INFO] [stdout] 68 | self.data.and_then(|vec| deserialize(&vec).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ptr.rs:63:20 [INFO] [stdout] | [INFO] [stdout] 57 | let b = unsafe { Box::from_raw(ptr) }; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | [INFO] [stdout] 59 | let arc = Arc::clone(&*b); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | inner: Box::new(arc), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ptr.rs:80:20 [INFO] [stdout] | [INFO] [stdout] 68 | pub(crate) fn swap(&self, new: T) -> Ref { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | let arc = Arc::new(new); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | let b = unsafe { Box::from_raw(ptr) }; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | let arc = Arc::clone(&*b); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | inner: Box::new(arc), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:18:14 [INFO] [stdout] | [INFO] [stdout] 17 | fn locked_stream(s: TcpStream) -> LockedStream { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | Arc::new(RwLock::new(Some(s))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:42:26 [INFO] [stdout] | [INFO] [stdout] 34 | routes: Arc, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | .map(|inner| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | Arc::new(Self { [INFO] [stdout] | __________________________^ [INFO] [stdout] 43 | | alive: Arc::new(true.into()), [INFO] [stdout] 44 | | incoming: IoPair::default(), [INFO] [stdout] 45 | | inner, [INFO] [stdout] ... | [INFO] [stdout] 48 | | mode, [INFO] [stdout] 49 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:94:85 [INFO] [stdout] | [INFO] [stdout] 87 | while let Some(Ok(stream)) = inc.next().await { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | let s = Arc::clone(&s); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | task::spawn(async move { s.accept_connection(locked_stream(stream)).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/server.rs:156:43 [INFO] [stdout] | [INFO] [stdout] 156 | (state, packet) => panic!(format!("state={:?}, packet={:?}", state, packet)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 156 - (state, packet) => panic!(format!("state={:?}, packet={:?}", state, packet)), [INFO] [stdout] 156 + (state, packet) => panic!("state={:?}, packet={:?}", state, packet), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proto.rs:68:34 [INFO] [stdout] | [INFO] [stdout] 68 | self.data.and_then(|vec| deserialize(&vec).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ptr.rs:63:20 [INFO] [stdout] | [INFO] [stdout] 57 | let b = unsafe { Box::from_raw(ptr) }; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | [INFO] [stdout] 59 | let arc = Arc::clone(&*b); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | inner: Box::new(arc), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ptr.rs:80:20 [INFO] [stdout] | [INFO] [stdout] 68 | pub(crate) fn swap(&self, new: T) -> Ref { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | let arc = Arc::new(new); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | let b = unsafe { Box::from_raw(ptr) }; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | let arc = Arc::clone(&*b); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | inner: Box::new(arc), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:18:14 [INFO] [stdout] | [INFO] [stdout] 17 | fn locked_stream(s: TcpStream) -> LockedStream { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | Arc::new(RwLock::new(Some(s))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:42:26 [INFO] [stdout] | [INFO] [stdout] 34 | routes: Arc, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | .map(|inner| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | Arc::new(Self { [INFO] [stdout] | __________________________^ [INFO] [stdout] 43 | | alive: Arc::new(true.into()), [INFO] [stdout] 44 | | incoming: IoPair::default(), [INFO] [stdout] 45 | | inner, [INFO] [stdout] ... | [INFO] [stdout] 48 | | mode, [INFO] [stdout] 49 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:94:85 [INFO] [stdout] | [INFO] [stdout] 87 | while let Some(Ok(stream)) = inc.next().await { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | let s = Arc::clone(&s); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | task::spawn(async move { s.accept_connection(locked_stream(stream)).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/server.rs:156:43 [INFO] [stdout] | [INFO] [stdout] 156 | (state, packet) => panic!(format!("state={:?}, packet={:?}", state, packet)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 156 - (state, packet) => panic!(format!("state={:?}, packet={:?}", state, packet)), [INFO] [stdout] 156 + (state, packet) => panic!("state={:?}, packet={:?}", state, packet), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `netmod-tcp` (lib test) due to 7 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 6 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `netmod-tcp` (lib) due to 7 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "2e19e49bda2e8c2b3db685e0b878fddec05da6e7a9e816925ca78204d58a6a40", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2e19e49bda2e8c2b3db685e0b878fddec05da6e7a9e816925ca78204d58a6a40", kill_on_drop: false }` [INFO] [stdout] 2e19e49bda2e8c2b3db685e0b878fddec05da6e7a9e816925ca78204d58a6a40