[INFO] fetching crate net_promoter_score 0.2.1... [INFO] checking net_promoter_score-0.2.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate net_promoter_score 0.2.1 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate net_promoter_score 0.2.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate net_promoter_score 0.2.1 [INFO] finished tweaking crates.io crate net_promoter_score 0.2.1 [INFO] tweaked toml for crates.io crate net_promoter_score 0.2.1 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 2 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c0d07ab0c3774300a4dc67c7f46c3c3af8a01d9ba0df880be3712c265d738b07 [INFO] running `Command { std: "docker" "start" "-a" "c0d07ab0c3774300a4dc67c7f46c3c3af8a01d9ba0df880be3712c265d738b07", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c0d07ab0c3774300a4dc67c7f46c3c3af8a01d9ba0df880be3712c265d738b07", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c0d07ab0c3774300a4dc67c7f46c3c3af8a01d9ba0df880be3712c265d738b07", kill_on_drop: false }` [INFO] [stdout] c0d07ab0c3774300a4dc67c7f46c3c3af8a01d9ba0df880be3712c265d738b07 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2b4c793c04a7cad947798acaa12bf777f2247f58e0ad6ce5b3f7e361bac10ece [INFO] running `Command { std: "docker" "start" "-a" "2b4c793c04a7cad947798acaa12bf777f2247f58e0ad6ce5b3f7e361bac10ece", kill_on_drop: false }` [INFO] [stderr] Checking net_promoter_score v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:325:31 [INFO] [stdout] | [INFO] [stdout] 325 | .map(|_| (respondent_id_fn(), score)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:698:12 [INFO] [stdout] | [INFO] [stdout] 696 | pub fn new(respondent_id: T, rating: NpsRating) -> Result { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 697 | let nps_rating = Rating::try_from(rating)?; [INFO] [stdout] 698 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 699 | | respondent_id, [INFO] [stdout] 700 | | score: nps_rating, [INFO] [stdout] 701 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `net_promoter_score` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:325:31 [INFO] [stdout] | [INFO] [stdout] 325 | .map(|_| (respondent_id_fn(), score)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:698:12 [INFO] [stdout] | [INFO] [stdout] 696 | pub fn new(respondent_id: T, rating: NpsRating) -> Result { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 697 | let nps_rating = Rating::try_from(rating)?; [INFO] [stdout] 698 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 699 | | respondent_id, [INFO] [stdout] 700 | | score: nps_rating, [INFO] [stdout] 701 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `net_promoter_score` (lib test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "2b4c793c04a7cad947798acaa12bf777f2247f58e0ad6ce5b3f7e361bac10ece", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2b4c793c04a7cad947798acaa12bf777f2247f58e0ad6ce5b3f7e361bac10ece", kill_on_drop: false }` [INFO] [stdout] 2b4c793c04a7cad947798acaa12bf777f2247f58e0ad6ce5b3f7e361bac10ece