[INFO] fetching crate net-stream 0.1.1... [INFO] checking net-stream-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate net-stream 0.1.1 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate net-stream 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-5-tc2/source/rust-toolchain.toml [INFO] started tweaking crates.io crate net-stream 0.1.1 [INFO] finished tweaking crates.io crate net-stream 0.1.1 [INFO] tweaked toml for crates.io crate net-stream 0.1.1 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate net-stream 0.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0ab9c514c3b20982301236cafc70a3b5e50ad77e14ded1e811caf7470c6df71b [INFO] running `Command { std: "docker" "start" "-a" "0ab9c514c3b20982301236cafc70a3b5e50ad77e14ded1e811caf7470c6df71b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0ab9c514c3b20982301236cafc70a3b5e50ad77e14ded1e811caf7470c6df71b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0ab9c514c3b20982301236cafc70a3b5e50ad77e14ded1e811caf7470c6df71b", kill_on_drop: false }` [INFO] [stdout] 0ab9c514c3b20982301236cafc70a3b5e50ad77e14ded1e811caf7470c6df71b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1172f1537c1cc65379d0a13b9fcbcc3322e1f4c086974b49cc21fa97a43355f5 [INFO] running `Command { std: "docker" "start" "-a" "1172f1537c1cc65379d0a13b9fcbcc3322e1f4c086974b49cc21fa97a43355f5", kill_on_drop: false }` [INFO] [stderr] Compiling unicode-ident v1.0.11 [INFO] [stderr] Compiling futures-core v0.3.28 [INFO] [stderr] Checking pin-project-lite v0.2.10 [INFO] [stderr] Compiling rustix v0.38.4 [INFO] [stderr] Compiling futures-task v0.3.28 [INFO] [stderr] Compiling futures-channel v0.3.28 [INFO] [stderr] Checking futures-sink v0.3.28 [INFO] [stderr] Compiling serde v1.0.178 [INFO] [stderr] Compiling futures-util v0.3.28 [INFO] [stderr] Compiling slab v0.4.8 [INFO] [stderr] Compiling tokio v1.29.1 [INFO] [stderr] Compiling serde_derive v1.0.178 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Checking futures-io v0.3.28 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking aho-corasick v1.0.2 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Compiling proc-macro2 v1.0.66 [INFO] [stderr] Checking anstyle-parse v0.2.1 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Compiling thiserror v1.0.44 [INFO] [stderr] Checking regex-syntax v0.7.4 [INFO] [stderr] Checking tracing v0.1.37 [INFO] [stderr] Checking log v0.4.19 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Compiling anyhow v1.0.72 [INFO] [stderr] Checking termcolor v1.2.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking assert_let_bind v0.1.1 [INFO] [stderr] Compiling quote v1.0.32 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Compiling syn v2.0.27 [INFO] [stderr] Checking anstream v0.3.2 [INFO] [stderr] Checking regex-automata v0.3.4 [INFO] [stderr] Checking clap_builder v4.3.19 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking uuid v1.4.1 [INFO] [stderr] Compiling derive_more v0.99.17 [INFO] [stderr] Checking regex v1.9.1 [INFO] [stderr] Checking env_logger v0.10.0 [INFO] [stderr] Compiling futures-macro v0.3.28 [INFO] [stderr] Compiling tokio-macros v2.1.0 [INFO] [stderr] Compiling thiserror-impl v1.0.44 [INFO] [stderr] Compiling typed-builder-macro v0.15.1 [INFO] [stderr] Compiling clap_derive v4.3.12 [INFO] [stderr] Compiling smart-default v0.7.1 [INFO] [stderr] Checking typed-builder v0.15.1 [INFO] [stderr] Checking clap v4.3.19 [INFO] [stderr] Checking futures-executor v0.3.28 [INFO] [stderr] Checking futures v0.3.28 [INFO] [stderr] Checking tokio-stream v0.1.14 [INFO] [stderr] Checking tokio-util v0.7.8 [INFO] [stderr] Checking net-stream v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/actor.rs:68:76 [INFO] [stdout] | [INFO] [stdout] 68 | let udp_tx = udp_tx.with(move |x| futures::future::ok::<_, udp::Error>((x, server_addr))); [INFO] [stdout] | - ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/actor_handle.rs:36:27 [INFO] [stdout] | [INFO] [stdout] 34 | pub(crate) fn new(join_handle: JoinHandle<()>, sender: mpsc::Sender>) -> ActorHandle { [INFO] [stdout] | --------------------------- -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | Self { [INFO] [stdout] 36 | _join_handle: Arc::new(join_handle), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/actor_handle.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 42 | pub fn send_message_tcp(&mut self, msg: M::TcpToServer) -> Result<(), Error> { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | self.sender.try_send(Message::ToServerTcp { msg }).map_err(|err| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/actor_handle.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn send_message_udp(&mut self, msg: M::UdpToServer) -> Result<(), Error> { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | self.sender.try_send(Message::ToServerUdp { msg }).map_err(|err| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/actor.rs:400:11 [INFO] [stdout] | [INFO] [stdout] 342 | fn handle_new_tcp_connection(state: &mut State, tcp_stream: TcpStream) { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 356 | let (stream, sink) = crate::networking::tcp::new(tcp_stream); [INFO] [stdout] | ------ ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 357 | [INFO] [stdout] 358 | let (tcp_reader_tx, tcp_reader_rx) = [INFO] [stdout] | ------------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 359 | futures::channel::mpsc::channel::<(read_actor::ReadActorEvent, tcp::Error>>, PeerUid)>(64); [INFO] [stdout] 360 | let reader_tx = tcp_reader_tx.with(move |x| futures::future::ok::<_, futures::channel::mpsc::SendError>((x, peer_uid))); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 361 | let tcp_read_actor_handle = crate::actors::read_actor::spawn_actor(stream, reader_tx); [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 362 | let tcp_write_actor_handle = crate::actors::write_actor::spawn_actor(sink); [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 363 | [INFO] [stdout] 364 | let tcp_reader_rx = tcp_reader_rx.map(|x| Incoming::TcpReader(x)).chain( [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 370 | let tcp_writer_rx = tcp_write_actor_handle [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 379 | let mut peer = Peer { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 400 | match state.event_sender.unbounded_send(Event::NewPeer(NewPeer { peer_uid })) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/actor.rs:360:109 [INFO] [stdout] | [INFO] [stdout] 360 | let reader_tx = tcp_reader_tx.with(move |x| futures::future::ok::<_, futures::channel::mpsc::SendError>((x, peer_uid))); [INFO] [stdout] | - ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/actor_handle.rs:23:27 [INFO] [stdout] | [INFO] [stdout] 21 | pub(crate) fn new(join_handle: JoinHandle<()>, sender: mpsc::UnboundedSender>) -> ActorHandle { [INFO] [stdout] | --------------------------- ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | Self { [INFO] [stdout] 23 | _join_handle: Arc::new(join_handle), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/actor_handle.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn message_peer_tcp(&self, peer_uid: PeerUid, msg: M::TcpFromServer) { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | log::debug!("Message {peer_uid:?} TCP"); [INFO] [stdout] 31 | / self.sender [INFO] [stdout] 32 | | .unbounded_send(Message::ToPeerTcp { peer_uid, msg }) [INFO] [stdout] | |_________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/actor_handle.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn message_peer_udp(&self, peer_uid: PeerUid, msg: M::UdpFromServer) { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | log::debug!("Message {peer_uid:?} UDP"); [INFO] [stdout] 39 | / self.sender [INFO] [stdout] 40 | | .unbounded_send(Message::ToPeerUdp { peer_uid, msg }) [INFO] [stdout] | |_________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/actor_handle.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn announce_tcp(&self, msg: M::TcpFromServer) { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | log::debug!("Announce TCP"); [INFO] [stdout] 47 | / self.sender [INFO] [stdout] 48 | | .unbounded_send(Message::AnnounceTcp { msg }) [INFO] [stdout] | |_________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/actor_handle.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 53 | pub fn announce_udp(&self, msg: M::UdpFromServer) { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | log::debug!("Announce UDP"); [INFO] [stdout] 55 | / self.sender [INFO] [stdout] 56 | | .unbounded_send(Message::AnnounceUdp { msg }) [INFO] [stdout] | |_________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/actors/write_actor.rs:73:33 [INFO] [stdout] | [INFO] [stdout] 72 | pub fn send(&mut self, item: T) -> Result<(), WriteActorError> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | self.send_actor_message(ActorMessage::Send(item)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/actors/write_actor.rs:78:33 [INFO] [stdout] | [INFO] [stdout] 77 | pub fn feed(&mut self, item: T) -> Result<(), WriteActorError> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | self.send_actor_message(ActorMessage::Feed(item)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/actors/write_actor.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 105 | fn send_actor_message(&mut self, msg: ActorMessage) -> Result<(), WriteActorError> { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | self.actor_msg_tx.try_send(msg).map_err(|err| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/networking/udp.rs:58:61 [INFO] [stdout] | [INFO] [stdout] 58 | let serialized = bincode::serialize(&item).map(|v| (Bytes::from(v), socket_addr)).map_err(Error::from); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream_ext.rs:7:41 [INFO] [stdout] | [INFO] [stdout] 3 | fn chain_once(self, item: T) -> futures::stream::Chain>> [INFO] [stdout] | ---- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 7 | futures::StreamExt::chain(self, futures::stream::once(std::future::ready(item))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 16 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `net-stream` (lib) due to 17 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/actor.rs:68:76 [INFO] [stdout] | [INFO] [stdout] 68 | let udp_tx = udp_tx.with(move |x| futures::future::ok::<_, udp::Error>((x, server_addr))); [INFO] [stdout] | - ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/actor_handle.rs:36:27 [INFO] [stdout] | [INFO] [stdout] 34 | pub(crate) fn new(join_handle: JoinHandle<()>, sender: mpsc::Sender>) -> ActorHandle { [INFO] [stdout] | --------------------------- -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | Self { [INFO] [stdout] 36 | _join_handle: Arc::new(join_handle), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/actor_handle.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 42 | pub fn send_message_tcp(&mut self, msg: M::TcpToServer) -> Result<(), Error> { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | self.sender.try_send(Message::ToServerTcp { msg }).map_err(|err| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/actor_handle.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn send_message_udp(&mut self, msg: M::UdpToServer) -> Result<(), Error> { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | self.sender.try_send(Message::ToServerUdp { msg }).map_err(|err| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/actor.rs:400:11 [INFO] [stdout] | [INFO] [stdout] 342 | fn handle_new_tcp_connection(state: &mut State, tcp_stream: TcpStream) { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 356 | let (stream, sink) = crate::networking::tcp::new(tcp_stream); [INFO] [stdout] | ------ ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 357 | [INFO] [stdout] 358 | let (tcp_reader_tx, tcp_reader_rx) = [INFO] [stdout] | ------------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 359 | futures::channel::mpsc::channel::<(read_actor::ReadActorEvent, tcp::Error>>, PeerUid)>(64); [INFO] [stdout] 360 | let reader_tx = tcp_reader_tx.with(move |x| futures::future::ok::<_, futures::channel::mpsc::SendError>((x, peer_uid))); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 361 | let tcp_read_actor_handle = crate::actors::read_actor::spawn_actor(stream, reader_tx); [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 362 | let tcp_write_actor_handle = crate::actors::write_actor::spawn_actor(sink); [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 363 | [INFO] [stdout] 364 | let tcp_reader_rx = tcp_reader_rx.map(|x| Incoming::TcpReader(x)).chain( [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 370 | let tcp_writer_rx = tcp_write_actor_handle [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 379 | let mut peer = Peer { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 400 | match state.event_sender.unbounded_send(Event::NewPeer(NewPeer { peer_uid })) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/actor.rs:360:109 [INFO] [stdout] | [INFO] [stdout] 360 | let reader_tx = tcp_reader_tx.with(move |x| futures::future::ok::<_, futures::channel::mpsc::SendError>((x, peer_uid))); [INFO] [stdout] | - ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/actor_handle.rs:23:27 [INFO] [stdout] | [INFO] [stdout] 21 | pub(crate) fn new(join_handle: JoinHandle<()>, sender: mpsc::UnboundedSender>) -> ActorHandle { [INFO] [stdout] | --------------------------- ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | Self { [INFO] [stdout] 23 | _join_handle: Arc::new(join_handle), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/actor_handle.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn message_peer_tcp(&self, peer_uid: PeerUid, msg: M::TcpFromServer) { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | log::debug!("Message {peer_uid:?} TCP"); [INFO] [stdout] 31 | / self.sender [INFO] [stdout] 32 | | .unbounded_send(Message::ToPeerTcp { peer_uid, msg }) [INFO] [stdout] | |_________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/actor_handle.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn message_peer_udp(&self, peer_uid: PeerUid, msg: M::UdpFromServer) { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | log::debug!("Message {peer_uid:?} UDP"); [INFO] [stdout] 39 | / self.sender [INFO] [stdout] 40 | | .unbounded_send(Message::ToPeerUdp { peer_uid, msg }) [INFO] [stdout] | |_________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/actor_handle.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn announce_tcp(&self, msg: M::TcpFromServer) { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | log::debug!("Announce TCP"); [INFO] [stdout] 47 | / self.sender [INFO] [stdout] 48 | | .unbounded_send(Message::AnnounceTcp { msg }) [INFO] [stdout] | |_________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/actor_handle.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 53 | pub fn announce_udp(&self, msg: M::UdpFromServer) { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | log::debug!("Announce UDP"); [INFO] [stdout] 55 | / self.sender [INFO] [stdout] 56 | | .unbounded_send(Message::AnnounceUdp { msg }) [INFO] [stdout] | |_________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/actors/write_actor.rs:73:33 [INFO] [stdout] | [INFO] [stdout] 72 | pub fn send(&mut self, item: T) -> Result<(), WriteActorError> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | self.send_actor_message(ActorMessage::Send(item)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/actors/write_actor.rs:78:33 [INFO] [stdout] | [INFO] [stdout] 77 | pub fn feed(&mut self, item: T) -> Result<(), WriteActorError> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | self.send_actor_message(ActorMessage::Feed(item)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/actors/write_actor.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 105 | fn send_actor_message(&mut self, msg: ActorMessage) -> Result<(), WriteActorError> { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | self.actor_msg_tx.try_send(msg).map_err(|err| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/networking/udp.rs:58:61 [INFO] [stdout] | [INFO] [stdout] 58 | let serialized = bincode::serialize(&item).map(|v| (Bytes::from(v), socket_addr)).map_err(Error::from); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream_ext.rs:7:41 [INFO] [stdout] | [INFO] [stdout] 3 | fn chain_once(self, item: T) -> futures::stream::Chain>> [INFO] [stdout] | ---- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 7 | futures::StreamExt::chain(self, futures::stream::once(std::future::ready(item))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 16 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `net-stream` (lib test) due to 17 previous errors [INFO] running `Command { std: "docker" "inspect" "1172f1537c1cc65379d0a13b9fcbcc3322e1f4c086974b49cc21fa97a43355f5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1172f1537c1cc65379d0a13b9fcbcc3322e1f4c086974b49cc21fa97a43355f5", kill_on_drop: false }` [INFO] [stdout] 1172f1537c1cc65379d0a13b9fcbcc3322e1f4c086974b49cc21fa97a43355f5