[INFO] fetching crate neovim-ctrl 0.2.0... [INFO] checking neovim-ctrl-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate neovim-ctrl 0.2.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate neovim-ctrl 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate neovim-ctrl 0.2.0 [INFO] finished tweaking crates.io crate neovim-ctrl 0.2.0 [INFO] tweaked toml for crates.io crate neovim-ctrl 0.2.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate neovim-ctrl 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f63c9b4999cf45f6092aefa1f791d21cb96706547b0df210f1debe9b10025ae9 [INFO] running `Command { std: "docker" "start" "-a" "f63c9b4999cf45f6092aefa1f791d21cb96706547b0df210f1debe9b10025ae9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f63c9b4999cf45f6092aefa1f791d21cb96706547b0df210f1debe9b10025ae9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f63c9b4999cf45f6092aefa1f791d21cb96706547b0df210f1debe9b10025ae9", kill_on_drop: false }` [INFO] [stdout] f63c9b4999cf45f6092aefa1f791d21cb96706547b0df210f1debe9b10025ae9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e3ac29c28253a6b58e73f8f839db6dd627f543d56f1ec7152ab3c181f13acb76 [INFO] running `Command { std: "docker" "start" "-a" "e3ac29c28253a6b58e73f8f839db6dd627f543d56f1ec7152ab3c181f13acb76", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Compiling serde v1.0.195 [INFO] [stderr] Compiling paste v1.0.14 [INFO] [stderr] Compiling libc v0.2.152 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking unix_socket v0.5.0 [INFO] [stderr] Checking rmp v0.8.12 [INFO] [stderr] Checking serde_bytes v0.11.14 [INFO] [stderr] Checking rmpv v0.4.7 [INFO] [stderr] Checking neovim-lib v0.6.1 [INFO] [stderr] Checking neovim-ctrl v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: lint `illegal_floating_point_literal_pattern` has been removed: no longer a warning, float patterns behave the same as `==` [INFO] [stdout] --> src/main.rs:11:3 [INFO] [stdout] | [INFO] [stdout] 11 | illegal_floating_point_literal_pattern, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unknown lint: `where_clauses_object_safety` [INFO] [stdout] --> src/main.rs:43:3 [INFO] [stdout] | [INFO] [stdout] 43 | where_clauses_object_safety, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unknown_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `illegal_floating_point_literal_pattern` has been removed: no longer a warning, float patterns behave the same as `==` [INFO] [stdout] --> src/main.rs:11:3 [INFO] [stdout] | [INFO] [stdout] 11 | illegal_floating_point_literal_pattern, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unknown lint: `where_clauses_object_safety` [INFO] [stdout] --> src/main.rs:43:3 [INFO] [stdout] | [INFO] [stdout] 43 | where_clauses_object_safety, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unknown_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:200:23 [INFO] [stdout] | [INFO] [stdout] 200 | self.map_err(|e| (ctx().into(), e)) [INFO] [stdout] | - ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:286:58 [INFO] [stdout] | [INFO] [stdout] 280 | Ok(entry) => { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 286 | check_pid(&entry.file_name()).map(|pid| Ok((pid, entry))) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:200:23 [INFO] [stdout] | [INFO] [stdout] 200 | self.map_err(|e| (ctx().into(), e)) [INFO] [stdout] | - ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:286:58 [INFO] [stdout] | [INFO] [stdout] 280 | Ok(entry) => { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 286 | check_pid(&entry.file_name()).map(|pid| Ok((pid, entry))) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:433:3 [INFO] [stdout] | [INFO] [stdout] 429 | fn map_socket_inodes(entry: DirEntry) -> Result>> { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 433 | / read_dir(&path) [INFO] [stdout] 434 | | .ctx(|| format!("failed to read directory {}", path.display())) [INFO] [stdout] | |___________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:473:7 [INFO] [stdout] | [INFO] [stdout] 472 | .filter_map_flat(|file| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 473 | / BufReader::new(file) [INFO] [stdout] 474 | | .lines() [INFO] [stdout] 475 | | .skip(1) [INFO] [stdout] 476 | | .filter_map(|line| line.filter_map_flat(|x| map_inode_to_socket(&x, inode))) [INFO] [stdout] 477 | | .map(|x| x.ctx(|| format!("error while reading lines from {}", PROC_UNIX))) [INFO] [stdout] | |___________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:670:36 [INFO] [stdout] | [INFO] [stdout] 670 | .map(|x| x.map_flat(|(x0, x1)| map_socket_inodes(x1).map(|x| (x0, x)))) [INFO] [stdout] | -------- ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:671:36 [INFO] [stdout] | [INFO] [stdout] 671 | .map(|x| x.map(|(x0, x1)| (x0, x1.filter_map(|x| x.filter_map_flat(map_unix_socket))))) [INFO] [stdout] | -------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:433:3 [INFO] [stdout] | [INFO] [stdout] 429 | fn map_socket_inodes(entry: DirEntry) -> Result>> { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 433 | / read_dir(&path) [INFO] [stdout] 434 | | .ctx(|| format!("failed to read directory {}", path.display())) [INFO] [stdout] | |___________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:473:7 [INFO] [stdout] | [INFO] [stdout] 472 | .filter_map_flat(|file| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 473 | / BufReader::new(file) [INFO] [stdout] 474 | | .lines() [INFO] [stdout] 475 | | .skip(1) [INFO] [stdout] 476 | | .filter_map(|line| line.filter_map_flat(|x| map_inode_to_socket(&x, inode))) [INFO] [stdout] 477 | | .map(|x| x.ctx(|| format!("error while reading lines from {}", PROC_UNIX))) [INFO] [stdout] | |___________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:670:36 [INFO] [stdout] | [INFO] [stdout] 670 | .map(|x| x.map_flat(|(x0, x1)| map_socket_inodes(x1).map(|x| (x0, x)))) [INFO] [stdout] | -------- ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:671:36 [INFO] [stdout] | [INFO] [stdout] 671 | .map(|x| x.map(|(x0, x1)| (x0, x1.filter_map(|x| x.filter_map_flat(map_unix_socket))))) [INFO] [stdout] | -------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:579:23 [INFO] [stdout] | [INFO] [stdout] 578 | fn from(e: (Str, IoError)) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 579 | Self(Some(e.0), e.1.into()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:579:23 [INFO] [stdout] | [INFO] [stdout] 578 | fn from(e: (Str, IoError)) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 579 | Self(Some(e.0), e.1.into()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `neovim-ctrl` (bin "nvim-ctrl" test) due to 8 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `neovim-ctrl` (bin "nvim-ctrl") due to 8 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "e3ac29c28253a6b58e73f8f839db6dd627f543d56f1ec7152ab3c181f13acb76", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e3ac29c28253a6b58e73f8f839db6dd627f543d56f1ec7152ab3c181f13acb76", kill_on_drop: false }` [INFO] [stdout] e3ac29c28253a6b58e73f8f839db6dd627f543d56f1ec7152ab3c181f13acb76