[INFO] fetching crate neighborgrid 0.1.0... [INFO] checking neighborgrid-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate neighborgrid 0.1.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate neighborgrid 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate neighborgrid 0.1.0 [INFO] finished tweaking crates.io crate neighborgrid 0.1.0 [INFO] tweaked toml for crates.io crate neighborgrid 0.1.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate neighborgrid 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c2613f57f6c5947632a2fd70d5615d325576980abbbc24fd1e3c6fbea05ccb45 [INFO] running `Command { std: "docker" "start" "-a" "c2613f57f6c5947632a2fd70d5615d325576980abbbc24fd1e3c6fbea05ccb45", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c2613f57f6c5947632a2fd70d5615d325576980abbbc24fd1e3c6fbea05ccb45", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c2613f57f6c5947632a2fd70d5615d325576980abbbc24fd1e3c6fbea05ccb45", kill_on_drop: false }` [INFO] [stdout] c2613f57f6c5947632a2fd70d5615d325576980abbbc24fd1e3c6fbea05ccb45 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fe8a292bfe6aa0d3af3edfc389a8270bbea61ea3112e97802b3014c3e2f61d4b [INFO] running `Command { std: "docker" "start" "-a" "fe8a292bfe6aa0d3af3edfc389a8270bbea61ea3112e97802b3014c3e2f61d4b", kill_on_drop: false }` [INFO] [stderr] Checking neighborgrid v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/grid.rs:71:12 [INFO] [stdout] | [INFO] [stdout] 63 | vec: Vec, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | Ok(Grid { [INFO] [stdout] | ____________^ [INFO] [stdout] 72 | | items: vec, [INFO] [stdout] 73 | | rows, [INFO] [stdout] 74 | | cols: columns, [INFO] [stdout] 75 | | options: options.unwrap_or_default(), [INFO] [stdout] 76 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/intogrid.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 10 | fn into_grid(self) -> Result, GridError> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | let mut grid = Vec::with_capacity(total); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | Ok(Grid::create(grid, rows, cols, None)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/intogrid.rs:66:12 [INFO] [stdout] | [INFO] [stdout] 63 | fn into_grid(self) -> Result, GridError> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | let total = row_col_length_check(self.0, self.1)?; [INFO] [stdout] 65 | let items = vec![self.2; total]; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | Ok(Grid { [INFO] [stdout] | ____________^ [INFO] [stdout] 67 | | items, [INFO] [stdout] 68 | | rows: self.1, [INFO] [stdout] 69 | | cols: self.0, [INFO] [stdout] 70 | | options: GridOptions::default(), [INFO] [stdout] 71 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/intogrid.rs:98:8 [INFO] [stdout] | [INFO] [stdout] 94 | let mut vec = Vec::with_capacity(total); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | Ok(Grid::create(vec, cols, items.1, None)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `neighborgrid` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/grid.rs:71:12 [INFO] [stdout] | [INFO] [stdout] 63 | vec: Vec, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | Ok(Grid { [INFO] [stdout] | ____________^ [INFO] [stdout] 72 | | items: vec, [INFO] [stdout] 73 | | rows, [INFO] [stdout] 74 | | cols: columns, [INFO] [stdout] 75 | | options: options.unwrap_or_default(), [INFO] [stdout] 76 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/intogrid.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 10 | fn into_grid(self) -> Result, GridError> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | let mut grid = Vec::with_capacity(total); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | Ok(Grid::create(grid, rows, cols, None)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/intogrid.rs:66:12 [INFO] [stdout] | [INFO] [stdout] 63 | fn into_grid(self) -> Result, GridError> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | let total = row_col_length_check(self.0, self.1)?; [INFO] [stdout] 65 | let items = vec![self.2; total]; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | Ok(Grid { [INFO] [stdout] | ____________^ [INFO] [stdout] 67 | | items, [INFO] [stdout] 68 | | rows: self.1, [INFO] [stdout] 69 | | cols: self.0, [INFO] [stdout] 70 | | options: GridOptions::default(), [INFO] [stdout] 71 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/intogrid.rs:98:8 [INFO] [stdout] | [INFO] [stdout] 94 | let mut vec = Vec::with_capacity(total); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | Ok(Grid::create(vec, cols, items.1, None)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `neighborgrid` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "fe8a292bfe6aa0d3af3edfc389a8270bbea61ea3112e97802b3014c3e2f61d4b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fe8a292bfe6aa0d3af3edfc389a8270bbea61ea3112e97802b3014c3e2f61d4b", kill_on_drop: false }` [INFO] [stdout] fe8a292bfe6aa0d3af3edfc389a8270bbea61ea3112e97802b3014c3e2f61d4b