[INFO] fetching crate needroleshere 0.4.0... [INFO] checking needroleshere-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate needroleshere 0.4.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate needroleshere 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate needroleshere 0.4.0 [INFO] finished tweaking crates.io crate needroleshere 0.4.0 [INFO] tweaked toml for crates.io crate needroleshere 0.4.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate needroleshere 0.4.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2c77b41f9c67686288ea554bfc02c94c6113db21b1ea52eb2173d83afbc021db [INFO] running `Command { std: "docker" "start" "-a" "2c77b41f9c67686288ea554bfc02c94c6113db21b1ea52eb2173d83afbc021db", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2c77b41f9c67686288ea554bfc02c94c6113db21b1ea52eb2173d83afbc021db", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2c77b41f9c67686288ea554bfc02c94c6113db21b1ea52eb2173d83afbc021db", kill_on_drop: false }` [INFO] [stdout] 2c77b41f9c67686288ea554bfc02c94c6113db21b1ea52eb2173d83afbc021db [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0dcfb525ea3fba4de0b1a09f0405289099288109934752be43d8ccf2af2b10ad [INFO] running `Command { std: "docker" "start" "-a" "0dcfb525ea3fba4de0b1a09f0405289099288109934752be43d8ccf2af2b10ad", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.69 [INFO] [stderr] Compiling libc v0.2.149 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Checking const-oid v0.9.5 [INFO] [stderr] Checking subtle v2.5.0 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Checking base64ct v1.6.0 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking flagset v0.4.4 [INFO] [stderr] Compiling futures-core v0.3.29 [INFO] [stderr] Compiling pkg-config v0.3.27 [INFO] [stderr] Compiling futures-task v0.3.29 [INFO] [stderr] Compiling futures-util v0.3.29 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling serde v1.0.190 [INFO] [stderr] Compiling rustversion v1.0.14 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking pem-rfc7468 v0.7.0 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Checking futures-sink v0.3.29 [INFO] [stderr] Checking http v0.2.9 [INFO] [stderr] Compiling futures-channel v0.3.29 [INFO] [stderr] Compiling openssl v0.10.59 [INFO] [stderr] Checking base16ct v0.2.0 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Checking cpufeatures v0.2.11 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking try-lock v0.2.4 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Checking percent-encoding v2.3.0 [INFO] [stderr] Compiling native-tls v0.2.11 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Compiling num-iter v0.1.43 [INFO] [stderr] Checking form_urlencoded v1.2.0 [INFO] [stderr] Compiling syn v2.0.38 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking http-body v0.4.5 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling async-trait v0.1.74 [INFO] [stderr] Compiling serde_json v1.0.108 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Compiling axum-core v0.3.4 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking unicode-bidi v0.3.13 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Checking mio v0.8.9 [INFO] [stderr] Checking socket2 v0.5.5 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking socket2 v0.4.10 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling num-bigint-dig v0.8.4 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Checking smallvec v1.11.1 [INFO] [stderr] Checking tower-layer v0.3.2 [INFO] [stderr] Compiling axum v0.6.20 [INFO] [stderr] Checking ff v0.13.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking idna v0.4.0 [INFO] [stderr] Checking group v0.13.0 [INFO] [stderr] Compiling num-bigint v0.4.4 [INFO] [stderr] Compiling thiserror v1.0.50 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking base64 v0.21.5 [INFO] [stderr] Checking os_str_bytes v6.6.1 [INFO] [stderr] Compiling anyhow v1.0.75 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking url v2.4.1 [INFO] [stderr] Checking headers-core v0.2.0 [INFO] [stderr] Checking tracing-log v0.1.4 [INFO] [stderr] Checking thread_local v1.1.7 [INFO] [stderr] Checking encoding_rs v0.8.33 [INFO] [stderr] Checking sync_wrapper v0.1.2 [INFO] [stderr] Checking ipnet v2.9.0 [INFO] [stderr] Checking matchit v0.7.3 [INFO] [stderr] Checking textwrap v0.16.0 [INFO] [stderr] Checking termcolor v1.3.0 [INFO] [stderr] Checking iana-time-zone v0.1.58 [INFO] [stderr] Compiling openssl-sys v0.9.95 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking generic-array v1.0.0 [INFO] [stderr] Checking listenfd v1.0.1 [INFO] [stderr] Checking temp-dir v0.1.11 [INFO] [stderr] Compiling indoc v2.0.4 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Compiling clap_derive v3.2.25 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling der_derive v0.7.2 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling tokio-macros v2.1.0 [INFO] [stderr] Compiling serde_derive v1.0.190 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling pin-project-internal v1.1.3 [INFO] [stderr] Compiling thiserror-impl v1.0.50 [INFO] [stderr] Checking zeroize v1.6.0 [INFO] [stderr] Checking clap v3.2.25 [INFO] [stderr] Checking tokio v1.33.0 [INFO] [stderr] Checking der v0.7.8 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-bigint v0.5.3 [INFO] [stderr] Checking pin-project v1.1.3 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking tracing-subscriber v0.3.17 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking signature v2.1.0 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking spki v0.7.2 [INFO] [stderr] Checking hkdf v0.12.3 [INFO] [stderr] Checking rfc6979 v0.4.0 [INFO] [stderr] Checking pkcs8 v0.10.2 [INFO] [stderr] Checking x509-cert v0.2.4 [INFO] [stderr] Checking headers v0.3.9 [INFO] [stderr] Checking sec1 v0.7.3 [INFO] [stderr] Checking pkcs1 v0.7.5 [INFO] [stderr] Checking rsa v0.9.3 [INFO] [stderr] Checking elliptic-curve v0.13.6 [INFO] [stderr] Checking ecdsa v0.16.8 [INFO] [stderr] Checking primeorder v0.13.3 [INFO] [stderr] Checking p256 v0.13.2 [INFO] [stderr] Checking p384 v0.13.0 [INFO] [stderr] Checking tokio-util v0.7.10 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking serde_path_to_error v0.1.14 [INFO] [stderr] Checking chrono v0.4.31 [INFO] [stderr] Checking secrecy v0.8.0 [INFO] [stderr] Checking h2 v0.3.21 [INFO] [stderr] Checking hyper v0.14.27 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.22 [INFO] [stderr] Checking needroleshere v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/binding.rs:71:12 [INFO] [stdout] | [INFO] [stdout] 63 | let mut secret_raw = secrecy::zeroize::Zeroizing::new([0u8; 64]); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | let secret = secrecy::Secret::new(base64ct::Base64UrlUnpadded::encode_string( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 72 | | name, [INFO] [stdout] 73 | | mode, [INFO] [stdout] 74 | | secret: Some(secret), [INFO] [stdout] ... | [INFO] [stdout] 78 | | secret_hash, [INFO] [stdout] 79 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:84:12 [INFO] [stdout] | [INFO] [stdout] 82 | let http_client = reqwest::ClientBuilder::new().http1_only().build().unwrap(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | [INFO] [stdout] 84 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 85 | | http_client, [INFO] [stdout] 86 | | region: match region { [INFO] [stdout] 87 | | Some(s) => s.to_owned(), [INFO] [stdout] 88 | | None => default_region()?, [INFO] [stdout] 89 | | }, [INFO] [stdout] 90 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sign.rs:267:12 [INFO] [stdout] | [INFO] [stdout] 250 | let mut canonical_headers = reqwest::header::HeaderMap::with_capacity(req.headers.len()); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 262 | let mut signed_headers = Vec::with_capacity(canonical_headers.len()); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 267 | Ok((signed_headers, canonical_headers)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sign.rs:351:35 [INFO] [stdout] | [INFO] [stdout] 351 | once_cell::sync::Lazy::new(|| regex::bytes::Regex::new(r" {2,}").unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sign.rs:590:9 [INFO] [stdout] | [INFO] [stdout] 589 | let source_key = crate::identity::PrivateKey::from_private_key_pem(KEY_RSA).unwrap(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 590 | crate::identity::Identity::from_chain_and_key(&chain, source_key).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sign.rs:596:9 [INFO] [stdout] | [INFO] [stdout] 595 | let source_key = crate::identity::PrivateKey::from_private_key_pem(KEY_RSA).unwrap(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 596 | crate::identity::Identity::from_chain_and_key(&chain, source_key).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sign.rs:602:9 [INFO] [stdout] | [INFO] [stdout] 601 | let source_key = crate::identity::PrivateKey::from_private_key_pem(KEY_EC).unwrap(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 602 | crate::identity::Identity::from_chain_and_key(&chain, source_key).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sign.rs:608:9 [INFO] [stdout] | [INFO] [stdout] 607 | let source_key = crate::identity::PrivateKey::from_private_key_pem(KEY_EC).unwrap(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 608 | crate::identity::Identity::from_chain_and_key(&chain, source_key).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sign.rs:614:9 [INFO] [stdout] | [INFO] [stdout] 613 | let source_key = crate::identity::PrivateKey::from_private_key_pem(KEY_P384).unwrap(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 614 | crate::identity::Identity::from_chain_and_key(&chain, source_key).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmd/serve.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 15 | arc_config: std::sync::Arc, [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | arc_client: std::sync::Arc, [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | ) -> axum::Router { [INFO] [stdout] 18 | / axum::Router::new() [INFO] [stdout] 19 | | .route("/healthz", axum::routing::get(healthz)) [INFO] [stdout] 20 | | .route("/ecs/credentials", axum::routing::get(get_ecs_credentials)) [INFO] [stdout] 21 | | .layer(axum::extract::Extension(arc_config)) [INFO] [stdout] | |____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmd/serve.rs:22:16 [INFO] [stdout] | [INFO] [stdout] 15 | arc_config: std::sync::Arc, [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | arc_client: std::sync::Arc, [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | .layer(axum::extract::Extension(arc_client)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmd/serve.rs:53:17 [INFO] [stdout] | [INFO] [stdout] 51 | .map(|v| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | tokio::spawn( [INFO] [stdout] 53 | v.serve(make_router(arc_config.clone(), arc_client.clone()).into_make_service()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmd/serve.rs:168:12 [INFO] [stdout] | [INFO] [stdout] 82 | value: bearer, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | }: ExtractBearer, [INFO] [stdout] 84 | axum::extract::Extension(config): axum::extract::Extension< [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 87 | axum::extract::Extension(client): axum::extract::Extension< [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 105 | let binding = match crate::binding::RoleBinding::load(&config, at.binding_name).await { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | Ok(v) => v, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | Err(crate::error::Error::StdIoError(e)) if e.kind() == std::io::ErrorKind::NotFound => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 148 | let session = match binding.create_session(&client).await { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | Ok(v) => v, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 150 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | let res = GetEcsCredentialsResponse { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 168 | Ok(axum::Json(res)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `needroleshere` (lib test) due to 14 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/binding.rs:71:12 [INFO] [stdout] | [INFO] [stdout] 63 | let mut secret_raw = secrecy::zeroize::Zeroizing::new([0u8; 64]); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | let secret = secrecy::Secret::new(base64ct::Base64UrlUnpadded::encode_string( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 72 | | name, [INFO] [stdout] 73 | | mode, [INFO] [stdout] 74 | | secret: Some(secret), [INFO] [stdout] ... | [INFO] [stdout] 78 | | secret_hash, [INFO] [stdout] 79 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:84:12 [INFO] [stdout] | [INFO] [stdout] 82 | let http_client = reqwest::ClientBuilder::new().http1_only().build().unwrap(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | [INFO] [stdout] 84 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 85 | | http_client, [INFO] [stdout] 86 | | region: match region { [INFO] [stdout] 87 | | Some(s) => s.to_owned(), [INFO] [stdout] 88 | | None => default_region()?, [INFO] [stdout] 89 | | }, [INFO] [stdout] 90 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sign.rs:267:12 [INFO] [stdout] | [INFO] [stdout] 250 | let mut canonical_headers = reqwest::header::HeaderMap::with_capacity(req.headers.len()); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 262 | let mut signed_headers = Vec::with_capacity(canonical_headers.len()); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 267 | Ok((signed_headers, canonical_headers)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sign.rs:351:35 [INFO] [stdout] | [INFO] [stdout] 351 | once_cell::sync::Lazy::new(|| regex::bytes::Regex::new(r" {2,}").unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmd/serve.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 15 | arc_config: std::sync::Arc, [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | arc_client: std::sync::Arc, [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | ) -> axum::Router { [INFO] [stdout] 18 | / axum::Router::new() [INFO] [stdout] 19 | | .route("/healthz", axum::routing::get(healthz)) [INFO] [stdout] 20 | | .route("/ecs/credentials", axum::routing::get(get_ecs_credentials)) [INFO] [stdout] 21 | | .layer(axum::extract::Extension(arc_config)) [INFO] [stdout] | |____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmd/serve.rs:22:16 [INFO] [stdout] | [INFO] [stdout] 15 | arc_config: std::sync::Arc, [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | arc_client: std::sync::Arc, [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | .layer(axum::extract::Extension(arc_client)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmd/serve.rs:53:17 [INFO] [stdout] | [INFO] [stdout] 51 | .map(|v| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | tokio::spawn( [INFO] [stdout] 53 | v.serve(make_router(arc_config.clone(), arc_client.clone()).into_make_service()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmd/serve.rs:168:12 [INFO] [stdout] | [INFO] [stdout] 82 | value: bearer, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | }: ExtractBearer, [INFO] [stdout] 84 | axum::extract::Extension(config): axum::extract::Extension< [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 87 | axum::extract::Extension(client): axum::extract::Extension< [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 105 | let binding = match crate::binding::RoleBinding::load(&config, at.binding_name).await { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | Ok(v) => v, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | Err(crate::error::Error::StdIoError(e)) if e.kind() == std::io::ErrorKind::NotFound => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 148 | let session = match binding.create_session(&client).await { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | Ok(v) => v, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 150 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | let res = GetEcsCredentialsResponse { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 168 | Ok(axum::Json(res)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `needroleshere` (lib) due to 9 previous errors [INFO] running `Command { std: "docker" "inspect" "0dcfb525ea3fba4de0b1a09f0405289099288109934752be43d8ccf2af2b10ad", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0dcfb525ea3fba4de0b1a09f0405289099288109934752be43d8ccf2af2b10ad", kill_on_drop: false }` [INFO] [stdout] 0dcfb525ea3fba4de0b1a09f0405289099288109934752be43d8ccf2af2b10ad