[INFO] fetching crate nebula-graph-fbthrift-common 0.1.1... [INFO] checking nebula-graph-fbthrift-common-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate nebula-graph-fbthrift-common 0.1.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate nebula-graph-fbthrift-common 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate nebula-graph-fbthrift-common 0.1.1 [INFO] finished tweaking crates.io crate nebula-graph-fbthrift-common 0.1.1 [INFO] tweaked toml for crates.io crate nebula-graph-fbthrift-common 0.1.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 25 packages to latest compatible versions [INFO] [stderr] Adding bufsize v0.5.1 (latest: v1.0.7) [INFO] [stderr] Adding bytes v0.4.12 (latest: v1.7.1) [INFO] [stderr] Adding bytes v0.5.6 (latest: v1.7.1) [INFO] [stderr] Adding fbthrift-git v0.0.1+unstable2020090200 (latest: v0.0.8+c383b5e) [INFO] [stderr] Adding num-derive v0.3.3 (latest: v0.4.2) [INFO] [stderr] Adding ordered-float v1.1.1 (latest: v4.2.2) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: version requirement `0.0.1+unstable2020090200` for dependency `fbthrift` includes semver metadata which will be ignored, removing the metadata is recommended to avoid confusion [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e23302ec094d0181bc2cb8dc931d8e373e5264ca74eb76ebf9eec8ef0d63cb41 [INFO] running `Command { std: "docker" "start" "-a" "e23302ec094d0181bc2cb8dc931d8e373e5264ca74eb76ebf9eec8ef0d63cb41", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e23302ec094d0181bc2cb8dc931d8e373e5264ca74eb76ebf9eec8ef0d63cb41", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e23302ec094d0181bc2cb8dc931d8e373e5264ca74eb76ebf9eec8ef0d63cb41", kill_on_drop: false }` [INFO] [stdout] e23302ec094d0181bc2cb8dc931d8e373e5264ca74eb76ebf9eec8ef0d63cb41 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5e97b89898c2b257f42a80cb6df3e2d4da1284828ac47a0afd5efca634397d86 [INFO] running `Command { std: "docker" "start" "-a" "5e97b89898c2b257f42a80cb6df3e2d4da1284828ac47a0afd5efca634397d86", kill_on_drop: false }` [INFO] [stderr] warning: version requirement `0.0.1+unstable2020090200` for dependency `fbthrift` includes semver metadata which will be ignored, removing the metadata is recommended to avoid confusion [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Compiling num-derive v0.3.3 [INFO] [stderr] Checking bytes v0.5.6 [INFO] [stderr] Checking ordered-float v1.1.1 [INFO] [stderr] Checking bytes v0.4.12 [INFO] [stderr] Checking bufsize v0.5.1 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Compiling ghost v0.1.17 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking fbthrift-git v0.0.1+unstable2020090200 [INFO] [stderr] Checking nebula-graph-fbthrift-common v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `self::errors::*` [INFO] [stdout] --> src/lib.rs:6:9 [INFO] [stdout] | [INFO] [stdout] 6 | pub use self::errors::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::errors::*` [INFO] [stdout] --> src/lib.rs:6:9 [INFO] [stdout] | [INFO] [stdout] 6 | pub use self::errors::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:435:39 [INFO] [stdout] | [INFO] [stdout] 420 | let mut field_value_type = ::std::option::Option::None; [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 421 | let mut field_schema = ::std::option::Option::None; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 435 | ::std::result::Result::Ok(Self { [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 436 | | type_: field_type.unwrap_or_default(), [INFO] [stdout] 437 | | value_type: field_value_type, [INFO] [stdout] 438 | | schema: field_schema, [INFO] [stdout] 439 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:608:39 [INFO] [stdout] | [INFO] [stdout] 593 | let mut field_type = ::std::option::Option::None; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 608 | ::std::result::Result::Ok(Self { [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 609 | | name: field_name.unwrap_or_default(), [INFO] [stdout] 610 | | type_: field_type.unwrap_or_default(), [INFO] [stdout] 611 | | default_value: field_default_value, [INFO] [stdout] 612 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:733:39 [INFO] [stdout] | [INFO] [stdout] 719 | let mut field_columns = ::std::option::Option::None; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 733 | ::std::result::Result::Ok(Self { [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 734 | | columns: field_columns.unwrap_or_default(), [INFO] [stdout] 735 | | schema_prop: field_schema_prop.unwrap_or_default(), [INFO] [stdout] 736 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:888:39 [INFO] [stdout] | [INFO] [stdout] 872 | let mut field_fields = ::std::option::Option::None; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 888 | ::std::result::Result::Ok(Self { [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 889 | | index_id: field_index_id.unwrap_or_default(), [INFO] [stdout] 890 | | index_name: field_index_name.unwrap_or_default(), [INFO] [stdout] 891 | | schema_id: field_schema_id.unwrap_or_default(), [INFO] [stdout] 892 | | schema_name: field_schema_name.unwrap_or_default(), [INFO] [stdout] 893 | | fields: field_fields.unwrap_or_default(), [INFO] [stdout] 894 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nebula-graph-fbthrift-common` (lib) due to 5 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:435:39 [INFO] [stdout] | [INFO] [stdout] 420 | let mut field_value_type = ::std::option::Option::None; [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 421 | let mut field_schema = ::std::option::Option::None; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 435 | ::std::result::Result::Ok(Self { [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 436 | | type_: field_type.unwrap_or_default(), [INFO] [stdout] 437 | | value_type: field_value_type, [INFO] [stdout] 438 | | schema: field_schema, [INFO] [stdout] 439 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:608:39 [INFO] [stdout] | [INFO] [stdout] 593 | let mut field_type = ::std::option::Option::None; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 608 | ::std::result::Result::Ok(Self { [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 609 | | name: field_name.unwrap_or_default(), [INFO] [stdout] 610 | | type_: field_type.unwrap_or_default(), [INFO] [stdout] 611 | | default_value: field_default_value, [INFO] [stdout] 612 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:733:39 [INFO] [stdout] | [INFO] [stdout] 719 | let mut field_columns = ::std::option::Option::None; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 733 | ::std::result::Result::Ok(Self { [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 734 | | columns: field_columns.unwrap_or_default(), [INFO] [stdout] 735 | | schema_prop: field_schema_prop.unwrap_or_default(), [INFO] [stdout] 736 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:888:39 [INFO] [stdout] | [INFO] [stdout] 872 | let mut field_fields = ::std::option::Option::None; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 888 | ::std::result::Result::Ok(Self { [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 889 | | index_id: field_index_id.unwrap_or_default(), [INFO] [stdout] 890 | | index_name: field_index_name.unwrap_or_default(), [INFO] [stdout] 891 | | schema_id: field_schema_id.unwrap_or_default(), [INFO] [stdout] 892 | | schema_name: field_schema_name.unwrap_or_default(), [INFO] [stdout] 893 | | fields: field_fields.unwrap_or_default(), [INFO] [stdout] 894 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nebula-graph-fbthrift-common` (lib test) due to 5 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "5e97b89898c2b257f42a80cb6df3e2d4da1284828ac47a0afd5efca634397d86", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5e97b89898c2b257f42a80cb6df3e2d4da1284828ac47a0afd5efca634397d86", kill_on_drop: false }` [INFO] [stdout] 5e97b89898c2b257f42a80cb6df3e2d4da1284828ac47a0afd5efca634397d86