[INFO] fetching crate nebula-fbthrift-raftex-v2 0.3.0... [INFO] checking nebula-fbthrift-raftex-v2-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate nebula-fbthrift-raftex-v2 0.3.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate nebula-fbthrift-raftex-v2 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate nebula-fbthrift-raftex-v2 0.3.0 [INFO] finished tweaking crates.io crate nebula-fbthrift-raftex-v2 0.3.0 [INFO] tweaked toml for crates.io crate nebula-fbthrift-raftex-v2 0.3.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 43 packages to latest compatible versions [INFO] [stderr] Adding base64 v0.11.0 (latest: v0.22.1) [INFO] [stderr] Adding fbthrift-git v0.0.7+b377f46 (latest: v0.0.8+c383b5e) [INFO] [stderr] Adding futures v0.1.31 (latest: v0.3.30) [INFO] [stderr] Adding num-derive v0.3.3 (latest: v0.4.2) [INFO] [stderr] Adding ordered-float v1.1.1 (latest: v4.2.2) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9afd03e5453c7aa12e79848b667b487abb27e42adebcb419a7433ae8443cd3bc [INFO] running `Command { std: "docker" "start" "-a" "9afd03e5453c7aa12e79848b667b487abb27e42adebcb419a7433ae8443cd3bc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9afd03e5453c7aa12e79848b667b487abb27e42adebcb419a7433ae8443cd3bc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9afd03e5453c7aa12e79848b667b487abb27e42adebcb419a7433ae8443cd3bc", kill_on_drop: false }` [INFO] [stdout] 9afd03e5453c7aa12e79848b667b487abb27e42adebcb419a7433ae8443cd3bc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cbb99b721e7cdf216425a9b8e69e343bc6702985745c825106b1115ee2711948 [INFO] running `Command { std: "docker" "start" "-a" "cbb99b721e7cdf216425a9b8e69e343bc6702985745c825106b1115ee2711948", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking futures v0.1.31 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking panic-message v0.3.0 [INFO] [stderr] Checking base64 v0.11.0 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking const-cstr v0.3.0 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Compiling ghost v0.1.17 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling num-derive v0.3.3 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking ordered-float v1.1.1 [INFO] [stderr] Checking bufsize v1.0.7 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking fbthrift-git v0.0.7+b377f46 [INFO] [stderr] Checking nebula-fbthrift-raftex-v2 v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:622:13 [INFO] [stdout] | [INFO] [stdout] 595 | rpc_options: T::RpcOptions, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 613 | let request_env = match ::fbthrift::help::serialize_request_envelope::("askForVote", &args) { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 614 | ::std::result::Result::Ok(res) => res, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 615 | ::std::result::Result::Err(err) => return ::futures::future::err(err.into()).boxed(), [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 618 | let call = transport [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 619 | .call(SERVICE_NAME.as_cstr(), METHOD_NAME.as_cstr(), request_env, rpc_options) [INFO] [stdout] 620 | .instrument(::tracing::trace_span!("call", function = "RaftexService.askForVote")); [INFO] [stdout] | --------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 621 | [INFO] [stdout] 622 | / async move { [INFO] [stdout] 623 | | let reply_env = call.await?; [INFO] [stdout] 624 | | [INFO] [stdout] 625 | | let de = P::deserializer(reply_env); [INFO] [stdout] ... | [INFO] [stdout] 635 | | } [INFO] [stdout] 636 | | .instrument(::tracing::info_span!("RaftexService.askForVote")) [INFO] [stdout] | |__________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:670:13 [INFO] [stdout] | [INFO] [stdout] 643 | rpc_options: T::RpcOptions, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 661 | let request_env = match ::fbthrift::help::serialize_request_envelope::("appendLog", &args) { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 662 | ::std::result::Result::Ok(res) => res, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 663 | ::std::result::Result::Err(err) => return ::futures::future::err(err.into()).boxed(), [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 666 | let call = transport [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 667 | .call(SERVICE_NAME.as_cstr(), METHOD_NAME.as_cstr(), request_env, rpc_options) [INFO] [stdout] 668 | .instrument(::tracing::trace_span!("call", function = "RaftexService.appendLog")); [INFO] [stdout] | -------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 669 | [INFO] [stdout] 670 | / async move { [INFO] [stdout] 671 | | let reply_env = call.await?; [INFO] [stdout] 672 | | [INFO] [stdout] 673 | | let de = P::deserializer(reply_env); [INFO] [stdout] ... | [INFO] [stdout] 683 | | } [INFO] [stdout] 684 | | .instrument(::tracing::info_span!("RaftexService.appendLog")) [INFO] [stdout] | |_________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:718:13 [INFO] [stdout] | [INFO] [stdout] 691 | rpc_options: T::RpcOptions, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 709 | let request_env = match ::fbthrift::help::serialize_request_envelope::("sendSnapshot", &args) { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 710 | ::std::result::Result::Ok(res) => res, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 711 | ::std::result::Result::Err(err) => return ::futures::future::err(err.into()).boxed(), [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 714 | let call = transport [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 715 | .call(SERVICE_NAME.as_cstr(), METHOD_NAME.as_cstr(), request_env, rpc_options) [INFO] [stdout] 716 | .instrument(::tracing::trace_span!("call", function = "RaftexService.sendSnapshot")); [INFO] [stdout] | ----------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 717 | [INFO] [stdout] 718 | / async move { [INFO] [stdout] 719 | | let reply_env = call.await?; [INFO] [stdout] 720 | | [INFO] [stdout] 721 | | let de = P::deserializer(reply_env); [INFO] [stdout] ... | [INFO] [stdout] 731 | | } [INFO] [stdout] 732 | | .instrument(::tracing::info_span!("RaftexService.sendSnapshot")) [INFO] [stdout] | |____________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:766:13 [INFO] [stdout] | [INFO] [stdout] 739 | rpc_options: T::RpcOptions, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 757 | let request_env = match ::fbthrift::help::serialize_request_envelope::("heartbeat", &args) { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 758 | ::std::result::Result::Ok(res) => res, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 759 | ::std::result::Result::Err(err) => return ::futures::future::err(err.into()).boxed(), [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 762 | let call = transport [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 763 | .call(SERVICE_NAME.as_cstr(), METHOD_NAME.as_cstr(), request_env, rpc_options) [INFO] [stdout] 764 | .instrument(::tracing::trace_span!("call", function = "RaftexService.heartbeat")); [INFO] [stdout] | -------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 765 | [INFO] [stdout] 766 | / async move { [INFO] [stdout] 767 | | let reply_env = call.await?; [INFO] [stdout] 768 | | [INFO] [stdout] 769 | | let de = P::deserializer(reply_env); [INFO] [stdout] ... | [INFO] [stdout] 779 | | } [INFO] [stdout] 780 | | .instrument(::tracing::info_span!("RaftexService.heartbeat")) [INFO] [stdout] | |_________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1138:35 [INFO] [stdout] | [INFO] [stdout] 1126 | protocol: P, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1127 | transport: T, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1128 | spawner: S, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1138 | ::std::sync::Arc::new(RaftexServiceImpl::::new(transport)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1170:35 [INFO] [stdout] | [INFO] [stdout] 1159 | protocol: P, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1160 | transport: T, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1161 | spawner: S, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1170 | ::std::sync::Arc::new(RaftexServiceImpl::::new(transport)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1743:35 [INFO] [stdout] | [INFO] [stdout] 1741 | _reply_state: ::std::sync::Arc<::std::sync::Mutex>, [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1742 | _seqid: ::std::primitive::u32, [INFO] [stdout] 1743 | ) -> ::anyhow::Result<()> { [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 1744 | | match idx { [INFO] [stdout] 1745 | | 0usize => { [INFO] [stdout] 1746 | | self.handle_askForVote(_p, _r, _reply_state, _seqid).await [INFO] [stdout] ... | [INFO] [stdout] 1762 | | } [INFO] [stdout] 1763 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:2015:36 [INFO] [stdout] | [INFO] [stdout] 2013 | let mut closure = self.askForVote.closure.lock().unwrap(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 2014 | let closure: &mut dyn ::std::ops::FnMut(crate::types::AskForVoteRequest) -> _ = &mut **closure; [INFO] [stdout] 2015 | ::std::boxed::Box::pin(::futures::future::ready(closure(arg_req.clone()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:2023:36 [INFO] [stdout] | [INFO] [stdout] 2021 | let mut closure = self.appendLog.closure.lock().unwrap(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 2022 | let closure: &mut dyn ::std::ops::FnMut(crate::types::AppendLogRequest) -> _ = &mut **closure; [INFO] [stdout] 2023 | ::std::boxed::Box::pin(::futures::future::ready(closure(arg_req.clone()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:2031:36 [INFO] [stdout] | [INFO] [stdout] 2029 | let mut closure = self.sendSnapshot.closure.lock().unwrap(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 2030 | let closure: &mut dyn ::std::ops::FnMut(crate::types::SendSnapshotRequest) -> _ = &mut **closure; [INFO] [stdout] 2031 | ::std::boxed::Box::pin(::futures::future::ready(closure(arg_req.clone()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:2039:36 [INFO] [stdout] | [INFO] [stdout] 2037 | let mut closure = self.heartbeat.closure.lock().unwrap(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 2038 | let closure: &mut dyn ::std::ops::FnMut(crate::types::HeartbeatRequest) -> _ = &mut **closure; [INFO] [stdout] 2039 | ::std::boxed::Box::pin(::futures::future::ready(closure(arg_req.clone()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:2087:124 [INFO] [stdout] | [INFO] [stdout] 2081 | ...(&self, exception: E) [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2087 | ...::std::boxed::Box::new(move |_: crate::types::AskForVoteRequest| ::std::result::Result::Err(exception.clone().into())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:2132:123 [INFO] [stdout] | [INFO] [stdout] 2126 | ...(&self, exception: E) [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2132 | ...::std::boxed::Box::new(move |_: crate::types::AppendLogRequest| ::std::result::Result::Err(exception.clone().into())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:2177:126 [INFO] [stdout] | [INFO] [stdout] 2171 | ...(&self, exception: E) [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2177 | ...::std::boxed::Box::new(move |_: crate::types::SendSnapshotRequest| ::std::result::Result::Err(exception.clone().into())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:2222:123 [INFO] [stdout] | [INFO] [stdout] 2216 | ...(&self, exception: E) [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2222 | ...::std::boxed::Box::new(move |_: crate::types::HeartbeatRequest| ::std::result::Result::Err(exception.clone().into())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:622:13 [INFO] [stdout] | [INFO] [stdout] 595 | rpc_options: T::RpcOptions, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 613 | let request_env = match ::fbthrift::help::serialize_request_envelope::("askForVote", &args) { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 614 | ::std::result::Result::Ok(res) => res, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 615 | ::std::result::Result::Err(err) => return ::futures::future::err(err.into()).boxed(), [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 618 | let call = transport [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 619 | .call(SERVICE_NAME.as_cstr(), METHOD_NAME.as_cstr(), request_env, rpc_options) [INFO] [stdout] 620 | .instrument(::tracing::trace_span!("call", function = "RaftexService.askForVote")); [INFO] [stdout] | --------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 621 | [INFO] [stdout] 622 | / async move { [INFO] [stdout] 623 | | let reply_env = call.await?; [INFO] [stdout] 624 | | [INFO] [stdout] 625 | | let de = P::deserializer(reply_env); [INFO] [stdout] ... | [INFO] [stdout] 635 | | } [INFO] [stdout] 636 | | .instrument(::tracing::info_span!("RaftexService.askForVote")) [INFO] [stdout] | |__________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:670:13 [INFO] [stdout] | [INFO] [stdout] 643 | rpc_options: T::RpcOptions, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 661 | let request_env = match ::fbthrift::help::serialize_request_envelope::("appendLog", &args) { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 662 | ::std::result::Result::Ok(res) => res, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 663 | ::std::result::Result::Err(err) => return ::futures::future::err(err.into()).boxed(), [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 666 | let call = transport [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 667 | .call(SERVICE_NAME.as_cstr(), METHOD_NAME.as_cstr(), request_env, rpc_options) [INFO] [stdout] 668 | .instrument(::tracing::trace_span!("call", function = "RaftexService.appendLog")); [INFO] [stdout] | -------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 669 | [INFO] [stdout] 670 | / async move { [INFO] [stdout] 671 | | let reply_env = call.await?; [INFO] [stdout] 672 | | [INFO] [stdout] 673 | | let de = P::deserializer(reply_env); [INFO] [stdout] ... | [INFO] [stdout] 683 | | } [INFO] [stdout] 684 | | .instrument(::tracing::info_span!("RaftexService.appendLog")) [INFO] [stdout] | |_________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:718:13 [INFO] [stdout] | [INFO] [stdout] 691 | rpc_options: T::RpcOptions, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 709 | let request_env = match ::fbthrift::help::serialize_request_envelope::("sendSnapshot", &args) { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 710 | ::std::result::Result::Ok(res) => res, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 711 | ::std::result::Result::Err(err) => return ::futures::future::err(err.into()).boxed(), [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 714 | let call = transport [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 715 | .call(SERVICE_NAME.as_cstr(), METHOD_NAME.as_cstr(), request_env, rpc_options) [INFO] [stdout] 716 | .instrument(::tracing::trace_span!("call", function = "RaftexService.sendSnapshot")); [INFO] [stdout] | ----------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 717 | [INFO] [stdout] 718 | / async move { [INFO] [stdout] 719 | | let reply_env = call.await?; [INFO] [stdout] 720 | | [INFO] [stdout] 721 | | let de = P::deserializer(reply_env); [INFO] [stdout] ... | [INFO] [stdout] 731 | | } [INFO] [stdout] 732 | | .instrument(::tracing::info_span!("RaftexService.sendSnapshot")) [INFO] [stdout] | |____________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:766:13 [INFO] [stdout] | [INFO] [stdout] 739 | rpc_options: T::RpcOptions, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 757 | let request_env = match ::fbthrift::help::serialize_request_envelope::("heartbeat", &args) { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 758 | ::std::result::Result::Ok(res) => res, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 759 | ::std::result::Result::Err(err) => return ::futures::future::err(err.into()).boxed(), [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 762 | let call = transport [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 763 | .call(SERVICE_NAME.as_cstr(), METHOD_NAME.as_cstr(), request_env, rpc_options) [INFO] [stdout] 764 | .instrument(::tracing::trace_span!("call", function = "RaftexService.heartbeat")); [INFO] [stdout] | -------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 765 | [INFO] [stdout] 766 | / async move { [INFO] [stdout] 767 | | let reply_env = call.await?; [INFO] [stdout] 768 | | [INFO] [stdout] 769 | | let de = P::deserializer(reply_env); [INFO] [stdout] ... | [INFO] [stdout] 779 | | } [INFO] [stdout] 780 | | .instrument(::tracing::info_span!("RaftexService.heartbeat")) [INFO] [stdout] | |_________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1138:35 [INFO] [stdout] | [INFO] [stdout] 1126 | protocol: P, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1127 | transport: T, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1128 | spawner: S, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1138 | ::std::sync::Arc::new(RaftexServiceImpl::::new(transport)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1170:35 [INFO] [stdout] | [INFO] [stdout] 1159 | protocol: P, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1160 | transport: T, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1161 | spawner: S, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1170 | ::std::sync::Arc::new(RaftexServiceImpl::::new(transport)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1743:35 [INFO] [stdout] | [INFO] [stdout] 1741 | _reply_state: ::std::sync::Arc<::std::sync::Mutex>, [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1742 | _seqid: ::std::primitive::u32, [INFO] [stdout] 1743 | ) -> ::anyhow::Result<()> { [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 1744 | | match idx { [INFO] [stdout] 1745 | | 0usize => { [INFO] [stdout] 1746 | | self.handle_askForVote(_p, _r, _reply_state, _seqid).await [INFO] [stdout] ... | [INFO] [stdout] 1762 | | } [INFO] [stdout] 1763 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:2015:36 [INFO] [stdout] | [INFO] [stdout] 2013 | let mut closure = self.askForVote.closure.lock().unwrap(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 2014 | let closure: &mut dyn ::std::ops::FnMut(crate::types::AskForVoteRequest) -> _ = &mut **closure; [INFO] [stdout] 2015 | ::std::boxed::Box::pin(::futures::future::ready(closure(arg_req.clone()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:2023:36 [INFO] [stdout] | [INFO] [stdout] 2021 | let mut closure = self.appendLog.closure.lock().unwrap(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 2022 | let closure: &mut dyn ::std::ops::FnMut(crate::types::AppendLogRequest) -> _ = &mut **closure; [INFO] [stdout] 2023 | ::std::boxed::Box::pin(::futures::future::ready(closure(arg_req.clone()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:2031:36 [INFO] [stdout] | [INFO] [stdout] 2029 | let mut closure = self.sendSnapshot.closure.lock().unwrap(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 2030 | let closure: &mut dyn ::std::ops::FnMut(crate::types::SendSnapshotRequest) -> _ = &mut **closure; [INFO] [stdout] 2031 | ::std::boxed::Box::pin(::futures::future::ready(closure(arg_req.clone()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:2039:36 [INFO] [stdout] | [INFO] [stdout] 2037 | let mut closure = self.heartbeat.closure.lock().unwrap(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 2038 | let closure: &mut dyn ::std::ops::FnMut(crate::types::HeartbeatRequest) -> _ = &mut **closure; [INFO] [stdout] 2039 | ::std::boxed::Box::pin(::futures::future::ready(closure(arg_req.clone()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:2087:124 [INFO] [stdout] | [INFO] [stdout] 2081 | ...(&self, exception: E) [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2087 | ...::std::boxed::Box::new(move |_: crate::types::AskForVoteRequest| ::std::result::Result::Err(exception.clone().into())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:2132:123 [INFO] [stdout] | [INFO] [stdout] 2126 | ...(&self, exception: E) [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2132 | ...::std::boxed::Box::new(move |_: crate::types::AppendLogRequest| ::std::result::Result::Err(exception.clone().into())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:2177:126 [INFO] [stdout] | [INFO] [stdout] 2171 | ...(&self, exception: E) [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2177 | ...::std::boxed::Box::new(move |_: crate::types::SendSnapshotRequest| ::std::result::Result::Err(exception.clone().into())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:2222:123 [INFO] [stdout] | [INFO] [stdout] 2216 | ...(&self, exception: E) [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2222 | ...::std::boxed::Box::new(move |_: crate::types::HeartbeatRequest| ::std::result::Result::Err(exception.clone().into())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 15 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 15 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nebula-fbthrift-raftex-v2` (lib) due to 16 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `nebula-fbthrift-raftex-v2` (lib test) due to 16 previous errors [INFO] running `Command { std: "docker" "inspect" "cbb99b721e7cdf216425a9b8e69e343bc6702985745c825106b1115ee2711948", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cbb99b721e7cdf216425a9b8e69e343bc6702985745c825106b1115ee2711948", kill_on_drop: false }` [INFO] [stdout] cbb99b721e7cdf216425a9b8e69e343bc6702985745c825106b1115ee2711948