[INFO] fetching crate nebula-fbthrift-raftex-v1 0.3.0... [INFO] checking nebula-fbthrift-raftex-v1-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate nebula-fbthrift-raftex-v1 0.3.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate nebula-fbthrift-raftex-v1 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate nebula-fbthrift-raftex-v1 0.3.0 [INFO] finished tweaking crates.io crate nebula-fbthrift-raftex-v1 0.3.0 [INFO] tweaked toml for crates.io crate nebula-fbthrift-raftex-v1 0.3.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 45 packages to latest compatible versions [INFO] [stderr] Adding base64 v0.11.0 (latest: v0.22.1) [INFO] [stderr] Adding fbthrift-git v0.0.7+b377f46 (latest: v0.0.8+c383b5e) [INFO] [stderr] Adding futures v0.1.31 (latest: v0.3.30) [INFO] [stderr] Adding num-derive v0.3.3 (latest: v0.4.2) [INFO] [stderr] Adding ordered-float v1.1.1 (latest: v4.2.2) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d090ea1205b138e652f670f1c808951ecd953508bcc8c9f6b7d6b03867974d61 [INFO] running `Command { std: "docker" "start" "-a" "d090ea1205b138e652f670f1c808951ecd953508bcc8c9f6b7d6b03867974d61", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d090ea1205b138e652f670f1c808951ecd953508bcc8c9f6b7d6b03867974d61", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d090ea1205b138e652f670f1c808951ecd953508bcc8c9f6b7d6b03867974d61", kill_on_drop: false }` [INFO] [stdout] d090ea1205b138e652f670f1c808951ecd953508bcc8c9f6b7d6b03867974d61 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a60d2272a1c32847ee1f47d03c618f3c9ea3205c85ff31493e7b827dc80cc23c [INFO] running `Command { std: "docker" "start" "-a" "a60d2272a1c32847ee1f47d03c618f3c9ea3205c85ff31493e7b827dc80cc23c", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking futures v0.1.31 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking base64 v0.11.0 [INFO] [stderr] Checking panic-message v0.3.0 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking const-cstr v0.3.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling num-derive v0.3.3 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking ordered-float v1.1.1 [INFO] [stderr] Checking bufsize v1.0.7 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling ghost v0.1.17 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking fbthrift-git v0.0.7+b377f46 [INFO] [stderr] Checking nebula-fbthrift-common-v1 v0.3.0 [INFO] [stderr] Checking nebula-fbthrift-raftex-v1 v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:488:13 [INFO] [stdout] | [INFO] [stdout] 461 | rpc_options: T::RpcOptions, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 479 | let request_env = match ::fbthrift::help::serialize_request_envelope::("askForVote", &args) { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 480 | ::std::result::Result::Ok(res) => res, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 481 | ::std::result::Result::Err(err) => return ::futures::future::err(err.into()).boxed(), [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 484 | let call = transport [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 485 | .call(SERVICE_NAME.as_cstr(), METHOD_NAME.as_cstr(), request_env, rpc_options) [INFO] [stdout] 486 | .instrument(::tracing::trace_span!("call", function = "RaftexService.askForVote")); [INFO] [stdout] | --------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 487 | [INFO] [stdout] 488 | / async move { [INFO] [stdout] 489 | | let reply_env = call.await?; [INFO] [stdout] 490 | | [INFO] [stdout] 491 | | let de = P::deserializer(reply_env); [INFO] [stdout] ... | [INFO] [stdout] 501 | | } [INFO] [stdout] 502 | | .instrument(::tracing::info_span!("RaftexService.askForVote")) [INFO] [stdout] | |__________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:536:13 [INFO] [stdout] | [INFO] [stdout] 509 | rpc_options: T::RpcOptions, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 527 | let request_env = match ::fbthrift::help::serialize_request_envelope::("appendLog", &args) { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 528 | ::std::result::Result::Ok(res) => res, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 529 | ::std::result::Result::Err(err) => return ::futures::future::err(err.into()).boxed(), [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 532 | let call = transport [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 533 | .call(SERVICE_NAME.as_cstr(), METHOD_NAME.as_cstr(), request_env, rpc_options) [INFO] [stdout] 534 | .instrument(::tracing::trace_span!("call", function = "RaftexService.appendLog")); [INFO] [stdout] | -------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 535 | [INFO] [stdout] 536 | / async move { [INFO] [stdout] 537 | | let reply_env = call.await?; [INFO] [stdout] 538 | | [INFO] [stdout] 539 | | let de = P::deserializer(reply_env); [INFO] [stdout] ... | [INFO] [stdout] 549 | | } [INFO] [stdout] 550 | | .instrument(::tracing::info_span!("RaftexService.appendLog")) [INFO] [stdout] | |_________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:584:13 [INFO] [stdout] | [INFO] [stdout] 557 | rpc_options: T::RpcOptions, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 575 | let request_env = match ::fbthrift::help::serialize_request_envelope::("sendSnapshot", &args) { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 576 | ::std::result::Result::Ok(res) => res, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 577 | ::std::result::Result::Err(err) => return ::futures::future::err(err.into()).boxed(), [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 580 | let call = transport [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 581 | .call(SERVICE_NAME.as_cstr(), METHOD_NAME.as_cstr(), request_env, rpc_options) [INFO] [stdout] 582 | .instrument(::tracing::trace_span!("call", function = "RaftexService.sendSnapshot")); [INFO] [stdout] | ----------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 583 | [INFO] [stdout] 584 | / async move { [INFO] [stdout] 585 | | let reply_env = call.await?; [INFO] [stdout] 586 | | [INFO] [stdout] 587 | | let de = P::deserializer(reply_env); [INFO] [stdout] ... | [INFO] [stdout] 597 | | } [INFO] [stdout] 598 | | .instrument(::tracing::info_span!("RaftexService.sendSnapshot")) [INFO] [stdout] | |____________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:890:35 [INFO] [stdout] | [INFO] [stdout] 878 | protocol: P, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 879 | transport: T, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 880 | spawner: S, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 890 | ::std::sync::Arc::new(RaftexServiceImpl::::new(transport)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:922:35 [INFO] [stdout] | [INFO] [stdout] 911 | protocol: P, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 912 | transport: T, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 913 | spawner: S, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 922 | ::std::sync::Arc::new(RaftexServiceImpl::::new(transport)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1377:35 [INFO] [stdout] | [INFO] [stdout] 1375 | _reply_state: ::std::sync::Arc<::std::sync::Mutex>, [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1376 | _seqid: ::std::primitive::u32, [INFO] [stdout] 1377 | ) -> ::anyhow::Result<()> { [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 1378 | | match idx { [INFO] [stdout] 1379 | | 0usize => { [INFO] [stdout] 1380 | | self.handle_askForVote(_p, _r, _reply_state, _seqid).await [INFO] [stdout] ... | [INFO] [stdout] 1393 | | } [INFO] [stdout] 1394 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1643:36 [INFO] [stdout] | [INFO] [stdout] 1641 | let mut closure = self.askForVote.closure.lock().unwrap(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1642 | let closure: &mut dyn ::std::ops::FnMut(crate::types::AskForVoteRequest) -> _ = &mut **closure; [INFO] [stdout] 1643 | ::std::boxed::Box::pin(::futures::future::ready(closure(arg_req.clone()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1651:36 [INFO] [stdout] | [INFO] [stdout] 1649 | let mut closure = self.appendLog.closure.lock().unwrap(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1650 | let closure: &mut dyn ::std::ops::FnMut(crate::types::AppendLogRequest) -> _ = &mut **closure; [INFO] [stdout] 1651 | ::std::boxed::Box::pin(::futures::future::ready(closure(arg_req.clone()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1659:36 [INFO] [stdout] | [INFO] [stdout] 1657 | let mut closure = self.sendSnapshot.closure.lock().unwrap(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1658 | let closure: &mut dyn ::std::ops::FnMut(crate::types::SendSnapshotRequest) -> _ = &mut **closure; [INFO] [stdout] 1659 | ::std::boxed::Box::pin(::futures::future::ready(closure(arg_req.clone()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1707:124 [INFO] [stdout] | [INFO] [stdout] 1701 | ...(&self, exception: E) [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1707 | ...::std::boxed::Box::new(move |_: crate::types::AskForVoteRequest| ::std::result::Result::Err(exception.clone().into())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1752:123 [INFO] [stdout] | [INFO] [stdout] 1746 | ...(&self, exception: E) [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1752 | ...::std::boxed::Box::new(move |_: crate::types::AppendLogRequest| ::std::result::Result::Err(exception.clone().into())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1797:126 [INFO] [stdout] | [INFO] [stdout] 1791 | ...(&self, exception: E) [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1797 | ...::std::boxed::Box::new(move |_: crate::types::SendSnapshotRequest| ::std::result::Result::Err(exception.clone().into())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nebula-fbthrift-raftex-v1` (lib test) due to 13 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:488:13 [INFO] [stdout] | [INFO] [stdout] 461 | rpc_options: T::RpcOptions, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 479 | let request_env = match ::fbthrift::help::serialize_request_envelope::("askForVote", &args) { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 480 | ::std::result::Result::Ok(res) => res, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 481 | ::std::result::Result::Err(err) => return ::futures::future::err(err.into()).boxed(), [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 484 | let call = transport [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 485 | .call(SERVICE_NAME.as_cstr(), METHOD_NAME.as_cstr(), request_env, rpc_options) [INFO] [stdout] 486 | .instrument(::tracing::trace_span!("call", function = "RaftexService.askForVote")); [INFO] [stdout] | --------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 487 | [INFO] [stdout] 488 | / async move { [INFO] [stdout] 489 | | let reply_env = call.await?; [INFO] [stdout] 490 | | [INFO] [stdout] 491 | | let de = P::deserializer(reply_env); [INFO] [stdout] ... | [INFO] [stdout] 501 | | } [INFO] [stdout] 502 | | .instrument(::tracing::info_span!("RaftexService.askForVote")) [INFO] [stdout] | |__________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:536:13 [INFO] [stdout] | [INFO] [stdout] 509 | rpc_options: T::RpcOptions, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 527 | let request_env = match ::fbthrift::help::serialize_request_envelope::("appendLog", &args) { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 528 | ::std::result::Result::Ok(res) => res, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 529 | ::std::result::Result::Err(err) => return ::futures::future::err(err.into()).boxed(), [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 532 | let call = transport [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 533 | .call(SERVICE_NAME.as_cstr(), METHOD_NAME.as_cstr(), request_env, rpc_options) [INFO] [stdout] 534 | .instrument(::tracing::trace_span!("call", function = "RaftexService.appendLog")); [INFO] [stdout] | -------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 535 | [INFO] [stdout] 536 | / async move { [INFO] [stdout] 537 | | let reply_env = call.await?; [INFO] [stdout] 538 | | [INFO] [stdout] 539 | | let de = P::deserializer(reply_env); [INFO] [stdout] ... | [INFO] [stdout] 549 | | } [INFO] [stdout] 550 | | .instrument(::tracing::info_span!("RaftexService.appendLog")) [INFO] [stdout] | |_________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:584:13 [INFO] [stdout] | [INFO] [stdout] 557 | rpc_options: T::RpcOptions, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 575 | let request_env = match ::fbthrift::help::serialize_request_envelope::("sendSnapshot", &args) { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 576 | ::std::result::Result::Ok(res) => res, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 577 | ::std::result::Result::Err(err) => return ::futures::future::err(err.into()).boxed(), [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 580 | let call = transport [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 581 | .call(SERVICE_NAME.as_cstr(), METHOD_NAME.as_cstr(), request_env, rpc_options) [INFO] [stdout] 582 | .instrument(::tracing::trace_span!("call", function = "RaftexService.sendSnapshot")); [INFO] [stdout] | ----------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 583 | [INFO] [stdout] 584 | / async move { [INFO] [stdout] 585 | | let reply_env = call.await?; [INFO] [stdout] 586 | | [INFO] [stdout] 587 | | let de = P::deserializer(reply_env); [INFO] [stdout] ... | [INFO] [stdout] 597 | | } [INFO] [stdout] 598 | | .instrument(::tracing::info_span!("RaftexService.sendSnapshot")) [INFO] [stdout] | |____________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:890:35 [INFO] [stdout] | [INFO] [stdout] 878 | protocol: P, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 879 | transport: T, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 880 | spawner: S, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 890 | ::std::sync::Arc::new(RaftexServiceImpl::::new(transport)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:922:35 [INFO] [stdout] | [INFO] [stdout] 911 | protocol: P, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 912 | transport: T, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 913 | spawner: S, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 922 | ::std::sync::Arc::new(RaftexServiceImpl::::new(transport)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1377:35 [INFO] [stdout] | [INFO] [stdout] 1375 | _reply_state: ::std::sync::Arc<::std::sync::Mutex>, [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1376 | _seqid: ::std::primitive::u32, [INFO] [stdout] 1377 | ) -> ::anyhow::Result<()> { [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 1378 | | match idx { [INFO] [stdout] 1379 | | 0usize => { [INFO] [stdout] 1380 | | self.handle_askForVote(_p, _r, _reply_state, _seqid).await [INFO] [stdout] ... | [INFO] [stdout] 1393 | | } [INFO] [stdout] 1394 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1643:36 [INFO] [stdout] | [INFO] [stdout] 1641 | let mut closure = self.askForVote.closure.lock().unwrap(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1642 | let closure: &mut dyn ::std::ops::FnMut(crate::types::AskForVoteRequest) -> _ = &mut **closure; [INFO] [stdout] 1643 | ::std::boxed::Box::pin(::futures::future::ready(closure(arg_req.clone()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1651:36 [INFO] [stdout] | [INFO] [stdout] 1649 | let mut closure = self.appendLog.closure.lock().unwrap(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1650 | let closure: &mut dyn ::std::ops::FnMut(crate::types::AppendLogRequest) -> _ = &mut **closure; [INFO] [stdout] 1651 | ::std::boxed::Box::pin(::futures::future::ready(closure(arg_req.clone()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1659:36 [INFO] [stdout] | [INFO] [stdout] 1657 | let mut closure = self.sendSnapshot.closure.lock().unwrap(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1658 | let closure: &mut dyn ::std::ops::FnMut(crate::types::SendSnapshotRequest) -> _ = &mut **closure; [INFO] [stdout] 1659 | ::std::boxed::Box::pin(::futures::future::ready(closure(arg_req.clone()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1707:124 [INFO] [stdout] | [INFO] [stdout] 1701 | ...(&self, exception: E) [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1707 | ...::std::boxed::Box::new(move |_: crate::types::AskForVoteRequest| ::std::result::Result::Err(exception.clone().into())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1752:123 [INFO] [stdout] | [INFO] [stdout] 1746 | ...(&self, exception: E) [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1752 | ...::std::boxed::Box::new(move |_: crate::types::AppendLogRequest| ::std::result::Result::Err(exception.clone().into())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1797:126 [INFO] [stdout] | [INFO] [stdout] 1791 | ...(&self, exception: E) [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1797 | ...::std::boxed::Box::new(move |_: crate::types::SendSnapshotRequest| ::std::result::Result::Err(exception.clone().into())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nebula-fbthrift-raftex-v1` (lib) due to 13 previous errors [INFO] running `Command { std: "docker" "inspect" "a60d2272a1c32847ee1f47d03c618f3c9ea3205c85ff31493e7b827dc80cc23c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a60d2272a1c32847ee1f47d03c618f3c9ea3205c85ff31493e7b827dc80cc23c", kill_on_drop: false }` [INFO] [stdout] a60d2272a1c32847ee1f47d03c618f3c9ea3205c85ff31493e7b827dc80cc23c