[INFO] fetching crate neat 0.5.1... [INFO] checking neat-0.5.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate neat 0.5.1 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate neat 0.5.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate neat 0.5.1 [INFO] finished tweaking crates.io crate neat 0.5.1 [INFO] tweaked toml for crates.io crate neat 0.5.1 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate neat 0.5.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b8fce869bcf4ac4ade50a4de2c631bffa71cb3073bb0d888aba1e74bb01623e5 [INFO] running `Command { std: "docker" "start" "-a" "b8fce869bcf4ac4ade50a4de2c631bffa71cb3073bb0d888aba1e74bb01623e5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b8fce869bcf4ac4ade50a4de2c631bffa71cb3073bb0d888aba1e74bb01623e5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b8fce869bcf4ac4ade50a4de2c631bffa71cb3073bb0d888aba1e74bb01623e5", kill_on_drop: false }` [INFO] [stdout] b8fce869bcf4ac4ade50a4de2c631bffa71cb3073bb0d888aba1e74bb01623e5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ef36302efddb5a4c3189578b00581f481cc63ff5ea619a1688efad09ab6fe447 [INFO] running `Command { std: "docker" "start" "-a" "ef36302efddb5a4c3189578b00581f481cc63ff5ea619a1688efad09ab6fe447", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling ppv-lite86 v0.2.17 [INFO] [stderr] Compiling replace_with v0.1.7 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Compiling serde_json v1.0.114 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Compiling syn v2.0.51 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking genetic-rs-common v0.5.1 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Compiling genetic-rs-macros v0.5.1 [INFO] [stderr] Checking genetic-rs v0.5.1 [INFO] [stderr] Checking neat v0.5.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/topology/mod.rs:237:9 [INFO] [stdout] | [INFO] [stdout] 188 | let neuron = Arc::into_inner(self.hidden_layers.remove(index)).unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 237 | neuron.into_inner().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/topology/mod.rs:247:31 [INFO] [stdout] | [INFO] [stdout] 247 | .map(|n| Arc::new(RwLock::new(n.read().unwrap().clone()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/topology/mod.rs:255:31 [INFO] [stdout] | [INFO] [stdout] 255 | .map(|n| Arc::new(RwLock::new(n.read().unwrap().clone()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/topology/mod.rs:261:31 [INFO] [stdout] | [INFO] [stdout] 261 | .map(|n| Arc::new(RwLock::new(n.read().unwrap().clone()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/topology/mod.rs:564:13 [INFO] [stdout] | [INFO] [stdout] 557 | activations: impl IntoIterator, [INFO] [stdout] | --------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 560 | let mut activations: Vec<_> = activations.into_iter().collect(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 564 | activations.remove(rng.gen_range(0..activations.len())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/topology/activation.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 77 | let acts = self.activations(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | [INFO] [stdout] 79 | / acts.into_iter() [INFO] [stdout] 80 | | .filter(|a| a.scope != ActivationScope::NONE && a.scope.contains(scope)) [INFO] [stdout] | |____________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runnable.rs:177:30 [INFO] [stdout] | [INFO] [stdout] 177 | .map(|n| Rc::new(RefCell::new(Neuron::from(&n.read().unwrap().clone())))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runnable.rs:185:30 [INFO] [stdout] | [INFO] [stdout] 185 | .map(|n| Rc::new(RefCell::new(Neuron::from(&n.read().unwrap().clone())))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runnable.rs:191:30 [INFO] [stdout] | [INFO] [stdout] 191 | .map(|n| Rc::new(RefCell::new(Neuron::from(&n.read().unwrap().clone())))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runnable.rs:295:9 [INFO] [stdout] | [INFO] [stdout] 294 | fn max_index(self) -> usize { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 295 | / self.enumerate() [INFO] [stdout] 296 | | .max_by(|(_, v), (_, v2)| v.partial_cmp(v2).unwrap()) [INFO] [stdout] 297 | | .unwrap() [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `neat` (lib test) due to 11 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/topology/mod.rs:237:9 [INFO] [stdout] | [INFO] [stdout] 188 | let neuron = Arc::into_inner(self.hidden_layers.remove(index)).unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 237 | neuron.into_inner().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/topology/mod.rs:247:31 [INFO] [stdout] | [INFO] [stdout] 247 | .map(|n| Arc::new(RwLock::new(n.read().unwrap().clone()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/topology/mod.rs:255:31 [INFO] [stdout] | [INFO] [stdout] 255 | .map(|n| Arc::new(RwLock::new(n.read().unwrap().clone()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/topology/mod.rs:261:31 [INFO] [stdout] | [INFO] [stdout] 261 | .map(|n| Arc::new(RwLock::new(n.read().unwrap().clone()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/topology/mod.rs:564:13 [INFO] [stdout] | [INFO] [stdout] 557 | activations: impl IntoIterator, [INFO] [stdout] | --------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 560 | let mut activations: Vec<_> = activations.into_iter().collect(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 564 | activations.remove(rng.gen_range(0..activations.len())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/topology/activation.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 77 | let acts = self.activations(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | [INFO] [stdout] 79 | / acts.into_iter() [INFO] [stdout] 80 | | .filter(|a| a.scope != ActivationScope::NONE && a.scope.contains(scope)) [INFO] [stdout] | |____________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runnable.rs:177:30 [INFO] [stdout] | [INFO] [stdout] 177 | .map(|n| Rc::new(RefCell::new(Neuron::from(&n.read().unwrap().clone())))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runnable.rs:185:30 [INFO] [stdout] | [INFO] [stdout] 185 | .map(|n| Rc::new(RefCell::new(Neuron::from(&n.read().unwrap().clone())))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runnable.rs:191:30 [INFO] [stdout] | [INFO] [stdout] 191 | .map(|n| Rc::new(RefCell::new(Neuron::from(&n.read().unwrap().clone())))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runnable.rs:295:9 [INFO] [stdout] | [INFO] [stdout] 294 | fn max_index(self) -> usize { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 295 | / self.enumerate() [INFO] [stdout] 296 | | .max_by(|(_, v), (_, v2)| v.partial_cmp(v2).unwrap()) [INFO] [stdout] 297 | | .unwrap() [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `neat` (lib) due to 11 previous errors [INFO] running `Command { std: "docker" "inspect" "ef36302efddb5a4c3189578b00581f481cc63ff5ea619a1688efad09ab6fe447", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ef36302efddb5a4c3189578b00581f481cc63ff5ea619a1688efad09ab6fe447", kill_on_drop: false }` [INFO] [stdout] ef36302efddb5a4c3189578b00581f481cc63ff5ea619a1688efad09ab6fe447