[INFO] fetching crate nbtscanner 0.0.1... [INFO] checking nbtscanner-0.0.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate nbtscanner 0.0.1 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate nbtscanner 0.0.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate nbtscanner 0.0.1 [INFO] finished tweaking crates.io crate nbtscanner 0.0.1 [INFO] tweaked toml for crates.io crate nbtscanner 0.0.1 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate nbtscanner 0.0.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e6eef2fbad7521cc39b410ff331dfdc196f7af1b2af9e4152a08525f8bd77a0d [INFO] running `Command { std: "docker" "start" "-a" "e6eef2fbad7521cc39b410ff331dfdc196f7af1b2af9e4152a08525f8bd77a0d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e6eef2fbad7521cc39b410ff331dfdc196f7af1b2af9e4152a08525f8bd77a0d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e6eef2fbad7521cc39b410ff331dfdc196f7af1b2af9e4152a08525f8bd77a0d", kill_on_drop: false }` [INFO] [stdout] e6eef2fbad7521cc39b410ff331dfdc196f7af1b2af9e4152a08525f8bd77a0d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 36c8b85a580346714f2a8639500fc4330f342c6119c8129cb72b0e3ad266667f [INFO] running `Command { std: "docker" "start" "-a" "36c8b85a580346714f2a8639500fc4330f342c6119c8129cb72b0e3ad266667f", kill_on_drop: false }` [INFO] [stderr] Checking libc v0.2.36 [INFO] [stderr] Checking unicode-width v0.1.4 [INFO] [stderr] Checking ansi_term v0.10.2 [INFO] [stderr] Checking vec_map v0.8.0 [INFO] [stderr] Checking bitflags v1.0.1 [INFO] [stderr] Checking strsim v0.6.0 [INFO] [stderr] Checking assert_matches v1.1.0 [INFO] [stderr] Checking textwrap v0.9.0 [INFO] [stderr] Checking atty v0.2.6 [INFO] [stderr] Checking clap v2.29.1 [INFO] [stderr] Checking nbtscanner v0.0.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/thread_pool.rs:71:16 [INFO] [stdout] | [INFO] [stdout] 71 | type Job = Box; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 71 | type Job = Box; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/thread_pool.rs:71:16 [INFO] [stdout] | [INFO] [stdout] 71 | type Job = Box; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 71 | type Job = Box; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `core::str::::trim_right`: superseded by `trim_end` [INFO] [stdout] --> src/nbt_packet.rs:46:43 [INFO] [stdout] | [INFO] [stdout] 46 | Ok(name) => String::from(name.trim_right()), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] help: replace the use of the deprecated method [INFO] [stdout] | [INFO] [stdout] 46 | Ok(name) => String::from(name.trim_end()), [INFO] [stdout] | ~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `core::str::::trim_right`: superseded by `trim_end` [INFO] [stdout] --> src/nbt_packet.rs:61:65 [INFO] [stdout] | [INFO] [stdout] 61 | let trimmed_group = group.trim_matches('\u{0}').trim_right(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: replace the use of the deprecated method [INFO] [stdout] | [INFO] [stdout] 61 | let trimmed_group = group.trim_matches('\u{0}').trim_end(); [INFO] [stdout] | ~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `core::str::::trim_right`: superseded by `trim_end` [INFO] [stdout] --> src/nbt_packet.rs:46:43 [INFO] [stdout] | [INFO] [stdout] 46 | Ok(name) => String::from(name.trim_right()), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] help: replace the use of the deprecated method [INFO] [stdout] | [INFO] [stdout] 46 | Ok(name) => String::from(name.trim_end()), [INFO] [stdout] | ~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `core::str::::trim_right`: superseded by `trim_end` [INFO] [stdout] --> src/nbt_packet.rs:61:65 [INFO] [stdout] | [INFO] [stdout] 61 | let trimmed_group = group.trim_matches('\u{0}').trim_right(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: replace the use of the deprecated method [INFO] [stdout] | [INFO] [stdout] 61 | let trimmed_group = group.trim_matches('\u{0}').trim_end(); [INFO] [stdout] | ~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `id` is never read [INFO] [stdout] --> src/thread_pool.rs:74:5 [INFO] [stdout] | [INFO] [stdout] 73 | struct Worker { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 74 | id: usize, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:70:19 [INFO] [stdout] | [INFO] [stdout] 47 | let socket = UdpSocket::bind("0.0.0.0:0").expect("Couldn't bind UDP socket"); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | match socket.recv(&mut buf) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `actual` [INFO] [stdout] --> src/nbt_packet.rs:124:13 [INFO] [stdout] | [INFO] [stdout] 124 | let actual = NetBiosPacket::from(Ipv4Addr::from([127, 0, 0, 1]), data, 175 as usize); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_actual` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `expected` [INFO] [stdout] --> src/nbt_packet.rs:256:13 [INFO] [stdout] | [INFO] [stdout] 256 | let expected = "SHARING"; [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_expected` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `actual` [INFO] [stdout] --> src/nbt_packet.rs:257:13 [INFO] [stdout] | [INFO] [stdout] 257 | let actual = NetBiosPacket::from(Ipv4Addr::from([127, 0, 0, 1]), data, 175 as usize); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_actual` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `id` is never read [INFO] [stdout] --> src/thread_pool.rs:74:5 [INFO] [stdout] | [INFO] [stdout] 73 | struct Worker { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 74 | id: usize, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:70:19 [INFO] [stdout] | [INFO] [stdout] 47 | let socket = UdpSocket::bind("0.0.0.0:0").expect("Couldn't bind UDP socket"); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | match socket.recv(&mut buf) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/thread_pool.rs:48:13 [INFO] [stdout] | [INFO] [stdout] 48 | self.sender.send(Message::Terminate); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 48 | let _ = self.sender.send(Message::Terminate); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/thread_pool.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 113 | fn join(self) -> Vec { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | self.thread.join().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/thread_pool.rs:48:13 [INFO] [stdout] | [INFO] [stdout] 48 | self.sender.send(Message::Terminate); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 48 | let _ = self.sender.send(Message::Terminate); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/thread_pool.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 113 | fn join(self) -> Vec { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | self.thread.join().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nbtscanner` (lib) due to 3 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `nbtscanner` (lib test) due to 3 previous errors; 8 warnings emitted [INFO] running `Command { std: "docker" "inspect" "36c8b85a580346714f2a8639500fc4330f342c6119c8129cb72b0e3ad266667f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "36c8b85a580346714f2a8639500fc4330f342c6119c8129cb72b0e3ad266667f", kill_on_drop: false }` [INFO] [stdout] 36c8b85a580346714f2a8639500fc4330f342c6119c8129cb72b0e3ad266667f