[INFO] fetching crate nbib 0.1.1... [INFO] checking nbib-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate nbib 0.1.1 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate nbib 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate nbib 0.1.1 [INFO] finished tweaking crates.io crate nbib 0.1.1 [INFO] tweaked toml for crates.io crate nbib 0.1.1 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 11 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3b82d59297f6f0a4b13613b869c5e8b2073555c7d75ab897943c147fc193a3d0 [INFO] running `Command { std: "docker" "start" "-a" "3b82d59297f6f0a4b13613b869c5e8b2073555c7d75ab897943c147fc193a3d0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3b82d59297f6f0a4b13613b869c5e8b2073555c7d75ab897943c147fc193a3d0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3b82d59297f6f0a4b13613b869c5e8b2073555c7d75ab897943c147fc193a3d0", kill_on_drop: false }` [INFO] [stdout] 3b82d59297f6f0a4b13613b869c5e8b2073555c7d75ab897943c147fc193a3d0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9db1fca6812ec1867ddaed846abefa8584088017bfbe52f8a8c3f4931092bad2 [INFO] running `Command { std: "docker" "start" "-a" "9db1fca6812ec1867ddaed846abefa8584088017bfbe52f8a8c3f4931092bad2", kill_on_drop: false }` [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking nbib v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `BufReader` and `self` [INFO] [stdout] --> src/lib.rs:2:15 [INFO] [stdout] | [INFO] [stdout] 2 | use std::io::{self, prelude::*, BufReader}; [INFO] [stdout] | ^^^^ ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `BufReader` and `self` [INFO] [stdout] --> src/lib.rs:2:15 [INFO] [stdout] | [INFO] [stdout] 2 | use std::io::{self, prelude::*, BufReader}; [INFO] [stdout] | ^^^^ ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `SerializeSeq` [INFO] [stdout] --> src/types.rs:2:30 [INFO] [stdout] | [INFO] [stdout] 2 | use serde::ser::{Serializer, SerializeSeq, SerializeMap}; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `prelude` [INFO] [stdout] --> src/lib.rs:2:21 [INFO] [stdout] | [INFO] [stdout] 2 | use std::io::{self, prelude::*, BufReader}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `SerializeSeq` [INFO] [stdout] --> src/types.rs:2:30 [INFO] [stdout] | [INFO] [stdout] 2 | use serde::ser::{Serializer, SerializeSeq, SerializeMap}; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:24:8 [INFO] [stdout] | [INFO] [stdout] 9 | pub fn nbib_to_csl_items(mut input: impl std::io::Read) -> Result, String> [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | Ok(transforms::into_csl_items(range).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn nbib_to_csljson(mut input: impl std::io::Read) -> Result [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | let range = transforms::into_csl_items(range); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | [INFO] [stdout] 44 | / serde_json::to_string( [INFO] [stdout] 45 | | &transforms::to_json(range).map_err(|e|e.to_string())? [INFO] [stdout] 46 | | ).map_err(|e|e.to_string()) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transforms.rs:88:5 [INFO] [stdout] | [INFO] [stdout] 84 | pub fn medline_to_csl<'a, I>(range: I) -> impl Iterator> [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | / range.map(|row|{ [INFO] [stdout] 89 | | // Format: "XXXX- The quick brown fox jumped..." [INFO] [stdout] 90 | | // where XXXX of length 1-4 and right-padded [INFO] [stdout] 91 | | if row.chars().count() < 7 { [INFO] [stdout] ... | [INFO] [stdout] 107 | | process_tag(key, value) [INFO] [stdout] 108 | | }).filter(|x| { [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `matchingNames` should have a snake case name [INFO] [stdout] --> src/types.rs:66:17 [INFO] [stdout] | [INFO] [stdout] 66 | let matchingNames = self.names.iter() [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `matching_names` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/groupby.rs:48:14 [INFO] [stdout] | [INFO] [stdout] 35 | let mut arr: Vec = Vec::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | Some(arr.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:56:13 [INFO] [stdout] | [INFO] [stdout] 56 | let mut input = String::from(r#"PMID- 12345 [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nbib` (lib) due to 5 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:24:8 [INFO] [stdout] | [INFO] [stdout] 9 | pub fn nbib_to_csl_items(mut input: impl std::io::Read) -> Result, String> [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | Ok(transforms::into_csl_items(range).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn nbib_to_csljson(mut input: impl std::io::Read) -> Result [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | let range = transforms::into_csl_items(range); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | [INFO] [stdout] 44 | / serde_json::to_string( [INFO] [stdout] 45 | | &transforms::to_json(range).map_err(|e|e.to_string())? [INFO] [stdout] 46 | | ).map_err(|e|e.to_string()) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transforms.rs:88:5 [INFO] [stdout] | [INFO] [stdout] 84 | pub fn medline_to_csl<'a, I>(range: I) -> impl Iterator> [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | / range.map(|row|{ [INFO] [stdout] 89 | | // Format: "XXXX- The quick brown fox jumped..." [INFO] [stdout] 90 | | // where XXXX of length 1-4 and right-padded [INFO] [stdout] 91 | | if row.chars().count() < 7 { [INFO] [stdout] ... | [INFO] [stdout] 107 | | process_tag(key, value) [INFO] [stdout] 108 | | }).filter(|x| { [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `matchingNames` should have a snake case name [INFO] [stdout] --> src/types.rs:66:17 [INFO] [stdout] | [INFO] [stdout] 66 | let matchingNames = self.names.iter() [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `matching_names` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/groupby.rs:48:14 [INFO] [stdout] | [INFO] [stdout] 35 | let mut arr: Vec = Vec::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | Some(arr.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nbib` (lib test) due to 5 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "9db1fca6812ec1867ddaed846abefa8584088017bfbe52f8a8c3f4931092bad2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9db1fca6812ec1867ddaed846abefa8584088017bfbe52f8a8c3f4931092bad2", kill_on_drop: false }` [INFO] [stdout] 9db1fca6812ec1867ddaed846abefa8584088017bfbe52f8a8c3f4931092bad2