[INFO] fetching crate natsclient 0.0.7... [INFO] checking natsclient-0.0.7 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate natsclient 0.0.7 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate natsclient 0.0.7 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate natsclient 0.0.7 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate natsclient 0.0.7 [INFO] tweaked toml for crates.io crate natsclient 0.0.7 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate natsclient 0.0.7 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 64d304321ff73248ea7903b3046011f7ed4d2087351386fefbf046c8f29fac75 [INFO] running `Command { std: "docker" "start" "-a" "64d304321ff73248ea7903b3046011f7ed4d2087351386fefbf046c8f29fac75", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "64d304321ff73248ea7903b3046011f7ed4d2087351386fefbf046c8f29fac75", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "64d304321ff73248ea7903b3046011f7ed4d2087351386fefbf046c8f29fac75", kill_on_drop: false }` [INFO] [stdout] 64d304321ff73248ea7903b3046011f7ed4d2087351386fefbf046c8f29fac75 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 222b861d0f3911a0358412779a239b330ecdc453d179d9a0b14ef5183424f6fe [INFO] running `Command { std: "docker" "start" "-a" "222b861d0f3911a0358412779a239b330ecdc453d179d9a0b14ef5183424f6fe", kill_on_drop: false }` [INFO] [stderr] Checking spin v0.5.0 [INFO] [stderr] Compiling autocfg v0.1.7 [INFO] [stderr] Compiling typenum v1.10.0 [INFO] [stderr] Compiling libc v0.2.60 [INFO] [stderr] Checking rand_core v0.4.0 [INFO] [stderr] Checking cfg-if v0.1.9 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Compiling cc v1.0.37 [INFO] [stderr] Compiling proc-macro2 v1.0.6 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling memchr v2.2.1 [INFO] [stderr] Compiling syn v1.0.11 [INFO] [stderr] Checking byte-tools v0.3.1 [INFO] [stderr] Compiling subtle v2.2.2 [INFO] [stderr] Compiling arrayvec v0.4.11 [INFO] [stderr] Compiling log v0.4.10 [INFO] [stderr] Checking block-padding v0.1.4 [INFO] [stderr] Compiling fnv v1.0.6 [INFO] [stderr] Checking lazy_static v1.3.0 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Compiling strsim v0.9.3 [INFO] [stderr] Compiling memoffset v0.5.3 [INFO] [stderr] Compiling ryu v1.0.0 [INFO] [stderr] Compiling serde v1.0.97 [INFO] [stderr] Checking ppv-lite86 v0.2.6 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking zeroize v1.1.0 [INFO] [stderr] Checking fake-simd v0.1.2 [INFO] [stderr] Compiling syn v0.15.39 [INFO] [stderr] Checking opaque-debug v0.2.2 [INFO] [stderr] Compiling crossbeam-utils v0.7.0 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Checking nodrop v0.1.13 [INFO] [stderr] Checking aho-corasick v0.7.6 [INFO] [stderr] Compiling crossbeam-epoch v0.8.0 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Checking subtle-encoding v0.4.1 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Checking crossbeam-utils v0.6.5 [INFO] [stderr] Checking memoffset v0.2.1 [INFO] [stderr] Checking smallvec v0.6.10 [INFO] [stderr] Checking regex-syntax v0.6.17 [INFO] [stderr] Checking failure v0.1.7 [INFO] [stderr] Compiling generic-array v0.12.3 [INFO] [stderr] Checking matches v0.1.8 [INFO] [stderr] Checking c2-chacha v0.2.3 [INFO] [stderr] Checking unicode-normalization v0.1.8 [INFO] [stderr] Checking unicode-bidi v0.3.4 [INFO] [stderr] Compiling digest v0.8.1 [INFO] [stderr] Checking crossbeam-epoch v0.7.1 [INFO] [stderr] Checking getrandom v0.1.6 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Compiling clear_on_drop v0.2.3 [INFO] [stderr] Compiling nom v4.2.3 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand_jitter v0.1.4 [INFO] [stderr] Compiling derive_builder v0.9.0 [INFO] [stderr] Checking quick-error v1.2.2 [INFO] [stderr] Checking itoa v0.4.4 [INFO] [stderr] Checking scopeguard v1.0.0 [INFO] [stderr] Checking crossbeam-deque v0.7.1 [INFO] [stderr] Checking rand_chacha v0.2.1 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking atty v0.2.13 [INFO] [stderr] Checking crossbeam-channel v0.4.2 [INFO] [stderr] Checking block-buffer v0.7.3 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking crossbeam-queue v0.2.0 [INFO] [stderr] Checking termcolor v1.0.5 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Checking data-encoding v2.2.0 [INFO] [stderr] Compiling curve25519-dalek v1.2.3 [INFO] [stderr] Checking signature v1.0.0-pre.1 [INFO] [stderr] Checking sha2 v0.8.0 [INFO] [stderr] Checking ed25519 v1.0.0-pre.1 [INFO] [stderr] Checking crossbeam v0.7.3 [INFO] [stderr] Checking signatory v0.18.1 [INFO] [stderr] Checking idna v0.2.0 [INFO] [stderr] Checking nuid v0.2.1 [INFO] [stderr] Checking url v2.1.1 [INFO] [stderr] Checking regex v1.3.5 [INFO] [stderr] Compiling serde_derive v1.0.97 [INFO] [stderr] Checking ed25519-dalek v1.0.0-pre.2 [INFO] [stderr] Checking signatory-dalek v0.18.1 [INFO] [stderr] Checking nkeys v0.0.9 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking pretty_env_logger v0.4.0 [INFO] [stderr] Checking serde_json v1.0.40 [INFO] [stderr] Compiling darling_core v0.10.2 [INFO] [stderr] Checking nats-types v0.1.8 [INFO] [stderr] Compiling darling_macro v0.10.2 [INFO] [stderr] Compiling darling v0.10.2 [INFO] [stderr] Compiling derive_builder_core v0.9.0 [INFO] [stderr] Checking natsclient v0.0.7 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/error.rs:167:56 [INFO] [stdout] | [INFO] [stdout] 167 | Some(ref desc) => write!(f, "{}: {}", self.description(), desc), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/error.rs:168:42 [INFO] [stdout] | [INFO] [stdout] 168 | None => write!(f, "{}", self.description()), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/error.rs:167:56 [INFO] [stdout] | [INFO] [stdout] 167 | Some(ref desc) => write!(f, "{}: {}", self.description(), desc), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/error.rs:168:42 [INFO] [stdout] | [INFO] [stdout] 168 | None => write!(f, "{}", self.description()), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:114:12 [INFO] [stdout] | [INFO] [stdout] 106 | let (ds, dr) = channel::unbounded(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | let (ws, wr) = channel::unbounded(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | Ok(Client { [INFO] [stdout] | ____________^ [INFO] [stdout] 115 | | inbox_wildcard: format!("_INBOX.{}.*", &id), [INFO] [stdout] 116 | | id: id.clone(), [INFO] [stdout] 117 | | opts, [INFO] [stdout] ... | [INFO] [stdout] 124 | | write_receiver: wr, [INFO] [stdout] 125 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:146:43 [INFO] [stdout] | [INFO] [stdout] 141 | pub fn subscribe(&self, subject: &str, handler: F) -> Result<()> [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 146 | self.raw_subscribe(subject, None, Arc::new(handler)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:157:56 [INFO] [stdout] | [INFO] [stdout] 152 | pub fn queue_subscribe(&self, subject: &str, queue_group: &str, handler: F) -> Result<()> [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 157 | self.raw_subscribe(subject, Some(queue_group), Arc::new(handler)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:239:44 [INFO] [stdout] | [INFO] [stdout] 206 | let (s, r) = bounded(1); // Create a thread block until we send the CONNECT preamble [INFO] [stdout] | - - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 207 | [INFO] [stdout] 208 | let tcp_client = TcpClient::new( [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 227 | let mgr = self.submgr.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 239 | self.start_subscription_dispatcher(self.delivery_receiver.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/subs.rs:33:19 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn new(client_id: String, sender: channel::Sender>) -> SubscriptionManager { [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | subs: Arc::new(RwLock::new(HashMap::new())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/subs.rs:35:26 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn new(client_id: String, sender: channel::Sender>) -> SubscriptionManager { [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | current_sid: Arc::new(AtomicUsize::new(1)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/subs.rs:36:22 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn new(client_id: String, sender: channel::Sender>) -> SubscriptionManager { [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | inboxes: Arc::new(RwLock::new(HashMap::new())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/subs.rs:99:12 [INFO] [stdout] | [INFO] [stdout] 98 | let subs = self.subs.read().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | Ok(subs[&sid].handler.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tcp.rs:35:27 [INFO] [stdout] | [INFO] [stdout] 28 | delivery_sender: Sender, [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | write_sender: Sender>, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | write_receiver: Receiver>, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | opts: ClientOptions, [INFO] [stdout] 32 | connlatch: Sender, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | connect_urls: Arc::new(RwLock::new(connect_urls)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `natsclient` (lib) due to 10 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:114:12 [INFO] [stdout] | [INFO] [stdout] 106 | let (ds, dr) = channel::unbounded(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | let (ws, wr) = channel::unbounded(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | Ok(Client { [INFO] [stdout] | ____________^ [INFO] [stdout] 115 | | inbox_wildcard: format!("_INBOX.{}.*", &id), [INFO] [stdout] 116 | | id: id.clone(), [INFO] [stdout] 117 | | opts, [INFO] [stdout] ... | [INFO] [stdout] 124 | | write_receiver: wr, [INFO] [stdout] 125 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:146:43 [INFO] [stdout] | [INFO] [stdout] 141 | pub fn subscribe(&self, subject: &str, handler: F) -> Result<()> [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 146 | self.raw_subscribe(subject, None, Arc::new(handler)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:157:56 [INFO] [stdout] | [INFO] [stdout] 152 | pub fn queue_subscribe(&self, subject: &str, queue_group: &str, handler: F) -> Result<()> [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 157 | self.raw_subscribe(subject, Some(queue_group), Arc::new(handler)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:239:44 [INFO] [stdout] | [INFO] [stdout] 206 | let (s, r) = bounded(1); // Create a thread block until we send the CONNECT preamble [INFO] [stdout] | - - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 207 | [INFO] [stdout] 208 | let tcp_client = TcpClient::new( [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 227 | let mgr = self.submgr.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 239 | self.start_subscription_dispatcher(self.delivery_receiver.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/subs.rs:33:19 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn new(client_id: String, sender: channel::Sender>) -> SubscriptionManager { [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | subs: Arc::new(RwLock::new(HashMap::new())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/subs.rs:35:26 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn new(client_id: String, sender: channel::Sender>) -> SubscriptionManager { [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | current_sid: Arc::new(AtomicUsize::new(1)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/subs.rs:36:22 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn new(client_id: String, sender: channel::Sender>) -> SubscriptionManager { [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | inboxes: Arc::new(RwLock::new(HashMap::new())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/subs.rs:99:12 [INFO] [stdout] | [INFO] [stdout] 98 | let subs = self.subs.read().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | Ok(subs[&sid].handler.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tcp.rs:35:27 [INFO] [stdout] | [INFO] [stdout] 28 | delivery_sender: Sender, [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | write_sender: Sender>, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | write_receiver: Receiver>, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | opts: ClientOptions, [INFO] [stdout] 32 | connlatch: Sender, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | connect_urls: Arc::new(RwLock::new(connect_urls)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `natsclient` (lib test) due to 10 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "222b861d0f3911a0358412779a239b330ecdc453d179d9a0b14ef5183424f6fe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "222b861d0f3911a0358412779a239b330ecdc453d179d9a0b14ef5183424f6fe", kill_on_drop: false }` [INFO] [stdout] 222b861d0f3911a0358412779a239b330ecdc453d179d9a0b14ef5183424f6fe