[INFO] fetching crate nash-mpc 1.2.4... [INFO] checking nash-mpc-1.2.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate nash-mpc 1.2.4 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate nash-mpc 1.2.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate nash-mpc 1.2.4 [INFO] finished tweaking crates.io crate nash-mpc 1.2.4 [INFO] tweaked toml for crates.io crate nash-mpc 1.2.4 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 123 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding block-buffer v0.9.0 (latest: v0.10.4) [INFO] [stderr] Adding clap v2.34.0 (latest: v4.5.16) [INFO] [stderr] Adding const-oid v0.6.2 (latest: v0.9.6) [INFO] [stderr] Adding criterion v0.3.6 (latest: v0.5.1) [INFO] [stderr] Adding criterion-plot v0.4.5 (latest: v0.5.0) [INFO] [stderr] Adding crypto-bigint v0.2.11 (latest: v0.5.5) [INFO] [stderr] Adding der v0.4.5 (latest: v0.7.9) [INFO] [stderr] Adding digest v0.9.0 (latest: v0.10.7) [INFO] [stderr] Adding ecdsa v0.12.4 (latest: v0.16.9) [INFO] [stderr] Adding elliptic-curve v0.10.6 (latest: v0.13.8) [INFO] [stderr] Adding ff v0.10.1 (latest: v0.13.0) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding group v0.10.0 (latest: v0.13.0) [INFO] [stderr] Adding half v1.8.3 (latest: v2.4.1) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding hmac v0.11.0 (latest: v0.12.1) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding k256 v0.9.6 (latest: v0.13.3) [INFO] [stderr] Adding p256 v0.9.0 (latest: v0.13.2) [INFO] [stderr] Adding pkcs8 v0.7.6 (latest: v0.10.2) [INFO] [stderr] Adding secp256k1 v0.20.3 (latest: v0.29.0) [INFO] [stderr] Adding secp256k1-sys v0.4.2 (latest: v0.10.0) [INFO] [stderr] Adding sha2 v0.9.9 (latest: v0.10.8) [INFO] [stderr] Adding signature v1.3.2 (latest: v2.2.0) [INFO] [stderr] Adding spki v0.4.1 (latest: v0.7.3) [INFO] [stderr] Adding subtle v2.4.1 (latest: v2.6.1) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding zeroize v1.4.3 (latest: v1.8.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 81f06d42c59f1426ec85edba266af93b64a37abca2af63ec1f17483254921dbc [INFO] running `Command { std: "docker" "start" "-a" "81f06d42c59f1426ec85edba266af93b64a37abca2af63ec1f17483254921dbc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "81f06d42c59f1426ec85edba266af93b64a37abca2af63ec1f17483254921dbc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "81f06d42c59f1426ec85edba266af93b64a37abca2af63ec1f17483254921dbc", kill_on_drop: false }` [INFO] [stdout] 81f06d42c59f1426ec85edba266af93b64a37abca2af63ec1f17483254921dbc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2a44cf2460fee3e9f7c3b571d1e74bb8d4240e563a3792944b9c49e0df13533a [INFO] running `Command { std: "docker" "start" "-a" "2a44cf2460fee3e9f7c3b571d1e74bb8d4240e563a3792944b9c49e0df13533a", kill_on_drop: false }` [INFO] [stderr] Checking subtle v2.4.1 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking const-oid v0.6.2 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking zeroize v1.4.3 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking plotters-backend v0.3.6 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking half v1.8.3 [INFO] [stderr] Checking crypto-mac v0.11.1 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking der v0.4.5 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking hmac v0.11.0 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking plotters-svg v0.3.6 [INFO] [stderr] Checking ff v0.10.1 [INFO] [stderr] Checking crypto-bigint v0.2.11 [INFO] [stderr] Checking signature v1.3.2 [INFO] [stderr] Checking group v0.10.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking crossbeam-queue v0.3.11 [INFO] [stderr] Checking spki v0.4.1 [INFO] [stderr] Checking pkcs8 v0.7.6 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking elliptic-curve v0.10.6 [INFO] [stderr] Checking plotters v0.3.6 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking criterion-plot v0.4.5 [INFO] [stderr] Checking ecdsa v0.12.4 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking p256 v0.9.0 [INFO] [stderr] Checking k256 v0.9.6 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking rust-gmp-kzen v0.5.1 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking rust-bigint v1.2.0 [INFO] [stderr] Checking paillier-common v0.2.0 [INFO] [stderr] Checking nash-mpc v1.2.4 (/opt/rustwide/workdir) [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:77:12 [INFO] [stdout] | [INFO] [stdout] 72 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | Ok(APIchildkeyCreator { [INFO] [stdout] | ____________^ [INFO] [stdout] 78 | | secret_key: self.secret_key, [INFO] [stdout] 79 | | paillier_pk: Some(paillier_pk.clone()), [INFO] [stdout] 80 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:212:8 [INFO] [stdout] | [INFO] [stdout] 167 | let rx: BigInt; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 168 | let q: BigInt; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 169 | let mut k: BigInt; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 170 | let r: BigInt; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 205 | let mut rn = match POOL_PAILLIER.pop() { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 206 | Option::Some(val) => val, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 209 | let c3 = compute_presig_curveindependent(api_childkey, msg_hash, &rx, &q, &k, &rn); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 212 | Ok((c3, r)) [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:244:5 [INFO] [stdout] | [INFO] [stdout] 223 | let rho = BigInt::sample_below(&q.pow(2u32)); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 224 | let mut k_inv = BigInt::mod_inv(k, q); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 225 | let partial_sig = rho * q + BigInt::mod_mul(&k_inv, msg_hash, q); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 226 | let mut rn_ = PrecomputedRandomness(rn.clone()); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 227 | let c1 = Paillier::encrypt_with_chosen_randomness( [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 233 | let v = BigInt::mod_mul( [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 239 | let c2 = Paillier::mul( [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 244 | / Paillier::add(&api_childkey.paillier_pk, c2, c1) [INFO] [stdout] 245 | | .0 [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common.rs:199:64 [INFO] [stdout] | [INFO] [stdout] 102 | let pk_int = match BigInt::from_hex(pubkey_str) { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | Ok(v) => v, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | let q: BigInt; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | let u1_plus_u2: BigInt; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 199 | rx_bytes.ct_eq(&u1_plus_u2_bytes).unwrap_u8() == 1 && s < &(q - s.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nash-mpc` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "2a44cf2460fee3e9f7c3b571d1e74bb8d4240e563a3792944b9c49e0df13533a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2a44cf2460fee3e9f7c3b571d1e74bb8d4240e563a3792944b9c49e0df13533a", kill_on_drop: false }` [INFO] [stdout] 2a44cf2460fee3e9f7c3b571d1e74bb8d4240e563a3792944b9c49e0df13533a