[INFO] fetching crate napi_async_local 0.2.0... [INFO] checking napi_async_local-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate napi_async_local 0.2.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate napi_async_local 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate napi_async_local 0.2.0 [INFO] finished tweaking crates.io crate napi_async_local 0.2.0 [INFO] tweaked toml for crates.io crate napi_async_local 0.2.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 39 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a0a1f663410860a97f6e6337dd29e0107a1ed04a27c22fd07303a16ea73b86a9 [INFO] running `Command { std: "docker" "start" "-a" "a0a1f663410860a97f6e6337dd29e0107a1ed04a27c22fd07303a16ea73b86a9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a0a1f663410860a97f6e6337dd29e0107a1ed04a27c22fd07303a16ea73b86a9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a0a1f663410860a97f6e6337dd29e0107a1ed04a27c22fd07303a16ea73b86a9", kill_on_drop: false }` [INFO] [stdout] a0a1f663410860a97f6e6337dd29e0107a1ed04a27c22fd07303a16ea73b86a9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b4cafe979e36f395c0717b30011003e796eb5d803df641b2a70a8d290ee70aa3 [INFO] running `Command { std: "docker" "start" "-a" "b4cafe979e36f395c0717b30011003e796eb5d803df641b2a70a8d290ee70aa3", kill_on_drop: false }` [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking napi-sys v2.4.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling ctor v0.2.8 [INFO] [stderr] Checking napi v2.16.9 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking napi_async_local v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variant `Object` is never constructed [INFO] [stdout] --> src/js_rc/root.rs:17:3 [INFO] [stdout] | [INFO] [stdout] 16 | pub enum RootObjectType { [INFO] [stdout] | -------------- variant in this enum [INFO] [stdout] 17 | Object, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `count` is never read [INFO] [stdout] --> src/js_rc/root.rs:24:7 [INFO] [stdout] | [INFO] [stdout] 22 | pub struct RootRef { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] 23 | pub raw_ref: sys::napi_ref, [INFO] [stdout] 24 | pub count: Arc, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RootRef` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new_object`, `clone`, and `get` are never used [INFO] [stdout] --> src/js_rc/root.rs:33:10 [INFO] [stdout] | [INFO] [stdout] 28 | impl RootRef { [INFO] [stdout] | ------------ associated items in this implementation [INFO] [stdout] ... [INFO] [stdout] 33 | pub fn new_object(env: &Env) -> napi::Result { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 92 | pub fn clone( [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 105 | pub fn get( [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/js_rc/js_rc.rs:89:8 [INFO] [stdout] | [INFO] [stdout] 87 | value: T, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | ) -> napi::Result { [INFO] [stdout] 89 | Ok(Self { [INFO] [stdout] | ________^ [INFO] [stdout] 90 | | count: Rc::new(RefCell::new(1)), [INFO] [stdout] 91 | | identifier: Rc::new(store::set_store_value(env, value)?), [INFO] [stdout] 92 | | kind: Default::default(), [INFO] [stdout] 93 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/js_rc/js_rc.rs:102:8 [INFO] [stdout] | [INFO] [stdout] 101 | let value = store::get_store_value::(env, &self.identifier)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | Ok(JsRcRef { [INFO] [stdout] | ________^ [INFO] [stdout] 103 | | inner: value, [INFO] [stdout] 104 | | _env: env, [INFO] [stdout] 105 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/js_rc/root.rs:73:8 [INFO] [stdout] | [INFO] [stdout] 48 | let count = Arc::new(AtomicU32::new(1)); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | let mut tsfn = env.create_threadsafe_function::<(), JsUnknown, _>(&jsfn, 0, { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | let count = count.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | Ok(RootRef { [INFO] [stdout] | ________^ [INFO] [stdout] 74 | | raw_ref, [INFO] [stdout] 75 | | count, [INFO] [stdout] 76 | | dropper: Arc::new(tsfn), [INFO] [stdout] 77 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/js_rc/store.rs:50:15 [INFO] [stdout] | [INFO] [stdout] 20 | func: F, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | GLOBAL.with(move |inner| -> napi::Result { [INFO] [stdout] | _______________^ [INFO] [stdout] 51 | | let global_ref = inner.get_or_try_init(move || RootRef::new_array(env))?; [INFO] [stdout] 52 | | func(global_ref) [INFO] [stdout] 53 | | }) [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/js_rc/store.rs:60:20 [INFO] [stdout] | [INFO] [stdout] 58 | value: impl NapiValue, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | ) -> napi::Result { [INFO] [stdout] 60 | with_global(env, |global_ref| { [INFO] [stdout] | ____________________^ [INFO] [stdout] 61 | | let store = global_ref.into_inner(&env)?; [INFO] [stdout] 62 | | [INFO] [stdout] 63 | | let push: JsFunction = store.get_named_property_unchecked("push")?; [INFO] [stdout] 64 | | let length = JsNumber::from_unknown(push.call(Some(&store), &[value])?)?; [INFO] [stdout] 65 | | Ok(length.get_int32()? - 1) [INFO] [stdout] 66 | | }) [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime/executor/local_pool.rs:123:18 [INFO] [stdout] | [INFO] [stdout] 121 | thread_notify: Arc, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 122 | ) -> bool { [INFO] [stdout] 123 | run_executor(thread_notify.clone(), |cx| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime/runtime.rs:13:76 [INFO] [stdout] | [INFO] [stdout] 13 | static SPAWNER: Lazy = Lazy::new(|| LOCAL_POOL.with(|ex| ex.borrow().spawner())); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime/runtime.rs:28:24 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn queue_future(future: impl Future + 'static) { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | ls.spawn_local(async move { [INFO] [stdout] | ________________________^ [INFO] [stdout] 29 | | future.await; [INFO] [stdout] 30 | | Self::decrement(); [INFO] [stdout] 31 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime/runtime.rs:37:31 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn run_until_stalled(thread_notify: ThreadNotifyRef) -> bool { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | LOCAL_POOL.with(move |lp| lp.borrow_mut().run_until_stalled(thread_notify)); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime/runtime.rs:46:29 [INFO] [stdout] | [INFO] [stdout] 46 | FUTURES_COUNT.with(|c| *c.borrow_mut()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spawn_local/spawn_local.rs:37:22 [INFO] [stdout] | [INFO] [stdout] 30 | callback: F, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | env.create_promise(Box::new(move |env, resolve_func, reject_func| { [INFO] [stdout] | ______________________^ [INFO] [stdout] 38 | | let future = callback(env); [INFO] [stdout] 39 | | runtime::spawn_async_local(&env, async move { [INFO] [stdout] 40 | | match future.await { [INFO] [stdout] ... | [INFO] [stdout] 44 | | }) [INFO] [stdout] 45 | | })) [INFO] [stdout] | |____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spawn_local/spawn_local.rs:39:38 [INFO] [stdout] | [INFO] [stdout] 30 | callback: F, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | env.create_promise(Box::new(move |env, resolve_func, reject_func| { [INFO] [stdout] | ------------ ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | let future = callback(env); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | runtime::spawn_async_local(&env, async move { [INFO] [stdout] | ______________________________________^ [INFO] [stdout] 40 | | match future.await { [INFO] [stdout] 41 | | Ok(result) => resolve_func(result), [INFO] [stdout] 42 | | Err(error) => reject_func(error), [INFO] [stdout] 43 | | }; [INFO] [stdout] 44 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/create_promise.rs:26:7 [INFO] [stdout] | [INFO] [stdout] 24 | let cell = Cell::new(Some(executor)); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | move |env, res, rej| { [INFO] [stdout] | --- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | / cell [INFO] [stdout] 27 | | .take() [INFO] [stdout] 28 | | .expect("This function should not be called more than once")(env, res, rej) [INFO] [stdout] | |____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Object` is never constructed [INFO] [stdout] --> src/js_rc/root.rs:17:3 [INFO] [stdout] | [INFO] [stdout] 16 | pub enum RootObjectType { [INFO] [stdout] | -------------- variant in this enum [INFO] [stdout] 17 | Object, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `count` is never read [INFO] [stdout] --> src/js_rc/root.rs:24:7 [INFO] [stdout] | [INFO] [stdout] 22 | pub struct RootRef { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] 23 | pub raw_ref: sys::napi_ref, [INFO] [stdout] 24 | pub count: Arc, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RootRef` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new_object`, `clone`, and `get` are never used [INFO] [stdout] --> src/js_rc/root.rs:33:10 [INFO] [stdout] | [INFO] [stdout] 28 | impl RootRef { [INFO] [stdout] | ------------ associated items in this implementation [INFO] [stdout] ... [INFO] [stdout] 33 | pub fn new_object(env: &Env) -> napi::Result { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 92 | pub fn clone( [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 105 | pub fn get( [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/js_rc/js_rc.rs:89:8 [INFO] [stdout] | [INFO] [stdout] 87 | value: T, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | ) -> napi::Result { [INFO] [stdout] 89 | Ok(Self { [INFO] [stdout] | ________^ [INFO] [stdout] 90 | | count: Rc::new(RefCell::new(1)), [INFO] [stdout] 91 | | identifier: Rc::new(store::set_store_value(env, value)?), [INFO] [stdout] 92 | | kind: Default::default(), [INFO] [stdout] 93 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `napi_async_local` (lib test) due to 14 previous errors; 3 warnings emitted [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/js_rc/js_rc.rs:102:8 [INFO] [stdout] | [INFO] [stdout] 101 | let value = store::get_store_value::(env, &self.identifier)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | Ok(JsRcRef { [INFO] [stdout] | ________^ [INFO] [stdout] 103 | | inner: value, [INFO] [stdout] 104 | | _env: env, [INFO] [stdout] 105 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/js_rc/root.rs:73:8 [INFO] [stdout] | [INFO] [stdout] 48 | let count = Arc::new(AtomicU32::new(1)); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | let mut tsfn = env.create_threadsafe_function::<(), JsUnknown, _>(&jsfn, 0, { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | let count = count.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | Ok(RootRef { [INFO] [stdout] | ________^ [INFO] [stdout] 74 | | raw_ref, [INFO] [stdout] 75 | | count, [INFO] [stdout] 76 | | dropper: Arc::new(tsfn), [INFO] [stdout] 77 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/js_rc/store.rs:50:15 [INFO] [stdout] | [INFO] [stdout] 20 | func: F, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | GLOBAL.with(move |inner| -> napi::Result { [INFO] [stdout] | _______________^ [INFO] [stdout] 51 | | let global_ref = inner.get_or_try_init(move || RootRef::new_array(env))?; [INFO] [stdout] 52 | | func(global_ref) [INFO] [stdout] 53 | | }) [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/js_rc/store.rs:60:20 [INFO] [stdout] | [INFO] [stdout] 58 | value: impl NapiValue, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | ) -> napi::Result { [INFO] [stdout] 60 | with_global(env, |global_ref| { [INFO] [stdout] | ____________________^ [INFO] [stdout] 61 | | let store = global_ref.into_inner(&env)?; [INFO] [stdout] 62 | | [INFO] [stdout] 63 | | let push: JsFunction = store.get_named_property_unchecked("push")?; [INFO] [stdout] 64 | | let length = JsNumber::from_unknown(push.call(Some(&store), &[value])?)?; [INFO] [stdout] 65 | | Ok(length.get_int32()? - 1) [INFO] [stdout] 66 | | }) [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime/executor/local_pool.rs:123:18 [INFO] [stdout] | [INFO] [stdout] 121 | thread_notify: Arc, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 122 | ) -> bool { [INFO] [stdout] 123 | run_executor(thread_notify.clone(), |cx| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime/runtime.rs:13:76 [INFO] [stdout] | [INFO] [stdout] 13 | static SPAWNER: Lazy = Lazy::new(|| LOCAL_POOL.with(|ex| ex.borrow().spawner())); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime/runtime.rs:28:24 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn queue_future(future: impl Future + 'static) { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | ls.spawn_local(async move { [INFO] [stdout] | ________________________^ [INFO] [stdout] 29 | | future.await; [INFO] [stdout] 30 | | Self::decrement(); [INFO] [stdout] 31 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime/runtime.rs:37:31 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn run_until_stalled(thread_notify: ThreadNotifyRef) -> bool { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | LOCAL_POOL.with(move |lp| lp.borrow_mut().run_until_stalled(thread_notify)); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime/runtime.rs:46:29 [INFO] [stdout] | [INFO] [stdout] 46 | FUTURES_COUNT.with(|c| *c.borrow_mut()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spawn_local/spawn_local.rs:37:22 [INFO] [stdout] | [INFO] [stdout] 30 | callback: F, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | env.create_promise(Box::new(move |env, resolve_func, reject_func| { [INFO] [stdout] | ______________________^ [INFO] [stdout] 38 | | let future = callback(env); [INFO] [stdout] 39 | | runtime::spawn_async_local(&env, async move { [INFO] [stdout] 40 | | match future.await { [INFO] [stdout] ... | [INFO] [stdout] 44 | | }) [INFO] [stdout] 45 | | })) [INFO] [stdout] | |____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spawn_local/spawn_local.rs:39:38 [INFO] [stdout] | [INFO] [stdout] 30 | callback: F, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | env.create_promise(Box::new(move |env, resolve_func, reject_func| { [INFO] [stdout] | ------------ ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | let future = callback(env); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | runtime::spawn_async_local(&env, async move { [INFO] [stdout] | ______________________________________^ [INFO] [stdout] 40 | | match future.await { [INFO] [stdout] 41 | | Ok(result) => resolve_func(result), [INFO] [stdout] 42 | | Err(error) => reject_func(error), [INFO] [stdout] 43 | | }; [INFO] [stdout] 44 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/create_promise.rs:26:7 [INFO] [stdout] | [INFO] [stdout] 24 | let cell = Cell::new(Some(executor)); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | move |env, res, rej| { [INFO] [stdout] | --- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | / cell [INFO] [stdout] 27 | | .take() [INFO] [stdout] 28 | | .expect("This function should not be called more than once")(env, res, rej) [INFO] [stdout] | |____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `napi_async_local` (lib) due to 14 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "b4cafe979e36f395c0717b30011003e796eb5d803df641b2a70a8d290ee70aa3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b4cafe979e36f395c0717b30011003e796eb5d803df641b2a70a8d290ee70aa3", kill_on_drop: false }` [INFO] [stdout] b4cafe979e36f395c0717b30011003e796eb5d803df641b2a70a8d290ee70aa3