[INFO] fetching crate namaste 0.29.0... [INFO] checking namaste-0.29.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate namaste 0.29.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate namaste 0.29.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate namaste 0.29.0 [INFO] finished tweaking crates.io crate namaste 0.29.0 [INFO] tweaked toml for crates.io crate namaste 0.29.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate namaste 0.29.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 01bd592a4c373874594f46bebf406b602a61b1ee8bcbb3197c2d2015945b1b7b [INFO] running `Command { std: "docker" "start" "-a" "01bd592a4c373874594f46bebf406b602a61b1ee8bcbb3197c2d2015945b1b7b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "01bd592a4c373874594f46bebf406b602a61b1ee8bcbb3197c2d2015945b1b7b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "01bd592a4c373874594f46bebf406b602a61b1ee8bcbb3197c2d2015945b1b7b", kill_on_drop: false }` [INFO] [stdout] 01bd592a4c373874594f46bebf406b602a61b1ee8bcbb3197c2d2015945b1b7b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b217778bfab6a320acdaaaec559465d000f65bfaefbdf8e871be91f9c71cee34 [INFO] running `Command { std: "docker" "start" "-a" "b217778bfab6a320acdaaaec559465d000f65bfaefbdf8e871be91f9c71cee34", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Checking zeros v16.0.4 [INFO] [stderr] Checking blackhole v0.20.2 [INFO] [stderr] Checking dia-args v0.60.2 [INFO] [stderr] Checking cld v0.5.1 [INFO] [stderr] Checking dia-time v9.0.0 [INFO] [stderr] Checking namaste v0.29.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/root/rw_namaste.rs:139:12 [INFO] [stdout] | [INFO] [stdout] 132 | pub fn make(read_id: R, write_id: W, timeout: Duration) -> Result { [INFO] [stdout] | ---------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 139 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 140 | | read_id, [INFO] [stdout] 141 | | write_id, [INFO] [stdout] 142 | | timeout, [INFO] [stdout] 143 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:115:38 [INFO] [stdout] | [INFO] [stdout] 115 | ($kind: path, $($arg: tt)+) => { std::io::Error::new($kind, __!($($arg)+)) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/root/rw_namaste/linux.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | write!(self) [INFO] [stdout] | ------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `err` which comes from the expansion of the macro `write` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/udsx_unix_stream.rs:146:12 [INFO] [stdout] | [INFO] [stdout] 116 | unsafe fn recv_streams(&self, id: B) -> Result<[T; N]> where B: AsRef<[u8]>, T: FromRawFd { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 135 | let mut result = Vec::with_capacity(N); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 146 | Ok(<[T; N]>::try_from(result).map_err(|v| err!("Expected to receive {n} stream{s}, got: {len}", n=N, s=plural_s!(N), len=v.len()))?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/udsx_unix_stream.rs:139:94 [INFO] [stdout] | [INFO] [stdout] 139 | AncillaryData::ScmRights(scm_rights) => scm_rights.for_each(|fd| result.push(T::from_raw_fd(fd))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linux.rs:66:39 [INFO] [stdout] | [INFO] [stdout] 65 | pub (crate) fn make(id: B, clonable: Option) -> Result where B: AsRef<[u8]> { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | Self::make_from_unix_listener(UnixListener::bind_addr(&SocketAddr::from_abstract_name(&id)?)?, clonable) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linux/server_proc/server.rs:77:12 [INFO] [stdout] | [INFO] [stdout] 75 | fn make(listener: UnixListener, clonable: bool, stop_flag: Arc) -> Result { [INFO] [stdout] | ---------------------- -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | let fd = listener.as_raw_fd(); [INFO] [stdout] 77 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 78 | | listener, [INFO] [stdout] 79 | | clonable, [INFO] [stdout] 80 | | stop_flag, [INFO] [stdout] ... | [INFO] [stdout] 84 | | }, [INFO] [stdout] 85 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `namaste` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "b217778bfab6a320acdaaaec559465d000f65bfaefbdf8e871be91f9c71cee34", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b217778bfab6a320acdaaaec559465d000f65bfaefbdf8e871be91f9c71cee34", kill_on_drop: false }` [INFO] [stdout] b217778bfab6a320acdaaaec559465d000f65bfaefbdf8e871be91f9c71cee34