[INFO] fetching crate nakamoto-test 0.4.0... [INFO] checking nakamoto-test-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate nakamoto-test 0.4.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate nakamoto-test 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate nakamoto-test 0.4.0 [INFO] finished tweaking crates.io crate nakamoto-test 0.4.0 [INFO] tweaked toml for crates.io crate nakamoto-test 0.4.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 52 packages to latest compatible versions [INFO] [stderr] Adding bech32 v0.9.1 (latest: v0.11.0) [INFO] [stderr] Adding bitcoin v0.29.2 (latest: v0.32.2) [INFO] [stderr] Adding bitcoin_hashes v0.11.0 (latest: v0.14.0) [INFO] [stderr] Adding colored v1.9.4 (latest: v2.1.0) [INFO] [stderr] Adding fastrand v1.9.0 (latest: v2.1.1) [INFO] [stderr] Adding nonempty v0.7.0 (latest: v0.10.0) [INFO] [stderr] Adding secp256k1 v0.24.3 (latest: v0.29.0) [INFO] [stderr] Adding secp256k1-sys v0.6.1 (latest: v0.10.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `quickcheck` dependency) [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5fce9cf1c6193dd7fca23c749e8eb5923e49aab7bf8b89b63bbed308cfdfa7c8 [INFO] running `Command { std: "docker" "start" "-a" "5fce9cf1c6193dd7fca23c749e8eb5923e49aab7bf8b89b63bbed308cfdfa7c8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5fce9cf1c6193dd7fca23c749e8eb5923e49aab7bf8b89b63bbed308cfdfa7c8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5fce9cf1c6193dd7fca23c749e8eb5923e49aab7bf8b89b63bbed308cfdfa7c8", kill_on_drop: false }` [INFO] [stdout] 5fce9cf1c6193dd7fca23c749e8eb5923e49aab7bf8b89b63bbed308cfdfa7c8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2e963cf521779abb7829a5eb396bc3f2a1f9f5625cc05b0241308175a668a5fb [INFO] running `Command { std: "docker" "start" "-a" "2e963cf521779abb7829a5eb396bc3f2a1f9f5625cc05b0241308175a668a5fb", kill_on_drop: false }` [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `quickcheck` dependency) [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking bitcoin_hashes v0.11.0 [INFO] [stderr] Checking bech32 v0.9.1 [INFO] [stderr] Checking nonempty v0.7.0 [INFO] [stderr] Compiling secp256k1-sys v0.6.1 [INFO] [stderr] Compiling microserde-derive v0.1.13 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking colored v1.9.4 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking microserde v0.1.13 [INFO] [stderr] Checking quickcheck v1.0.3 [INFO] [stderr] Checking nakamoto-net v0.4.0 [INFO] [stderr] Checking secp256k1 v0.24.3 [INFO] [stderr] Checking bitcoin v0.29.2 [INFO] [stderr] Checking nakamoto-common v0.4.0 [INFO] [stderr] Checking nakamoto-test v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: private item shadows public glob re-export [INFO] [stdout] --> src/block.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use nakamoto_common::block::BlockHeader; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the name `BlockHeader` in the type namespace is supposed to be publicly re-exported here [INFO] [stdout] --> src/block.rs:6:9 [INFO] [stdout] | [INFO] [stdout] 6 | pub use nakamoto_common::block::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: but the private item here shadows it [INFO] [stdout] --> src/block.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use nakamoto_common::block::BlockHeader; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(hidden_glob_reexports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: private item shadows public glob re-export [INFO] [stdout] --> src/block.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use nakamoto_common::block::BlockHeader; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the name `BlockHeader` in the type namespace is supposed to be publicly re-exported here [INFO] [stdout] --> src/block.rs:6:9 [INFO] [stdout] | [INFO] [stdout] 6 | pub use nakamoto_common::block::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: but the private item here shadows it [INFO] [stdout] --> src/block.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use nakamoto_common::block::BlockHeader; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(hidden_glob_reexports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/block.rs:364:9 [INFO] [stdout] | [INFO] [stdout] 357 | let mut txmap = HashMap::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 364 | / BlockFilter::new_script_filter(block, |out| { [INFO] [stdout] 365 | | if let Some(s) = txmap.get(out) { [INFO] [stdout] 366 | | Ok(s.clone()) [INFO] [stdout] 367 | | } else { [INFO] [stdout] 368 | | Err(bip158::Error::UtxoMissing(*out)) [INFO] [stdout] 369 | | } [INFO] [stdout] 370 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nakamoto-test` (lib) due to 2 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/assert.rs:256:10 [INFO] [stdout] | [INFO] [stdout] 250 | fn panic_message(f: F) -> String [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 254 | let err = catch_unwind(f).expect_err("function did not panic"); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 255 | [INFO] [stdout] 256 | *err.downcast::() [INFO] [stdout] | __________^ [INFO] [stdout] 257 | | .expect("function panicked with non-String value") [INFO] [stdout] | |______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/block.rs:364:9 [INFO] [stdout] | [INFO] [stdout] 357 | let mut txmap = HashMap::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 364 | / BlockFilter::new_script_filter(block, |out| { [INFO] [stdout] 365 | | if let Some(s) = txmap.get(out) { [INFO] [stdout] 366 | | Ok(s.clone()) [INFO] [stdout] 367 | | } else { [INFO] [stdout] 368 | | Err(bip158::Error::UtxoMissing(*out)) [INFO] [stdout] 369 | | } [INFO] [stdout] 370 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nakamoto-test` (lib test) due to 3 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "2e963cf521779abb7829a5eb396bc3f2a1f9f5625cc05b0241308175a668a5fb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2e963cf521779abb7829a5eb396bc3f2a1f9f5625cc05b0241308175a668a5fb", kill_on_drop: false }` [INFO] [stdout] 2e963cf521779abb7829a5eb396bc3f2a1f9f5625cc05b0241308175a668a5fb