[INFO] fetching crate naia-derive 0.22.0... [INFO] checking naia-derive-0.22.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate naia-derive 0.22.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate naia-derive 0.22.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate naia-derive 0.22.0 [INFO] finished tweaking crates.io crate naia-derive 0.22.0 [INFO] tweaked toml for crates.io crate naia-derive 0.22.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 8 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 12fedf045bcd85d65274c77ea1226ac085c669d56222d470db9e0d6f2b0675c4 [INFO] running `Command { std: "docker" "start" "-a" "12fedf045bcd85d65274c77ea1226ac085c669d56222d470db9e0d6f2b0675c4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "12fedf045bcd85d65274c77ea1226ac085c669d56222d470db9e0d6f2b0675c4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "12fedf045bcd85d65274c77ea1226ac085c669d56222d470db9e0d6f2b0675c4", kill_on_drop: false }` [INFO] [stdout] 12fedf045bcd85d65274c77ea1226ac085c669d56222d470db9e0d6f2b0675c4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 80f991ad1ecff74fdcb952d407327daaeb67f255d0d5e229f0b6c4ce00bf4fc0 [INFO] running `Command { std: "docker" "start" "-a" "80f991ad1ecff74fdcb952d407327daaeb67f255d0d5e229f0b6c4ce00bf4fc0", kill_on_drop: false }` [INFO] [stderr] Compiling log v0.4.22 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling naia-serde-derive v0.22.0 [INFO] [stderr] Checking naia-derive v0.22.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `uppercase_variable_name` is never read [INFO] [stdout] --> src/message.rs:458:9 [INFO] [stdout] | [INFO] [stdout] 456 | pub struct EntityProperty { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] 457 | pub variable_name: Ident, [INFO] [stdout] 458 | pub uppercase_variable_name: Ident, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/message.rs:474:30 [INFO] [stdout] | [INFO] [stdout] 473 | pub fn entity_property(variable_name: Ident) -> Self { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 474 | Self::EntityProperty(EntityProperty { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 475 | | variable_name: variable_name.clone(), [INFO] [stdout] 476 | | uppercase_variable_name: Ident::new( [INFO] [stdout] 477 | | variable_name.to_string().to_uppercase().as_str(), [INFO] [stdout] 478 | | Span::call_site(), [INFO] [stdout] 479 | | ), [INFO] [stdout] 480 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/message.rs:484:22 [INFO] [stdout] | [INFO] [stdout] 483 | pub fn normal(variable_name: Ident, field_type: Type) -> Self { [INFO] [stdout] | -------------------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 484 | Self::Normal(Normal { [INFO] [stdout] | ______________________^ [INFO] [stdout] 485 | | variable_name: variable_name.clone(), [INFO] [stdout] 486 | | field_type, [INFO] [stdout] 487 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/replicate.rs:197:22 [INFO] [stdout] | [INFO] [stdout] 196 | pub fn normal(index: usize, variable_name: Ident, inner_type: Type) -> Self { [INFO] [stdout] | -------------------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 197 | Self::Normal(NormalProperty { [INFO] [stdout] | ______________________^ [INFO] [stdout] 198 | | index, [INFO] [stdout] 199 | | variable_name: variable_name.clone(), [INFO] [stdout] 200 | | inner_type, [INFO] [stdout] ... | [INFO] [stdout] 204 | | ), [INFO] [stdout] 205 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/replicate.rs:209:22 [INFO] [stdout] | [INFO] [stdout] 208 | pub fn entity(index: usize, variable_name: Ident) -> Self { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 209 | Self::Entity(EntityProperty { [INFO] [stdout] | ______________________^ [INFO] [stdout] 210 | | index, [INFO] [stdout] 211 | | variable_name: variable_name.clone(), [INFO] [stdout] 212 | | uppercase_variable_name: Ident::new( [INFO] [stdout] ... | [INFO] [stdout] 215 | | ), [INFO] [stdout] 216 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/replicate.rs:220:29 [INFO] [stdout] | [INFO] [stdout] 219 | pub fn nonreplicated(variable_name: Ident, field_type: Type) -> Self { [INFO] [stdout] | -------------------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 220 | Self::NonReplicated(NonReplicatedProperty { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 221 | | variable_name: variable_name.clone(), [INFO] [stdout] 222 | | field_type, [INFO] [stdout] 223 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `naia-derive` (lib) due to 6 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `uppercase_variable_name` is never read [INFO] [stdout] --> src/message.rs:458:9 [INFO] [stdout] | [INFO] [stdout] 456 | pub struct EntityProperty { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] 457 | pub variable_name: Ident, [INFO] [stdout] 458 | pub uppercase_variable_name: Ident, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/message.rs:474:30 [INFO] [stdout] | [INFO] [stdout] 473 | pub fn entity_property(variable_name: Ident) -> Self { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 474 | Self::EntityProperty(EntityProperty { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 475 | | variable_name: variable_name.clone(), [INFO] [stdout] 476 | | uppercase_variable_name: Ident::new( [INFO] [stdout] 477 | | variable_name.to_string().to_uppercase().as_str(), [INFO] [stdout] 478 | | Span::call_site(), [INFO] [stdout] 479 | | ), [INFO] [stdout] 480 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/message.rs:484:22 [INFO] [stdout] | [INFO] [stdout] 483 | pub fn normal(variable_name: Ident, field_type: Type) -> Self { [INFO] [stdout] | -------------------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 484 | Self::Normal(Normal { [INFO] [stdout] | ______________________^ [INFO] [stdout] 485 | | variable_name: variable_name.clone(), [INFO] [stdout] 486 | | field_type, [INFO] [stdout] 487 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/replicate.rs:197:22 [INFO] [stdout] | [INFO] [stdout] 196 | pub fn normal(index: usize, variable_name: Ident, inner_type: Type) -> Self { [INFO] [stdout] | -------------------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 197 | Self::Normal(NormalProperty { [INFO] [stdout] | ______________________^ [INFO] [stdout] 198 | | index, [INFO] [stdout] 199 | | variable_name: variable_name.clone(), [INFO] [stdout] 200 | | inner_type, [INFO] [stdout] ... | [INFO] [stdout] 204 | | ), [INFO] [stdout] 205 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/replicate.rs:209:22 [INFO] [stdout] | [INFO] [stdout] 208 | pub fn entity(index: usize, variable_name: Ident) -> Self { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 209 | Self::Entity(EntityProperty { [INFO] [stdout] | ______________________^ [INFO] [stdout] 210 | | index, [INFO] [stdout] 211 | | variable_name: variable_name.clone(), [INFO] [stdout] 212 | | uppercase_variable_name: Ident::new( [INFO] [stdout] ... | [INFO] [stdout] 215 | | ), [INFO] [stdout] 216 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/replicate.rs:220:29 [INFO] [stdout] | [INFO] [stdout] 219 | pub fn nonreplicated(variable_name: Ident, field_type: Type) -> Self { [INFO] [stdout] | -------------------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 220 | Self::NonReplicated(NonReplicatedProperty { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 221 | | variable_name: variable_name.clone(), [INFO] [stdout] 222 | | field_type, [INFO] [stdout] 223 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `naia-derive` (lib test) due to 6 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "80f991ad1ecff74fdcb952d407327daaeb67f255d0d5e229f0b6c4ce00bf4fc0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "80f991ad1ecff74fdcb952d407327daaeb67f255d0d5e229f0b6c4ce00bf4fc0", kill_on_drop: false }` [INFO] [stdout] 80f991ad1ecff74fdcb952d407327daaeb67f255d0d5e229f0b6c4ce00bf4fc0