[INFO] fetching crate mycodee-project_manager 0.1.1... [INFO] checking mycodee-project_manager-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate mycodee-project_manager 0.1.1 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate mycodee-project_manager 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate mycodee-project_manager 0.1.1 [INFO] finished tweaking crates.io crate mycodee-project_manager 0.1.1 [INFO] tweaked toml for crates.io crate mycodee-project_manager 0.1.1 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate mycodee-project_manager 0.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 23a2176453e9dd9e5ce21ccd9264db80df90570d3c24e27d0a81b82bbb6813ee [INFO] running `Command { std: "docker" "start" "-a" "23a2176453e9dd9e5ce21ccd9264db80df90570d3c24e27d0a81b82bbb6813ee", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "23a2176453e9dd9e5ce21ccd9264db80df90570d3c24e27d0a81b82bbb6813ee", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "23a2176453e9dd9e5ce21ccd9264db80df90570d3c24e27d0a81b82bbb6813ee", kill_on_drop: false }` [INFO] [stdout] 23a2176453e9dd9e5ce21ccd9264db80df90570d3c24e27d0a81b82bbb6813ee [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] be53b3ee451e99c6573c771a60eaaa76f7e131928727d7a0a26c9d3345392b56 [INFO] running `Command { std: "docker" "start" "-a" "be53b3ee451e99c6573c771a60eaaa76f7e131928727d7a0a26c9d3345392b56", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.32 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.81 [INFO] [stderr] Compiling serde_derive v1.0.130 [INFO] [stderr] Compiling serde v1.0.130 [INFO] [stderr] Compiling quote v1.0.10 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking toml v0.5.8 [INFO] [stderr] Checking mycodee-project_manager v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/configuration.rs:33:68 [INFO] [stdout] | [INFO] [stdout] 33 | eprintln!("Error: {:?}", config.expect_err("").as_ref().clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `bincode::ErrorKind` does not implement `Clone`, so calling `clone` on `&bincode::ErrorKind` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 33 - eprintln!("Error: {:?}", config.expect_err("").as_ref().clone()); [INFO] [stdout] 33 + eprintln!("Error: {:?}", config.expect_err("").as_ref()); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `bincode::ErrorKind`, implement `Clone` for it [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/bincode-1.3.3/src/error.rs:16:1 [INFO] [stdout] | [INFO] [stdout] 16 + #[derive(Clone)] [INFO] [stdout] 17 | pub enum ErrorKind { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/configuration.rs:44:68 [INFO] [stdout] | [INFO] [stdout] 44 | eprintln!("Error: {:?}", binary.expect_err("").as_ref().clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `bincode::ErrorKind` does not implement `Clone`, so calling `clone` on `&bincode::ErrorKind` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 44 - eprintln!("Error: {:?}", binary.expect_err("").as_ref().clone()); [INFO] [stdout] 44 + eprintln!("Error: {:?}", binary.expect_err("").as_ref()); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `bincode::ErrorKind`, implement `Clone` for it [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/bincode-1.3.3/src/error.rs:16:1 [INFO] [stdout] | [INFO] [stdout] 16 + #[derive(Clone)] [INFO] [stdout] 17 | pub enum ErrorKind { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/configuration.rs:75:68 [INFO] [stdout] | [INFO] [stdout] 75 | eprintln!("Error: {:?}", config.expect_err("").as_ref().clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `bincode::ErrorKind` does not implement `Clone`, so calling `clone` on `&bincode::ErrorKind` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 75 - eprintln!("Error: {:?}", config.expect_err("").as_ref().clone()); [INFO] [stdout] 75 + eprintln!("Error: {:?}", config.expect_err("").as_ref()); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `bincode::ErrorKind`, implement `Clone` for it [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/bincode-1.3.3/src/error.rs:16:1 [INFO] [stdout] | [INFO] [stdout] 16 + #[derive(Clone)] [INFO] [stdout] 17 | pub enum ErrorKind { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/configuration.rs:88:66 [INFO] [stdout] | [INFO] [stdout] 88 | binary.expect_err("Failed to get error").as_ref().clone() [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `bincode::ErrorKind` does not implement `Clone`, so calling `clone` on `&bincode::ErrorKind` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 88 - binary.expect_err("Failed to get error").as_ref().clone() [INFO] [stdout] 88 + binary.expect_err("Failed to get error").as_ref() [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `bincode::ErrorKind`, implement `Clone` for it [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/bincode-1.3.3/src/error.rs:16:1 [INFO] [stdout] | [INFO] [stdout] 16 + #[derive(Clone)] [INFO] [stdout] 17 | pub enum ErrorKind { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:207:5 [INFO] [stdout] | [INFO] [stdout] 191 | let mut command = if cfg!(target_os = "windows") { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 192 | let mut command = Command::new("cmd.exe"); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 197 | let mut command = Command::new("bash"); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 207 | command.output().expect("Failed to spawn a process") [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mycodee-project_manager` (bin "project_manager") due to 2 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/configuration.rs:33:68 [INFO] [stdout] | [INFO] [stdout] 33 | eprintln!("Error: {:?}", config.expect_err("").as_ref().clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `bincode::ErrorKind` does not implement `Clone`, so calling `clone` on `&bincode::ErrorKind` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 33 - eprintln!("Error: {:?}", config.expect_err("").as_ref().clone()); [INFO] [stdout] 33 + eprintln!("Error: {:?}", config.expect_err("").as_ref()); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `bincode::ErrorKind`, implement `Clone` for it [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/bincode-1.3.3/src/error.rs:16:1 [INFO] [stdout] | [INFO] [stdout] 16 + #[derive(Clone)] [INFO] [stdout] 17 | pub enum ErrorKind { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/configuration.rs:44:68 [INFO] [stdout] | [INFO] [stdout] 44 | eprintln!("Error: {:?}", binary.expect_err("").as_ref().clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `bincode::ErrorKind` does not implement `Clone`, so calling `clone` on `&bincode::ErrorKind` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 44 - eprintln!("Error: {:?}", binary.expect_err("").as_ref().clone()); [INFO] [stdout] 44 + eprintln!("Error: {:?}", binary.expect_err("").as_ref()); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `bincode::ErrorKind`, implement `Clone` for it [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/bincode-1.3.3/src/error.rs:16:1 [INFO] [stdout] | [INFO] [stdout] 16 + #[derive(Clone)] [INFO] [stdout] 17 | pub enum ErrorKind { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/configuration.rs:75:68 [INFO] [stdout] | [INFO] [stdout] 75 | eprintln!("Error: {:?}", config.expect_err("").as_ref().clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `bincode::ErrorKind` does not implement `Clone`, so calling `clone` on `&bincode::ErrorKind` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 75 - eprintln!("Error: {:?}", config.expect_err("").as_ref().clone()); [INFO] [stdout] 75 + eprintln!("Error: {:?}", config.expect_err("").as_ref()); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `bincode::ErrorKind`, implement `Clone` for it [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/bincode-1.3.3/src/error.rs:16:1 [INFO] [stdout] | [INFO] [stdout] 16 + #[derive(Clone)] [INFO] [stdout] 17 | pub enum ErrorKind { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/configuration.rs:88:66 [INFO] [stdout] | [INFO] [stdout] 88 | binary.expect_err("Failed to get error").as_ref().clone() [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `bincode::ErrorKind` does not implement `Clone`, so calling `clone` on `&bincode::ErrorKind` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 88 - binary.expect_err("Failed to get error").as_ref().clone() [INFO] [stdout] 88 + binary.expect_err("Failed to get error").as_ref() [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `bincode::ErrorKind`, implement `Clone` for it [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/bincode-1.3.3/src/error.rs:16:1 [INFO] [stdout] | [INFO] [stdout] 16 + #[derive(Clone)] [INFO] [stdout] 17 | pub enum ErrorKind { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:207:5 [INFO] [stdout] | [INFO] [stdout] 191 | let mut command = if cfg!(target_os = "windows") { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 192 | let mut command = Command::new("cmd.exe"); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 197 | let mut command = Command::new("bash"); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 207 | command.output().expect("Failed to spawn a process") [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mycodee-project_manager` (bin "project_manager" test) due to 2 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "be53b3ee451e99c6573c771a60eaaa76f7e131928727d7a0a26c9d3345392b56", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "be53b3ee451e99c6573c771a60eaaa76f7e131928727d7a0a26c9d3345392b56", kill_on_drop: false }` [INFO] [stdout] be53b3ee451e99c6573c771a60eaaa76f7e131928727d7a0a26c9d3345392b56