[INFO] fetching crate mycitadel-desktop2 1.1.0... [INFO] checking mycitadel-desktop2-1.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate mycitadel-desktop2 1.1.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate mycitadel-desktop2 1.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-4-tc2/source/rust-toolchain.toml [INFO] started tweaking crates.io crate mycitadel-desktop2 1.1.0 [INFO] finished tweaking crates.io crate mycitadel-desktop2 1.1.0 [INFO] tweaked toml for crates.io crate mycitadel-desktop2 1.1.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate mycitadel-desktop2 1.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ea1b1055484b91634dce8a2494a5e3b115d1572aa69d313bf81a3fd992d252b0 [INFO] running `Command { std: "docker" "start" "-a" "ea1b1055484b91634dce8a2494a5e3b115d1572aa69d313bf81a3fd992d252b0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ea1b1055484b91634dce8a2494a5e3b115d1572aa69d313bf81a3fd992d252b0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ea1b1055484b91634dce8a2494a5e3b115d1572aa69d313bf81a3fd992d252b0", kill_on_drop: false }` [INFO] [stdout] ea1b1055484b91634dce8a2494a5e3b115d1572aa69d313bf81a3fd992d252b0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7d1906ce51a051c56f13f4c17d29bd462e2adaee406c7310003a74c62cae2ef1 [INFO] running `Command { std: "docker" "start" "-a" "7d1906ce51a051c56f13f4c17d29bd462e2adaee406c7310003a74c62cae2ef1", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.40 [INFO] [stderr] Compiling quote v1.0.20 [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Compiling unicode-ident v1.0.1 [INFO] [stderr] Compiling syn v1.0.98 [INFO] [stderr] Compiling serde v1.0.137 [INFO] [stderr] Compiling pkg-config v0.3.25 [INFO] [stderr] Compiling smallvec v1.8.1 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Compiling version-compare v0.1.0 [INFO] [stderr] Compiling cfg-expr v0.10.3 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling cc v1.0.73 [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Compiling autocfg v0.1.8 [INFO] [stderr] Compiling serde_derive v1.0.137 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking once_cell v1.12.0 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Compiling futures-core v0.3.21 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking rand_jitter v0.1.4 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Compiling futures-task v0.3.21 [INFO] [stderr] Compiling anyhow v1.0.58 [INFO] [stderr] Checking getrandom v0.2.7 [INFO] [stderr] Compiling secp256k1-sys v0.5.2 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking base64-compat v1.0.0 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Checking pin-project-lite v0.2.9 [INFO] [stderr] Checking bech32 v0.8.1 [INFO] [stderr] Checking ppv-lite86 v0.2.16 [INFO] [stderr] Compiling futures-channel v0.3.21 [INFO] [stderr] Checking slab v0.4.6 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Compiling amplify_num v0.4.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking amplify_syn v1.1.6 [INFO] [stderr] Compiling ucd-trie v0.1.3 [INFO] [stderr] Compiling pest v2.1.3 [INFO] [stderr] Compiling toml v0.5.9 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking futures-executor v0.3.21 [INFO] [stderr] Compiling semver-parser v0.10.2 [INFO] [stderr] Compiling gio v0.15.12 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Checking futures-io v0.3.21 [INFO] [stderr] Compiling semver v0.11.0 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling rustc_version v0.3.3 [INFO] [stderr] Compiling serde_json v1.0.81 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Compiling field-offset v0.3.4 [INFO] [stderr] Compiling system-deps v6.0.2 [INFO] [stderr] Compiling gtk v0.15.5 [INFO] [stderr] Checking ryu v1.0.10 [INFO] [stderr] Checking itoa v1.0.2 [INFO] [stderr] Compiling rustls v0.20.6 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Checking matches v0.1.9 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Checking unicode-bidi v0.3.8 [INFO] [stderr] Checking miniz_oxide v0.5.3 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Checking base64 v0.13.0 [INFO] [stderr] Checking unicode-normalization v0.1.20 [INFO] [stderr] Compiling glib-sys v0.15.10 [INFO] [stderr] Compiling gobject-sys v0.15.10 [INFO] [stderr] Compiling gio-sys v0.15.10 [INFO] [stderr] Compiling atk-sys v0.15.1 [INFO] [stderr] Compiling gdk-sys v0.15.1 [INFO] [stderr] Compiling pango-sys v0.15.10 [INFO] [stderr] Compiling gdk-pixbuf-sys v0.15.10 [INFO] [stderr] Compiling cairo-sys-rs v0.15.1 [INFO] [stderr] Compiling gtk-sys v0.15.3 [INFO] [stderr] Checking flate2 v1.0.24 [INFO] [stderr] Checking socks v0.3.4 [INFO] [stderr] Checking fragile v1.2.1 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Checking chunked_transfer v1.4.0 [INFO] [stderr] Checking urlencoding v2.1.0 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Compiling thiserror-impl v1.0.31 [INFO] [stderr] Compiling amplify_derive v2.11.2 [INFO] [stderr] Compiling stability v0.1.1 [INFO] [stderr] Compiling gladis_proc_macro v2.1.2 [INFO] [stderr] Compiling relm-derive v0.23.0 [INFO] [stderr] Checking webpki v0.22.0 [INFO] [stderr] Checking sct v0.7.0 [INFO] [stderr] Checking webpki-roots v0.22.3 [INFO] [stderr] Compiling thiserror v1.0.31 [INFO] [stderr] Compiling proc-macro-crate v1.1.3 [INFO] [stderr] Compiling glib-macros v0.15.11 [INFO] [stderr] Compiling gtk3-macros v0.15.4 [INFO] [stderr] Compiling amplify v3.12.1 [INFO] [stderr] Compiling encoding_derive_helpers v1.7.6 [INFO] [stderr] Compiling strict_encoding_derive v1.7.6 [INFO] [stderr] Checking glib v0.15.12 [INFO] [stderr] Checking bitcoin_hashes v0.10.0 [INFO] [stderr] Checking secp256k1 v0.22.1 [INFO] [stderr] Checking ureq v2.4.0 [INFO] [stderr] Checking cairo-rs v0.15.12 [INFO] [stderr] Checking pango v0.15.10 [INFO] [stderr] Checking atk v0.15.1 [INFO] [stderr] Checking bitcoin v0.28.1 [INFO] [stderr] Checking miniscript v7.0.0 [INFO] [stderr] Checking electrum-client v0.10.1 [INFO] [stderr] Checking bitcoin_hwi v0.2.0 [INFO] [stderr] Checking strict_encoding v1.8.11 [INFO] [stderr] Checking slip132 v0.7.0 [INFO] [stderr] Checking bitcoin_scripts v0.7.2 [INFO] [stderr] Checking bitcoin_hd v0.7.1 [INFO] [stderr] Checking descriptors v0.7.0 [INFO] [stderr] Checking bitcoin_onchain v0.7.0 [INFO] [stderr] Checking psbt v0.7.1 [INFO] [stderr] Checking descriptor-wallet v0.7.1 [INFO] [stderr] Checking gdk-pixbuf v0.15.11 [INFO] [stderr] Checking gdk v0.15.4 [INFO] [stderr] Checking gladis v2.1.2 [INFO] [stderr] Checking relm v0.23.0 [INFO] [stderr] Checking mycitadel-desktop2 v1.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/file.rs:126:17 [INFO] [stdout] | [INFO] [stdout] 124 | .or_else(|_| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | file.rewind()?; [INFO] [stdout] 126 | DocReader::::strict_decode(&mut file).map(|r| DocReader::< [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/file.rs:130:27 [INFO] [stdout] | [INFO] [stdout] 126 | DocReader::::strict_decode(&mut file).map(|r| DocReader::< [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | data: r.data.into(), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/taptree.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 28 | fn to_tap_tree(self) -> Result, miniscript::Error> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | let (tap_tree, remnant) = self.into_iter().try_rfold( [INFO] [stdout] | -------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | / tap_tree [INFO] [stdout] 59 | | .or_else(|| remnant.map(|ms| TapTree::Leaf(Arc::new(ms)))) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________________________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/taptree.rs:37:47 [INFO] [stdout] | [INFO] [stdout] 37 | |(tree, prev), (depth, ms)| match (tree, prev) { [INFO] [stdout] | ------------ ----------- ^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/taptree.rs:59:56 [INFO] [stdout] | [INFO] [stdout] 59 | .or_else(|| remnant.map(|ms| TapTree::Leaf(Arc::new(ms)))) [INFO] [stdout] | -- ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/types.rs:208:12 [INFO] [stdout] | [INFO] [stdout] 166 | let mut log = vec![]; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 208 | Ok((devices.into(), log)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/wallet.rs:273:25 [INFO] [stdout] | [INFO] [stdout] 273 | .map(|src| (src.address.script_pubkey().into_inner(), *src)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/wallet.rs:709:12 [INFO] [stdout] | [INFO] [stdout] 708 | let ms = policy.compile::().map_err(err_mapper)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 709 | Ok(Descriptor::Sh(Sh::new(ms)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/file.rs:126:17 [INFO] [stdout] | [INFO] [stdout] 124 | .or_else(|_| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | file.rewind()?; [INFO] [stdout] 126 | DocReader::::strict_decode(&mut file).map(|r| DocReader::< [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/xkey.rs:226:12 [INFO] [stdout] | [INFO] [stdout] 176 | standard: Option, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 182 | let standard_slip = application.and_then(Standard::matching); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 226 | Ok(XpubOrigin { [INFO] [stdout] | ____________^ [INFO] [stdout] 227 | | testnet: xpub.network == bitcoin::Network::Bitcoin, [INFO] [stdout] 228 | | master_fingerprint, [INFO] [stdout] 229 | | standard: standard.or(standard_slip), [INFO] [stdout] 230 | | account, [INFO] [stdout] 231 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/file.rs:130:27 [INFO] [stdout] | [INFO] [stdout] 126 | DocReader::::strict_decode(&mut file).map(|r| DocReader::< [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | data: r.data.into(), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/xkey.rs:250:23 [INFO] [stdout] | [INFO] [stdout] 237 | standard: Option, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 243 | let standard_slip = application.and_then(Standard::matching); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 250 | standard: standard.or(standard_slip), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/xkey.rs:306:12 [INFO] [stdout] | [INFO] [stdout] 279 | let standard = Standard::deduce(source); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 306 | Ok(XpubOrigin::with(master_fingerprint, xpub, standard, slip)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/xkey.rs:577:12 [INFO] [stdout] | [INFO] [stdout] 568 | let mut xd = XpubDescriptor::from(xpub); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 569 | let origin = match XpubOrigin::deduce(master_fingerprint, source, xpub, slip) { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 572 | Ok(Ok(origin)) => origin, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 577 | Ok(Ok(xd)) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/devices/device_row/view_model.rs:223:22 [INFO] [stdout] | [INFO] [stdout] 223 | .map(|o| o.clone().upcast::()) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/devices/device_row/widget.rs:46:25 [INFO] [stdout] | [INFO] [stdout] 43 | let stream = stream_.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | stream.emit(devices::Msg::AccountChange(fingerprint, account)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/devices/devices.rs:64:22 [INFO] [stdout] | [INFO] [stdout] 60 | fn model(_relm: &Relm, model: Self::ModelParam) -> Self::Model { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | devices: DeviceModel::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/taptree.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 28 | fn to_tap_tree(self) -> Result, miniscript::Error> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | let (tap_tree, remnant) = self.into_iter().try_rfold( [INFO] [stdout] | -------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | / tap_tree [INFO] [stdout] 59 | | .or_else(|| remnant.map(|ms| TapTree::Leaf(Arc::new(ms)))) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________________________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/taptree.rs:37:47 [INFO] [stdout] | [INFO] [stdout] 37 | |(tree, prev), (depth, ms)| match (tree, prev) { [INFO] [stdout] | ------------ ----------- ^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/taptree.rs:59:56 [INFO] [stdout] | [INFO] [stdout] 59 | .or_else(|| remnant.map(|ms| TapTree::Leaf(Arc::new(ms)))) [INFO] [stdout] | -- ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/devices/devices.rs:210:34 [INFO] [stdout] | [INFO] [stdout] 206 | let stream = relm.stream().clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 210 | RowWidgets::init(stream.clone(), item) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/launch/component.rs:253:21 [INFO] [stdout] | [INFO] [stdout] 233 | let widgets = Widgets::from_string(glade_src).expect("glade file broken"); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 237 | let new_wallet = [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 240 | let about = init::(()).expect("unable to instantiate about settings"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 253 | stream: relm.stream().clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/types.rs:208:12 [INFO] [stdout] | [INFO] [stdout] 166 | let mut log = vec![]; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 208 | Ok((devices.into(), log)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/psbt/component.rs:48:39 [INFO] [stdout] | [INFO] [stdout] 48 | .map(|stream| stream.emit(launch::Msg::PsbtClosed)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/psbt/sign_row/view_model.rs:223:22 [INFO] [stdout] | [INFO] [stdout] 223 | .map(|o| o.clone().upcast::()) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/psbt/widget.rs:294:40 [INFO] [stdout] | [INFO] [stdout] 292 | let relm = relm.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 293 | self.signatures_list.bind_model(Some(model), move |item| { [INFO] [stdout] 294 | sign_row::RowWidgets::init(relm.clone(), item) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/psbt/xpriv_dlg/component.rs:63:15 [INFO] [stdout] | [INFO] [stdout] 57 | let signer = XprivSigner { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | match self.model.psbt.sign_all(&signer) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/settings/component.rs:42:43 [INFO] [stdout] | [INFO] [stdout] 42 | .map(|stream| stream.emit(launch::Msg::ShowPage(launch::Page::Template))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/wallet.rs:273:25 [INFO] [stdout] | [INFO] [stdout] 273 | .map(|src| (src.address.script_pubkey().into_inner(), *src)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/settings/component.rs:451:30 [INFO] [stdout] | [INFO] [stdout] 425 | fn view(relm: &Relm, model: Self::Model) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 426 | let glade_src = include_str!("settings.glade"); [INFO] [stdout] 427 | let widgets = Widgets::from_string(glade_src).expect("glade file broken"); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 428 | [INFO] [stdout] 429 | let stream = relm.stream().clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 430 | let (_channel, sender) = Channel::new(move |msg| { [INFO] [stdout] | -------- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 434 | let devices = init::((model.bip43(), model.network, sender.clone())) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 435 | .expect("error in devices component"); [INFO] [stdout] 436 | let xpub_dlg = init::((model.bip43().into(), sender)) [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 441 | let stream = relm.stream().clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 442 | let (channel, sender) = Channel::new(move |_| stream.emit(Msg::ConditionChange)); [INFO] [stdout] | ------- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 451 | launcher_stream: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/settings/component.rs:452:28 [INFO] [stdout] | [INFO] [stdout] 425 | fn view(relm: &Relm, model: Self::Model) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 426 | let glade_src = include_str!("settings.glade"); [INFO] [stdout] 427 | let widgets = Widgets::from_string(glade_src).expect("glade file broken"); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 428 | [INFO] [stdout] 429 | let stream = relm.stream().clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 430 | let (_channel, sender) = Channel::new(move |msg| { [INFO] [stdout] | -------- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 434 | let devices = init::((model.bip43(), model.network, sender.clone())) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 435 | .expect("error in devices component"); [INFO] [stdout] 436 | let xpub_dlg = init::((model.bip43().into(), sender)) [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 441 | let stream = relm.stream().clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 442 | let (channel, sender) = Channel::new(move |_| stream.emit(Msg::ConditionChange)); [INFO] [stdout] | ------- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 452 | wallet_stream: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/settings/component.rs:442:67 [INFO] [stdout] | [INFO] [stdout] 441 | let stream = relm.stream().clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 442 | let (channel, sender) = Channel::new(move |_| stream.emit(Msg::ConditionChange)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/wallet.rs:709:12 [INFO] [stdout] | [INFO] [stdout] 708 | let ms = policy.compile::().map_err(err_mapper)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 709 | Ok(Descriptor::Sh(Sh::new(ms)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/xkey.rs:226:12 [INFO] [stdout] | [INFO] [stdout] 176 | standard: Option, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 182 | let standard_slip = application.and_then(Standard::matching); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 226 | Ok(XpubOrigin { [INFO] [stdout] | ____________^ [INFO] [stdout] 227 | | testnet: xpub.network == bitcoin::Network::Bitcoin, [INFO] [stdout] 228 | | master_fingerprint, [INFO] [stdout] 229 | | standard: standard.or(standard_slip), [INFO] [stdout] 230 | | account, [INFO] [stdout] 231 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/xkey.rs:250:23 [INFO] [stdout] | [INFO] [stdout] 237 | standard: Option, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 243 | let standard_slip = application.and_then(Standard::matching); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 250 | standard: standard.or(standard_slip), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/xkey.rs:306:12 [INFO] [stdout] | [INFO] [stdout] 279 | let standard = Standard::deduce(source); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 306 | Ok(XpubOrigin::with(master_fingerprint, xpub, standard, slip)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/xkey.rs:577:12 [INFO] [stdout] | [INFO] [stdout] 568 | let mut xd = XpubDescriptor::from(xpub); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 569 | let origin = match XpubOrigin::deduce(master_fingerprint, source, xpub, slip) { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 572 | Ok(Ok(origin)) => origin, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 577 | Ok(Ok(xd)) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/devices/device_row/view_model.rs:223:22 [INFO] [stdout] | [INFO] [stdout] 223 | .map(|o| o.clone().upcast::()) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/devices/device_row/widget.rs:46:25 [INFO] [stdout] | [INFO] [stdout] 43 | let stream = stream_.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | stream.emit(devices::Msg::AccountChange(fingerprint, account)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/devices/devices.rs:64:22 [INFO] [stdout] | [INFO] [stdout] 60 | fn model(_relm: &Relm, model: Self::ModelParam) -> Self::Model { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | devices: DeviceModel::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/devices/devices.rs:210:34 [INFO] [stdout] | [INFO] [stdout] 206 | let stream = relm.stream().clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 210 | RowWidgets::init(stream.clone(), item) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/launch/component.rs:253:21 [INFO] [stdout] | [INFO] [stdout] 233 | let widgets = Widgets::from_string(glade_src).expect("glade file broken"); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 237 | let new_wallet = [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 240 | let about = init::(()).expect("unable to instantiate about settings"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 253 | stream: relm.stream().clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/psbt/component.rs:48:39 [INFO] [stdout] | [INFO] [stdout] 48 | .map(|stream| stream.emit(launch::Msg::PsbtClosed)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/psbt/sign_row/view_model.rs:223:22 [INFO] [stdout] | [INFO] [stdout] 223 | .map(|o| o.clone().upcast::()) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/psbt/widget.rs:294:40 [INFO] [stdout] | [INFO] [stdout] 292 | let relm = relm.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 293 | self.signatures_list.bind_model(Some(model), move |item| { [INFO] [stdout] 294 | sign_row::RowWidgets::init(relm.clone(), item) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/psbt/xpriv_dlg/component.rs:63:15 [INFO] [stdout] | [INFO] [stdout] 57 | let signer = XprivSigner { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | match self.model.psbt.sign_all(&signer) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/settings/component.rs:42:43 [INFO] [stdout] | [INFO] [stdout] 42 | .map(|stream| stream.emit(launch::Msg::ShowPage(launch::Page::Template))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/settings/component.rs:451:30 [INFO] [stdout] | [INFO] [stdout] 425 | fn view(relm: &Relm, model: Self::Model) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 426 | let glade_src = include_str!("settings.glade"); [INFO] [stdout] 427 | let widgets = Widgets::from_string(glade_src).expect("glade file broken"); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 428 | [INFO] [stdout] 429 | let stream = relm.stream().clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 430 | let (_channel, sender) = Channel::new(move |msg| { [INFO] [stdout] | -------- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 434 | let devices = init::((model.bip43(), model.network, sender.clone())) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 435 | .expect("error in devices component"); [INFO] [stdout] 436 | let xpub_dlg = init::((model.bip43().into(), sender)) [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 441 | let stream = relm.stream().clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 442 | let (channel, sender) = Channel::new(move |_| stream.emit(Msg::ConditionChange)); [INFO] [stdout] | ------- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 451 | launcher_stream: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/settings/component.rs:452:28 [INFO] [stdout] | [INFO] [stdout] 425 | fn view(relm: &Relm, model: Self::Model) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 426 | let glade_src = include_str!("settings.glade"); [INFO] [stdout] 427 | let widgets = Widgets::from_string(glade_src).expect("glade file broken"); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 428 | [INFO] [stdout] 429 | let stream = relm.stream().clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 430 | let (_channel, sender) = Channel::new(move |msg| { [INFO] [stdout] | -------- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 434 | let devices = init::((model.bip43(), model.network, sender.clone())) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 435 | .expect("error in devices component"); [INFO] [stdout] 436 | let xpub_dlg = init::((model.bip43().into(), sender)) [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 441 | let stream = relm.stream().clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 442 | let (channel, sender) = Channel::new(move |_| stream.emit(Msg::ConditionChange)); [INFO] [stdout] | ------- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 452 | wallet_stream: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/settings/component.rs:442:67 [INFO] [stdout] | [INFO] [stdout] 441 | let stream = relm.stream().clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 442 | let (channel, sender) = Channel::new(move |_| stream.emit(Msg::ConditionChange)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/view/settings/spending_row/view_model.rs:355:40 [INFO] [stdout] | [INFO] [stdout] 355 | let condition = condition.imp().borrow(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `ConditionInner` does not implement `Borrow`, so calling `borrow` on `&ConditionInner` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 355 - let condition = condition.imp().borrow(); [INFO] [stdout] 355 + let condition = condition.imp(); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `ConditionInner`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 29 + #[derive(Clone)] [INFO] [stdout] 30 | pub struct ConditionInner { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/settings/spending_row/view_model.rs:399:22 [INFO] [stdout] | [INFO] [stdout] 399 | .map(|o| o.clone().upcast::()) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/settings/view_model.rs:144:29 [INFO] [stdout] | [INFO] [stdout] 137 | pub fn new(stream: StreamHandle) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 144 | spending_model: SpendingModel::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/settings/view_model.rs:147:25 [INFO] [stdout] | [INFO] [stdout] 137 | pub fn new(stream: StreamHandle) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 147 | descriptor: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/settings/view_model.rs:342:19 [INFO] [stdout] | [INFO] [stdout] 332 | let (_channel, sender) = Channel::new(move |msg| match msg { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 342 | match ElectrumClient::from_config(&url, config).and_then(|client| client.ping()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/settings/widget.rs:396:44 [INFO] [stdout] | [INFO] [stdout] 394 | pub(super) fn bind_spending_model(&self, sender: Sender<()>, model: &SpendingModel) { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 395 | self.spending_list.bind_model(Some(model), move |item| { [INFO] [stdout] 396 | spending_row::RowWidgets::init(sender.clone(), item) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/wallet/component.rs:62:39 [INFO] [stdout] | [INFO] [stdout] 62 | .map(|stream| stream.emit(launch::Msg::WalletClosed)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/wallet/component.rs:182:12 [INFO] [stdout] | [INFO] [stdout] 81 | let mut txouts = Vec::with_capacity(output_count as usize); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | let (descriptor, _) = self.model.as_settings().descriptors_all()?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 159 | let outputs = txouts [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 164 | let mut psbt = Psbt::construct( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 182 | Ok((psbt, change_index, fee)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/wallet/component.rs:161:27 [INFO] [stdout] | [INFO] [stdout] 161 | .map(|txout| (PubkeyScript::from(txout.script_pubkey), txout.value)) [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/wallet/component.rs:337:47 [INFO] [stdout] | [INFO] [stdout] 337 | .map(|stream| stream.emit(launch::Msg::ShowPage(launch::Page::Template))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/wallet/component.rs:342:47 [INFO] [stdout] | [INFO] [stdout] 342 | .map(|stream| stream.emit(launch::Msg::Wallet)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/wallet/component.rs:353:47 [INFO] [stdout] | [INFO] [stdout] 353 | .map(|stream| stream.emit(launch::Msg::Duplicate(settings, new_path))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/wallet/component.rs:358:47 [INFO] [stdout] | [INFO] [stdout] 358 | .map(|stream| stream.emit(launch::Msg::ShowPage(launch::Page::Import))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/wallet/component.rs:364:47 [INFO] [stdout] | [INFO] [stdout] 364 | .map(|stream| stream.emit(launch::Msg::About)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/wallet/component.rs:464:33 [INFO] [stdout] | [INFO] [stdout] 458 | let (psbt, change_index, _) = match self.sync_pay() { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 464 | stream.emit(launch::Msg::CreatePsbt( [INFO] [stdout] | _________________________________^ [INFO] [stdout] 465 | | psbt, [INFO] [stdout] 466 | | self.model.as_settings().network(), [INFO] [stdout] 467 | | )) [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/wallet/component.rs:579:30 [INFO] [stdout] | [INFO] [stdout] 534 | fn view(relm: &Relm, model: Self::Model) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 535 | let glade_src = include_str!("wallet.glade"); [INFO] [stdout] 536 | let widgets = Widgets::from_string(glade_src).expect("glade file broken"); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 537 | [INFO] [stdout] 538 | let settings = init::(()).expect("error in settings component"); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 541 | let stream = relm.stream().clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 542 | let (electrum_channel, sender) = [INFO] [stdout] | ---------------- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 543 | Channel::new(move |msg| stream.emit(Msg::ElectrumWatch(msg))); [INFO] [stdout] 544 | let electrum_worker = ElectrumWorker::with(sender, model.as_wallet().to_settings(), 60) [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 547 | let stream = relm.stream().clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 548 | let (exchange_channel, sender) = [INFO] [stdout] | ---------------- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 549 | Channel::new(move |msg| stream.emit(Msg::ExchangeRefresh(msg))); [INFO] [stdout] 550 | let exchange_worker = ExchangeWorker::with(sender, model.exchange(), model.fiat(), 600) [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 558 | let pay_widgets = pay::Widgets::from_string(glade_src).expect("glade file broken"); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 579 | launcher_stream: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/wallet/component.rs:543:49 [INFO] [stdout] | [INFO] [stdout] 541 | let stream = relm.stream().clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 542 | let (electrum_channel, sender) = [INFO] [stdout] 543 | Channel::new(move |msg| stream.emit(Msg::ElectrumWatch(msg))); [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/wallet/component.rs:549:49 [INFO] [stdout] | [INFO] [stdout] 547 | let stream = relm.stream().clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 548 | let (exchange_channel, sender) = [INFO] [stdout] 549 | Channel::new(move |msg| stream.emit(Msg::ExchangeRefresh(msg))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/wallet/pay/beneficiary_row/view_model.rs:157:22 [INFO] [stdout] | [INFO] [stdout] 157 | .map(|o| o.clone().upcast::()) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/wallet/pay/beneficiary_row/widget.rs:102:22 [INFO] [stdout] | [INFO] [stdout] 72 | let address_fld: Entry = binding.source().unwrap().downcast().unwrap(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | [INFO] [stdout] 74 | let addr_str = address_fld.text(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | Some(value.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/wallet/pay/beneficiary_row/widget.rs:148:22 [INFO] [stdout] | [INFO] [stdout] 110 | let item: Beneficiary = binding.target().unwrap().downcast().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 111 | let amount_fld: Entry = binding.source().unwrap().downcast().unwrap(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | [INFO] [stdout] 113 | let amount_str = amount_fld.text(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 148 | Some(amount.to_value()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/wallet/pay/widget.rs:96:42 [INFO] [stdout] | [INFO] [stdout] 93 | let remove_btn = self.remove_btn.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | remove_btn.set_sensitive(list.selected_row().is_some()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/wallet/pay/widget.rs:149:51 [INFO] [stdout] | [INFO] [stdout] 145 | let relm = relm.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 149 | beneficiary_row::RowWidgets::init(relm.clone(), item, network) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/wallet/view_model.rs:65:28 [INFO] [stdout] | [INFO] [stdout] 59 | pub fn with(wallet: Wallet, path: PathBuf) -> ViewModel { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | beneficiaries: BeneficiaryModel::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/worker/electrum.rs:161:12 [INFO] [stdout] | [INFO] [stdout] 108 | sender: Sender, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | let (tx, rx) = mpsc::channel::(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | let worker_thread = thread::Builder::new().name(s!("electrum")).spawn(move || { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 152 | let sender = tx.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | let watcher_thread = thread::Builder::new() [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 161 | Ok(ElectrumWorker { [INFO] [stdout] | ____________^ [INFO] [stdout] 162 | | tx, [INFO] [stdout] 163 | | worker_thread, [INFO] [stdout] 164 | | watcher_thread, [INFO] [stdout] 165 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/worker/electrum.rs:266:42 [INFO] [stdout] | [INFO] [stdout] 265 | .flat_map(|(utxo, (index, script))| { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 266 | utxo.into_iter().map(move |res| { [INFO] [stdout] | __________________________________________^ [INFO] [stdout] 267 | | UtxoTxid::with(res, AddressSource::with(&script, index, change, network)) [INFO] [stdout] 268 | | }) [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/worker/exchange.rs:119:12 [INFO] [stdout] | [INFO] [stdout] 77 | sender: Sender, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | let (tx, rx) = mpsc::channel::(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | let worker_thread = thread::Builder::new() [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 110 | let sender = tx.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 111 | let watcher_thread = thread::Builder::new() [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | Ok(ExchangeWorker { [INFO] [stdout] | ____________^ [INFO] [stdout] 120 | | tx, [INFO] [stdout] 121 | | worker_thread, [INFO] [stdout] 122 | | watcher_thread, [INFO] [stdout] 123 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/view/settings/spending_row/view_model.rs:355:40 [INFO] [stdout] | [INFO] [stdout] 355 | let condition = condition.imp().borrow(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `ConditionInner` does not implement `Borrow`, so calling `borrow` on `&ConditionInner` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 355 - let condition = condition.imp().borrow(); [INFO] [stdout] 355 + let condition = condition.imp(); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `ConditionInner`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 29 + #[derive(Clone)] [INFO] [stdout] 30 | pub struct ConditionInner { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/settings/spending_row/view_model.rs:399:22 [INFO] [stdout] | [INFO] [stdout] 399 | .map(|o| o.clone().upcast::()) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/settings/view_model.rs:144:29 [INFO] [stdout] | [INFO] [stdout] 137 | pub fn new(stream: StreamHandle) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 144 | spending_model: SpendingModel::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/settings/view_model.rs:147:25 [INFO] [stdout] | [INFO] [stdout] 137 | pub fn new(stream: StreamHandle) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 147 | descriptor: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/settings/view_model.rs:342:19 [INFO] [stdout] | [INFO] [stdout] 332 | let (_channel, sender) = Channel::new(move |msg| match msg { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 342 | match ElectrumClient::from_config(&url, config).and_then(|client| client.ping()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/settings/widget.rs:396:44 [INFO] [stdout] | [INFO] [stdout] 394 | pub(super) fn bind_spending_model(&self, sender: Sender<()>, model: &SpendingModel) { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 395 | self.spending_list.bind_model(Some(model), move |item| { [INFO] [stdout] 396 | spending_row::RowWidgets::init(sender.clone(), item) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/wallet/component.rs:62:39 [INFO] [stdout] | [INFO] [stdout] 62 | .map(|stream| stream.emit(launch::Msg::WalletClosed)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/wallet/component.rs:182:12 [INFO] [stdout] | [INFO] [stdout] 81 | let mut txouts = Vec::with_capacity(output_count as usize); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | let (descriptor, _) = self.model.as_settings().descriptors_all()?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 159 | let outputs = txouts [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 164 | let mut psbt = Psbt::construct( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 182 | Ok((psbt, change_index, fee)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/wallet/component.rs:161:27 [INFO] [stdout] | [INFO] [stdout] 161 | .map(|txout| (PubkeyScript::from(txout.script_pubkey), txout.value)) [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/wallet/component.rs:337:47 [INFO] [stdout] | [INFO] [stdout] 337 | .map(|stream| stream.emit(launch::Msg::ShowPage(launch::Page::Template))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/wallet/component.rs:342:47 [INFO] [stdout] | [INFO] [stdout] 342 | .map(|stream| stream.emit(launch::Msg::Wallet)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/wallet/component.rs:353:47 [INFO] [stdout] | [INFO] [stdout] 353 | .map(|stream| stream.emit(launch::Msg::Duplicate(settings, new_path))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/wallet/component.rs:358:47 [INFO] [stdout] | [INFO] [stdout] 358 | .map(|stream| stream.emit(launch::Msg::ShowPage(launch::Page::Import))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/wallet/component.rs:364:47 [INFO] [stdout] | [INFO] [stdout] 364 | .map(|stream| stream.emit(launch::Msg::About)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/wallet/component.rs:464:33 [INFO] [stdout] | [INFO] [stdout] 458 | let (psbt, change_index, _) = match self.sync_pay() { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 464 | stream.emit(launch::Msg::CreatePsbt( [INFO] [stdout] | _________________________________^ [INFO] [stdout] 465 | | psbt, [INFO] [stdout] 466 | | self.model.as_settings().network(), [INFO] [stdout] 467 | | )) [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/wallet/component.rs:579:30 [INFO] [stdout] | [INFO] [stdout] 534 | fn view(relm: &Relm, model: Self::Model) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 535 | let glade_src = include_str!("wallet.glade"); [INFO] [stdout] 536 | let widgets = Widgets::from_string(glade_src).expect("glade file broken"); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 537 | [INFO] [stdout] 538 | let settings = init::(()).expect("error in settings component"); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 541 | let stream = relm.stream().clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 542 | let (electrum_channel, sender) = [INFO] [stdout] | ---------------- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 543 | Channel::new(move |msg| stream.emit(Msg::ElectrumWatch(msg))); [INFO] [stdout] 544 | let electrum_worker = ElectrumWorker::with(sender, model.as_wallet().to_settings(), 60) [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 547 | let stream = relm.stream().clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 548 | let (exchange_channel, sender) = [INFO] [stdout] | ---------------- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 549 | Channel::new(move |msg| stream.emit(Msg::ExchangeRefresh(msg))); [INFO] [stdout] 550 | let exchange_worker = ExchangeWorker::with(sender, model.exchange(), model.fiat(), 600) [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 558 | let pay_widgets = pay::Widgets::from_string(glade_src).expect("glade file broken"); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 579 | launcher_stream: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/wallet/component.rs:543:49 [INFO] [stdout] | [INFO] [stdout] 541 | let stream = relm.stream().clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 542 | let (electrum_channel, sender) = [INFO] [stdout] 543 | Channel::new(move |msg| stream.emit(Msg::ElectrumWatch(msg))); [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/wallet/component.rs:549:49 [INFO] [stdout] | [INFO] [stdout] 547 | let stream = relm.stream().clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 548 | let (exchange_channel, sender) = [INFO] [stdout] 549 | Channel::new(move |msg| stream.emit(Msg::ExchangeRefresh(msg))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/wallet/pay/beneficiary_row/view_model.rs:157:22 [INFO] [stdout] | [INFO] [stdout] 157 | .map(|o| o.clone().upcast::()) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/wallet/pay/beneficiary_row/widget.rs:102:22 [INFO] [stdout] | [INFO] [stdout] 72 | let address_fld: Entry = binding.source().unwrap().downcast().unwrap(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | [INFO] [stdout] 74 | let addr_str = address_fld.text(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | Some(value.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/wallet/pay/beneficiary_row/widget.rs:148:22 [INFO] [stdout] | [INFO] [stdout] 110 | let item: Beneficiary = binding.target().unwrap().downcast().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 111 | let amount_fld: Entry = binding.source().unwrap().downcast().unwrap(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | [INFO] [stdout] 113 | let amount_str = amount_fld.text(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 148 | Some(amount.to_value()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/wallet/pay/widget.rs:96:42 [INFO] [stdout] | [INFO] [stdout] 93 | let remove_btn = self.remove_btn.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | remove_btn.set_sensitive(list.selected_row().is_some()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/wallet/pay/widget.rs:149:51 [INFO] [stdout] | [INFO] [stdout] 145 | let relm = relm.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 149 | beneficiary_row::RowWidgets::init(relm.clone(), item, network) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/wallet/view_model.rs:65:28 [INFO] [stdout] | [INFO] [stdout] 59 | pub fn with(wallet: Wallet, path: PathBuf) -> ViewModel { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | beneficiaries: BeneficiaryModel::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/worker/electrum.rs:161:12 [INFO] [stdout] | [INFO] [stdout] 108 | sender: Sender, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | let (tx, rx) = mpsc::channel::(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | let worker_thread = thread::Builder::new().name(s!("electrum")).spawn(move || { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 152 | let sender = tx.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | let watcher_thread = thread::Builder::new() [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 161 | Ok(ElectrumWorker { [INFO] [stdout] | ____________^ [INFO] [stdout] 162 | | tx, [INFO] [stdout] 163 | | worker_thread, [INFO] [stdout] 164 | | watcher_thread, [INFO] [stdout] 165 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/worker/electrum.rs:266:42 [INFO] [stdout] | [INFO] [stdout] 265 | .flat_map(|(utxo, (index, script))| { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 266 | utxo.into_iter().map(move |res| { [INFO] [stdout] | __________________________________________^ [INFO] [stdout] 267 | | UtxoTxid::with(res, AddressSource::with(&script, index, change, network)) [INFO] [stdout] 268 | | }) [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/worker/exchange.rs:119:12 [INFO] [stdout] | [INFO] [stdout] 77 | sender: Sender, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | let (tx, rx) = mpsc::channel::(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | let worker_thread = thread::Builder::new() [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 110 | let sender = tx.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 111 | let watcher_thread = thread::Builder::new() [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | Ok(ExchangeWorker { [INFO] [stdout] | ____________^ [INFO] [stdout] 120 | | tx, [INFO] [stdout] 121 | | worker_thread, [INFO] [stdout] 122 | | watcher_thread, [INFO] [stdout] 123 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 51 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 51 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mycitadel-desktop2` (lib) due to 52 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `mycitadel-desktop2` (lib test) due to 52 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "7d1906ce51a051c56f13f4c17d29bd462e2adaee406c7310003a74c62cae2ef1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7d1906ce51a051c56f13f4c17d29bd462e2adaee406c7310003a74c62cae2ef1", kill_on_drop: false }` [INFO] [stdout] 7d1906ce51a051c56f13f4c17d29bd462e2adaee406c7310003a74c62cae2ef1