[INFO] fetching crate mvn 0.2.0... [INFO] checking mvn-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate mvn 0.2.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate mvn 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate mvn 0.2.0 [INFO] finished tweaking crates.io crate mvn 0.2.0 [INFO] tweaked toml for crates.io crate mvn 0.2.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 95 packages to latest compatible versions [INFO] [stderr] Adding base64 v0.13.1 (latest: v0.22.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding der v0.6.1 (latest: v0.7.9) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding heck v0.4.1 (latest: v0.5.0) [INFO] [stderr] Adding image v0.24.9 (latest: v0.25.2) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding konst v0.2.19 (latest: v0.3.9) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding pem v1.1.1 (latest: v3.0.4) [INFO] [stderr] Adding pem-rfc7468 v0.6.0 (latest: v0.7.0) [INFO] [stderr] Adding pkcs1 v0.4.1 (latest: v0.7.5) [INFO] [stderr] Adding pkcs8 v0.9.0 (latest: v0.10.2) [INFO] [stderr] Adding quick-xml v0.26.0 (latest: v0.36.1) [INFO] [stderr] Adding radium v0.7.0 (latest: v1.1.0) [INFO] [stderr] Adding rasn v0.6.1 (latest: v0.16.6) [INFO] [stderr] Adding rasn-derive v0.6.0 (latest: v0.16.6) [INFO] [stderr] Adding rasn-pkix v0.6.0 (latest: v0.16.6) [INFO] [stderr] Adding rsa v0.7.2 (latest: v0.9.6) [INFO] [stderr] Adding rustc-hash v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding signature v1.6.4 (latest: v2.2.0) [INFO] [stderr] Adding snafu v0.7.5 (latest: v0.8.4) [INFO] [stderr] Adding snafu-derive v0.7.5 (latest: v0.8.4) [INFO] [stderr] Adding spki v0.6.0 (latest: v0.7.3) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding wyz v0.5.1 (latest: v0.6.1) [INFO] [stderr] Adding zip v0.6.6 (latest: v2.2.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1773e9f652ea3a86c51028bb07819341cd0b385bde5d1fe9406117c5b7d4045d [INFO] running `Command { std: "docker" "start" "-a" "1773e9f652ea3a86c51028bb07819341cd0b385bde5d1fe9406117c5b7d4045d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1773e9f652ea3a86c51028bb07819341cd0b385bde5d1fe9406117c5b7d4045d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1773e9f652ea3a86c51028bb07819341cd0b385bde5d1fe9406117c5b7d4045d", kill_on_drop: false }` [INFO] [stdout] 1773e9f652ea3a86c51028bb07819341cd0b385bde5d1fe9406117c5b7d4045d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 928b72f4cf64f93d73abddc2e07fa40ca6bcea6d2de0069cd629b77e95029799 [INFO] running `Command { std: "docker" "start" "-a" "928b72f4cf64f93d73abddc2e07fa40ca6bcea6d2de0069cd629b77e95029799", kill_on_drop: false }` [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking const-oid v0.9.6 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking base64ct v1.6.0 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Compiling radium v0.7.0 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Checking tap v1.0.1 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Checking wyz v0.5.1 [INFO] [stderr] Checking konst_macro_rules v0.2.19 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling itertools v0.10.5 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking funty v2.0.0 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Compiling num-bigint-dig v0.8.4 [INFO] [stderr] Checking konst v0.2.19 [INFO] [stderr] Checking pem-rfc7468 v0.6.0 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking fdeflate v0.3.4 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking bitvec v1.0.1 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking der v0.6.1 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking cpufeatures v0.2.13 [INFO] [stderr] Checking bytemuck v1.17.1 [INFO] [stderr] Checking base64 v0.13.1 [INFO] [stderr] Checking color_quant v1.1.0 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking zip v0.6.6 [INFO] [stderr] Checking pem v1.1.1 [INFO] [stderr] Checking png v0.17.13 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Checking dunce v1.0.5 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking spki v0.6.0 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking pkcs8 v0.9.0 [INFO] [stderr] Checking pkcs1 v0.4.1 [INFO] [stderr] Checking image v0.24.9 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking signature v1.6.4 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking pubgrub v0.2.1 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling snafu-derive v0.7.5 [INFO] [stderr] Compiling rasn-derive v0.6.0 [INFO] [stderr] Checking snafu v0.7.5 [INFO] [stderr] Checking rsa v0.7.2 [INFO] [stderr] Checking rasn v0.6.1 [INFO] [stderr] Checking rasn-pkix v0.6.0 [INFO] [stderr] Checking xcommon v0.3.0 [INFO] [stderr] Checking quick-xml v0.26.0 [INFO] [stderr] Checking mvn v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:36:12 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn new(cache_dir: PathBuf, client: D) -> Result { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | std::fs::create_dir_all(&cache_dir)?; [INFO] [stdout] 36 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 37 | | cache_dir, [INFO] [stdout] 38 | | client, [INFO] [stdout] 39 | | repositories: vec![], [INFO] [stdout] 40 | | local: Default::default(), [INFO] [stdout] 41 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:51:40 [INFO] [stdout] | [INFO] [stdout] 51 | .map(|dep| (dep.package(), dep.range().unwrap())) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:69:44 [INFO] [stdout] | [INFO] [stdout] 69 | |(package, version)| match self.package(&package, &version) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:104:39 [INFO] [stdout] | [INFO] [stdout] 104 | .filter_map(|version| Version::from_str(version).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:195:12 [INFO] [stdout] | [INFO] [stdout] 176 | potential_packages: impl Iterator, [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 177 | ) -> Result<(T, Option), Box> { [INFO] [stdout] 178 | let mut selected: Option<(_, Vec<_>)> = None; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 192 | let (p, v) = selected.expect("non empty iterator"); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 195 | Ok((p, v)) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:212:40 [INFO] [stdout] | [INFO] [stdout] 212 | .map(|dep| (dep.package(), dep.range().unwrap())) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mvn` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:36:12 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn new(cache_dir: PathBuf, client: D) -> Result { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | std::fs::create_dir_all(&cache_dir)?; [INFO] [stdout] 36 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 37 | | cache_dir, [INFO] [stdout] 38 | | client, [INFO] [stdout] 39 | | repositories: vec![], [INFO] [stdout] 40 | | local: Default::default(), [INFO] [stdout] 41 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:51:40 [INFO] [stdout] | [INFO] [stdout] 51 | .map(|dep| (dep.package(), dep.range().unwrap())) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:69:44 [INFO] [stdout] | [INFO] [stdout] 69 | |(package, version)| match self.package(&package, &version) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:104:39 [INFO] [stdout] | [INFO] [stdout] 104 | .filter_map(|version| Version::from_str(version).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:195:12 [INFO] [stdout] | [INFO] [stdout] 176 | potential_packages: impl Iterator, [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 177 | ) -> Result<(T, Option), Box> { [INFO] [stdout] 178 | let mut selected: Option<(_, Vec<_>)> = None; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 192 | let (p, v) = selected.expect("non empty iterator"); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 195 | Ok((p, v)) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:212:40 [INFO] [stdout] | [INFO] [stdout] 212 | .map(|dep| (dep.package(), dep.range().unwrap())) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mvn` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "928b72f4cf64f93d73abddc2e07fa40ca6bcea6d2de0069cd629b77e95029799", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "928b72f4cf64f93d73abddc2e07fa40ca6bcea6d2de0069cd629b77e95029799", kill_on_drop: false }` [INFO] [stdout] 928b72f4cf64f93d73abddc2e07fa40ca6bcea6d2de0069cd629b77e95029799