[INFO] fetching crate mutex 0.1.0... [INFO] checking mutex-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate mutex 0.1.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate mutex 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate mutex 0.1.0 [INFO] finished tweaking crates.io crate mutex 0.1.0 [INFO] tweaked toml for crates.io crate mutex 0.1.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 3 packages to latest compatible versions [INFO] [stderr] Adding mutex-traits v0.999.0 (latest: v1.0.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d73dae35ebf385ac0a2b20a9c2b9111c6b571c359aaad63e11ed3550c5e711b1 [INFO] running `Command { std: "docker" "start" "-a" "d73dae35ebf385ac0a2b20a9c2b9111c6b571c359aaad63e11ed3550c5e711b1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d73dae35ebf385ac0a2b20a9c2b9111c6b571c359aaad63e11ed3550c5e711b1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d73dae35ebf385ac0a2b20a9c2b9111c6b571c359aaad63e11ed3550c5e711b1", kill_on_drop: false }` [INFO] [stdout] d73dae35ebf385ac0a2b20a9c2b9111c6b571c359aaad63e11ed3550c5e711b1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bd1a0b9c19af5a757830ccdf50b3381f2a10040e6924729dd05d6ec9bc598b40 [INFO] running `Command { std: "docker" "start" "-a" "bd1a0b9c19af5a757830ccdf50b3381f2a10040e6924729dd05d6ec9bc598b40", kill_on_drop: false }` [INFO] [stderr] Compiling mutex v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking critical-section v1.1.3 [INFO] [stderr] Checking mutex-traits v0.999.0 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:43:18 [INFO] [stdout] | [INFO] [stdout] 41 | pub const fn new(val: T) -> BlockingMutex { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | BlockingMutex { [INFO] [stdout] 43 | raw: R::INIT, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mutex` (lib) due to 9 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:44:19 [INFO] [stdout] | [INFO] [stdout] 41 | pub const fn new(val: T) -> BlockingMutex { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | data: UnsafeCell::new(val), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:56:28 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn with_lock(&self, f: impl FnOnce(&mut T) -> U) -> U { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | self.raw.with_lock(|| { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 57 | | let ptr = self.data.get(); [INFO] [stdout] 58 | | // SAFETY: Raw Mutex proves we have exclusive access to the inner data [INFO] [stdout] 59 | | let inner = unsafe { &mut *ptr }; [INFO] [stdout] 60 | | f(inner) [INFO] [stdout] 61 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:70:32 [INFO] [stdout] | [INFO] [stdout] 69 | pub fn try_with_lock(&self, f: impl FnOnce(&mut T) -> U) -> Option { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | self.raw.try_with_lock(|| { [INFO] [stdout] | ________________________________^ [INFO] [stdout] 71 | | let ptr = self.data.get(); [INFO] [stdout] 72 | | // SAFETY: Raw Mutex proves we have exclusive access to the inner data [INFO] [stdout] 73 | | let inner = unsafe { &mut *ptr }; [INFO] [stdout] 74 | | f(inner) [INFO] [stdout] 75 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:87:19 [INFO] [stdout] | [INFO] [stdout] 84 | pub const fn const_new(raw_mutex: R, val: T) -> BlockingMutex { [INFO] [stdout] | ------------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 87 | data: UnsafeCell::new(val), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/raw_impls.rs:48:36 [INFO] [stdout] | [INFO] [stdout] 47 | fn try_with_lock(&self, f: impl FnOnce() -> R) -> Option { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | critical_section::with(|_| { [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 49 | | // NOTE: separated load/stores are acceptable as we are in [INFO] [stdout] 50 | | // a critical section [INFO] [stdout] 51 | | if self.taken.load(Ordering::Relaxed) { [INFO] [stdout] ... | [INFO] [stdout] 57 | | Some(ret) [INFO] [stdout] 58 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/raw_impls.rs:66:13 [INFO] [stdout] | [INFO] [stdout] 62 | fn with_lock(&self, f: impl FnOnce() -> R) -> R { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | self.try_with_lock(f).expect("Deadlocked") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/raw_impls.rs:127:13 [INFO] [stdout] | [INFO] [stdout] 123 | fn with_lock(&self, f: impl FnOnce() -> R) -> R { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | self.try_with_lock(f).expect("Deadlocked") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:43:18 [INFO] [stdout] | [INFO] [stdout] 41 | pub const fn new(val: T) -> BlockingMutex { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | BlockingMutex { [INFO] [stdout] 43 | raw: R::INIT, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:44:19 [INFO] [stdout] | [INFO] [stdout] 41 | pub const fn new(val: T) -> BlockingMutex { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | data: UnsafeCell::new(val), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:56:28 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn with_lock(&self, f: impl FnOnce(&mut T) -> U) -> U { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | self.raw.with_lock(|| { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 57 | | let ptr = self.data.get(); [INFO] [stdout] 58 | | // SAFETY: Raw Mutex proves we have exclusive access to the inner data [INFO] [stdout] 59 | | let inner = unsafe { &mut *ptr }; [INFO] [stdout] 60 | | f(inner) [INFO] [stdout] 61 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:70:32 [INFO] [stdout] | [INFO] [stdout] 69 | pub fn try_with_lock(&self, f: impl FnOnce(&mut T) -> U) -> Option { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | self.raw.try_with_lock(|| { [INFO] [stdout] | ________________________________^ [INFO] [stdout] 71 | | let ptr = self.data.get(); [INFO] [stdout] 72 | | // SAFETY: Raw Mutex proves we have exclusive access to the inner data [INFO] [stdout] 73 | | let inner = unsafe { &mut *ptr }; [INFO] [stdout] 74 | | f(inner) [INFO] [stdout] 75 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:87:19 [INFO] [stdout] | [INFO] [stdout] 84 | pub const fn const_new(raw_mutex: R, val: T) -> BlockingMutex { [INFO] [stdout] | ------------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 87 | data: UnsafeCell::new(val), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/raw_impls.rs:48:36 [INFO] [stdout] | [INFO] [stdout] 47 | fn try_with_lock(&self, f: impl FnOnce() -> R) -> Option { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | critical_section::with(|_| { [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 49 | | // NOTE: separated load/stores are acceptable as we are in [INFO] [stdout] 50 | | // a critical section [INFO] [stdout] 51 | | if self.taken.load(Ordering::Relaxed) { [INFO] [stdout] ... | [INFO] [stdout] 57 | | Some(ret) [INFO] [stdout] 58 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/raw_impls.rs:66:13 [INFO] [stdout] | [INFO] [stdout] 62 | fn with_lock(&self, f: impl FnOnce() -> R) -> R { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | self.try_with_lock(f).expect("Deadlocked") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/raw_impls.rs:127:13 [INFO] [stdout] | [INFO] [stdout] 123 | fn with_lock(&self, f: impl FnOnce() -> R) -> R { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | self.try_with_lock(f).expect("Deadlocked") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mutex` (lib test) due to 9 previous errors [INFO] running `Command { std: "docker" "inspect" "bd1a0b9c19af5a757830ccdf50b3381f2a10040e6924729dd05d6ec9bc598b40", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bd1a0b9c19af5a757830ccdf50b3381f2a10040e6924729dd05d6ec9bc598b40", kill_on_drop: false }` [INFO] [stdout] bd1a0b9c19af5a757830ccdf50b3381f2a10040e6924729dd05d6ec9bc598b40